)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5a210a61630461a139bab327f4c253a4c07bbca0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matthew Thode \u003cmthode@mthode.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-28 16:24:12 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix gentoo hardened support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7fb855249a9e6c9b6497ab5061b4ea3c014f5081"},{"line_number":10,"context_line":"Closes-Bug: 1537177"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_1979b8c8","line":7,"updated":"2016-01-28 23:20:52.000000000","message":"can you explain what i\u0027m looking at here?","commit_id":"40f1c1fecead6bcd704ab3516bdeaa0111e78214"}],"bin/disk-image-create":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"003a3a58b73940311ea748ba2d7bb6291a5cbfee","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"if [[ -n \"${GENTOO_PROFILE}\" ]]; then"},{"line_number":221,"context_line":"    if [[ \"${GENTOO_PROFILE}\" \u003d~ \"hardened\" ]]; then"},{"line_number":222,"context_line":"        echo \u0027disabling tmpfs for gentoo hardened build\u0027"},{"line_number":223,"context_line":"        export DIB_NO_TMPFS\u003d1"},{"line_number":224,"context_line":"    fi"},{"line_number":225,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7a5de9d1_d27ba726","line":222,"updated":"2016-01-31 23:24:18.000000000","message":"can you please add a comment in here explaining the reason for this; i presume the problem is that tmpfs doesn\u0027t support xattr which is why the build fails.","commit_id":"b0fa2bc25cadee869d47a3a429b21fe73b56f18a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3d1196eff922929fea407f7501748d78eefdbc55","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    fi"},{"line_number":218,"context_line":"fi"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"if [[ -n \"${GENTOO_PROFILE}\" ]]; then"},{"line_number":221,"context_line":"    if [[ \"${GENTOO_PROFILE}\" \u003d~ \"hardened\" ]]; then"},{"line_number":222,"context_line":"        echo \u0027disabling tmpfs for gentoo hardened build\u0027"},{"line_number":223,"context_line":"        export DIB_NO_TMPFS\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a5de9d1_f95bf183","line":220,"updated":"2016-02-02 02:12:42.000000000","message":"this seems to have lost the comment that was added in a prior changeset explaining it was due to xattr support","commit_id":"b747a88f423780effba245a7f45a63acaa11b402"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2fab7bcdbc69c59b755b8a027aa4e603d0e74d56","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# xattr support cannot be relied upon with tmpfs builds"},{"line_number":221,"context_line":"# some kernels supoprt it, some don\u0027t"},{"line_number":222,"context_line":"if [[ -n \"${GENTOO_PROFILE}\" ]]; then"},{"line_number":223,"context_line":"    if [[ \"${GENTOO_PROFILE}\" \u003d~ \"hardened\" ]]; then"},{"line_number":224,"context_line":"        echo \u0027disabling tmpfs for gentoo hardened build\u0027"},{"line_number":225,"context_line":"        export DIB_NO_TMPFS\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_5ffd45af","line":222,"updated":"2016-02-02 03:03:30.000000000","message":"this seems ok, but if the default were changed to be hardened, and people were not setting it from the command-line, then it seems like this would be missed.  but I guess it has to be done early here before the other files are sourced?","commit_id":"01fce7b70cb749606e8529a9059ad078557639a7"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"684c2da335e056b4d2169629dfce12180920a77e","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# xattr support cannot be relied upon with tmpfs builds"},{"line_number":221,"context_line":"# some kernels supoprt it, some don\u0027t"},{"line_number":222,"context_line":"if [[ -n \"${GENTOO_PROFILE}\" ]]; then"},{"line_number":223,"context_line":"    if [[ \"${GENTOO_PROFILE}\" \u003d~ \"hardened\" ]]; then"},{"line_number":224,"context_line":"        echo \u0027disabling tmpfs for gentoo hardened build\u0027"},{"line_number":225,"context_line":"        export DIB_NO_TMPFS\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_9fe5fd09","line":222,"in_reply_to":"7a5de9d1_5ffd45af","updated":"2016-02-02 03:05:28.000000000","message":"ya, has to be done before the lines directly below this (mk_build_dir specifically iirc, as it makes the tmpfs (or not)).","commit_id":"01fce7b70cb749606e8529a9059ad078557639a7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0f925b7ccb1c0b391bf285ad83352bb49bd5014a","unresolved":false,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# xattr support cannot be relied upon with tmpfs builds"},{"line_number":221,"context_line":"# some kernels supoprt it, some don\u0027t"},{"line_number":222,"context_line":"if [[ -n \"${GENTOO_PROFILE}\" ]]; then"},{"line_number":223,"context_line":"    if [[ \"${GENTOO_PROFILE}\" \u003d~ \"hardened\" ]]; then"},{"line_number":224,"context_line":"        echo \u0027disabling tmpfs for gentoo hardened build\u0027"},{"line_number":225,"context_line":"        export DIB_NO_TMPFS\u003d1"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_bfa9d991","line":222,"in_reply_to":"7a5de9d1_9fe5fd09","updated":"2016-02-02 03:08:20.000000000","message":"For future reference, that type of info makes for a good comment that helps reviewers understand why things are they way they are.","commit_id":"01fce7b70cb749606e8529a9059ad078557639a7"}],"elements/gentoo/bin/install-packages":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"003a3a58b73940311ea748ba2d7bb6291a5cbfee","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"function fix_shm {"},{"line_number":36,"context_line":"    if [[ \"${RUN_ONCE_SHM}\" \u003d\u003d \u00271\u0027 ]]; then"},{"line_number":37,"context_line":"        if [[ -L /dev/shm.orig ]]; then"},{"line_number":38,"context_line":"            rm /dev/shm.orig"},{"line_number":39,"context_line":"        fi"},{"line_number":40,"context_line":"        if [[ -d /dev/shm.orig ]]; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a5de9d1_9271af46","line":37,"updated":"2016-01-31 23:24:18.000000000","message":"is this related to the hardening mentioned in the subject?","commit_id":"b0fa2bc25cadee869d47a3a429b21fe73b56f18a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"003a3a58b73940311ea748ba2d7bb6291a5cbfee","unresolved":false,"context_lines":[{"line_number":59,"context_line":"function install_gentoo_packages {"},{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    fix_shm"},{"line_number":62,"context_line":"    emerge $@"},{"line_number":63,"context_line":"    unfix_shm"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a5de9d1_3291db47","line":62,"updated":"2016-01-31 23:24:18.000000000","message":"this seems wrong ... you don\u0027t want the arguments quoted?","commit_id":"b0fa2bc25cadee869d47a3a429b21fe73b56f18a"}],"elements/gentoo/environment.d/00-gentoo-distro-name.bash":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5a210a61630461a139bab327f4c253a4c07bbca0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export DISTRO_NAME\u003dgentoo"},{"line_number":2,"context_line":"export PROFILE\u003d$(eselect profile show | tail -n 1)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7a5de9d1_7ca9bade","line":2,"updated":"2016-01-28 23:20:52.000000000","message":"i\u0027d like to see this name-spaced further as PROFILE is pretty generic (GENTOO_PROFILE, i guess i logical)","commit_id":"40f1c1fecead6bcd704ab3516bdeaa0111e78214"}],"elements/gentoo/post-install.d/99-cleanup":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5a210a61630461a139bab327f4c253a4c07bbca0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#/usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"USE\u003d\"-build\" emerge -uDNv --with-bdeps\u003dy --jobs\u003d2 @world"},{"line_number":4,"context_line":"USE\u003d\"-build\" emerge --verbose\u003dn --depclean"},{"line_number":5,"context_line":"USE\u003d\"-build\" emerge -v --usepkg\u003dn @preserved-rebuild"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"7a5de9d1_3c9342a5","line":2,"updated":"2016-01-28 23:20:52.000000000","message":"this should have our tracing header ... but why didn\u0027t dib-lint pick this up?","commit_id":"40f1c1fecead6bcd704ab3516bdeaa0111e78214"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"003a3a58b73940311ea748ba2d7bb6291a5cbfee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [[ ${DIB_DEBUG_TRACE:-0} -gt 0 ]]; then"},{"line_number":4,"context_line":"    set -x"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7a5de9d1_328a3b1c","line":1,"updated":"2016-01-31 23:24:18.000000000","message":"missing !\n\nI think I609721b2671e704ea26075dad7e5b39a8b858f6b would pick that up","commit_id":"b0fa2bc25cadee869d47a3a429b21fe73b56f18a"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"aa3c24d77534f0be14c8ca3aeec58a99ae77cbce","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# shrink a bit"},{"line_number":32,"context_line":"for i in $(find /var/log -type f); do echo \u003e $i; done"},{"line_number":33,"context_line":"find /usr/share/man/ -mindepth 1  -maxdepth 1 -path \"/usr/share/man/man*\" -prune -o -exec rm -rf {} \\;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# make it so we don\u0027t have to reinstall grub"},{"line_number":36,"context_line":"if [[ -a /usr/sbin/grub2-install ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_e4b55231","line":33,"updated":"2016-02-02 20:05:48.000000000","message":"Removing all of the extra languages seems like premature optimization... I don\u0027t think we do this in any of the other OS image builds anyway. Perhaps we need to have a \"shrink\" element that handles things like this one.","commit_id":"01fce7b70cb749606e8529a9059ad078557639a7"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"f46fbea6154163282ba7f32c8afa3b89f75d481c","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# shrink a bit"},{"line_number":32,"context_line":"for i in $(find /var/log -type f); do echo \u003e $i; done"},{"line_number":33,"context_line":"find /usr/share/man/ -mindepth 1  -maxdepth 1 -path \"/usr/share/man/man*\" -prune -o -exec rm -rf {} \\;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# make it so we don\u0027t have to reinstall grub"},{"line_number":36,"context_line":"if [[ -a /usr/sbin/grub2-install ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a5de9d1_24f60ad8","line":33,"in_reply_to":"7a5de9d1_e4b55231","updated":"2016-02-02 20:09:49.000000000","message":"We (upstream gentoo infra) actually do this before shipping the minimal tarball this is built from.","commit_id":"01fce7b70cb749606e8529a9059ad078557639a7"}]}