)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c498e4a8256db6e816d855e66fc95e05a7a4ef07","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Gentoo provides eclean-dist via the gentoolkit package"},{"line_number":10,"context_line":"eclean-dist isn\u0027t needed anyway was /usr/portage is removed anyway"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"this was renamed to be run after 99-package-uninstalls as it needs a file in /tmp"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"removed redundant update in cleanup"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a5ae5dd_b52283a1","line":12,"updated":"2016-02-08 01:50:25.000000000","message":"Doesn\u0027t this indicate that this is generally doing something unsafe (i.e. removing files that other elements depend on)?\n\nIt does seem that this sort of cleanup should be done in the finalise stage, rather than the post-install stage?  That\u0027s still in the build chroot?","commit_id":"5e6b75605af0cb6c3ef47b6cb69c1230b9ff9f5e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a6e57dd0dd50792a6bd29f186ee288cc301303c5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Gentoo provides eclean-dist via the gentoolkit package"},{"line_number":10,"context_line":"eclean-dist isn\u0027t needed anyway was /usr/portage is removed anyway"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Documented post-installs.d to be the location to put cleanup actions for"},{"line_number":13,"context_line":"shrinking image size."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Removed redundant package update in cleanup."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_33797dfd","line":12,"updated":"2016-02-10 04:42:50.000000000","message":"as mentioned inline, what i want to see documented is the choices we have made around ordering, and giving people an idea where we expect them to put their elements","commit_id":"eb09333eb3ee2b2ccba520f548efd24166867581"}],"elements/package-installs/README.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a6e57dd0dd50792a6bd29f186ee288cc301303c5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"the specified installtype would be used for the element. See the"},{"line_number":42,"context_line":"diskimage-builder docs for more information on installtypes."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"The post-install.d actions are the last that are completed in the temporary"},{"line_number":45,"context_line":"build location, before copy to the final image is done.  As such, this is the"},{"line_number":46,"context_line":"proper place to put actions for cleaning and lowering the image size."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a57f1b5_3312ddb5","line":44,"updated":"2016-02-10 04:42:50.000000000","message":"What I\u0027m looking to document is not post-install.d behaviour, but to say that the package uninstall is run in post-install.d at 95 level, so if you have reason to do cleanup *after* package uninstalls you should number it higher than that.  you might even say that you should be careful not to clear out /tmp before this, or describe whatever the issue was you hit.\n\nthis would be appropriate in a separate section under say \"ordering\".","commit_id":"eb09333eb3ee2b2ccba520f548efd24166867581"}]}