)]}'
{"lib/img-functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ebe3815a7634ebe80f0b88b4e7d4610a498452d8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    fi"},{"line_number":123,"context_line":"    # Cleanup /tmp in the guest, so there is less cruft left there"},{"line_number":124,"context_line":"    if [ -d \"$TMP_MOUNT_PATH/tmp\" ]; then"},{"line_number":125,"context_line":"        unmount_dir $TMP_MOUNT_PATH/tmp"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":"    find $TMP_MOUNT_PATH/tmp -maxdepth 1 -mindepth 1 | xargs sudo rm -rf --one-file-system"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"dab17558_1541023a","line":124,"updated":"2016-05-13 01:39:11.000000000","message":"so we fixed that up in Ic7aca155492967b9819f129d3843cf95e136410e\n\ni don\u0027t think it\u0027s unreasonable to expect /tmp to be there, and since we do things like bind-mount random stuff in there i think i\u0027d prefer we just keep this as is.\n\nyou can probably argue that elements should clean themselves up, so anything unmounted here is an error.  if we want to turn this into a check, that might be ok in a separate change","commit_id":"22888aa11943be9275ea0b564786ffd5367da444"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"aad9ac262f565b69afb2251df625110c550ad485","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        fi"},{"line_number":122,"context_line":"    fi"},{"line_number":123,"context_line":"    # Cleanup /tmp in the guest, so there is less cruft left there"},{"line_number":124,"context_line":"    if [ -d \"$TMP_MOUNT_PATH/tmp\" ]; then"},{"line_number":125,"context_line":"        unmount_dir $TMP_MOUNT_PATH/tmp"},{"line_number":126,"context_line":"    fi"},{"line_number":127,"context_line":"    find $TMP_MOUNT_PATH/tmp -maxdepth 1 -mindepth 1 | xargs sudo rm -rf --one-file-system"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"dab17558_4a13bc5c","line":124,"in_reply_to":"dab17558_1541023a","updated":"2016-05-13 16:53:53.000000000","message":"This is just extra safeguarding - lets do both things: fix bugs and make sure to code defensively.\n\nThe unmount here is also just extra safeguarding so it definitely should stay to prevent us from leaking mounts. I agree that elements should also clean up after themselves. If we want to plumb through a flag or something we can use to fail on finding a mount here, thats fine, but this is just a straightforward bugfix as is.","commit_id":"22888aa11943be9275ea0b564786ffd5367da444"}],"tests/install_test_deps.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8074b5ada2f4ed66da3c3734ebd540202cb694ee","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        kpartx \\"},{"line_number":17,"context_line":"        qemu-img"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# install dockerdockerdocker"},{"line_number":20,"context_line":"if [ -n \"$(command -v apt-get)\" ]; then"},{"line_number":21,"context_line":"    sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D"},{"line_number":22,"context_line":"    echo \"deb https://apt.dockerproject.org/repo ubuntu-$(lsb_release -s -c) main\" | sudo tee /etc/apt/sources.list.d/docker.list"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dae33548_3941ba0c","line":19,"updated":"2016-02-14 19:52:16.000000000","message":"3 times docker?","commit_id":"5f3481a2ffc2ae0fd2c86d4c8978e02488118759"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"c427a28ab29132554a2e1258f8ee7c9ff8cafae7","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# install dockerdockerdocker"},{"line_number":20,"context_line":"if [ -n \"$(command -v apt-get)\" ]; then"},{"line_number":21,"context_line":"    sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D"},{"line_number":22,"context_line":"    echo \"deb https://apt.dockerproject.org/repo ubuntu-$(lsb_release -s -c) main\" | sudo tee /etc/apt/sources.list.d/docker.list"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    sudo apt-get update"}],"source_content_type":"text/x-sh","patch_set":11,"id":"dae33548_e0728548","line":21,"updated":"2016-02-16 23:38:29.000000000","message":"This is insufficient security I\u0027m afraid. While it\u0027s _PRETTY_ good, it is not impossible to make a key with a duplicate long ID and upload it. However, apt-key will happily take stdin, so\n\n    wget https://yum.dockerproject.org/gpg | apt-key add -\n\nThis at least requires them to pwn a CA in the same way as the yum bits do.","commit_id":"8ebe5f942648e25044dfcb68b556f5b53fb5d0f4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ebe3815a7634ebe80f0b88b4e7d4610a498452d8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        qemu-img"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# install dockerdockerdocker"},{"line_number":21,"context_line":"if [ -n \"$(command -v apt-get)\" ]; then"},{"line_number":22,"context_line":"    wget -O - https://yum.dockerproject.org/gpg | sudo apt-key add -"},{"line_number":23,"context_line":"    echo \"deb https://apt.dockerproject.org/repo ubuntu-$(lsb_release -s -c) main\" | sudo tee /etc/apt/sources.list.d/docker.list"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":14,"id":"dab17558_55b9ca2d","line":21,"updated":"2016-05-13 01:39:11.000000000","message":"is this necessary?  I tested on trusty with docker.io package and it worked.\n\nhttp://packages.ubuntu.com/trusty/docker.io","commit_id":"22888aa11943be9275ea0b564786ffd5367da444"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ebe3815a7634ebe80f0b88b4e7d4610a498452d8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    sudo apt-get update"},{"line_number":26,"context_line":"    sudo apt-get purge lxc-docker"},{"line_number":27,"context_line":"    sudo apt-get install -y docker-engine"},{"line_number":28,"context_line":"else"},{"line_number":29,"context_line":"    if grep -q Fedora /etc/redhat-release; then"},{"line_number":30,"context_line":"        rh_os\u003dfedora"},{"line_number":31,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":14,"id":"dab17558_b580f647","line":28,"updated":"2016-05-13 01:39:11.000000000","message":"it\u0027s also on centos in extras, right?","commit_id":"22888aa11943be9275ea0b564786ffd5367da444"}]}