)]}'
{"id":"openstack%2Fdiskimage-builder~279821","triplet_id":"openstack%2Fdiskimage-builder~master~I1dca2e8ffd31044a6b441ccb277298601e62f67c","project":"openstack/diskimage-builder","branch":"master","hashtags":[],"change_id":"I1dca2e8ffd31044a6b441ccb277298601e62f67c","subject":"debian-minimal: configurable debootstrap components","status":"MERGED","created":"2016-02-12 22:04:21.000000000","updated":"2016-03-12 19:13:03.000000000","submitted":"2016-03-12 19:13:03.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ea98c332a412a3e89d66e746c7e3428ed2ce95f0","_number":279821,"virtual_id_number":279821,"owner":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":2,"date":"2016-03-12 19:13:03.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"value":0,"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"all":[{"value":2,"date":"2016-03-12 18:38:18.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-02-15 18:24:09.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"value":2,"date":"2016-02-27 14:11:49.000000000","_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"all":[{"value":1,"date":"2016-03-12 18:38:18.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"value":0,"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-15 18:24:09.000000000","updated_by":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"reviewer":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"state":"REVIEWER"},{"updated":"2016-02-27 14:11:49.000000000","updated_by":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"reviewer":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"state":"REVIEWER"},{"updated":"2016-03-12 18:38:18.000000000","updated_by":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"reviewer":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"state":"REVIEWER"},{"updated":"2016-03-12 19:13:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"16f9fce2d19e6a40db9c5517554d27e62db74002","author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"date":"2016-02-12 22:04:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"555afb4949bf61408c0e04179e5af482620f95f4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-13 02:53:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-pep8 http://logs.openstack.org/21/279821/1/check/gate-diskimage-builder-pep8/bc9b848/ : SUCCESS in 1m 37s\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/21/279821/1/check/gate-diskimage-builder-docs/7e2a05d//doc/build/html/ : SUCCESS in 11m 25s\n- gate-diskimage-builder-python27 http://logs.openstack.org/21/279821/1/check/gate-diskimage-builder-python27/9d41a8c/ : SUCCESS in 43s\n- gate-diskimage-builder-python34 http://logs.openstack.org/21/279821/1/check/gate-diskimage-builder-python34/1489c03/ : SUCCESS in 56s\n- gate-dib-dsvm-functests-devstack-trusty http://logs.openstack.org/21/279821/1/check/gate-dib-dsvm-functests-devstack-trusty/7f189ba/ : SUCCESS in 21m 47s\n- gate-dib-dsvm-functests-devstack-centos7 http://logs.openstack.org/21/279821/1/check/gate-dib-dsvm-functests-devstack-centos7/005ea29/ : SUCCESS in 32m 21s\n- gate-tempest-dsvm-ironic-pxe_ssh-dib http://logs.openstack.org/21/279821/1/check/gate-tempest-dsvm-ironic-pxe_ssh-dib/c3d6bc3/ : SUCCESS in 47m 50s","accounts_in_message":[],"_revision_number":1},{"id":"cfb16ce37c3df0659e6984265339a81fd98b7c24","author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"date":"2016-02-15 10:00:41.000000000","message":"Patch Set 1:\n\nHaving only \u0027main\u0027 hardcoded in diskimage-builder comes all back to the change https://review.openstack.org/#/c/82325/   \"debian: install cloud-init on Wheezy\"","accounts_in_message":[],"_revision_number":1},{"id":"bd040208caa4edf44a0bd5e37eea2a71464e0043","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-15 18:24:09.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nHi Antoine,","accounts_in_message":[],"_revision_number":1},{"id":"987574a35d5e4918853f4fe6d7e481d81b72d856","author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"date":"2016-02-15 19:09:00.000000000","message":"Patch Set 1:\n\nThank you to have taken the time to look at the patch.\n\nThe debian-minimal element /etc/apt/sources.list provides a default list of repositories and I have a puppet recipe which then add some more under sources.list.d indeed.  My problem is one of them ends up causing a duplicate definition and both side are ignored --\u003e no packages available.\n\nThe details are on https://phabricator.wikimedia.org/T126246#2009901 copy pasted here..\n\nIn short delian-minimum ships:\n\n deb http://mirrors.wikimedia.org/debian/ jessie main\n deb http://mirrors.wikimedia.org/debian/ jessie-backports main\n\nMy puppet recipe ships:\n\n deb http://mirrors.wikimedia.org/debian/ jessie-backports main contrib non-free\n\nThe jessie-backports is listed twice, once with solely \u0027main\u0027 via dib and another time with \u0027main contrib non-free\u0027 by my puppet recipe.\n\n $ apt-cache policy openjdk-7-jre-headless\n W: Duplicate sources.list entry http://mirrors.wikimedia.org/debian/ jessie-backports/main amd64 Packages (/var/lib/apt/lists/mirrors.wikimedia.org_debian_dists_jessie-backports_main_binary-amd64_Packages)\n W: You may want to run apt-get update to correct these problems\n N: Unable to locate package openjdk-7-jre-headless\n\nCraziness.\n\nFor people willing to have debootstrap and the base sources.list to have different components I thought it would be good to reuse the list passed to debootstrap.  The element still default to only shipping \u0027main\u0027, but let one use different components as needed.\n\n\nI will be hit again by this if dib provides:\n\n deb http://mirrors.wikimedia.org/debian/ jessie main\n\nAnd I need to add a sources.list.d that has:\n\n deb http://mirrors.wikimedia.org/debian/ jessie main thirdparty\n\nThat will causes yet another duplicate and discard both repos :-\\\n\n\nSo I believe it is a good thing to let people change the components and specially have both debootstrap and debian-minimum to be in sync.","accounts_in_message":[],"_revision_number":1},{"id":"0b426fa9c0fff67101d971f021ecccf30f7c50d8","author":{"_account_id":9268,"name":"Gonéri Le Bouder","email":"goneri@redhat.com","username":"goneri"},"date":"2016-02-15 20:06:32.000000000","message":"Patch Set 1:\n\nWhy don\u0027t you just adjust the source.list with your puppet scripts?","accounts_in_message":[],"_revision_number":1},{"id":"d146cb4354e7654f505645cfdabaccc2cfdac155","author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"date":"2016-02-27 14:11:49.000000000","message":"Patch Set 1: Code-Review+2\n\nI disagree with Goneri. This is how people _use_ Debian sometimes, even if it isn\u0027t specifically part of Debian. References to these are included in every system and in the installer, so this is not unprecedented.","accounts_in_message":[],"_revision_number":1},{"id":"4d970a230fb216b7416cf19eae397a5a8da7b5a3","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-03-12 18:38:18.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThe point that a user can add in these repos using souces.list.d is valid, but I don\u0027t like the idea of telling users that they need to make an element for a common use case (avoiding that is the whole point of in tree elements, after all), and making an element just for setting those repos seems overkill. So, I think this is the best practical solution.","accounts_in_message":[],"_revision_number":1},{"id":"d08fa6eeb5594c188b3cb2cdf20c5fae180dd033","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-12 18:38:23.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"139be39f97894c061bf78edc2fc62632f666dedd","date":"2016-03-12 19:13:03.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"ea98c332a412a3e89d66e746c7e3428ed2ce95f0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-12 19:13:03.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/21/279821/1/gate/gate-diskimage-builder-docs/e58c40d//doc/build/html/ : SUCCESS in 3m 38s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/21/279821/1/gate/gate-diskimage-builder-pep8/5afec68/ : SUCCESS in 1m 42s\n- gate-diskimage-builder-python27 http://logs.openstack.org/21/279821/1/gate/gate-diskimage-builder-python27/3a48c91/ : SUCCESS in 2m 48s\n- gate-diskimage-builder-python34 http://logs.openstack.org/21/279821/1/gate/gate-diskimage-builder-python34/19a80ba/ : SUCCESS in 2m 58s\n- gate-dib-dsvm-functests-devstack-trusty http://logs.openstack.org/21/279821/1/gate/gate-dib-dsvm-functests-devstack-trusty/a774612/ : SUCCESS in 16m 31s\n- gate-dib-dsvm-functests-devstack-centos7 http://logs.openstack.org/21/279821/1/gate/gate-dib-dsvm-functests-devstack-centos7/3897966/ : SUCCESS in 29m 08s\n- gate-tempest-dsvm-ironic-pxe_ssh-dib http://logs.openstack.org/21/279821/1/gate/gate-tempest-dsvm-ironic-pxe_ssh-dib/4897566/ : SUCCESS in 34m 32s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ee58c5b1cc40674d8a320eac4d36e2b33146a860","revisions":{"ee58c5b1cc40674d8a320eac4d36e2b33146a860":{"kind":"REWORK","_number":1,"created":"2016-02-12 22:04:21.000000000","uploader":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"ref":"refs/changes/21/279821/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/21/279821/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/21/279821/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/21/279821/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/21/279821/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/21/279821/1"}}},"commit":{"parents":[{"commit":"6f6a096d94f5f9d46bc05572bbe31c5af63c6d7d","subject":"Merge \"Handle install with pip -e\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6f6a096d94f5f9d46bc05572bbe31c5af63c6d7d"}]}],"author":{"name":"Antoine Musso","email":"hashar@free.fr","date":"2016-02-12 21:57:58.000000000","tz":60},"committer":{"name":"Antoine Musso","email":"hashar@free.fr","date":"2016-02-12 21:57:58.000000000","tz":60},"subject":"debian-minimal: configurable debootstrap components","message":"debian-minimal: configurable debootstrap components\n\nThe debian-minimal element creates /etc/apt/sources.list solely with\nthe \u0027main\u0027 component. I need to add \u0027non-free\u0027 and \u0027contribs\u0027. I tried\nto pass them via DIB_DEBIAN_COMPONENTS but it is not recognized.\n\nMake debian-minimal to honor DIB_DEBIAN_COMPONENTS. Note that it is\ncomma separated for \u0027debootstrap\u0027, so replace commas with spaces to fit\nthe needs of sources.list.\n\nExample usage:\n\n DIB_DEBIAN_COMPONENTS\u003d\u0027main,non-free,contrib\u0027\n\nWill debootstrap with the three components then when debian-minimal is\nrealized pre install a sources.list that has:\n\n  deb http://example.org/debian jessie main contrib non-free\n\nChange-Id: I1dca2e8ffd31044a6b441ccb277298601e62f67c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/ee58c5b1cc40674d8a320eac4d36e2b33146a860"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/ee58c5b1cc40674d8a320eac4d36e2b33146a860"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
