)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5e772f93e52d3945410baea7a68e3378e64a8b58","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elsewhere, it was not working on non-gentoo systems and giving bad results on"},{"line_number":16,"context_line":"gentoo systems (returing values from the host, not the guest being built)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch also fixes shm detection by checking if it is mounted already."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ie58d8e19529a731bfbc9eeb4bb246988d1aaa772"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bae84128_8030f9e9","line":18,"updated":"2016-02-22 06:28:38.000000000","message":"I still prefer splitting unrelated things, but i\u0027m not going to get too hung up on it","commit_id":"dacfc23c36b32d6b4c5c185236b881b60504f97b"}],"elements/gentoo/bin/install-packages":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"d859b124b471d6cdedd6e18321fe5f951f0dc2b0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    set +e"},{"line_number":62,"context_line":"    mount | grep -q /dev/shm"},{"line_number":63,"context_line":"    CODE\u003d$?"},{"line_number":64,"context_line":"    set -e"},{"line_number":65,"context_line":"    if [[ $? -ne 0 ]]; then"},{"line_number":66,"context_line":"        fix_shm"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bae84128_2c72e3ad","line":63,"updated":"2016-02-20 21:33:15.000000000","message":"This should be local","commit_id":"15d6ca83c4dccdbbf0c5a82d07d029c4a036b461"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"b2323f4c11c2f6aa5f1bef4e241f0a08c6c55903","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    set +e"},{"line_number":62,"context_line":"    mount | grep -q /dev/shm"},{"line_number":63,"context_line":"    CODE\u003d$?"},{"line_number":64,"context_line":"    set -e"},{"line_number":65,"context_line":"    if [[ $? -ne 0 ]]; then"},{"line_number":66,"context_line":"        fix_shm"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bae84128_cc56d7d1","line":63,"in_reply_to":"bae84128_2c72e3ad","updated":"2016-02-20 21:52:50.000000000","message":"done","commit_id":"15d6ca83c4dccdbbf0c5a82d07d029c4a036b461"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"d859b124b471d6cdedd6e18321fe5f951f0dc2b0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    mount | grep -q /dev/shm"},{"line_number":63,"context_line":"    CODE\u003d$?"},{"line_number":64,"context_line":"    set -e"},{"line_number":65,"context_line":"    if [[ $? -ne 0 ]]; then"},{"line_number":66,"context_line":"        fix_shm"},{"line_number":67,"context_line":"        emerge $@"},{"line_number":68,"context_line":"        unfix_shm"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bae84128_8c696fc1","line":65,"updated":"2016-02-20 21:33:15.000000000","message":"did you mean $CODE -ne 0 ?","commit_id":"15d6ca83c4dccdbbf0c5a82d07d029c4a036b461"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"b2323f4c11c2f6aa5f1bef4e241f0a08c6c55903","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    mount | grep -q /dev/shm"},{"line_number":63,"context_line":"    CODE\u003d$?"},{"line_number":64,"context_line":"    set -e"},{"line_number":65,"context_line":"    if [[ $? -ne 0 ]]; then"},{"line_number":66,"context_line":"        fix_shm"},{"line_number":67,"context_line":"        emerge $@"},{"line_number":68,"context_line":"        unfix_shm"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bae84128_ac51d3da","line":65,"in_reply_to":"bae84128_8c696fc1","updated":"2016-02-20 21:52:50.000000000","message":"yep","commit_id":"15d6ca83c4dccdbbf0c5a82d07d029c4a036b461"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"381449a268bff35f21bed7329e160e922f9cab98","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    set +e"},{"line_number":62,"context_line":"    mount | grep -q /dev/shm"},{"line_number":63,"context_line":"    local CODE\u003d$?"},{"line_number":64,"context_line":"    set -e"},{"line_number":65,"context_line":"    if [[ $CODE -ne 0 ]]; then"},{"line_number":66,"context_line":"        fix_shm"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bae84128_3fde716d","line":63,"updated":"2016-02-22 02:01:24.000000000","message":"local should be named with underscore by convention, to distinguish them from globals\n\nbut, i don\u0027t see why this should not just be\n\n if mount | grep -q /dev/shm; then\n  ...\n else\n  ...\n fi\n\nbut even better maybe, just grep on /proc/mounts?","commit_id":"a961bb9ce807f45dbc8d4564501746eaac61db58"}],"elements/gentoo/environment.d/00-gentoo-distro-name.bash":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"cb4b5eab25f1e3ed81c9f6d84b8d193ffc04bd50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export DISTRO_NAME\u003dgentoo"},{"line_number":2,"context_line":"export GENTOO_PROFILE\u003d${GENTOO_PROFILE:-$(eselect profile show | tail -n 1 | xargs)}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bae84128_71b02d44","line":2,"updated":"2016-02-22 03:55:01.000000000","message":"As a reviewer, how am i supposed to know what the problem is with the status quo and and if this is the right thing to do or not?\n\nOn one hand, gentoo building doesn\u0027t really affect me, we have no CI for it, this seems rather trivial, so what does it really matter?\n\nBut i don\u0027t just + stuff i don\u0027t understand or have any context on, because + is basically me signing my name saying \"i\u0027ve understood this and to the best of my knowledge it looks good\".   \n\nFor example, I understand what passing a command through xargs does.  Here, I do not understand what that would fix, when it seems like it was working before.\n\nUsually I don\u0027t need much convincing, and I certainly do not distrust by default or require some essay or formalised proof; just something in the change like \"with foo, this command does blah, so moo\", or, \"we forgot foo does blah, so moo\" would clue me in to what is going on.\n\nI have to be honest, this isn\u0027t the first time i feel we\u0027ve discussed this (I don\u0027t generally write such responses to 4 character patches).  I get the feeling you might think i\u0027m imposing some bureaucratic nightmare.  Your code is welcome.  But I\u0027d urge you that when authoring changes, consider the reviewer who you are basically asking to formally sign their name that your code is good.","commit_id":"4bde45383cbd7eb0e55c13632477f8f2fcd6754e"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"a1fb749a5d5429479fa37cbd3321e2985cf7b3e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export DISTRO_NAME\u003dgentoo"},{"line_number":2,"context_line":"export GENTOO_PROFILE\u003d${GENTOO_PROFILE:-$(eselect profile show | tail -n 1 | xargs)}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bae84128_27cb07a7","line":2,"in_reply_to":"bae84128_71b02d44","updated":"2016-02-22 04:05:58.000000000","message":"Sorry, I thought the xargs thing was explained by the commit message.  xargs was used because it strips leading spaces from arguments and was simpler to use then sed.\n\nThe reason why this wasn\u0027t caught before is that it seems like this is run outside the chroot (or whatever DIB uses).  On ubuntu the command would fail and the variable would be empty.  On gentoo the command succeeds and set the variable is set to something like \u0027  profile/goes/here\u0027.\n\nI have a bad habit of not giving enough info, please don\u0027t take it personally.  Something like this does warrant a bigger explanation.\n\nThis patch also overrode whatever envvar was set.\n\nI would like to eventually have CI for this.","commit_id":"4bde45383cbd7eb0e55c13632477f8f2fcd6754e"}]}