)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19701,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hpe.com","username":"vaddikk"},"change_message_id":"5f4f5b61d041fe1d9c9a41d2bd0408af9750ec22","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds support for to build images using diskimage-builder"},{"line_number":10,"context_line":"which are capable to boot in UEFI based systems. Currently Ubuntu and Fedora"},{"line_number":11,"context_line":"images have been tested and verified."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If1fb0abe3507a0fe2b6f5266e0e2e5b32d628c45"},{"line_number":14,"context_line":"Signed-off-by: Purandhar Sairam Mannidi \u003cmannidi@hpe.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7af24918_a3b20e92","line":11,"range":{"start_line":11,"start_character":36,"end_line":11,"end_character":37},"updated":"2016-03-03 14:45:03.000000000","message":"Can you briefly add details of how this is achieved","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"57906821905d169c0348521ea15c69dd55d15e12","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   partition."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"4. Grub configuration files are modified to work with respective"},{"line_number":29,"context_line":"   distributions."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: If1fb0abe3507a0fe2b6f5266e0e2e5b32d628c45"},{"line_number":32,"context_line":"Signed-off-by: Purandhar Sairam Mannidi \u003cmannidi@hpe.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1a122d0e_8420f99c","line":29,"updated":"2016-04-25 19:20:12.000000000","message":"Agreed, I\u0027d like to do some followup on this to make sure it works for my particular distro.","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"006ba914dd59827d636d57a0415d0e8fb8e613b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   partition."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"4. Grub configuration files are modified to work with respective"},{"line_number":29,"context_line":"   distributions."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: If1fb0abe3507a0fe2b6f5266e0e2e5b32d628c45"},{"line_number":32,"context_line":"Signed-off-by: Purandhar Sairam Mannidi \u003cmannidi@hpe.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"1a122d0e_ea9b98c7","line":29,"updated":"2016-04-18 16:38:53.000000000","message":"The bits above are extremely useful. Can we move it to the documentation, so it\u0027s not lost in just the git commit history? I think that\u0027s fine as a follow-up.","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"552b0ae304b90e8a61c823c10b66bbff98bd5584","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"To build an UEFI capable image,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. Two Partions were created with GPT partition table. First partition"},{"line_number":17,"context_line":"   contains the root file system, while the second partition is an EFI"},{"line_number":18,"context_line":"   System Partition(ESP). parted is used for creating the partitions."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"2. Bootloader element pkg-map has been added with grub-efi which"},{"line_number":21,"context_line":"   installs dependent packages for default and redhat distributions."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"9ad45d7e_0612af62","line":18,"range":{"start_line":16,"start_character":3,"end_line":18,"end_character":24},"updated":"2016-08-09 05:03:05.000000000","message":"Need to be changed to reflect the latest changes.","commit_id":"b3b75ccb3d2cd1f5fdfd0c5f8c6471c0302560e7"}],"README.rst":[{"author":{"_account_id":19701,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hpe.com","username":"vaddikk"},"change_message_id":"5f4f5b61d041fe1d9c9a41d2bd0408af9750ec22","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* http://docs.openstack.org/developer/diskimage-builder/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Additionally, the `DIB_UEFI_SUPPORT` environmental variable can be set to"},{"line_number":34,"context_line":"create the image with UEFI support."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"NOTE: Currently UEFI support in diskimage-builder is available for Ubuntu"},{"line_number":37,"context_line":"      and Fedora images only."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_23655e1d","line":34,"range":{"start_line":34,"start_character":34,"end_line":34,"end_character":35},"updated":"2016-03-03 14:45:03.000000000","message":"This information has to go into the documentation of the DIB as well","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"aac2c9d2c6ea8664a78cf1a6fd8852c0bc32010e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* http://docs.openstack.org/developer/diskimage-builder/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Additionally, the `DIB_UEFI_SUPPORT` environmental variable can be set to"},{"line_number":34,"context_line":"create the image with UEFI support."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"NOTE: Currently UEFI support in diskimage-builder is available for Ubuntu"},{"line_number":37,"context_line":"      and Fedora images only."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_3b9ba219","line":34,"range":{"start_line":34,"start_character":34,"end_line":34,"end_character":35},"in_reply_to":"7af24918_23655e1d","updated":"2016-03-04 02:10:16.000000000","message":"I will update the documentation.","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"aac2c9d2c6ea8664a78cf1a6fd8852c0bc32010e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Copyright"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Copyright 2012 Hewlett-Packard Development Company, L.P."},{"line_number":44,"context_line":"Copyright (c) 2012 NTT DOCOMO, INC."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"All Rights Reserved."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7af24918_1b9346fb","line":43,"range":{"start_line":43,"start_character":55,"end_line":43,"end_character":56},"updated":"2016-03-04 02:10:16.000000000","message":"Do we need to update the Copyright as well??","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* http://docs.openstack.org/developer/diskimage-builder/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Additionally, the `DIB_UEFI_SUPPORT` environmental variable can be set to"},{"line_number":34,"context_line":"create the image which will boot only in the UEFI mode."},{"line_number":35,"context_line":"Refer `building_an_image.rst` user guide."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Copyright"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_da044719","line":34,"range":{"start_line":34,"start_character":41,"end_line":34,"end_character":44},"updated":"2016-05-10 21:29:35.000000000","message":"s/the//","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"* http://docs.openstack.org/developer/diskimage-builder/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Additionally, the `DIB_UEFI_SUPPORT` environmental variable can be set to"},{"line_number":34,"context_line":"create the image which will boot only in the UEFI mode."},{"line_number":35,"context_line":"Refer `building_an_image.rst` user guide."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Copyright"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_1a4c0f9d","line":34,"range":{"start_line":34,"start_character":6,"end_line":34,"end_character":10},"updated":"2016-05-10 21:29:35.000000000","message":"s/the/an/","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Additionally, the `DIB_UEFI_SUPPORT` environmental variable can be set to"},{"line_number":34,"context_line":"create the image which will boot only in the UEFI mode."},{"line_number":35,"context_line":"Refer `building_an_image.rst` user guide."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Copyright"},{"line_number":38,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_450cf83a","line":35,"updated":"2016-05-10 21:29:35.000000000","message":"Maybe \"Refer to the\" here.","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"87ba71ba1644139b3af29e91289b7e221a479738","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* http://docs.openstack.org/developer/diskimage-builder/"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Additionally, the `DIB_UEFI_SUPPORT` environmental variable can be set to"},{"line_number":34,"context_line":"create an image which will boot only in UEFI mode."},{"line_number":35,"context_line":"Refer to the `building_an_image.rst` user guide."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"bab6814e_4c6c179c","line":33,"updated":"2016-05-21 19:23:40.000000000","message":"I\u0027d rather not have this blurb here - we used to document features like this in the README and it became way too large. A blurb in the user guide and element README should be good.","commit_id":"6de9659300c151dbef78f15c3001d284841d8ca3"}],"doc/source/user_guide/building_an_image.rst":[{"author":{"_account_id":19701,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hpe.com","username":"vaddikk"},"change_message_id":"a149656d91c0ae29c99c4cb092e0aaa9cfe35718","unresolved":false,"context_lines":[{"line_number":89,"context_line":"UEFI Support"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"By default, disk-image-create creates a image which is capable to boot in BIOS"},{"line_number":93,"context_line":"based systems. In order to create an image capable to boot in UEFI based "},{"line_number":94,"context_line":"systems by setting the DIB_UEFI_SUPPORT environment variable as follows:"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5aef4532_9236a5e5","line":92,"range":{"start_line":92,"start_character":39,"end_line":92,"end_character":40},"updated":"2016-03-08 11:56:00.000000000","message":"/s/a image/an image","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"8ac9fd7076f6cf6abac8b666fea66bb40f293d2d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"UEFI Support"},{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"By default, disk-image-create creates a image which is capable to boot in BIOS"},{"line_number":93,"context_line":"based systems. In order to create an image capable to boot in UEFI based "},{"line_number":94,"context_line":"systems by setting the DIB_UEFI_SUPPORT environment variable as follows:"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5aef4532_43872dd7","line":92,"range":{"start_line":92,"start_character":39,"end_line":92,"end_character":40},"in_reply_to":"5aef4532_9236a5e5","updated":"2016-03-08 13:08:45.000000000","message":"Done","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":19701,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hpe.com","username":"vaddikk"},"change_message_id":"a149656d91c0ae29c99c4cb092e0aaa9cfe35718","unresolved":false,"context_lines":[{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"By default, disk-image-create creates a image which is capable to boot in BIOS"},{"line_number":93,"context_line":"based systems. In order to create an image capable to boot in UEFI based "},{"line_number":94,"context_line":"systems by setting the DIB_UEFI_SUPPORT environment variable as follows:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5aef4532_923d05be","line":93,"range":{"start_line":93,"start_character":72,"end_line":93,"end_character":73},"updated":"2016-03-08 11:56:00.000000000","message":"remove trailing space\nRephrase to\nTo create an image to boot in UEFI systems, the DIB_UEFI_SUPPORT environment variable must be set as follows","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"8ac9fd7076f6cf6abac8b666fea66bb40f293d2d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"------------"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"By default, disk-image-create creates a image which is capable to boot in BIOS"},{"line_number":93,"context_line":"based systems. In order to create an image capable to boot in UEFI based "},{"line_number":94,"context_line":"systems by setting the DIB_UEFI_SUPPORT environment variable as follows:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5aef4532_63b7c986","line":93,"range":{"start_line":93,"start_character":72,"end_line":93,"end_character":73},"in_reply_to":"5aef4532_923d05be","updated":"2016-03-08 13:08:45.000000000","message":"Will fix it in next patch sets.","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"d63fba62af7f463876e928be062a2d84397ceac9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"By default, disk-image-create creates an image which is capable to boot in"},{"line_number":93,"context_line":"BIOS based systems. To create an image to boot in UEFI systems, the"},{"line_number":94,"context_line":"DIB_UEFI_SUPPORT environment variable must be set as follows:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Note: Currently Ubuntu and Fedora distributions are supported while building"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3afc51ec_1fe4a70b","line":95,"updated":"2016-03-11 11:19:10.000000000","message":"May be we should also mention that vm element needs to be used. And possibly mention that, as of now, only disk images can be built.","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"0873ff77d4bc80e5d22b02210115de89089a8356","unresolved":false,"context_lines":[{"line_number":92,"context_line":"By default, disk-image-create creates an image which is capable to boot in"},{"line_number":93,"context_line":"BIOS based systems. To create an image to boot in UEFI systems, the"},{"line_number":94,"context_line":"DIB_UEFI_SUPPORT environment variable must be set as follows:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Note: Currently Ubuntu and Fedora distributions are supported while building"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3afc51ec_3dc7c413","line":95,"in_reply_to":"3afc51ec_1fe4a70b","updated":"2016-03-12 05:59:25.000000000","message":"Done","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"d63fba62af7f463876e928be062a2d84397ceac9","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Note: Currently Ubuntu and Fedora distributions are supported while building"},{"line_number":99,"context_line":"      UEFI image."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3afc51ec_ff08db2a","line":98,"range":{"start_line":98,"start_character":17,"end_line":98,"end_character":33},"updated":"2016-03-11 11:19:10.000000000","message":"As per the other doc \n\nDistributions which are supported as a target for an UEFI capable image:\n\n  - Fedora 22\n  - Ubuntu 14.04 (\"trusty\")\n  - RHEL 7\n  - Centos 7\n  - Debian 8 (\"jessie\")\n\n  Note: Currently images for x64_64/amd64 architectures are tested.\n\nI guess, both docs should be in sync with each other. Or, even better, this doc should point to other one to reduce doc maintenance.","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"0873ff77d4bc80e5d22b02210115de89089a8356","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Note: Currently Ubuntu and Fedora distributions are supported while building"},{"line_number":99,"context_line":"      UEFI image."}],"source_content_type":"text/x-rst","patch_set":12,"id":"3afc51ec_1dcc8834","line":98,"range":{"start_line":98,"start_character":17,"end_line":98,"end_character":33},"in_reply_to":"3afc51ec_ff08db2a","updated":"2016-03-12 05:59:25.000000000","message":"Done","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d8cf2532c63adc4eca73b12d8a4cb19ff4d7e96","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Note: UEFI support is supported for only vm images (must include vm element)"},{"line_number":99,"context_line":"      and supports only whole disk images."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3afc51ec_c75d22eb","line":99,"range":{"start_line":98,"start_character":0,"end_line":99,"end_character":42},"updated":"2016-03-13 11:04:43.000000000","message":"Formatting is misplaced for this note in the generated docs.","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"96a89bbb07ce5e6458decd08867d74cdc0f64548","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"Note: UEFI support is supported for only vm images (must include vm element)"},{"line_number":99,"context_line":"      and supports only whole disk images."}],"source_content_type":"text/x-rst","patch_set":14,"id":"3afc51ec_05f24d6f","line":99,"range":{"start_line":98,"start_character":0,"end_line":99,"end_character":42},"in_reply_to":"3afc51ec_c75d22eb","updated":"2016-03-14 11:00:45.000000000","message":"Done","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"UEFI Support"},{"line_number":91,"context_line":"------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"By default, disk-image-create creates an image which is capable to boot in"},{"line_number":94,"context_line":"BIOS based systems. To create an image to boot in UEFI systems, the"},{"line_number":95,"context_line":"DIB_UEFI_SUPPORT environment variable must be set as follows:"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_2528d485","line":93,"range":{"start_line":93,"start_character":64,"end_line":93,"end_character":74},"updated":"2016-05-10 21:29:35.000000000","message":"maybe \"capable of booting on\"","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":91,"context_line":"------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"By default, disk-image-create creates an image which is capable to boot in"},{"line_number":94,"context_line":"BIOS based systems. To create an image to boot in UEFI systems, the"},{"line_number":95,"context_line":"DIB_UEFI_SUPPORT environment variable must be set as follows:"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_85f8a0c4","line":94,"range":{"start_line":94,"start_character":47,"end_line":94,"end_character":49},"updated":"2016-05-10 21:29:35.000000000","message":"on","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"942911c43634ebb49d256531681d578a95554680","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    export DIB_UEFI_SUPPORT\u003dtrue"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"UEFI support is only for vm (must include vm element) and whole disk images."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Given below is an explanation of how UEFI capable images are built:"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"5a9d85d2_28bca404","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":76},"updated":"2016-06-20 21:15:10.000000000","message":"The vm element appears to install a boot loader and I think might be more clear stated as \"systems intended to local boot\"","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"552b0ae304b90e8a61c823c10b66bbff98bd5584","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Given below is an explanation of how UEFI capable images are built:"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"1. Two partitions are created with GPT partition table. First partition"},{"line_number":104,"context_line":"   contains the root file system, while the second partition is an EFI"},{"line_number":105,"context_line":"   System Partition(ESP). ``parted`` is used for creating partitions."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"2. As part of installing grub boot loader, the ESP is mounted"},{"line_number":108,"context_line":"   to /boot/efi directory of the root file system so that grub will"}],"source_content_type":"text/x-rst","patch_set":32,"id":"9ad45d7e_a951f410","line":105,"range":{"start_line":103,"start_character":3,"end_line":105,"end_character":24},"updated":"2016-08-09 05:03:05.000000000","message":"Need to be changed.","commit_id":"b3b75ccb3d2cd1f5fdfd0c5f8c6471c0302560e7"}],"doc/source/user_guide/supported_distros.rst":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aa4ae83a7321183889b60cc2dd841882bb3d65c3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Distributions which are supported as a target for an UEFI capable image:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - Fedora 22"},{"line_number":26,"context_line":"  - Ubuntu 14.04 (\"trusty\")"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_299f5f51","line":26,"updated":"2016-03-08 14:19:01.000000000","message":"Nit: Ideally this should support Debian and centos since the code is already injected into the blocks.  Otherwise, we likely need to explicitly fail any builds requested for an unsupported OS.","commit_id":"f56f7a5aa733747fde5c1f688748a4a2af38193f"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"144283fab71f9f52c1310933dc8a0b24ee2d86a3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Distributions which are supported as a target for an UEFI capable image:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - Fedora 22"},{"line_number":26,"context_line":"  - Ubuntu 14.04 (\"trusty\")"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_3993bffb","line":26,"in_reply_to":"5aef4532_299f5f51","updated":"2016-03-10 06:50:15.000000000","message":"Done. Supported OS list has been updated with new OS.","commit_id":"f56f7a5aa733747fde5c1f688748a4a2af38193f"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"c162247c090bf9a89a272442e1561e3996007d62","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Distributions which are supported as a target for an UEFI capable image:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - Fedora 22"},{"line_number":26,"context_line":"  - Ubuntu 14.04 (\"trusty\")"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5aef4532_712b0595","line":26,"in_reply_to":"5aef4532_299f5f51","updated":"2016-03-09 09:44:05.000000000","message":"We never tried building any other OS except mentioned. It might build images for Debian and CentOS.","commit_id":"f56f7a5aa733747fde5c1f688748a4a2af38193f"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"d63fba62af7f463876e928be062a2d84397ceac9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - RHEL 6, 7"},{"line_number":20,"context_line":"  - Ubuntu 12.04 (\"precise\"), 14.04 (\"trusty\")"},{"line_number":21,"context_line":"  - Gentoo"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Distributions which are supported as a target for an UEFI capable image:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - Fedora 22"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3afc51ec_5f73cf4d","line":22,"updated":"2016-03-11 11:19:10.000000000","message":"I think, there should be two line gap.","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"0873ff77d4bc80e5d22b02210115de89089a8356","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  - RHEL 6, 7"},{"line_number":20,"context_line":"  - Ubuntu 12.04 (\"precise\"), 14.04 (\"trusty\")"},{"line_number":21,"context_line":"  - Gentoo"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Distributions which are supported as a target for an UEFI capable image:"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - Fedora 22"}],"source_content_type":"text/x-rst","patch_set":12,"id":"3afc51ec_fde55ca8","line":22,"in_reply_to":"3afc51ec_5f73cf4d","updated":"2016-03-12 05:59:25.000000000","message":"Done","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d8cf2532c63adc4eca73b12d8a4cb19ff4d7e96","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Gentoo"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Distributions which are supported as a target for an image:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - Centos 6, 7"},{"line_number":17,"context_line":"  - Debian 8 (\"jessie\")"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3afc51ec_071eea0b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":58},"updated":"2016-03-13 11:04:43.000000000","message":"Would it be helpful to indicate that this list is for \u0027BIOS\u0027 boot-only images ?","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"96a89bbb07ce5e6458decd08867d74cdc0f64548","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Gentoo"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Distributions which are supported as a target for an image:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - Centos 6, 7"},{"line_number":17,"context_line":"  - Debian 8 (\"jessie\")"}],"source_content_type":"text/x-rst","patch_set":14,"id":"3afc51ec_85f5bdcc","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":58},"in_reply_to":"3afc51ec_071eea0b","updated":"2016-03-14 11:00:45.000000000","message":"Done","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- Gentoo"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Distributions which are supported as a target for an BIOS boot image:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  - Centos 6, 7"},{"line_number":17,"context_line":"  - Debian 8 (\"jessie\")"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_053310ac","line":14,"range":{"start_line":14,"start_character":50,"end_line":14,"end_character":52},"updated":"2016-05-10 21:29:35.000000000","message":"a","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bddf1bbe9879b5d0cea62851e092f0fd2ca2c0ce","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  - Centos 7"},{"line_number":30,"context_line":"  - Debian 8 (\"jessie\")"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  Note: Currently images for x64_64/amd64 architectures are tested."}],"source_content_type":"text/x-rst","patch_set":22,"id":"7aa08908_7c497b32","line":32,"updated":"2016-06-15 12:38:03.000000000","message":"Perhaps?\n\n.. NOTE::\n   UEFI support presently supports only the x86_64/amd64 architectures.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"}],"elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":19701,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hpe.com","username":"vaddikk"},"change_message_id":"5f4f5b61d041fe1d9c9a41d2bd0408af9750ec22","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if [[ \"$DISTRO_NAME\" \u003d~ \"fedora\" ]]; then"},{"line_number":81,"context_line":"            rm -f /boot/grub2/grubenv*"},{"line_number":82,"context_line":"        fi"},{"line_number":83,"context_line":"    else"},{"line_number":84,"context_line":"        install-packages -m bootloader grub-pc"},{"line_number":85,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7af24918_86e60013","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":10},"updated":"2016-03-03 14:45:03.000000000","message":"Why are we removing this folder?","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"aac2c9d2c6ea8664a78cf1a6fd8852c0bc32010e","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        if [[ \"$DISTRO_NAME\" \u003d~ \"fedora\" ]]; then"},{"line_number":81,"context_line":"            rm -f /boot/grub2/grubenv*"},{"line_number":82,"context_line":"        fi"},{"line_number":83,"context_line":"    else"},{"line_number":84,"context_line":"        install-packages -m bootloader grub-pc"},{"line_number":85,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7af24918_1bf2269a","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":10},"in_reply_to":"7af24918_86e60013","updated":"2016-03-04 02:10:16.000000000","message":"First, it\u0027s a file. Second, It will be regenerated during grub2-install operation. It is conflicting with existing file and grub2-install is not able to proceed.","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":19701,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hpe.com","username":"vaddikk"},"change_message_id":"5f4f5b61d041fe1d9c9a41d2bd0408af9750ec22","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":143,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":144,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":145,"context_line":"        $GRUBNAME --modules\u003d\"part_gpt fat ext2 normal chain boot configfile linux multiboot search_fs_uuid search_label terminal serial video video_fb video_bochs usb usb_keyboard efi_gop efi_uga\" $GRUB_OPTS $BOOT_DEV --boot-directory\u003d/boot --efi-directory\u003d/boot/efi --target\u003dx86_64-efi --removable"},{"line_number":146,"context_line":"    else"},{"line_number":147,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":148,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7af24918_06bdd0b6","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":8},"updated":"2016-03-03 14:45:03.000000000","message":"Can you add a comment why these modules are required?","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"aac2c9d2c6ea8664a78cf1a6fd8852c0bc32010e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":143,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":144,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":145,"context_line":"        $GRUBNAME --modules\u003d\"part_gpt fat ext2 normal chain boot configfile linux multiboot search_fs_uuid search_label terminal serial video video_fb video_bochs usb usb_keyboard efi_gop efi_uga\" $GRUB_OPTS $BOOT_DEV --boot-directory\u003d/boot --efi-directory\u003d/boot/efi --target\u003dx86_64-efi --removable"},{"line_number":146,"context_line":"    else"},{"line_number":147,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":148,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7af24918_bb521265","line":145,"range":{"start_line":145,"start_character":0,"end_line":145,"end_character":8},"in_reply_to":"7af24918_06bdd0b6","updated":"2016-03-04 02:10:16.000000000","message":"These modules were considered from existing ubuntu qcow2 image. Yes, we need to check why these modules are required and remove irrelevant modules. I\u0027ll consider this in next patchset.","commit_id":"15afea4d7047073c5e01d3667ad0ab2581925dd9"},{"author":{"_account_id":19701,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hpe.com","username":"vaddikk"},"change_message_id":"a149656d91c0ae29c99c4cb092e0aaa9cfe35718","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        if [ \"$DIB_RELEASE\" \u003d \u002719\u0027 ]; then"},{"line_number":235,"context_line":"            sed -i \"s%UUID\u003d[A-Za-z0-9\\-]*%LABEL\u003d${DIB_ROOT_LABEL}%\" /etc/fstab"},{"line_number":236,"context_line":"        fi"},{"line_number":237,"context_line":"        sed -i \u0027s%\\(initrd\\|linux\\)[[:digit:]]\\+ %\\1 %g\u0027 $GRUB_CFG"},{"line_number":238,"context_line":"    fi"},{"line_number":239,"context_line":"    # Fix efi specific instructions in grub config file"},{"line_number":240,"context_line":"    if [ -d /sys/firmware/efi ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5aef4532_d2edcdf0","line":237,"range":{"start_line":237,"start_character":58,"end_line":237,"end_character":66},"updated":"2016-03-08 11:56:00.000000000","message":"cant we have this only done for UEFI, so that the BIOS image creation path is not modified in anyway","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"8ac9fd7076f6cf6abac8b666fea66bb40f293d2d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        if [ \"$DIB_RELEASE\" \u003d \u002719\u0027 ]; then"},{"line_number":235,"context_line":"            sed -i \"s%UUID\u003d[A-Za-z0-9\\-]*%LABEL\u003d${DIB_ROOT_LABEL}%\" /etc/fstab"},{"line_number":236,"context_line":"        fi"},{"line_number":237,"context_line":"        sed -i \u0027s%\\(initrd\\|linux\\)[[:digit:]]\\+ %\\1 %g\u0027 $GRUB_CFG"},{"line_number":238,"context_line":"    fi"},{"line_number":239,"context_line":"    # Fix efi specific instructions in grub config file"},{"line_number":240,"context_line":"    if [ -d /sys/firmware/efi ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"5aef4532_c31cddc3","line":237,"range":{"start_line":237,"start_character":58,"end_line":237,"end_character":66},"in_reply_to":"5aef4532_d2edcdf0","updated":"2016-03-08 13:08:45.000000000","message":"Handled in a different way. Done.","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"aa4ae83a7321183889b60cc2dd841882bb3d65c3","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        source /tmp/grub/install"},{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they were causing issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5aef4532_c95ebbe8","line":70,"updated":"2016-03-08 14:19:01.000000000","message":"Is this code block intended for all EFI supporting platforms?","commit_id":"f56f7a5aa733747fde5c1f688748a4a2af38193f"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"c162247c090bf9a89a272442e1561e3996007d62","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        source /tmp/grub/install"},{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they were causing issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5aef4532_9194d1e2","line":70,"in_reply_to":"5aef4532_c95ebbe8","updated":"2016-03-09 09:44:05.000000000","message":"yes. This block is intended as common code.","commit_id":"f56f7a5aa733747fde5c1f688748a4a2af38193f"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"d63fba62af7f463876e928be062a2d84397ceac9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they were causing issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"},{"line_number":74,"context_line":"            rm -rf /boot/grub2"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3afc51ec_1f3787e4","line":71,"range":{"start_line":71,"start_character":49,"end_line":71,"end_character":67},"updated":"2016-03-11 11:19:10.000000000","message":"s/they were causing/they cause/","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"0873ff77d4bc80e5d22b02210115de89089a8356","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they were causing issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"},{"line_number":74,"context_line":"            rm -rf /boot/grub2"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3afc51ec_3d9504e4","line":71,"range":{"start_line":71,"start_character":49,"end_line":71,"end_character":67},"in_reply_to":"3afc51ec_1f3787e4","updated":"2016-03-12 05:59:25.000000000","message":"Done","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"d63fba62af7f463876e928be062a2d84397ceac9","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        GRUB_MOD\u003d\"part_gpt fat ext2 normal configfile linux\""},{"line_number":156,"context_line":"        GRUB_MOD+\u003d\" search_fs_uuid search_label terminal serial\""},{"line_number":157,"context_line":"        GRUB_MOD+\u003d\" video video_fb video_bochs usb efi_gop efi_uga\""},{"line_number":158,"context_line":"        $GRUBNAME --modules\u003d\"$GRUB_MOD\" $GRUB_OPTS $BOOT_DEV --boot-directory\u003d/boot --efi-directory\u003d/boot/efi --target\u003d$ARCH-efi --removable"},{"line_number":159,"context_line":"    else"},{"line_number":160,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":161,"context_line":"    fi"},{"line_number":162,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3afc51ec_7f904b96","line":159,"range":{"start_line":158,"start_character":8,"end_line":159,"end_character":8},"updated":"2016-03-11 11:19:10.000000000","message":"Break this into multi-line??\n\n$GRUBNAME --modules\u003d\"$GRUB_MOD\" $GRUB_OPTS $BOOT_DEV \\\n    --boot-directory\u003d/boot --efi-directory\u003d/boot/efi \\\n    --target\u003d$ARCH-efi --removable","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"0873ff77d4bc80e5d22b02210115de89089a8356","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        GRUB_MOD\u003d\"part_gpt fat ext2 normal configfile linux\""},{"line_number":156,"context_line":"        GRUB_MOD+\u003d\" search_fs_uuid search_label terminal serial\""},{"line_number":157,"context_line":"        GRUB_MOD+\u003d\" video video_fb video_bochs usb efi_gop efi_uga\""},{"line_number":158,"context_line":"        $GRUBNAME --modules\u003d\"$GRUB_MOD\" $GRUB_OPTS $BOOT_DEV --boot-directory\u003d/boot --efi-directory\u003d/boot/efi --target\u003d$ARCH-efi --removable"},{"line_number":159,"context_line":"    else"},{"line_number":160,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":161,"context_line":"    fi"},{"line_number":162,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3afc51ec_40b627dd","line":159,"range":{"start_line":158,"start_character":8,"end_line":159,"end_character":8},"in_reply_to":"3afc51ec_7f904b96","updated":"2016-03-12 05:59:25.000000000","message":"Done","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"8eeb92e82701f0d4b7ff6945644c15f5560af5b1","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027|\u0027rhel7\u0027)"},{"line_number":200,"context_line":"            echo \u0027GRUB_CMDLINE_LINUX\u003d\"nofb nomodeset vga\u003dnormal\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":201,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":202,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":203,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":204,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":205,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3afc51ec_a2d75a22","line":202,"range":{"start_line":202,"start_character":16,"end_line":202,"end_character":81},"updated":"2016-03-11 11:24:11.000000000","message":"An explanation (in comment form) about this would help me understand why its being done.","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"0873ff77d4bc80e5d22b02210115de89089a8356","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027|\u0027rhel7\u0027)"},{"line_number":200,"context_line":"            echo \u0027GRUB_CMDLINE_LINUX\u003d\"nofb nomodeset vga\u003dnormal\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":201,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":202,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":203,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":204,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":205,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"3afc51ec_20bb1bc6","line":202,"range":{"start_line":202,"start_character":16,"end_line":202,"end_character":81},"in_reply_to":"3afc51ec_a2d75a22","updated":"2016-03-12 05:59:25.000000000","message":"Done","commit_id":"475625990f673da22eb7b6f83fe483893a5da8ad"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d8cf2532c63adc4eca73b12d8a4cb19ff4d7e96","unresolved":false,"context_lines":[{"line_number":10,"context_line":"set -o pipefail"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \u0027amd64\u0027 \u003d \"$ARCH\" ] ; then"},{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# FIXME:"},{"line_number":17,"context_line":"[ -n \"$IMAGE_BLOCK_DEVICE\" ]"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3afc51ec_a7a1f6ab","line":14,"range":{"start_line":13,"start_character":4,"end_line":14,"end_character":2},"updated":"2016-03-13 11:04:43.000000000","message":"Would it better to treat them similarly wherever required instead of a change like this. See https://github.com/openstack/diskimage-builder/blob/master/elements/bootloader/finalise.d/50-bootloader#L103","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"96a89bbb07ce5e6458decd08867d74cdc0f64548","unresolved":false,"context_lines":[{"line_number":10,"context_line":"set -o pipefail"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \u0027amd64\u0027 \u003d \"$ARCH\" ] ; then"},{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# FIXME:"},{"line_number":17,"context_line":"[ -n \"$IMAGE_BLOCK_DEVICE\" ]"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3afc51ec_60369f53","line":14,"range":{"start_line":13,"start_character":4,"end_line":14,"end_character":2},"in_reply_to":"3afc51ec_a7a1f6ab","updated":"2016-03-14 11:00:45.000000000","message":"This change is not necessary as we are using this for grub-install and valid only for amd64 where fedora cannot handle this. This works fine for other OS.","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d8cf2532c63adc4eca73b12d8a4cb19ff4d7e96","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        source /tmp/grub/install"},{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they cause issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3afc51ec_a788d623","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":45},"updated":"2016-03-13 11:04:43.000000000","message":"Would it work for 32-bit architectures? Or you may have to put a check around this variable indicating its supported for 64-bit architectures.","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"96a89bbb07ce5e6458decd08867d74cdc0f64548","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        source /tmp/grub/install"},{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they cause issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3afc51ec_2061373a","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":45},"in_reply_to":"3afc51ec_a788d623","updated":"2016-03-14 11:00:45.000000000","message":"It might work and this code is common and is independent of architecture.","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d743226f15738ca39736d04b358f9f2659a277ae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"set -o pipefail"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \u0027amd64\u0027 \u003d \"$ARCH\" ] ; then"},{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# FIXME:"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_382cac01","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":17},"updated":"2016-03-23 05:06:59.000000000","message":"Will it not work if the ARCH value is amd64?","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"4da71d0896f4e1ae55a8e06ee97e0217bcc1513c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"set -o pipefail"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \u0027amd64\u0027 \u003d \"$ARCH\" ] ; then"},{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# FIXME:"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_5a22dfa3","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":17},"in_reply_to":"fa0719c6_382cac01","updated":"2016-03-24 12:46:25.000000000","message":"No, script will not be able to run grub-install","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c1b642eb877f8bdc211d3c07e596e8c30b909d2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"set -o pipefail"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \u0027amd64\u0027 \u003d \"$ARCH\" ] ; then"},{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# FIXME:"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"da0c15f0_fcdc6548","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":17},"in_reply_to":"fa0719c6_5a22dfa3","updated":"2016-03-29 11:35:16.000000000","message":"Ok then can u add valid argument of x86_64 to $ARCH in DIB and then use it here.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"8c949d44fc89c17219d041c6888d4f64b4d3164f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            rm -rf /boot/grub"},{"line_number":76,"context_line":"        fi"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # TODO: Secure boot packages need to be handled"},{"line_number":79,"context_line":"        install-packages -m bootloader grub-efi"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        # create efi directory and mount EFI boot partition"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_3dbb30e7","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":55},"updated":"2016-03-22 09:44:50.000000000","message":"I believe you will only need to install the \"shim\" package (redhat, debian it\u0027s called shim-signed) for this to work.\n\nWhat else you think needs to be done, in terms of packages to be installed for secure boot?","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"31d1984de13e7a43d2d9294595aa256805775134","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            rm -rf /boot/grub"},{"line_number":76,"context_line":"        fi"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # TODO: Secure boot packages need to be handled"},{"line_number":79,"context_line":"        install-packages -m bootloader grub-efi"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        # create efi directory and mount EFI boot partition"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_44d28401","line":78,"range":{"start_line":78,"start_character":10,"end_line":78,"end_character":55},"in_reply_to":"fa0719c6_3dbb30e7","updated":"2016-03-22 12:57:24.000000000","message":"you are correct, shim-signed should be fine. we have not tested secure boot, so we\u0027ve not enabled it. we\u0027ll put another patch for it after testing.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d743226f15738ca39736d04b358f9f2659a277ae","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Removing existing /boot/grub2/grubenv so that it will not create"},{"line_number":87,"context_line":"        # issues while running grub2-install"},{"line_number":88,"context_line":"        case $DISTRO_NAME in"},{"line_number":89,"context_line":"            \"fedora\"|\"rhel7\"|\"centos7\"|\"centos\")"},{"line_number":90,"context_line":"                rm -f /boot/grub2/grubenv*"},{"line_number":91,"context_line":"            ;;"},{"line_number":92,"context_line":"        esac"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_d81c90c3","line":89,"range":{"start_line":89,"start_character":12,"end_line":89,"end_character":48},"updated":"2016-03-23 05:06:59.000000000","message":"ubuntu, opensuse is not in this list. So those distros doesnt require this step?","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"26a35b55a685deca1c2e5614866c559477849053","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Removing existing /boot/grub2/grubenv so that it will not create"},{"line_number":87,"context_line":"        # issues while running grub2-install"},{"line_number":88,"context_line":"        case $DISTRO_NAME in"},{"line_number":89,"context_line":"            \"fedora\"|\"rhel7\"|\"centos7\"|\"centos\")"},{"line_number":90,"context_line":"                rm -f /boot/grub2/grubenv*"},{"line_number":91,"context_line":"            ;;"},{"line_number":92,"context_line":"        esac"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba0121b8_1c563c29","line":89,"range":{"start_line":89,"start_character":12,"end_line":89,"end_character":48},"in_reply_to":"ba0121b8_341249b5","updated":"2016-03-29 16:50:00.000000000","message":"currently, we\u0027re not supporting opensuse. Same has been updated in support matrix.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c1b642eb877f8bdc211d3c07e596e8c30b909d2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Removing existing /boot/grub2/grubenv so that it will not create"},{"line_number":87,"context_line":"        # issues while running grub2-install"},{"line_number":88,"context_line":"        case $DISTRO_NAME in"},{"line_number":89,"context_line":"            \"fedora\"|\"rhel7\"|\"centos7\"|\"centos\")"},{"line_number":90,"context_line":"                rm -f /boot/grub2/grubenv*"},{"line_number":91,"context_line":"            ;;"},{"line_number":92,"context_line":"        esac"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba0121b8_341249b5","line":89,"range":{"start_line":89,"start_character":12,"end_line":89,"end_character":48},"in_reply_to":"fa0719c6_9a94778b","updated":"2016-03-29 11:35:16.000000000","message":"could you please add the comment for the same above so that people are aware that it is not expected to work for opensuse.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"4da71d0896f4e1ae55a8e06ee97e0217bcc1513c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        # Removing existing /boot/grub2/grubenv so that it will not create"},{"line_number":87,"context_line":"        # issues while running grub2-install"},{"line_number":88,"context_line":"        case $DISTRO_NAME in"},{"line_number":89,"context_line":"            \"fedora\"|\"rhel7\"|\"centos7\"|\"centos\")"},{"line_number":90,"context_line":"                rm -f /boot/grub2/grubenv*"},{"line_number":91,"context_line":"            ;;"},{"line_number":92,"context_line":"        esac"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_9a94778b","line":89,"range":{"start_line":89,"start_character":12,"end_line":89,"end_character":48},"in_reply_to":"fa0719c6_d81c90c3","updated":"2016-03-24 12:46:25.000000000","message":"Yes, ubuntu does not require this step. we\u0027re not supporting opensuse yet as it has issues with cloud-init","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"ea301213807dd9b86dab30499f680a464943a969","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    echo \u0027GRUB_TERMINAL\u003d\"serial console\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":174,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":175,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dauto\u0027 \u003e\u003e/etc/default/grub"},{"line_number":176,"context_line":"    else"},{"line_number":177,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dtext\u0027 \u003e\u003e/etc/default/grub"},{"line_number":178,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"1af94dfe_86452b44","line":175,"updated":"2016-03-19 12:23:00.000000000","message":"does auto always show as text? because one thing we want is for all dib produced images to _never_ use graphics mode when booting if at all possible.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"16e6559db3c5b0b103caf403deeb14bb55650b44","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    echo \u0027GRUB_TERMINAL\u003d\"serial console\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":174,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":175,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dauto\u0027 \u003e\u003e/etc/default/grub"},{"line_number":176,"context_line":"    else"},{"line_number":177,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dtext\u0027 \u003e\u003e/etc/default/grub"},{"line_number":178,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_481132ac","line":175,"in_reply_to":"1af94dfe_86452b44","updated":"2016-03-21 12:14:34.000000000","message":"we\u0027re looking into forcing the graphics mode into text when the system supports graphics. I\u0027ll push another patch set fixing it.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"fe0a2d570d440bb5bd9e48f6eed7b0bf20c1a71c","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    echo \u0027GRUB_TERMINAL\u003d\"serial console\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":174,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":175,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dauto\u0027 \u003e\u003e/etc/default/grub"},{"line_number":176,"context_line":"    else"},{"line_number":177,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dtext\u0027 \u003e\u003e/etc/default/grub"},{"line_number":178,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_c8351bdb","line":175,"in_reply_to":"fa0719c6_481132ac","updated":"2016-03-22 04:08:03.000000000","message":"It\u0027s not possible to get a VGA text mode console with EFI. The only way to get a console is to use a graphics mode framebuffer.\n\nPlease refer to \nhttp://www.gossamer-threads.com/lists/gentoo/user/286992","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"4d618def0e3412c0d0696dfef58ed29b69bcbca5","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    echo \u0027GRUB_TERMINAL\u003d\"serial console\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":174,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":175,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dauto\u0027 \u003e\u003e/etc/default/grub"},{"line_number":176,"context_line":"    else"},{"line_number":177,"context_line":"        echo \u0027GRUB_GFXPAYLOAD_LINUX\u003dtext\u0027 \u003e\u003e/etc/default/grub"},{"line_number":178,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba0121b8_f3d3e05d","line":175,"in_reply_to":"fa0719c6_c8351bdb","updated":"2016-04-02 15:30:50.000000000","message":"Can you put that as a comment above this line?","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d743226f15738ca39736d04b358f9f2659a277ae","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":188,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":189,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":190,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":191,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""},{"line_number":192,"context_line":"                else"},{"line_number":193,"context_line":"                    cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_78a0e443","line":190,"range":{"start_line":190,"start_character":46,"end_line":190,"end_character":50},"updated":"2016-03-23 05:06:59.000000000","message":"is this label gpt1 constant always?","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d743226f15738ca39736d04b358f9f2659a277ae","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":188,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":189,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":190,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":191,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""},{"line_number":192,"context_line":"                else"},{"line_number":193,"context_line":"                    cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_d8e1309c","line":190,"range":{"start_line":190,"start_character":42,"end_line":190,"end_character":45},"updated":"2016-03-23 05:06:59.000000000","message":"will it be always hd0? means can it be any other name like sd0, vd0 etc...","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"26a35b55a685deca1c2e5614866c559477849053","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":188,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":189,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":190,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":191,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""},{"line_number":192,"context_line":"                else"},{"line_number":193,"context_line":"                    cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba0121b8_77ff9101","line":190,"range":{"start_line":190,"start_character":42,"end_line":190,"end_character":45},"in_reply_to":"ba0121b8_b4549954","updated":"2016-03-29 16:50:00.000000000","message":"We will take this as a supplementary patch. I\u0027ll propose additional change on top of this patch after testing if it works when we remove hd0.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"4da71d0896f4e1ae55a8e06ee97e0217bcc1513c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":188,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":189,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":190,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":191,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""},{"line_number":192,"context_line":"                else"},{"line_number":193,"context_line":"                    cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_9ac2b783","line":190,"range":{"start_line":190,"start_character":46,"end_line":190,"end_character":50},"in_reply_to":"fa0719c6_78a0e443","updated":"2016-03-24 12:46:25.000000000","message":"yes, as we are creating partition 1 for root filesystem","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c1b642eb877f8bdc211d3c07e596e8c30b909d2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":188,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":189,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":190,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":191,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""},{"line_number":192,"context_line":"                else"},{"line_number":193,"context_line":"                    cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba0121b8_b4549954","line":190,"range":{"start_line":190,"start_character":42,"end_line":190,"end_character":45},"in_reply_to":"fa0719c6_c7f733d1","updated":"2016-03-29 11:35:16.000000000","message":"ok. please add the comment for it also. i have seen naming convention as sd0 and vd0 also. But since for you it always work as hd0, please leave the comment for the same.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"4da71d0896f4e1ae55a8e06ee97e0217bcc1513c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":188,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":189,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":190,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":191,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""},{"line_number":192,"context_line":"                else"},{"line_number":193,"context_line":"                    cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_c7f733d1","line":190,"range":{"start_line":190,"start_character":42,"end_line":190,"end_character":45},"in_reply_to":"fa0719c6_d8e1309c","updated":"2016-03-24 12:46:25.000000000","message":"yes, as we are building whole disk images and by default it is assumed that there would only be one disk as multiple disk is not yet supported in DIB. We are not sure about sd0 or vd0","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d743226f15738ca39736d04b358f9f2659a277ae","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":208,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":209,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":210,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"},{"line_number":211,"context_line":"set prefix\u003d(\\$root)/boot/grub2"},{"line_number":212,"context_line":"configfile \\$prefix/grub.cfg\""},{"line_number":213,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_d8f8104c","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":47},"updated":"2016-03-23 05:06:59.000000000","message":"ditto as on L190","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"26a35b55a685deca1c2e5614866c559477849053","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":208,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":209,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":210,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"},{"line_number":211,"context_line":"set prefix\u003d(\\$root)/boot/grub2"},{"line_number":212,"context_line":"configfile \\$prefix/grub.cfg\""},{"line_number":213,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba0121b8_d7101d51","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":47},"in_reply_to":"ba0121b8_b4dbf9ec","updated":"2016-03-29 16:50:00.000000000","message":"same as above.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"8c1b642eb877f8bdc211d3c07e596e8c30b909d2","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":208,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":209,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":210,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"},{"line_number":211,"context_line":"set prefix\u003d(\\$root)/boot/grub2"},{"line_number":212,"context_line":"configfile \\$prefix/grub.cfg\""},{"line_number":213,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ba0121b8_b4dbf9ec","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":47},"in_reply_to":"fa0719c6_67caa71c","updated":"2016-03-29 11:35:16.000000000","message":"ditto as above","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"4da71d0896f4e1ae55a8e06ee97e0217bcc1513c","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":208,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":209,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":210,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"},{"line_number":211,"context_line":"set prefix\u003d(\\$root)/boot/grub2"},{"line_number":212,"context_line":"configfile \\$prefix/grub.cfg\""},{"line_number":213,"context_line":"EOF"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_67caa71c","line":210,"range":{"start_line":210,"start_character":44,"end_line":210,"end_character":47},"in_reply_to":"fa0719c6_d8f8104c","updated":"2016-03-24 12:46:25.000000000","message":"Same as above","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":10375,"name":"Om Kumar","email":"om.kumar@hpe.com","username":"lazy_prince"},"change_message_id":"39000a9799a6f8ea0e5dbe22fe8185d41903686b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    fi"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    echo \u0027GRUB_TERMINAL\u003d\"serial console\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":174,"context_line":"    "},{"line_number":175,"context_line":"    # It is not possible to get a VGA text mode console with EFI. The only"},{"line_number":176,"context_line":"    # way to get a console is to use a graphics mode framebuffer. Refer to"},{"line_number":177,"context_line":"    # http://www.gossamer-threads.com/lists/gentoo/user/286992"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"9a061dce_d949a690","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":4},"updated":"2016-04-05 09:16:47.000000000","message":"White spaces","commit_id":"4a9e4f76fd60f1d9ef3e7b78bc6e97a3062bba43"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"9de65dbdc09e272203b7c84a0a6360a859d0f7fb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"set -eu"},{"line_number":10,"context_line":"set -o pipefail"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \u0027amd64\u0027 \u003d \"$ARCH\" ] ; then"},{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":20,"id":"bab6814e_422fbb87","line":12,"updated":"2016-05-22 09:37:30.000000000","message":"Just don\u0027t understand:\nWhy do you need to overwrite the ARCH here?","commit_id":"6de9659300c151dbef78f15c3001d284841d8ca3"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"9de65dbdc09e272203b7c84a0a6360a859d0f7fb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1##\u0027 | sed -e \u0027s#mapper/##\u0027)"},{"line_number":23,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":24,"context_line":"        UEFI_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1#p2#\u0027)"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":20,"id":"bab6814e_c259eb36","line":24,"updated":"2016-05-22 09:37:30.000000000","message":"... and the next place where an assumption of the partition layout is made.","commit_id":"6de9659300c151dbef78f15c3001d284841d8ca3"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"fea5a9baa9afd80b1918a4c5280b2c7866261ce5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1##\u0027 | sed -e \u0027s#mapper/##\u0027)"},{"line_number":23,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":24,"context_line":"        UEFI_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1#p2#\u0027)"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"bab6814e_e2a4a8ba","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":64},"updated":"2016-05-24 04:53:55.000000000","message":"When the loop device selected is /dev/loop1 IMAGE_BLOCK_DEVICE\u003d\u0027/dev/loop1p1\u0027. Applying the regex to this will result in UEFI_DEV\u003d\u0027/dev/loop2p1\u0027 and eventually the image building fails since it can\u0027t find /dev/loop2p1.\nSo i\u0027d rather suggest to change the regex to below.\n\nUEFI_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1$#p2#\u0027)\n\nNote the \u0027$\u0027 after p1.","commit_id":"9b17b295d202e509006b9068eee3dd798f3e00ba"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e6488f2fe5859b1805204491a463d660f7276032","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p2##\u0027)\u0027p1\u0027"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1##\u0027 | sed -e \u0027s#mapper/##\u0027)"},{"line_number":23,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":24,"context_line":"        UEFI_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1$#p2#\u0027)"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_36892e27","line":23,"range":{"start_line":23,"start_character":7,"end_line":23,"end_character":37},"updated":"2016-06-13 23:17:29.000000000","message":"nit: in your docs you indicate that this should be set to true but you\u0027re just checking the length is nonzero, so someone who didn\u0027t read the element could set it to false and it would still pass. Maybe better to use 0/1?","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"b285ce870ae717ebc61327ec1d3ab751b01a4280","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p2##\u0027)\u0027p1\u0027"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1##\u0027 | sed -e \u0027s#mapper/##\u0027)"},{"line_number":23,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":24,"context_line":"        UEFI_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1$#p2#\u0027)"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"3aaa91ec_9fa98ee2","line":23,"range":{"start_line":23,"start_character":7,"end_line":23,"end_character":37},"in_reply_to":"7aa08908_36892e27","updated":"2016-06-28 10:01:53.000000000","message":"The variable should be set to any value - yes/ true/0. Basically, it has to be non zero. If we check for true/false here, then it would require that the variable should be set each time the tool is run which is not the case. will update the docs that the variable should be set to non-zero value.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"942911c43634ebb49d256531681d578a95554680","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p2##\u0027)\u0027p1\u0027"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1##\u0027 | sed -e \u0027s#mapper/##\u0027)"},{"line_number":23,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":24,"context_line":"        UEFI_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1$#p2#\u0027)"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"5a9d85d2_e81d7c10","line":23,"range":{"start_line":23,"start_character":7,"end_line":23,"end_character":37},"in_reply_to":"7aa08908_36892e27","updated":"2016-06-20 21:15:10.000000000","message":"or check that it is set to true","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e6488f2fe5859b1805204491a463d660f7276032","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they cause issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"},{"line_number":74,"context_line":"            rm -rf /boot/grub2"},{"line_number":75,"context_line":"            rm -rf /boot/grub"},{"line_number":76,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_b6b19e91","line":73,"range":{"start_line":73,"start_character":11,"end_line":73,"end_character":28},"updated":"2016-06-13 23:17:29.000000000","message":"Might be worth checking for both here.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"90ff4351f9cda47b35135cd0a364396a6c90a7ae","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they cause issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ]; then"},{"line_number":74,"context_line":"            rm -rf /boot/grub2"},{"line_number":75,"context_line":"            rm -rf /boot/grub"},{"line_number":76,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"3aaa91ec_9356f759","line":73,"range":{"start_line":73,"start_character":11,"end_line":73,"end_character":28},"in_reply_to":"7aa08908_b6b19e91","updated":"2016-07-01 07:42:05.000000000","message":"Done","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"d79de1a344727030251279c905ad250619c73df0","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            echo \u0027GRUB_PLATFORMS\u003d\"emu efi-32 efi-64 pc\"\u0027 \u003e\u003e /etc/portage/make.conf"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # TODO: Secure boot packages need to be handled"},{"line_number":83,"context_line":"        install-packages -m bootloader grub-efi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # create efi directory and mount EFI boot partition"},{"line_number":86,"context_line":"        mkdir -p \"/boot/efi\""},{"line_number":87,"context_line":"        mount $UEFI_DEV /boot/efi"},{"line_number":88,"context_line":"        mkdir -p \"/boot/efi/EFI/BOOT\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Removing existing /boot/grub2/grubenv so that it will not create"},{"line_number":91,"context_line":"        # issues while running grub2-install"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"9abb7d3a_62e1ed29","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":37},"updated":"2016-06-02 05:58:16.000000000","message":"The better way here would be to mount the EFI partition and then install the packages. i.e\n\n# create efi directory and mount EFI boot partition\n  mkdir -p \"/boot/efi\"\n  mount $UEFI_DEV /boot/efi\n  mkdir -p \"/boot/efi/EFI/BOOT\"\n\n# TODO: Secure boot packages need to be handled\n  install-packages -m bootloader grub-efi","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"90ff4351f9cda47b35135cd0a364396a6c90a7ae","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            echo \u0027GRUB_PLATFORMS\u003d\"emu efi-32 efi-64 pc\"\u0027 \u003e\u003e /etc/portage/make.conf"},{"line_number":80,"context_line":"        fi"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        # TODO: Secure boot packages need to be handled"},{"line_number":83,"context_line":"        install-packages -m bootloader grub-efi"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # create efi directory and mount EFI boot partition"},{"line_number":86,"context_line":"        mkdir -p \"/boot/efi\""},{"line_number":87,"context_line":"        mount $UEFI_DEV /boot/efi"},{"line_number":88,"context_line":"        mkdir -p \"/boot/efi/EFI/BOOT\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        # Removing existing /boot/grub2/grubenv so that it will not create"},{"line_number":91,"context_line":"        # issues while running grub2-install"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"3aaa91ec_13c96726","line":88,"range":{"start_line":82,"start_character":0,"end_line":88,"end_character":37},"in_reply_to":"9abb7d3a_62e1ed29","updated":"2016-07-01 07:42:05.000000000","message":"Done","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e6488f2fe5859b1805204491a463d660f7276032","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # issues while running grub2-install"},{"line_number":92,"context_line":"        case $DISTRO_NAME in"},{"line_number":93,"context_line":"            \"fedora\"|\"rhel7\"|\"centos7\"|\"centos\")"},{"line_number":94,"context_line":"                rm -f /boot/grub2/grubenv*"},{"line_number":95,"context_line":"            ;;"},{"line_number":96,"context_line":"        esac"},{"line_number":97,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_247a94f1","line":94,"range":{"start_line":94,"start_character":20,"end_line":94,"end_character":42},"updated":"2016-06-13 23:17:29.000000000","message":"/boot/grub/grubenv can certainly exist on debian \u0026 ubuntu systems as well.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bddf1bbe9879b5d0cea62851e092f0fd2ca2c0ce","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        # issues while running grub2-install"},{"line_number":92,"context_line":"        case $DISTRO_NAME in"},{"line_number":93,"context_line":"            \"fedora\"|\"rhel7\"|\"centos7\"|\"centos\")"},{"line_number":94,"context_line":"                rm -f /boot/grub2/grubenv*"},{"line_number":95,"context_line":"            ;;"},{"line_number":96,"context_line":"        esac"},{"line_number":97,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_673c82e1","line":94,"range":{"start_line":94,"start_character":41,"end_line":94,"end_character":42},"updated":"2016-06-15 12:38:03.000000000","message":"If there is any way we can avoid wildcard use, I think that would be ideal.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e6488f2fe5859b1805204491a463d660f7276032","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":157,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":158,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":159,"context_line":"        GRUB_MOD\u003d\"part_gpt fat ext2 normal configfile linux\""},{"line_number":160,"context_line":"        GRUB_MOD+\u003d\" search_fs_uuid search_label terminal serial\""},{"line_number":161,"context_line":"        GRUB_MOD+\u003d\" video video_fb video_bochs usb efi_gop efi_uga\""},{"line_number":162,"context_line":"        $GRUBNAME --modules\u003d\"$GRUB_MOD\" $GRUB_OPTS $BOOT_DEV \\"},{"line_number":163,"context_line":"                --boot-directory\u003d/boot --efi-directory\u003d/boot/efi \\"},{"line_number":164,"context_line":"                --target\u003d$ARCH-efi --removable"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_79f0c9fd","line":161,"range":{"start_line":159,"start_character":6,"end_line":161,"end_character":67},"updated":"2016-06-13 23:17:29.000000000","message":"Lots of modules here - are all these necessary for UEFI? If not we should eliminate what\u0027s not necessary, document inline and/or give users a choice about what is added.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"f0247e3b8574bfdd0568513ffcdf7317b5987385","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":157,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":158,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":159,"context_line":"        GRUB_MOD\u003d\"part_gpt fat ext2 normal configfile linux\""},{"line_number":160,"context_line":"        GRUB_MOD+\u003d\" search_fs_uuid search_label terminal serial\""},{"line_number":161,"context_line":"        GRUB_MOD+\u003d\" video video_fb video_bochs usb efi_gop efi_uga\""},{"line_number":162,"context_line":"        $GRUBNAME --modules\u003d\"$GRUB_MOD\" $GRUB_OPTS $BOOT_DEV \\"},{"line_number":163,"context_line":"                --boot-directory\u003d/boot --efi-directory\u003d/boot/efi \\"},{"line_number":164,"context_line":"                --target\u003d$ARCH-efi --removable"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"1aa78d24_61432214","line":161,"range":{"start_line":159,"start_character":6,"end_line":161,"end_character":67},"in_reply_to":"3aaa91ec_df007903","updated":"2016-07-11 17:47:47.000000000","message":"This is ok, but it\u0027d be great to have a reference (like a link) inline to why these are all required so future developers don\u0027t try to rip bits out.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"942911c43634ebb49d256531681d578a95554680","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":157,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":158,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":159,"context_line":"        GRUB_MOD\u003d\"part_gpt fat ext2 normal configfile linux\""},{"line_number":160,"context_line":"        GRUB_MOD+\u003d\" search_fs_uuid search_label terminal serial\""},{"line_number":161,"context_line":"        GRUB_MOD+\u003d\" video video_fb video_bochs usb efi_gop efi_uga\""},{"line_number":162,"context_line":"        $GRUBNAME --modules\u003d\"$GRUB_MOD\" $GRUB_OPTS $BOOT_DEV \\"},{"line_number":163,"context_line":"                --boot-directory\u003d/boot --efi-directory\u003d/boot/efi \\"},{"line_number":164,"context_line":"                --target\u003d$ARCH-efi --removable"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"5a9d85d2_08cba854","line":161,"range":{"start_line":159,"start_character":6,"end_line":161,"end_character":67},"in_reply_to":"7aa08908_79f0c9fd","updated":"2016-06-20 21:15:10.000000000","message":"+1","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"bcf95287f0246d067603b05822d89155f5926260","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":157,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":158,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":159,"context_line":"        GRUB_MOD\u003d\"part_gpt fat ext2 normal configfile linux\""},{"line_number":160,"context_line":"        GRUB_MOD+\u003d\" search_fs_uuid search_label terminal serial\""},{"line_number":161,"context_line":"        GRUB_MOD+\u003d\" video video_fb video_bochs usb efi_gop efi_uga\""},{"line_number":162,"context_line":"        $GRUBNAME --modules\u003d\"$GRUB_MOD\" $GRUB_OPTS $BOOT_DEV \\"},{"line_number":163,"context_line":"                --boot-directory\u003d/boot --efi-directory\u003d/boot/efi \\"},{"line_number":164,"context_line":"                --target\u003d$ARCH-efi --removable"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"3aaa91ec_df007903","line":161,"range":{"start_line":159,"start_character":6,"end_line":161,"end_character":67},"in_reply_to":"7aa08908_79f0c9fd","updated":"2016-07-01 10:38:48.000000000","message":"All the packages mentioned here are mandatory. Flexibility to add additional packages will be added as follow up patch","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e6488f2fe5859b1805204491a463d660f7276032","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            sed -i -e \u0027s/\\(^GRUB_CMDLINE_LINUX.*\\)\"$/\\1 nofb nomodeset vga\u003dnormal\"/\u0027 /etc/default/grub"},{"line_number":195,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":196,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":197,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":198,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":199,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":200,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_b95fd13f","line":197,"range":{"start_line":197,"start_character":24,"end_line":197,"end_character":56},"updated":"2016-06-13 23:17:29.000000000","message":"This is going to be /boot/efi/boot/grub2 which looks a little strange.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"bcf95287f0246d067603b05822d89155f5926260","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            sed -i -e \u0027s/\\(^GRUB_CMDLINE_LINUX.*\\)\"$/\\1 nofb nomodeset vga\u003dnormal\"/\u0027 /etc/default/grub"},{"line_number":195,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":196,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":197,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":198,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":199,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":200,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"3aaa91ec_ff99f56d","line":197,"range":{"start_line":197,"start_character":24,"end_line":197,"end_character":56},"in_reply_to":"7aa08908_b95fd13f","updated":"2016-07-01 10:38:48.000000000","message":"GRUB_CFG is set to /boot/grub2/grub.cfg.\n\nSince efi will be a separate partition, the path should be /boot/efi/boot/grub2.\n\nWhy do you think it is strange?","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e6488f2fe5859b1805204491a463d660f7276032","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                # grub2 generates linux16 and initrd16 in grub.cfg for efi"},{"line_number":214,"context_line":"                # systems. Resolved as suggested in"},{"line_number":215,"context_line":"                # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1173993"},{"line_number":216,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":217,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":218,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":219,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_043dd88e","line":216,"range":{"start_line":216,"start_character":14,"end_line":216,"end_character":81},"updated":"2016-06-13 23:17:29.000000000","message":"Might be worth checking for the file here prior to acting on it as sed will error out if it\u0027s not there.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"90ff4351f9cda47b35135cd0a364396a6c90a7ae","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                # grub2 generates linux16 and initrd16 in grub.cfg for efi"},{"line_number":214,"context_line":"                # systems. Resolved as suggested in"},{"line_number":215,"context_line":"                # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1173993"},{"line_number":216,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":217,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":218,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":219,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"3aaa91ec_53cf6f28","line":216,"range":{"start_line":216,"start_character":14,"end_line":216,"end_character":81},"in_reply_to":"7aa08908_043dd88e","updated":"2016-07-01 07:42:05.000000000","message":"Done","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e6488f2fe5859b1805204491a463d660f7276032","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1173993"},{"line_number":216,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":217,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":218,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":219,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"},{"line_number":220,"context_line":"set prefix\u003d(\\$root)/boot/grub2"},{"line_number":221,"context_line":"configfile \\$prefix/grub.cfg\""},{"line_number":222,"context_line":"EOF"},{"line_number":223,"context_line":"            fi"},{"line_number":224,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"7aa08908_f9ef99ae","line":221,"range":{"start_line":218,"start_character":14,"end_line":221,"end_character":29},"updated":"2016-06-13 23:17:29.000000000","message":"I would strongly prefer not to see duplicated code. This could be broken out into its own if statement potentially given that the path being acted upon is the same for all the supported distros.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"14ec40d60a7a5a6a7d45998eeb72d75f212d366c","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1173993"},{"line_number":216,"context_line":"                sed -i -e \u0027s/sixteenbit\u003d\"16\"/sixteenbit\u003d\"\"/\u0027 /etc/grub.d/10_linux"},{"line_number":217,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":218,"context_line":"                cat \u003e \"/boot/efi$GRUB_CFG\" \u003c\u003c EOF"},{"line_number":219,"context_line":"search.fs_uuid $DIB_IMAGE_ROOT_FS_UUID root hd0,gpt1"},{"line_number":220,"context_line":"set prefix\u003d(\\$root)/boot/grub2"},{"line_number":221,"context_line":"configfile \\$prefix/grub.cfg\""},{"line_number":222,"context_line":"EOF"},{"line_number":223,"context_line":"            fi"},{"line_number":224,"context_line":"        ;;"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"1aa78d24_5ef8f4c4","line":221,"range":{"start_line":218,"start_character":14,"end_line":221,"end_character":29},"in_reply_to":"7aa08908_f9ef99ae","updated":"2016-07-08 04:48:11.000000000","message":"@Stephanie, the above code is valid only for the first two cases and not for the third one (opensuse)... given this, do you think we can separate it out?","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"1ef82cae670008c22369d4297fdb533573ff03f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"set -eu"},{"line_number":10,"context_line":"set -o pipefail"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if [ \u0027amd64\u0027 \u003d \"$ARCH\" ] ; then"},{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":25,"id":"3aaa91ec_b3081e2f","line":12,"updated":"2016-06-27 21:44:26.000000000","message":"Why are we doing this here? Where we use $ARCH in this script we check for both forms where relevant. A comment would be good - otherwise someone might clean this up mistakenly later if it\u0027s actually needed.","commit_id":"2f9ea1fcc238f3ae0f55c7d0577a7d201c012bad"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"c04fcdf73e06eb71ead7c2296e19d1ca93c280bf","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                fi"},{"line_number":204,"context_line":"            fi"},{"line_number":205,"context_line":"        ;;"},{"line_number":206,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027|\u0027rhel7\u0027)"},{"line_number":207,"context_line":"            echo \u0027GRUB_CMDLINE_LINUX\u003d\"nofb nomodeset vga\u003dnormal\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":208,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":209,"context_line":"                # grub2 generates linux16 and initrd16 in grub.cfg for efi"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1aa78d24_acd8b6f0","line":206,"range":{"start_line":206,"start_character":27,"end_line":206,"end_character":35},"updated":"2016-07-04 11:24:22.000000000","message":"May be i am missing a basic thing here. When building for \u0027centos\u0027 this function (install_grub2) is not executed since DIB_EXTLINUX\u003d1. Can you explain under what conditions we get to this place for \u0027centos\u0027?","commit_id":"9a9b26ea1fa4b82866cbfe5c487e42c01551be6b"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"f2b651725a0f637c8f33a30ceb5912c009485a74","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                fi"},{"line_number":204,"context_line":"            fi"},{"line_number":205,"context_line":"        ;;"},{"line_number":206,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027|\u0027rhel7\u0027)"},{"line_number":207,"context_line":"            echo \u0027GRUB_CMDLINE_LINUX\u003d\"nofb nomodeset vga\u003dnormal\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":208,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":209,"context_line":"                # grub2 generates linux16 and initrd16 in grub.cfg for efi"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1aa78d24_bed63825","line":206,"range":{"start_line":206,"start_character":27,"end_line":206,"end_character":35},"in_reply_to":"1aa78d24_acd8b6f0","updated":"2016-07-08 04:50:55.000000000","message":"@Vinay, if you check the base, this is an existing code. The patch adds rhel17 to it.","commit_id":"9a9b26ea1fa4b82866cbfe5c487e42c01551be6b"},{"author":{"_account_id":18781,"name":"vinay50muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"f856d537e9b120032fc164d97a31256194d2d46e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                fi"},{"line_number":204,"context_line":"            fi"},{"line_number":205,"context_line":"        ;;"},{"line_number":206,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027|\u0027rhel7\u0027)"},{"line_number":207,"context_line":"            echo \u0027GRUB_CMDLINE_LINUX\u003d\"nofb nomodeset vga\u003dnormal\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":208,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":209,"context_line":"                # grub2 generates linux16 and initrd16 in grub.cfg for efi"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"1aa78d24_2859205c","line":206,"range":{"start_line":206,"start_character":27,"end_line":206,"end_character":35},"in_reply_to":"1aa78d24_bed63825","updated":"2016-07-11 06:48:25.000000000","message":"I agree. This is kind of a open question so that others can answer. Should we really need to retain \"centos\" here? I think you can still consider to remove this in a follow up patch.","commit_id":"9a9b26ea1fa4b82866cbfe5c487e42c01551be6b"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p2##\u0027)\u0027p1\u0027"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p1##\u0027 | sed -e \u0027s#mapper/##\u0027)"},{"line_number":23,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":24,"context_line":"        UEFI_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e \u0027s#p2$#p1#\u0027)"},{"line_number":25,"context_line":"    fi"},{"line_number":26,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_ba6d8c34","line":23,"updated":"2016-08-19 23:45:43.000000000","message":"ditto","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"function install_grub2 {"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # Check for offline installation of grub"},{"line_number":66,"context_line":"    if [ ! -n \"${DIB_UEFI_SUPPORT:-}\" ] \u0026\u0026 [ -f \"/tmp/grub/install\" ] ; then"},{"line_number":67,"context_line":"        source /tmp/grub/install"},{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_5a5f3872","line":66,"updated":"2016-08-19 23:45:43.000000000","message":"ditto","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        source /tmp/grub/install"},{"line_number":68,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":69,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":70,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":71,"context_line":"        # Remove stale grub2 and grub folders as they cause issues"},{"line_number":72,"context_line":"        # while installing grub-efi package"},{"line_number":73,"context_line":"        if [ -d /boot/grub2 ] || [ -d /boot/grub ]; then"}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_fa4ee4bf","line":70,"updated":"2016-08-19 23:45:43.000000000","message":"ditto","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":153,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":154,"context_line":"    elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":155,"context_line":"        # Following are the grub module packages needed for UEFI support"},{"line_number":156,"context_line":"        GRUB_MOD\u003d\"part_gpt fat ext2 normal configfile linux\""},{"line_number":157,"context_line":"        GRUB_MOD+\u003d\" search_fs_uuid search_label terminal serial\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_3ac7dc13","line":154,"updated":"2016-08-19 23:45:43.000000000","message":"ditto","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        \u0027ubuntu\u0027|\u0027debian\u0027)"},{"line_number":191,"context_line":"            sed -i -e \u0027s/\\(^GRUB_CMDLINE_LINUX.*\\)\"$/\\1 nofb nomodeset vga\u003dnormal\"/\u0027 /etc/default/grub"},{"line_number":192,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":193,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":194,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":195,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":196,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_7a9f9403","line":193,"updated":"2016-08-19 23:45:43.000000000","message":"ditto","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            sed -i -e \u0027s/\\(^GRUB_CMDLINE_LINUX.*\\)\"$/\\1 nofb nomodeset vga\u003dnormal\"/\u0027 /etc/default/grub"},{"line_number":192,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":193,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":194,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":195,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":196,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":197,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_d5c13b30","line":194,"updated":"2016-08-19 23:45:43.000000000","message":"This is making \"/boot/efi/boot/grub/\" or \"/boot/efi/boot/grub2/\", neither of which are being used.\n\nI can\u0027t find any reference of the \u0027grub2\u0027 instance ever being used on an ESP partition on the Ubuntu wiki, Archwiki, Gentoo wiki, grub docs, or grub source.\n\nI think it\u0027s always /boot/efi/EFI/GRUB/grub.cfg in /boot/efi/EFI/BOOT/grub.cfg","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            GRUB_MKCONFIG\u003dupdate-grub"},{"line_number":193,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":194,"context_line":"                mkdir -p $(dirname \"/boot/efi$GRUB_CFG\")"},{"line_number":195,"context_line":"                if [ -e /boot/efi/EFI/BOOT/grub.cfg ]; then"},{"line_number":196,"context_line":"                    sed -i \"s| root| root hd0,gpt1|\" /boot/efi/EFI/BOOT/grub.cfg || fail \"failed update hd0\""},{"line_number":197,"context_line":"                    cp /boot/efi/EFI/BOOT/grub.cfg \"/boot/efi$GRUB_CFG\""},{"line_number":198,"context_line":"                else"}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_b5891fcd","line":195,"updated":"2016-08-19 23:45:43.000000000","message":"I don\u0027t think grub-install ever installs grub.cfg to the ESP, so this will always return false.","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        ;;"},{"line_number":207,"context_line":"        \u0027fedora\u0027|\u0027centos7\u0027|\u0027centos\u0027|\u0027rhel7\u0027)"},{"line_number":208,"context_line":"            echo \u0027GRUB_CMDLINE_LINUX\u003d\"nofb nomodeset vga\u003dnormal\"\u0027 \u003e\u003e/etc/default/grub"},{"line_number":209,"context_line":"            if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":210,"context_line":"                # grub2 generates linux16 and initrd16 in grub.cfg for efi"},{"line_number":211,"context_line":"                # systems. Resolved as suggested in"},{"line_number":212,"context_line":"                # https://bugzilla.redhat.com/show_bug.cgi?id\u003d1173993"}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_75b6878b","line":209,"updated":"2016-08-19 23:45:43.000000000","message":"ditto","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"}],"elements/bootloader/pkg-map":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7d8cf2532c63adc4eca73b12d8a4cb19ff4d7e96","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"redhat\": {"},{"line_number":13,"context_line":"      \"extlinux\": \"syslinux-extlinux\","},{"line_number":14,"context_line":"      \"grub-pc\": \"grub2-tools grub2\","},{"line_number":15,"context_line":"      \"grub-efi\": \"grub2-efi grub2-efi-modules\""},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"  },"},{"line_number":18,"context_line":"  \"default\": {"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"3afc51ec_87bb1ac4","line":15,"range":{"start_line":15,"start_character":7,"end_line":15,"end_character":46},"updated":"2016-03-13 11:04:43.000000000","message":"Can this be done using \u0027grub2\u0027 element, by using \u0027element-deps\u0027?\nhttps://github.com/openstack/diskimage-builder/blob/master/elements/grub2","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"96a89bbb07ce5e6458decd08867d74cdc0f64548","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"redhat\": {"},{"line_number":13,"context_line":"      \"extlinux\": \"syslinux-extlinux\","},{"line_number":14,"context_line":"      \"grub-pc\": \"grub2-tools grub2\","},{"line_number":15,"context_line":"      \"grub-efi\": \"grub2-efi grub2-efi-modules\""},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"  },"},{"line_number":18,"context_line":"  \"default\": {"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"3afc51ec_40a3a34f","line":15,"range":{"start_line":15,"start_character":7,"end_line":15,"end_character":46},"in_reply_to":"3afc51ec_87bb1ac4","updated":"2016-03-14 11:00:45.000000000","message":"No, as of now grub2 element is not stable and does not support all the Operating Systems. We will consider it once it matures and supports most of the Operating Systems.","commit_id":"d3c28aca384ef09963d5c292e049018c2efeb289"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bddf1bbe9879b5d0cea62851e092f0fd2ca2c0ce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      \"dkms_package\": \"\","},{"line_number":5,"context_line":"      \"extlinux\": \"syslinux\","},{"line_number":6,"context_line":"      \"grub-pc\": \"grub\","},{"line_number":7,"context_line":"      \"grub-efi\": \"sys-boot/grub:2\""},{"line_number":8,"context_line":"    },"},{"line_number":9,"context_line":"    \"suse\": {"},{"line_number":10,"context_line":"      \"dkms_package\": \"\","}],"source_content_type":"application/octet-stream","patch_set":22,"id":"7aa08908_bc6ac37f","line":7,"updated":"2016-06-15 12:38:03.000000000","message":"Was gentoo tested?  Does it work?","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"942911c43634ebb49d256531681d578a95554680","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \"suse\": {"},{"line_number":10,"context_line":"      \"dkms_package\": \"\","},{"line_number":11,"context_line":"      \"grub-pc\": \"grub2\","},{"line_number":12,"context_line":"      \"grub-efi\": \"grub2-efi\""},{"line_number":13,"context_line":"    },"},{"line_number":14,"context_line":"    \"redhat\": {"},{"line_number":15,"context_line":"      \"extlinux\": \"syslinux-extlinux\","}],"source_content_type":"application/octet-stream","patch_set":22,"id":"5a9d85d2_0855684f","line":12,"updated":"2016-06-20 21:15:10.000000000","message":"same comment here.","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"},{"author":{"_account_id":12411,"name":"sandhya","email":"sandhya.ganapathy@hp.com","username":"sandhya"},"change_message_id":"90ff4351f9cda47b35135cd0a364396a6c90a7ae","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \"suse\": {"},{"line_number":10,"context_line":"      \"dkms_package\": \"\","},{"line_number":11,"context_line":"      \"grub-pc\": \"grub2\","},{"line_number":12,"context_line":"      \"grub-efi\": \"grub2-efi\""},{"line_number":13,"context_line":"    },"},{"line_number":14,"context_line":"    \"redhat\": {"},{"line_number":15,"context_line":"      \"extlinux\": \"syslinux-extlinux\","}],"source_content_type":"application/octet-stream","patch_set":22,"id":"3aaa91ec_a35d257b","line":12,"in_reply_to":"5a9d85d2_0855684f","updated":"2016-07-01 07:42:05.000000000","message":"suse was tested","commit_id":"ec0513ed6f5f345b4dec09df4722f82e4c08f5a2"}],"elements/vm/README.rst":[{"author":{"_account_id":10369,"name":"lokesh s","email":"slokesh184@gmail.com","username":"loki"},"change_message_id":"52205582afadb881259113d6204d5b596a30fe4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Sets up a partitioned disk (rather than building just one filesystem with no"},{"line_number":5,"context_line":"partition table)."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"For UEFI systems, to configure the size of an EFI System Partition "},{"line_number":8,"context_line":"(in short ESP), set the environment variable DIB_UEFI_ESP_SIZE."},{"line_number":9,"context_line":"Ensure the size is understandable format by parted tool."},{"line_number":10,"context_line":"For example, to make ESP size as 512MB use following command:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5aef4532_af2b7d93","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":66},"updated":"2016-03-08 09:40:19.000000000","message":"nit: please remove white space.","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"8ac9fd7076f6cf6abac8b666fea66bb40f293d2d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Sets up a partitioned disk (rather than building just one filesystem with no"},{"line_number":5,"context_line":"partition table)."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"For UEFI systems, to configure the size of an EFI System Partition "},{"line_number":8,"context_line":"(in short ESP), set the environment variable DIB_UEFI_ESP_SIZE."},{"line_number":9,"context_line":"Ensure the size is understandable format by parted tool."},{"line_number":10,"context_line":"For example, to make ESP size as 512MB use following command:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5aef4532_833bf537","line":7,"range":{"start_line":7,"start_character":57,"end_line":7,"end_character":66},"in_reply_to":"5aef4532_af2b7d93","updated":"2016-03-08 13:08:45.000000000","message":"Done","commit_id":"e8f1725c3934b9011e2f2e6bcf81771804ba656a"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"For UEFI systems, to configure the size of an EFI System Partition"},{"line_number":8,"context_line":"(in short ESP), set the environment variable DIB_UEFI_ESP_SIZE."},{"line_number":9,"context_line":"Ensure the size is in understandable format by parted tool."},{"line_number":10,"context_line":"For example, to make ESP size as 512MB use following command:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    export DIB_UEFI_ESP_SIZE\u003d512MiB"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_a5b20492","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":58},"updated":"2016-05-10 21:29:35.000000000","message":"\"is in a format the parted tool can understand\"","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"For UEFI systems, to configure the size of an EFI System Partition"},{"line_number":8,"context_line":"(in short ESP), set the environment variable DIB_UEFI_ESP_SIZE."},{"line_number":9,"context_line":"Ensure the size is in understandable format by parted tool."},{"line_number":10,"context_line":"For example, to make ESP size as 512MB use following command:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    export DIB_UEFI_ESP_SIZE\u003d512MiB"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_c5ed88b8","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":38},"updated":"2016-05-10 21:29:35.000000000","message":"\"to create a 512MB ESP\"","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"55c72c31a7686c37a94a34385f643f9161c4f4c9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"For UEFI systems, to configure the size of an EFI System Partition"},{"line_number":8,"context_line":"(in short ESP), set the environment variable DIB_UEFI_ESP_SIZE."},{"line_number":9,"context_line":"Ensure the size is in understandable format by parted tool."},{"line_number":10,"context_line":"For example, to make ESP size as 512MB use following command:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    export DIB_UEFI_ESP_SIZE\u003d512MiB"}],"source_content_type":"text/x-rst","patch_set":18,"id":"dab17558_6533fc62","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":43},"updated":"2016-05-10 21:29:35.000000000","message":"use the","commit_id":"a4a163952b80260e5928bfb9dcab17ca9c36756d"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"f60ee1e76e543a04b493395247b646009d068724","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Ensure the size is in a format the parted tool can understand."},{"line_number":10,"context_line":"For example, to create a 512MB ESP use the following command:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    export DIB_UEFI_ESP_SIZE\u003d512MiB"}],"source_content_type":"text/x-rst","patch_set":28,"id":"dada55a8_cb53656b","line":12,"updated":"2016-07-22 17:03:26.000000000","message":"Can you document this var in the same format we document vars in apt-sources/README.rst? Also include a default value please.\n\nCan you also add the DIB_UEFI_SUPPORT var to this README","commit_id":"ce6ec59ed7f9d454df85cf807d1351263c39efff"}],"elements/vm/block-device.d/10-partition":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d743226f15738ca39736d04b358f9f2659a277ae","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${DM}p2\""},{"line_number":60,"context_line":"else"},{"line_number":61,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":62,"context_line":"        sudo mkfs -t vfat -n UEFI ${IMAGE_BLOCK_DEVICE}p2"},{"line_number":63,"context_line":"    fi"},{"line_number":64,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${IMAGE_BLOCK_DEVICE}p1\""},{"line_number":65,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_5871a0df","line":62,"range":{"start_line":62,"start_character":55,"end_line":62,"end_character":57},"updated":"2016-03-23 05:06:59.000000000","message":"why p2? what is the final partition name we get here?","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":16347,"name":"Purandhar Mannidi","display_name":"Sai","email":"sai438@gmail.com","username":"mpsairam"},"change_message_id":"4da71d0896f4e1ae55a8e06ee97e0217bcc1513c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${DM}p2\""},{"line_number":60,"context_line":"else"},{"line_number":61,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":62,"context_line":"        sudo mkfs -t vfat -n UEFI ${IMAGE_BLOCK_DEVICE}p2"},{"line_number":63,"context_line":"    fi"},{"line_number":64,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${IMAGE_BLOCK_DEVICE}p1\""},{"line_number":65,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"fa0719c6_c70a9325","line":62,"range":{"start_line":62,"start_character":55,"end_line":62,"end_character":57},"in_reply_to":"fa0719c6_5871a0df","updated":"2016-03-24 12:46:25.000000000","message":"We are formatting the EFI System Partition which is created second and by default when parted is used it starts with partition number one. Here, ESP partition is number two. Refer to line no 24,25\n\nFinal partition name would be \u003cloop device\u003ep2. For example, if image is mounted at /dev/loop0 then root file system partition is dev/loop0p1 and ESP partition is /dev/loop0p2.","commit_id":"262c346a3ce4d2c1450b9ef4dd3aed15f04fa0f8"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"9de65dbdc09e272203b7c84a0a6360a859d0f7fb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        set 1 boot on \\"},{"line_number":18,"context_line":"        set 1 prep on \\"},{"line_number":19,"context_line":"        mkpart primary 9cyl 100%"},{"line_number":20,"context_line":"elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":21,"context_line":"    ESP_SIZE\u003d${DIB_UEFI_ESP_SIZE:-110MiB}"},{"line_number":22,"context_line":"    sudo parted -a optimal -s $IMAGE_BLOCK_DEVICE \\"},{"line_number":23,"context_line":"        mklabel gpt \\"}],"source_content_type":"application/x-shellscript","patch_set":20,"id":"bab6814e_82052312","line":20,"updated":"2016-05-22 09:37:30.000000000","message":"At this point you inject knowledge about your changes of the bootloader element into a *completely* different element.\n\nWhen continue in this way, the list here gets longer and longer\nand the dependency to the different elements is lost.\n\nWhy don\u0027t you put it separately? Why not in the bootloader element?\n\nWhy do you fix things in this way? What happens if e.g. one user needs the first partition as UEFI boot partition and tries to use partitioning-sfdisk for this?","commit_id":"6de9659300c151dbef78f15c3001d284841d8ca3"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"9de65dbdc09e272203b7c84a0a6360a859d0f7fb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${DM}p2\""},{"line_number":60,"context_line":"else"},{"line_number":61,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":62,"context_line":"        sudo mkfs -t vfat -n UEFI ${IMAGE_BLOCK_DEVICE}p2"},{"line_number":63,"context_line":"    fi"},{"line_number":64,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${IMAGE_BLOCK_DEVICE}p1\""},{"line_number":65,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":20,"id":"bab6814e_e21fcf58","line":62,"updated":"2016-05-22 09:37:30.000000000","message":"... here is exactly one of issues just discussed: you assume that the UEFI partition is always p2 - which, depending on your use of the partitioning-sfdisk element might not be true.\n\nAdditional: Why do you split the mkfs of the two partitions into two different places? Why do you do it at this place and not at the place where partition one is formatted?","commit_id":"6de9659300c151dbef78f15c3001d284841d8ca3"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"f60ee1e76e543a04b493395247b646009d068724","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        set 1 prep on \\"},{"line_number":20,"context_line":"        mkpart primary 9cyl 100%"},{"line_number":21,"context_line":"elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":22,"context_line":"    ESP_SIZE\u003d${DIB_UEFI_ESP_SIZE:-110MiB}"},{"line_number":23,"context_line":"    sudo parted -a optimal -s $IMAGE_BLOCK_DEVICE \\"},{"line_number":24,"context_line":"        mklabel gpt \\"},{"line_number":25,"context_line":"        mkpart primary $ESP_SIZE 100% \\"}],"source_content_type":"application/x-shellscript","patch_set":28,"id":"dada55a8_6b87d9d7","line":22,"updated":"2016-07-22 17:03:26.000000000","message":"Can we break this var DIB_UEFI_ESP_SIZE out in to environment.d as something we export - it makes it a lot easier to find where the default value is set.","commit_id":"ce6ec59ed7f9d454df85cf807d1351263c39efff"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        set 1 boot on \\"},{"line_number":19,"context_line":"        set 1 prep on \\"},{"line_number":20,"context_line":"        mkpart primary 9cyl 100%"},{"line_number":21,"context_line":"elif [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":22,"context_line":"    ESP_SIZE\u003d${DIB_UEFI_ESP_SIZE:-110MiB}"},{"line_number":23,"context_line":"    sudo parted -a optimal -s $IMAGE_BLOCK_DEVICE \\"},{"line_number":24,"context_line":"        mklabel gpt \\"}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_5a11f8ab","line":21,"updated":"2016-08-19 23:45:43.000000000","message":"This will always return true due if $DIB_UEFI_SUPPORT is non-zero (even if the value is \u0027false\u0027).\n\nvm/environment.d/50-vm is setting this environment variable to non-zero too.","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"},{"author":{"_account_id":6721,"name":"Ben Kero","email":"ben.kero@gmail.com","username":"ben-kero"},"change_message_id":"997d3bbbb4f3e6c2819297b777a8d9eb4d11a5a5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    DM\u003d${IMAGE_BLOCK_DEVICE/#\\/dev/\\/dev\\/mapper}"},{"line_number":60,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${DM}p2\""},{"line_number":61,"context_line":"else"},{"line_number":62,"context_line":"    if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":63,"context_line":"        sudo mkfs -t vfat -n UEFI ${IMAGE_BLOCK_DEVICE}p1"},{"line_number":64,"context_line":"    fi"},{"line_number":65,"context_line":"    echo \"IMAGE_BLOCK_DEVICE\u003d${IMAGE_BLOCK_DEVICE}p1\""}],"source_content_type":"application/x-shellscript","patch_set":35,"id":"1ac06dbe_ba262c14","line":62,"updated":"2016-08-19 23:45:43.000000000","message":"ditto","commit_id":"daa7b9ff7e1dd273fcedb193e8930aed3a73084d"}]}