)]}'
{"elements/gentoo/bin/install-packages":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"6311331542ad3caf6e6e93a0824ddf78d674c68a","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function install_gentoo_packages {"},{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    if grep -q /dev/shm /proc/mounts; then"},{"line_number":62,"context_line":"        emerge $@"},{"line_number":63,"context_line":"    elif [[ -k /dev/shm ]]; then"},{"line_number":64,"context_line":"        emerge $@"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5aef4532_f24e976d","line":61,"updated":"2016-03-10 02:21:26.000000000","message":"probably should subshell this (though as ive seen dib doesnt really follow a bash coding standard...)\n\nif [[ $( ) ]]; then","commit_id":"5deec195643ec4ebaa39049272c2bd553e5853f5"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"fe873e413066599f6beb046dace68bc72678e950","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function install_gentoo_packages {"},{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    if grep -q /dev/shm /proc/mounts; then"},{"line_number":62,"context_line":"        emerge $@"},{"line_number":63,"context_line":"    elif [[ -k /dev/shm ]]; then"},{"line_number":64,"context_line":"        emerge $@"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5aef4532_72228753","line":61,"in_reply_to":"5aef4532_32c8ffa7","updated":"2016-03-10 02:30:21.000000000","message":"we should rewrite dib following https://google.github.io/styleguide/shell.xml","commit_id":"5deec195643ec4ebaa39049272c2bd553e5853f5"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"c99bf9ae9b1ea816ace91c2e048b0b3f3431f8b9","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function install_gentoo_packages {"},{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    if grep -q /dev/shm /proc/mounts; then"},{"line_number":62,"context_line":"        emerge $@"},{"line_number":63,"context_line":"    elif [[ -k /dev/shm ]]; then"},{"line_number":64,"context_line":"        emerge $@"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3afc51ec_3bb18590","line":61,"in_reply_to":"5aef4532_72228753","updated":"2016-03-13 00:38:19.000000000","message":"Yep - the tl;dr is that dib code uses test ([) where possible and built in conditionals where necessary (regex matching, etc). There wasn\u0027t much thought given to this beyond \u0027that\u0027s what the code already is so lets at least try and make it consistent\u0027.\n\nA style guide would be a good convo to bring up in a larger context (the ML) - I personally would love to adopt one but I am not really interested in dealing with the code churn...","commit_id":"5deec195643ec4ebaa39049272c2bd553e5853f5"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"fd9aff7a155ecd82562538ece913a4488c3a9072","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"function install_gentoo_packages {"},{"line_number":60,"context_line":"    RUN_ONCE_SHM\u003d\u00271\u0027"},{"line_number":61,"context_line":"    if grep -q /dev/shm /proc/mounts; then"},{"line_number":62,"context_line":"        emerge $@"},{"line_number":63,"context_line":"    elif [[ -k /dev/shm ]]; then"},{"line_number":64,"context_line":"        emerge $@"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5aef4532_32c8ffa7","line":61,"in_reply_to":"5aef4532_f24e976d","updated":"2016-03-10 02:26:43.000000000","message":"ya, I was told not to do that before to match the rest of dib :(","commit_id":"5deec195643ec4ebaa39049272c2bd553e5853f5"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ab8299c58e8d635a9fbba2d97f2df68c5d8fb1f6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    else"},{"line_number":66,"context_line":"        fix_shm"},{"line_number":67,"context_line":"        emerge $@"},{"line_number":68,"context_line":"        unfix_shm"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1af94dfe_0f9c0768","line":68,"updated":"2016-03-17 05:22:03.000000000","message":"Why this fix/unfix shm logic here ?","commit_id":"9707cf5282ee74cc40adedec96f010f39ca389cb"},{"author":{"_account_id":14288,"name":"Matthew Thode","display_name":"prometheanfire","email":"mthode@mthode.org","username":"prometheanfire"},"change_message_id":"6c49c8ee86a5db080943ba5e9d1ea16ca185dc45","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    else"},{"line_number":66,"context_line":"        fix_shm"},{"line_number":67,"context_line":"        emerge $@"},{"line_number":68,"context_line":"        unfix_shm"},{"line_number":69,"context_line":"    fi"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1af94dfe_8fb497d1","line":68,"in_reply_to":"1af94dfe_0f9c0768","updated":"2016-03-17 05:25:36.000000000","message":"In testing the element it was required.  Emerge needs it unfortunately.","commit_id":"9707cf5282ee74cc40adedec96f010f39ca389cb"}]}