)]}'
{"id":"openstack%2Fdiskimage-builder~294384","triplet_id":"openstack%2Fdiskimage-builder~master~Id57c016643f89c6c32646b817f8779cba1894655","project":"openstack/diskimage-builder","branch":"master","topic":"centos-minimal-eth1","hashtags":[],"change_id":"Id57c016643f89c6c32646b817f8779cba1894655","subject":"centos-minimal: Disable creation of eth0/eth1 interface scripts","status":"ABANDONED","created":"2016-03-18 04:25:45.000000000","updated":"2016-04-21 04:53:24.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"16ef8857c0858b236125260cd28be492c8c74dcf","_number":294384,"virtual_id_number":294384,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-03-21 07:25:20.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"date":"2016-04-02 15:04:37.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":1,"date":"2016-03-21 08:03:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2016-04-18 18:16:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"value":1,"date":"2016-04-18 21:36:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":1,"date":"2016-03-21 14:26:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"value":1,"date":"2016-04-02 15:04:43.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-21 08:03:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-21 14:26:08.000000000","updated_by":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"reviewer":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"state":"REVIEWER"},{"updated":"2016-04-02 15:04:37.000000000","updated_by":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"reviewer":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"state":"REVIEWER"},{"updated":"2016-04-18 18:16:37.000000000","updated_by":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"reviewer":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"state":"REVIEWER"},{"updated":"2016-04-18 21:36:45.000000000","updated_by":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"reviewer":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"state":"REVIEWER"}],"messages":[{"id":"5ed840547b881c9d6ea85e7198b1854c584f1caf","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-03-18 04:25:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b5f0c05a39efdc7440ee4b3a8836d3046e34a0ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 05:27:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-pep8 http://logs.openstack.org/84/294384/1/check/gate-diskimage-builder-pep8/a72ac49/ : SUCCESS in 4m 10s\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/84/294384/1/check/gate-diskimage-builder-docs/ab011ad//doc/build/html/ : SUCCESS in 4m 52s\n- gate-diskimage-builder-python27 http://logs.openstack.org/84/294384/1/check/gate-diskimage-builder-python27/1b237ee/ : SUCCESS in 3m 46s\n- gate-diskimage-builder-python34 http://logs.openstack.org/84/294384/1/check/gate-diskimage-builder-python34/a38cc81/ : SUCCESS in 3m 57s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/84/294384/1/check/gate-dib-dsvm-functests-ubuntu-trusty/fad2ade/ : FAILURE in 16s\n- gate-dib-dsvm-functests-devstack-centos7 http://logs.openstack.org/84/294384/1/check/gate-dib-dsvm-functests-devstack-centos7/0aa48a4/ : FAILURE in 2m 53s\n- gate-tempest-dsvm-ironic-pxe_ssh-dib http://logs.openstack.org/84/294384/1/check/gate-tempest-dsvm-ironic-pxe_ssh-dib/573b6dd/ : SUCCESS in 56m 48s","accounts_in_message":[],"_revision_number":1},{"id":"9de91541afe7519bee96d0a93f3982902b2e96d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-18 05:51:20.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/84/294384/1/check-tripleo/gate-tripleo-ci-f22-nonha/38fcaaf/ : SUCCESS in 1h 25m 27s","accounts_in_message":[],"_revision_number":1},{"id":"7b97cd5314e3b406c9ee37bfe7058b9fc410f494","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-03-21 07:25:20.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"9a1b7a119820e0e60a830d3d28feb3cff8c306e8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-21 07:33:51.000000000","message":"Patch Set 1:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/84/294384/1/check-tripleo/gate-tripleo-ci-f22-nonha/702f514/ : FAILURE in 8m 14s","accounts_in_message":[],"_revision_number":1},{"id":"2a3df314a7fa1931885a27ca1b79747fe96970ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-21 08:03:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/84/294384/1/check/gate-diskimage-builder-docs/dd40f8e//doc/build/html/ : SUCCESS in 1m 29s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/84/294384/1/check/gate-diskimage-builder-pep8/cd14708/ : SUCCESS in 13m 17s\n- gate-diskimage-builder-python27 http://logs.openstack.org/84/294384/1/check/gate-diskimage-builder-python27/5a77f93/ : SUCCESS in 2m 41s\n- gate-diskimage-builder-python34 http://logs.openstack.org/84/294384/1/check/gate-diskimage-builder-python34/13b2cd6/ : SUCCESS in 2m 57s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/84/294384/1/check/gate-dib-dsvm-functests-ubuntu-trusty/fc10433/ : SUCCESS in 15m 17s\n- gate-dib-dsvm-functests-devstack-centos7 http://logs.openstack.org/84/294384/1/check/gate-dib-dsvm-functests-devstack-centos7/0cd7cfb/ : SUCCESS in 20m 24s\n- gate-tempest-dsvm-ironic-pxe_ssh-dib http://logs.openstack.org/84/294384/1/check/gate-tempest-dsvm-ironic-pxe_ssh-dib/29209b1/ : SUCCESS in 35m 52s","accounts_in_message":[],"_revision_number":1},{"id":"07e9b264d1076cc3530f0d2918739bc645e03373","author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"date":"2016-03-21 14:26:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"78dd224556073d12dd2fcf049b98facb3b6ce76f","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-04-02 15:04:37.000000000","message":"Patch Set 1:\n\nSo, I am inclined to agree that we shouldn\u0027t be creating the static interface files in our minimal images. I think the reason we create them at all is that the Ubuntu cloud images created them and we were attempting to replicate their behavior.\n\nWhat do you think of removing static interfaces from all the -minimal images, not just centos/fedora?","accounts_in_message":[],"_revision_number":1},{"id":"a1a86d1e81360d91f9ad6b72218a252ad71bd392","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-04-02 15:04:43.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"109a262ede5d59d7a5213f5ac07be5cd31ddaf88","author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"date":"2016-04-18 18:16:37.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nI have one worry, which is that this introduces backwards incompatibility with existing builds which expect those files to be there.","accounts_in_message":[],"_revision_number":1},{"id":"2563c3bf00101347af670b1e015abadd0f5e8fc5","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-04-18 21:36:45.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4ade4aa7bfe22b534992574468bf73b9b19020b2","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-04-21 04:53:24.000000000","message":"Abandoned\n\n@Greg -- I agree that we should not be creating these.  I have approved I49c74a3285e6a610ac723bdf976f3727d2736749 to work around the immediate issue and will work on that","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5dcedda91d424a00769a5794e0d9ec6d8681e371","revisions":{"5dcedda91d424a00769a5794e0d9ec6d8681e371":{"kind":"REWORK","_number":1,"created":"2016-03-18 04:25:45.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/84/294384/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/84/294384/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/84/294384/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/84/294384/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/84/294384/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/84/294384/1"}}},"commit":{"parents":[{"commit":"db50f8f8e1a63b095e7c44055e1775157e1f185b","subject":"Merge \"Reorder developer quickstart docs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/db50f8f8e1a63b095e7c44055e1775157e1f185b"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-03-18 04:18:21.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-03-18 04:18:21.000000000","tz":660},"subject":"centos-minimal: Disable creation of eth0/eth1 interface scripts","message":"centos-minimal: Disable creation of eth0/eth1 interface scripts\n\nIn I3f1ffeb6de3b1f952292a144efab9554f7f99a5f I disabled creation of\nthe interface scripts for Fedora because there have \"stable device\nnames\" and so aren\u0027t likely to have an eth0 \u0026 eth1.\n\nHaving this on for centos-minimal has just bitten us when trying to\ndeploy this into openstack CI.  What\u0027s silly is that we are creating\nthe interfaces with this falg, but then the simple-init install goes\nand removes the eth0 interface file [1].\n\nThis lead to the confusing situation of glean *not* bringing up eth1\non centos-minimal, because it was already configured for DHCP.\n\nThis is unnecessary and confusing.  Creating eth0 and eth1 statically\nlike this is really just aiming the gun right at your foot, because\nthese days interface names can change or be totally different.  The\nonly sane thing to do is to use a dynamic configuration element like\nsimple-init or cloud-init.  If you really want to opt in to creating\nthese, it should not be the default.\n\nThus disable creation of the default interfaces for centos-minimal\ntoo.  I\u0027ve updated the documentation to reflect what\u0027s going on.\n\n[1] http://git.openstack.org/cgit/openstack/diskimage-builder/tree/elements/simple-init/install.d/60-simple-init-remove-interfaces\n\nChange-Id: Id57c016643f89c6c32646b817f8779cba1894655\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5dcedda91d424a00769a5794e0d9ec6d8681e371"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5dcedda91d424a00769a5794e0d9ec6d8681e371"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"db50f8f8e1a63b095e7c44055e1775157e1f185b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}