)]}'
{"elements/ironic-agent/README.rst":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a58023e33e1b200b50ae9f8dc91c2bc65351cee9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  in order to support source based installation of ironic-python-agent and its"},{"line_number":17,"context_line":"  dependencies."},{"line_number":18,"context_line":"* Copy self-signed certificate if any, which is set to the environment"},{"line_number":19,"context_line":"  variable ``CA_CERT`` for validating the authenticity by ironic-python-agent"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This element outputs three files:"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a1b2928_f3b807e8","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":20},"updated":"2016-04-11 07:14:03.000000000","message":"CA implies that this certificate comes from a Certificate Authority, and it seems to me that this is not the intent of this CR. Is there a chance to change this naming? On a side note, it would also be useful to be able to inject CA certs, that way the certificate doesn\u0027t need to be self-signed.","commit_id":"7d71cca9c10cb43aeeec4dd3650566faf3cd84ab"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ba4e3bf94d9e609f2f2e43ceceb381683b8fbab9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  in order to support source based installation of ironic-python-agent and its"},{"line_number":17,"context_line":"  dependencies."},{"line_number":18,"context_line":"* Copy self-signed certificate if any, which is set to the environment"},{"line_number":19,"context_line":"  variable ``CA_CERT`` for validating the authenticity by ironic-python-agent"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"This element outputs three files:"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"7a1b2928_8ecb5a72","line":19,"range":{"start_line":19,"start_character":13,"end_line":19,"end_character":20},"in_reply_to":"7a1b2928_f3b807e8","updated":"2016-04-11 12:04:47.000000000","message":"Done","commit_id":"7d71cca9c10cb43aeeec4dd3650566faf3cd84ab"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"574c9625e93067aaee1a7aedc9202ccaa7e5e570","unresolved":false,"context_lines":[{"line_number":15,"context_line":"* When installing from source, ``python-dev`` and ``gcc`` are also installed"},{"line_number":16,"context_line":"  in order to support source based installation of ironic-python-agent and its"},{"line_number":17,"context_line":"  dependencies."},{"line_number":18,"context_line":"* Install the certificate if any, which is set to the environment variable "},{"line_number":19,"context_line":"  ``DIB_CERT`` for validating the authenticity by ironic-python-agent. The"},{"line_number":20,"context_line":"  certificate can be self-signed certificate or CA certificate."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a1b2928_eec80e77","line":18,"range":{"start_line":18,"start_character":74,"end_line":18,"end_character":75},"updated":"2016-04-11 12:00:21.000000000","message":"nit: whitespace in the end of this line","commit_id":"0b37ed48f0f416b78a7ffcac63839b6616e0acb8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b79270f1e596673a03dfd3a0e6934c4541da520a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"* When installing from source, ``python-dev`` and ``gcc`` are also installed"},{"line_number":16,"context_line":"  in order to support source based installation of ironic-python-agent and its"},{"line_number":17,"context_line":"  dependencies."},{"line_number":18,"context_line":"* Install the certificate if any, which is set to the environment variable "},{"line_number":19,"context_line":"  ``DIB_CERT`` for validating the authenticity by ironic-python-agent. The"},{"line_number":20,"context_line":"  certificate can be self-signed certificate or CA certificate."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7a1b2928_21821753","line":18,"range":{"start_line":18,"start_character":74,"end_line":18,"end_character":75},"in_reply_to":"7a1b2928_eec80e77","updated":"2016-04-11 12:11:50.000000000","message":"Done","commit_id":"0b37ed48f0f416b78a7ffcac63839b6616e0acb8"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0ae5a2d982b5f9f7ab8e6ab816b66beff782f5b7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  in order to support source based installation of ironic-python-agent and its"},{"line_number":17,"context_line":"  dependencies."},{"line_number":18,"context_line":"* Install the certificate if any, which is set to the environment variable"},{"line_number":19,"context_line":"  ``DIB_CERT`` for validating the authenticity by ironic-python-agent. The"},{"line_number":20,"context_line":"  certificate can be self-signed certificate or CA certificate."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This element outputs three files:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_5819aa87","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":12},"updated":"2016-04-13 20:54:17.000000000","message":"DIB_CERT feels very generic for a certificate that\u0027s only being installed for the IPA virtualenv.  Can we call this something like DIB_IPA_CERT or something?","commit_id":"f87c9bf90966d152b9308d3d5529b4a330cd7a25"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cf4cc21a268b1701eb1f33fc67910d18bc0a5ce2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  in order to support source based installation of ironic-python-agent and its"},{"line_number":17,"context_line":"  dependencies."},{"line_number":18,"context_line":"* Install the certificate if any, which is set to the environment variable"},{"line_number":19,"context_line":"  ``DIB_CERT`` for validating the authenticity by ironic-python-agent. The"},{"line_number":20,"context_line":"  certificate can be self-signed certificate or CA certificate."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This element outputs three files:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"5a18252c_212bb395","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":12},"in_reply_to":"5a18252c_5819aa87","updated":"2016-04-14 13:52:36.000000000","message":"Done","commit_id":"f87c9bf90966d152b9308d3d5529b4a330cd7a25"}],"elements/ironic-agent/install.d/ironic-agent-source-install/60-ironic-agent-install":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0656f59ad15ccd5d586059f178c473b74368eb03","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Copying the self signed certificate for request library"},{"line_number":24,"context_line":"if [ -f /tmp/in_target.d/server.pem ]; then"},{"line_number":25,"context_line":"    cat /tmp/in_target.d/server.pem \u003e\u003e $IPADIR/venv/lib/python2.7/site-packages/requests/cacert.pem"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"case \"$DIB_INIT_SYSTEM\" in"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa0719c6_abc0a12b","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":99},"updated":"2016-03-22 04:48:56.000000000","message":"Better not to hard code this path. \nFind out the path used by request library in venv and then copy the same. Better to create these small scripts on fly and execute.\n\n#! /bin/bash    \ncd $IPADIR/venv/\nsource bin/activate\npython GetCaPath.py\n\n\nGetCaPath.py\n--------------\nimport requests\nprint requests.certs.where()","commit_id":"81929499112de32bbb194b6bbaf53db85e0f0299"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"1eb3f104e67511a74575c226f91732b1ea60c212","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Copying the self signed certificate for request library"},{"line_number":24,"context_line":"if [ -f /tmp/in_target.d/server.pem ]; then"},{"line_number":25,"context_line":"    cat /tmp/in_target.d/server.pem \u003e\u003e $IPADIR/venv/lib/python2.7/site-packages/requests/cacert.pem"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"case \"$DIB_INIT_SYSTEM\" in"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba0121b8_a28882c6","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":99},"in_reply_to":"fa0719c6_0b054d79","updated":"2016-03-30 16:40:31.000000000","message":"Done","commit_id":"81929499112de32bbb194b6bbaf53db85e0f0299"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7e499277b774a9fd161bf1dcaea0dfebaa4f68f4","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Copying the self signed certificate for request library"},{"line_number":24,"context_line":"if [ -f /tmp/in_target.d/server.pem ]; then"},{"line_number":25,"context_line":"    cat /tmp/in_target.d/server.pem \u003e\u003e $IPADIR/venv/lib/python2.7/site-packages/requests/cacert.pem"},{"line_number":26,"context_line":"fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"case \"$DIB_INIT_SYSTEM\" in"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa0719c6_0b054d79","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":99},"in_reply_to":"fa0719c6_abc0a12b","updated":"2016-03-22 04:51:29.000000000","message":"Add \u0027deactivate\u0027 at the end of the bash script to exit from venv environment.","commit_id":"81929499112de32bbb194b6bbaf53db85e0f0299"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"e60698ee579255025d7701e716fcbe381d54f3ac","unresolved":false,"context_lines":[{"line_number":38,"context_line":"esac"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#Copying the self signed certificate for request library"},{"line_number":41,"context_line":"export PS1\u003d\"[\\u@\\h \\W]\\$\""},{"line_number":42,"context_line":"source $IPADIR/venv/bin/activate"},{"line_number":43,"context_line":"echo \"import requests;print requests.certs.where()\" \u003e GetCaPath"},{"line_number":44,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba0121b8_1fc85273","line":41,"range":{"start_line":41,"start_character":7,"end_line":41,"end_character":10},"updated":"2016-04-01 03:21:16.000000000","message":"Could you explain the value for the PS1?","commit_id":"2d74f438321c415c2071ee5e55b060640d4a725b"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ddc7d95ac8f73238e18d0f4526a18093881713d8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"esac"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#Copying the self signed certificate for request library"},{"line_number":41,"context_line":"export PS1\u003d\"[\\u@\\h \\W]\\$\""},{"line_number":42,"context_line":"source $IPADIR/venv/bin/activate"},{"line_number":43,"context_line":"echo \"import requests;print requests.certs.where()\" \u003e GetCaPath"},{"line_number":44,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba0121b8_f3df8b0a","line":41,"range":{"start_line":41,"start_character":7,"end_line":41,"end_character":10},"in_reply_to":"ba0121b8_1fc85273","updated":"2016-04-01 11:09:43.000000000","message":"I have added the description","commit_id":"2d74f438321c415c2071ee5e55b060640d4a725b"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"a58023e33e1b200b50ae9f8dc91c2bc65351cee9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"echo \"import requests;print requests.certs.where()\" \u003e GetCaPath"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"if [ -f /tmp/in_target.d/server.pem ]; then"},{"line_number":50,"context_line":"    cat /tmp/in_target.d/server.pem \u003e\u003e `python GetCaPath`"},{"line_number":51,"context_line":"fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a1b2928_13b023dd","line":50,"range":{"start_line":50,"start_character":3,"end_line":50,"end_character":57},"updated":"2016-04-11 07:14:03.000000000","message":"I guess you could do this, but this is what the update-ca-trust command is for in RHEL based systems. For debian-based systems you have update-ca-certificates","commit_id":"7d71cca9c10cb43aeeec4dd3650566faf3cd84ab"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ba4e3bf94d9e609f2f2e43ceceb381683b8fbab9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"echo \"import requests;print requests.certs.where()\" \u003e GetCaPath"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"if [ -f /tmp/in_target.d/server.pem ]; then"},{"line_number":50,"context_line":"    cat /tmp/in_target.d/server.pem \u003e\u003e `python GetCaPath`"},{"line_number":51,"context_line":"fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"deactivate"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a1b2928_0e658a44","line":50,"range":{"start_line":50,"start_character":3,"end_line":50,"end_character":57},"in_reply_to":"7a1b2928_13b023dd","updated":"2016-04-11 12:04:47.000000000","message":"update-ca-trust command is updating the certificate to the default /etc/ssl/cert/. But request library is using certifi for certificate checking i.e. the path request library looking for is /usr/share/ironic-python-agent/venv/lib/python2.7/request/cacert.pem.","commit_id":"7d71cca9c10cb43aeeec4dd3650566faf3cd84ab"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0ae5a2d982b5f9f7ab8e6ab816b66beff782f5b7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        ;;"},{"line_number":38,"context_line":"esac"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# setting the default PS1 prompt used for virtualenv activation"},{"line_number":41,"context_line":"export PS1\u003d\"$\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Activate the virtual environment"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a18252c_5b9c04c0","line":40,"updated":"2016-04-13 20:54:17.000000000","message":"Nit: This whole thing could be simplified down to:\n\nif [ -f /tmp/in_target.d/server.pem ]; then\n    cat /tmp/in_target.d/server.pem \u003e\u003e $($IPADIR/venv/bin/python -c \"import requests; print requests.certs.where()\")\nfi","commit_id":"f87c9bf90966d152b9308d3d5529b4a330cd7a25"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cf4cc21a268b1701eb1f33fc67910d18bc0a5ce2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        ;;"},{"line_number":38,"context_line":"esac"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# setting the default PS1 prompt used for virtualenv activation"},{"line_number":41,"context_line":"export PS1\u003d\"$\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"# Activate the virtual environment"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a18252c_52b2fe94","line":40,"in_reply_to":"5a18252c_5b9c04c0","updated":"2016-04-14 13:52:36.000000000","message":"Done","commit_id":"f87c9bf90966d152b9308d3d5529b4a330cd7a25"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0ae5a2d982b5f9f7ab8e6ab816b66beff782f5b7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Copying the self signed certificate for request library"},{"line_number":47,"context_line":"echo \"import requests;print requests.certs.where()\" \u003e GetCaPath"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"bash"},{"line_number":50,"context_line":"if [ -f /tmp/in_target.d/server.pem ]; then"},{"line_number":51,"context_line":"    cat /tmp/in_target.d/server.pem \u003e\u003e `python GetCaPath`"},{"line_number":52,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a18252c_b85a7e4e","line":49,"updated":"2016-04-13 20:54:17.000000000","message":"What is the purpose of this?","commit_id":"f87c9bf90966d152b9308d3d5529b4a330cd7a25"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cf4cc21a268b1701eb1f33fc67910d18bc0a5ce2","unresolved":false,"context_lines":[{"line_number":46,"context_line":"# Copying the self signed certificate for request library"},{"line_number":47,"context_line":"echo \"import requests;print requests.certs.where()\" \u003e GetCaPath"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"bash"},{"line_number":50,"context_line":"if [ -f /tmp/in_target.d/server.pem ]; then"},{"line_number":51,"context_line":"    cat /tmp/in_target.d/server.pem \u003e\u003e `python GetCaPath`"},{"line_number":52,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5a18252c_6918f175","line":49,"in_reply_to":"5a18252c_b85a7e4e","updated":"2016-04-14 13:52:36.000000000","message":"my mistake. It is removed.","commit_id":"f87c9bf90966d152b9308d3d5529b4a330cd7a25"}]}
