)]}'
{"bin/disk-image-create":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9aca2a2547b0182a49f3740c35d5a50f607ecb47","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"# Unmount and cleanup the /mnt and /build subdirectories, to save"},{"line_number":456,"context_line":"# space before converting the image to some other format."},{"line_number":457,"context_line":"run_d unmount"},{"line_number":458,"context_line":"cleanup_build_dir"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"has_raw_type\u003d"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab6814e_77afd0e3","line":457,"range":{"start_line":457,"start_character":0,"end_line":457,"end_character":5},"updated":"2016-05-18 11:09:10.000000000","message":"can you explain the reason of that change?","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1f5b689ff1d67bd13569d73e2a0b288a356c8a2d","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"# Unmount and cleanup the /mnt and /build subdirectories, to save"},{"line_number":456,"context_line":"# space before converting the image to some other format."},{"line_number":457,"context_line":"run_d unmount"},{"line_number":458,"context_line":"cleanup_build_dir"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"has_raw_type\u003d"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab6814e_3e2180fc","line":457,"range":{"start_line":457,"start_character":0,"end_line":457,"end_character":5},"in_reply_to":"bab6814e_77afd0e3","updated":"2016-05-18 22:14:05.000000000","message":"This is because a pure \u0027unmount_image\u0027 does not work any longer.\nThe unmount_image function did two things:\no unmounting the TMP/mnt file system and\no detaching the /dev/loopX device\n\nFor LVM in between the deactivation of LV and VG must be done (see unmount.d/70-lvm-remove).\n\nThe other reason is, that I think each element should cleanup the things that it sets up.\n\nNow the LVM element detaches the LV and VG that it earlier created.\n\nI know that this is a major change (adding another phase), but I did not find any other more local solution. Do you have an idea?","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"}],"elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9aca2a2547b0182a49f3740c35d5a50f607ecb47","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    # prepping it in a different environment that needs fiddling."},{"line_number":181,"context_line":"    sed -i \"s%$PART_DEV%LABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":182,"context_line":"    sed -i \"s%search --no-floppy --fs-uuid --set\u003droot .*$%search --no-floppy --set\u003droot --label ${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":183,"context_line":"    sed -i \"s%root\u003d[A-Za-z0-9\\\u003d/\\\u0027-]*%root\u003d${DIB_ROOT_LOGICAL_DEVICE}%\" $GRUB_CFG"},{"line_number":184,"context_line":"    if [ \"$DISTRO_NAME\" \u003d \u0027fedora\u0027 ] ; then"},{"line_number":185,"context_line":"        if [ \"$DIB_RELEASE\" \u003d \u002719\u0027 ]; then"},{"line_number":186,"context_line":"            sed -i \"s%UUID\u003d[A-Za-z0-9\\-]*%LABEL\u003d${DIB_ROOT_LABEL}%\" /etc/fstab"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab6814e_37f3880c","line":183,"range":{"start_line":183,"start_character":14,"end_line":183,"end_character":18},"updated":"2016-05-18 11:09:10.000000000","message":"why are you stripping UUID from here?","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1f5b689ff1d67bd13569d73e2a0b288a356c8a2d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    # prepping it in a different environment that needs fiddling."},{"line_number":181,"context_line":"    sed -i \"s%$PART_DEV%LABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":182,"context_line":"    sed -i \"s%search --no-floppy --fs-uuid --set\u003droot .*$%search --no-floppy --set\u003droot --label ${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":183,"context_line":"    sed -i \"s%root\u003d[A-Za-z0-9\\\u003d/\\\u0027-]*%root\u003d${DIB_ROOT_LOGICAL_DEVICE}%\" $GRUB_CFG"},{"line_number":184,"context_line":"    if [ \"$DISTRO_NAME\" \u003d \u0027fedora\u0027 ] ; then"},{"line_number":185,"context_line":"        if [ \"$DIB_RELEASE\" \u003d \u002719\u0027 ]; then"},{"line_number":186,"context_line":"            sed -i \"s%UUID\u003d[A-Za-z0-9\\-]*%LABEL\u003d${DIB_ROOT_LABEL}%\" /etc/fstab"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab6814e_f93f1223","line":183,"range":{"start_line":183,"start_character":14,"end_line":183,"end_character":18},"in_reply_to":"bab6814e_37f3880c","updated":"2016-05-18 22:14:05.000000000","message":"Because there was no UUID :-)\n\nI typically create Debian images. Under Debian when using LVM as root, this has the format like:\n   root\u003d\u0027lvmid/iq4XvJ-D....\u0027\n\nIMHO removing the UUID and adding \u0027\u003d\u0027 and \u0027\u0027\u0027 to the regexp will catch all systems.","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"}],"elements/debootstrap/install.d/15-cleanup-debootstrap":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9aca2a2547b0182a49f3740c35d5a50f607ecb47","unresolved":false,"context_lines":[{"line_number":24,"context_line":"install -d -m 0755 -o root -g root /etc/sudoers.d"},{"line_number":25,"context_line":"echo \u0027blacklist pcspkr\u0027 \u003e /etc/modprobe.d/blacklist.conf"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"### Create new FSTAB"},{"line_number":28,"context_line":"# The source is needed for the partitioning_mount_point_to_identifier"},{"line_number":29,"context_line":"# function."},{"line_number":30,"context_line":"source /tmp/in_target.d/lib/partitioning-in-target-functions"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab6814e_b7be58fd","side":"PARENT","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":3},"updated":"2016-05-18 11:09:10.000000000","message":"why do you change that order?","commit_id":"01382bbb3408b645767ed3c80eebcb7e1beb8289"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1f5b689ff1d67bd13569d73e2a0b288a356c8a2d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"install -d -m 0755 -o root -g root /etc/sudoers.d"},{"line_number":25,"context_line":"echo \u0027blacklist pcspkr\u0027 \u003e /etc/modprobe.d/blacklist.conf"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"### Create new FSTAB"},{"line_number":28,"context_line":"# The source is needed for the partitioning_mount_point_to_identifier"},{"line_number":29,"context_line":"# function."},{"line_number":30,"context_line":"source /tmp/in_target.d/lib/partitioning-in-target-functions"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bab6814e_794a0285","side":"PARENT","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":3},"in_reply_to":"bab6814e_b7be58fd","updated":"2016-05-18 22:14:05.000000000","message":"I hope I did not change the order but moved the functionality to a the elements that need this: this is now the implementation used for partitions (see 11-create-fstab).\nThe LVM needs another fstab, that is now created in 12-create-fstab - and it is important that the later one overwrites the first one.\n\nThe partition implementation uses the LABEL for identifying disks, the LVM implementation uses DM path for this - like /dev/mapper/vgname-lvname.","commit_id":"01382bbb3408b645767ed3c80eebcb7e1beb8289"}],"elements/lvm/README.rst":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9aca2a2547b0182a49f3740c35d5a50f607ecb47","unresolved":false,"context_lines":[{"line_number":16,"context_line":"One partition mapping consists of the name of the volume group"},{"line_number":17,"context_line":"followed by a colon, followed by a comma separated list of partition"},{"line_number":18,"context_line":"numbers."},{"line_number":19,"context_line":"Example: `cloudsys:1,3 cloudtmp:2`"},{"line_number":20,"context_line":"         Partition 1 and three will be used for VG `cloudsys`,"},{"line_number":21,"context_line":"         partition number 2 will be used for VG `cloudtmp`."},{"line_number":22,"context_line":"The default is: `cloudsys:1`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_5779ec2e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"updated":"2016-05-18 11:09:10.000000000","message":"i am afraid of adding that extra complexity, while my initial change just was limiting one partition to one volume group. Do you have an use case for needed different partitions?","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1f5b689ff1d67bd13569d73e2a0b288a356c8a2d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"One partition mapping consists of the name of the volume group"},{"line_number":17,"context_line":"followed by a colon, followed by a comma separated list of partition"},{"line_number":18,"context_line":"numbers."},{"line_number":19,"context_line":"Example: `cloudsys:1,3 cloudtmp:2`"},{"line_number":20,"context_line":"         Partition 1 and three will be used for VG `cloudsys`,"},{"line_number":21,"context_line":"         partition number 2 will be used for VG `cloudtmp`."},{"line_number":22,"context_line":"The default is: `cloudsys:1`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_74884723","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"bab6814e_5779ec2e","updated":"2016-05-18 22:14:05.000000000","message":"Honestly speaking: my first implementation was also capable of handling only one partition.\nDuring the implementation I saw, that is is minimal effort to go for the more general solution: it\u0027s the for loop part in line 14 in the 20-lvm.\nCurrently I have no requirement to use many partitions here - but I often found, that operations or customers have strange sights on these things.","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"9aca2a2547b0182a49f3740c35d5a50f607ecb47","unresolved":false,"context_lines":[{"line_number":38,"context_line":"2. size of logical volume. It is possible to specify the size in one"},{"line_number":39,"context_line":"   of the units `bBsSkKmMgGtTpPeE`.  Please see the man page of"},{"line_number":40,"context_line":"   lvcreate for further details."},{"line_number":41,"context_line":"3. mount point or string `SWAP`.  The mount point is used to mount the"},{"line_number":42,"context_line":"   logical volume.  If `SWAP` is specified, the LV is used as"},{"line_number":43,"context_line":"   swap space.  If `IGNORE` is given, the LV is ignored."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_f7dc601a","line":41,"range":{"start_line":41,"start_character":3,"end_line":41,"end_character":8},"updated":"2016-05-18 11:09:10.000000000","message":"what about extra options that can be passed to volumes, extra flags?","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1f5b689ff1d67bd13569d73e2a0b288a356c8a2d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"2. size of logical volume. It is possible to specify the size in one"},{"line_number":39,"context_line":"   of the units `bBsSkKmMgGtTpPeE`.  Please see the man page of"},{"line_number":40,"context_line":"   lvcreate for further details."},{"line_number":41,"context_line":"3. mount point or string `SWAP`.  The mount point is used to mount the"},{"line_number":42,"context_line":"   logical volume.  If `SWAP` is specified, the LV is used as"},{"line_number":43,"context_line":"   swap space.  If `IGNORE` is given, the LV is ignored."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"bab6814e_f402773d","line":41,"range":{"start_line":41,"start_character":3,"end_line":41,"end_character":8},"in_reply_to":"bab6814e_f7dc601a","updated":"2016-05-18 22:14:05.000000000","message":"I do not have any requirements for this.\nThe only thing I could imagine is the size - and this is encoded into the (real) third field.\nI really like the idea - as implemented in the main disk-image-builder script - that the tool measures the size of the system and creates an appropriate sized disk image. It would be really nice to adapt this functionality here - so e.g. a \u0027COMPUTE\u0027 or something in the size field could be used to trigger the mechanism of computing the sizes automatically.  This is the reason why I put the size into a special field instead of providing the complete options to the lvcreate call.\nDo you need special options here?","commit_id":"8b4bdf06e447f9a1227c3608c62e39e7c848fd0b"}]}
