)]}'
{"id":"openstack%2Fdiskimage-builder~319591","triplet_id":"openstack%2Fdiskimage-builder~master~Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1","project":"openstack/diskimage-builder","branch":"master","topic":"block-device/refactor/102-initial-infrastructure","hashtags":[],"change_id":"Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1","subject":"Refactor: block-device handling (local loop)","status":"ABANDONED","created":"2016-05-21 20:44:08.000000000","updated":"2016-09-21 05:18:53.000000000","total_comment_count":59,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6d97efd43ce737b37ab62105080ce4161255d46c","_number":319591,"virtual_id_number":319591,"owner":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":1,"date":"2016-08-23 20:33:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"all":[{"value":-1,"date":"2016-09-12 19:46:33.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-06 23:18:32.000000000","updated_by":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"reviewer":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"state":"REVIEWER"},{"updated":"2016-07-19 21:56:13.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-08-23 20:33:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-12 19:46:33.000000000","updated_by":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"reviewer":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"state":"REVIEWER"}],"messages":[{"id":"90a5ae015b0ff83b6ed940ef6e6aaf3573bb26b5","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-05-21 20:44:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ecf828383f20ce36f1d259d4e0123057990540ad","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-05-21 20:55:40.000000000","message":"Patch Set 1:\n\nHello Reviewers!\n\nThis is a try to implement:\no the possibility to get results of elements back to the main script\no a phase that is called when something nasty happens.\n\nloopdev was used here as a first step, because it needs exactly those both requirements.\n\nThis is a try to extract some functionality used in my partitioning-parted and lvm2 patches into a minimal usable and sensible patch. IMHO this single change can easier be discussed, changed and fixed. Hopefully in this way the other patches will get somewhat smaller.","accounts_in_message":[],"_revision_number":1},{"id":"2d93c5281ac23220d7efc83d0bf1616c60551e39","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-05-21 20:59:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7e55ee2ed487056b2be54d1892bad9f0a230ec85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-21 21:18:21.000000000","message":"Patch Set 2:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/91/319591/2/check-tripleo/gate-tripleo-ci-f22-nonha/55558df/ : FAILURE in 19m 08s","accounts_in_message":[],"_revision_number":2},{"id":"69d89179e7f9a57346267bffc80221ba907117d8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-21 21:49:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/2/check/gate-diskimage-builder-docs/254d33b//doc/build/html/ : SUCCESS in 2m 52s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/2/check/gate-diskimage-builder-pep8/162fbab/ : SUCCESS in 2m 48s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/2/check/gate-diskimage-builder-python27/e7da24e/ : SUCCESS in 2m 00s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/2/check/gate-diskimage-builder-python34/e5a3f08/ : SUCCESS in 1m 31s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/2/check/gate-dib-dsvm-functests-ubuntu-trusty/c8ba615/ : SUCCESS in 19m 51s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/2/check/gate-dib-dsvm-functests-centos-7/1e954cf/ : SUCCESS in 28m 09s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/2/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/c8ef592/ : FAILURE in 27s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/2/check/gate-dib-dsvm-functests-centos-7-extras-nv/9c3b0d6/ : SUCCESS in 4m 03s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"f32547a2603d246b998f3efa8b728acb40158ac4","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-05-23 19:45:35.000000000","message":"Patch Set 2: Code-Review-1 Workflow-1\n\nWIP","accounts_in_message":[],"_revision_number":2},{"id":"7dc42fc0615591c2d8c855c97963d52d55ce858c","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-05-24 18:25:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"24ccfbfbc1a39b0671c4f673a949a45f29d8d20e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-24 20:18:20.000000000","message":"Patch Set 3:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/91/319591/3/check-tripleo/gate-tripleo-ci-f22-nonha/ebf0337/ : FAILURE in 23m 30s","accounts_in_message":[],"_revision_number":3},{"id":"1ad7b38f1e58416062b2de2e77a69d71952dd604","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-25 00:28:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/3/check/gate-diskimage-builder-docs/2f1e395//doc/build/html/ : SUCCESS in 1m 34s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/3/check/gate-diskimage-builder-pep8/66aa6eb/ : SUCCESS in 3m 59s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/3/check/gate-diskimage-builder-python27/ccd7a01/ : SUCCESS in 2m 54s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/3/check/gate-diskimage-builder-python34/a547ff1/ : SUCCESS in 2m 56s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/3/check/gate-dib-dsvm-functests-ubuntu-trusty/f8cdafe/ : SUCCESS in 19m 32s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/3/check/gate-dib-dsvm-functests-centos-7/c3830a0/ : SUCCESS in 41m 06s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/3/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/b09c8b9/ : SUCCESS in 5m 31s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/3/check/gate-dib-dsvm-functests-centos-7-extras-nv/3d1a6d6/ : SUCCESS in 5m 05s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"6e1449bd3711ecd544ba41baa32c6de060396964","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-05-25 20:34:07.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"974dd86dfe5d0c557de3b5dc1aa484c3755780da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-25 20:54:02.000000000","message":"Patch Set 4:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/91/319591/4/check-tripleo/gate-tripleo-ci-f22-nonha/496b193/ : FAILURE in 19m 13s","accounts_in_message":[],"_revision_number":4},{"id":"240144248606df23bcea9a5d3c9e80c1253bd164","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-25 23:11:49.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/4/check/gate-diskimage-builder-docs/6084962//doc/build/html/ : SUCCESS in 3m 02s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/4/check/gate-diskimage-builder-pep8/50a145e/ : SUCCESS in 2m 53s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/4/check/gate-diskimage-builder-python27/b1bd672/ : SUCCESS in 1m 46s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/4/check/gate-diskimage-builder-python34/ec3b382/ : SUCCESS in 2m 00s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/4/check/gate-dib-dsvm-functests-ubuntu-trusty/526426a/ : SUCCESS in 32m 51s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/4/check/gate-dib-dsvm-functests-centos-7/2a7f022/ : SUCCESS in 27m 18s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/4/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/4f385f5/ : SUCCESS in 3m 36s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/4/check/gate-dib-dsvm-functests-centos-7-extras-nv/aa0121b/ : SUCCESS in 5m 08s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"2098fdb5314d097b27cff0c117633c8b93a938d8","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-05-28 06:50:08.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"5450beb8453aeba9e5d2ddd4c465a5a756ba080e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-28 07:12:46.000000000","message":"Patch Set 5:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-f22-nonha http://logs.openstack.org/91/319591/5/check-tripleo/gate-tripleo-ci-f22-nonha/f29caee/ : FAILURE in 22m 31s","accounts_in_message":[],"_revision_number":5},{"id":"1cb266f5e2778f629d99f6fb845c6cf03d910654","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-28 07:24:00.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/5/check/gate-diskimage-builder-docs/4ad89d4//doc/build/html/ : SUCCESS in 2m 23s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/5/check/gate-diskimage-builder-pep8/e920b04/ : SUCCESS in 2m 46s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/5/check/gate-diskimage-builder-python27/71bb846/ : SUCCESS in 2m 47s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/5/check/gate-diskimage-builder-python34/68c910d/ : SUCCESS in 2m 51s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/5/check/gate-dib-dsvm-functests-ubuntu-trusty/6f2e0d3/ : SUCCESS in 33m 45s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/5/check/gate-dib-dsvm-functests-centos-7/87788db/ : SUCCESS in 28m 19s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/5/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/bc35ee8/ : SUCCESS in 8m 20s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/5/check/gate-dib-dsvm-functests-centos-7-extras-nv/601297d/ : SUCCESS in 15m 15s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"5f9af7acd43e943f244c026a9f96aafe4eb17ed9","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-05-31 20:24:06.000000000","message":"Patch Set 5: Code-Review-1\n\n(3 comments)\n\nthis is interesting ... i\u0027m still processing the layers bit and also how best to use python as elements.\n\nin the mean time, i\u0027d like to see some of the smaller bits split out, like the new exit phase in particular, so we can consider that separately\n\ni\u0027m not sure what you mean about \"passing arguments with the help of dib-run-parts\"?  can you point me at what you\u0027re talking about there","accounts_in_message":[],"_revision_number":5},{"id":"b914c3a2315244760f407edd14eb450c6a316ec1","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-05-31 20:32:20.000000000","message":"Patch Set 5:\n\nFurther thought on the python-as-element thing ... I\u0027m not strictly opposed to it; although writing shell scripts in python often means you gain a lot of syntax complexity to just do a series of exec()s and lose the ability to easily trace what the heck is going on.  good logging is paramount.\n\nbut dib-lint currently just skips over all these files?  We need to be running flake8 at least so we\u0027re at least close to ensuring we\u0027re looking like standard openstack python","accounts_in_message":[],"_revision_number":5},{"id":"ab552c5549163d4b9329bbb980e62fa9fa6cae3f","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-01 05:40:48.000000000","message":"Patch Set 5:\n\n(3 comments)\n\n\u003ei\u0027m not sure what you mean about \"passing arguments with the help of dib-run-parts\"?  can you point me at what you\u0027re talking about there\nThere are some shortcomings of dib-run-parts as it is used in DIB: whilst it seams possible to pass arguments back to the caller (see eval_run_d), it is currently impossible to pass arguments from one script in a phase to a different one. Example block-device.d: If you have an element that creates the image, it is not possible to pass on the result to the next script in the same phase, e.g. the partitioning. (Of course, it would be possible to define a \u0027common file interface\u0027 here, but this feels strange [1].)\n\nAlso it is impossible with dib-run-parts to specify the order of the elements: a partitioning-\u003elvm-\u003ecrypt should be different from partitioning-\u003ecrypt-\u003elvm.\n\nAdditionally instead of having a pure dependency based approach (as done e.g. in systemd) the old sysv-init sort-with-number approach is used in dib-run-parts (you have to globally fiddle around when adjusting the order here) and scripts with the same \u0027number\u0027 can theoretically be executed in parallel (see comment in dib-run-parts).\n\n\u003e python-as-element thing\nI\u0027m also unsure about this. The initial version of this patch was written using bash. But at some point, there is the need for a structured configuration. (I tried to use bash arrays - but this was really a pain and it still never really fits the needs.) As you can see, currently the configuration is written in JSON.  This can easily be handled using python - but using bash (jq) becomes complex.\nYou are right with the exec()s. My current idea is, that some exec will be needed - but other parts can be easily replaced and are more straight forward to implement. Example 1: truncate -\u003e open/seek, Example 2: use pyparted library [3]\n\n(Please note that also [2] is using python as an element.)\n\n\u003e but dib-lint currently just skips over all these files?\nNo - I\u0027m sure they are checked ;-) This is why all the fancy copyright headers and additional empty lines are in my code...\n\n\n[1] https://review.openstack.org/#/c/319591/1/lib/common-functions\n[2] https://review.openstack.org/#/c/252041/\n[3] https://review.openstack.org/#/c/322671/6/elements/block-device/pylib/block-device/level1/Partitioning.py","accounts_in_message":[],"_revision_number":5},{"id":"3faa66bfc2967a7279c7923b859e6255e41f8a0a","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-01 16:00:15.000000000","message":"Patch Set 5: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":5},{"id":"ead798bcc2619ce5e03836c4346391a0267650f1","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-02 20:23:40.000000000","message":"Patch Set 5: Code-Review-1 Workflow-1\n\n[WIP]: Parts of this patch are / will be factored out.\nHope that this patch will shrink and shrink in size.","accounts_in_message":[],"_revision_number":5},{"id":"1ec96e44c52dcb1e7fe1271195d77e53a5fef675","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-03 18:12:43.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nThanks about the hints of factoring out things. Already started with this.","accounts_in_message":[],"_revision_number":5},{"id":"a6e61f633bef7ba85b4699d0853748e0bf1e3e76","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-15 03:20:19.000000000","message":"Patch Set 5:\n\nSorry Andreas, I think the bunch of different convos are getting mixed. My comment about not becoming a general purpose app building tool is about the pylib feature. I want to make sure that we arent trying to build tooling so that folks can write python applications in our framework - thats what python/setuptools/etc is for. That being said, I think you\u0027re right in that making an external project for this is moving some core dib functionality out of tree.\n\n\nWhat do you think of having this code be part of the diskimage-builder package itself (so in the diskimage-builder dir rather than in an element) and coming up with a way to have the diskimage-builder package available in side of the image? This came up in another package recently, we might want to do something like install the python application in to a venv in tmpfs and have it available during image build.","accounts_in_message":[],"_revision_number":5},{"id":"9af81c5211471006fb3c5952437f5a29aff770bf","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-15 03:25:15.000000000","message":"Patch Set 5:\n\nactually, I am going back on what I said, its better if we can have python live in elements. Lets add this feature in the python hook copying patch, though.","accounts_in_message":[],"_revision_number":5},{"id":"3c6f4ebfde6628a13d16caffe5ed88d9f98a0af6","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-16 07:27:57.000000000","message":"Patch Set 5:\n\nI think I do not completely understand you - two comments on things I hope I understood :-)\n\no IMHO python for an element makes perfectly sense.\n\no In this special case of block-device handling, it might make sense to include it (somehow) into the main; especially when we go into the direction of using configuration instead of code for this.\n\nMy idea is to get the logging config and new hook generation merged first; as a next step I\u0027d like to agree on what to do [1]; and finally the \u0027how\u0027 by rebasing / refactoring this patch.\n\n[1] https://etherpad.openstack.org/p/C80jjsAs4x","accounts_in_message":[],"_revision_number":5},{"id":"d1256ea5af5a46c5d894fe4a22535b72317d3732","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-16 20:30:15.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"ac0a07c367b88a3a536065a46763903a9398da1a","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-16 20:36:34.000000000","message":"Patch Set 6:\n\nThis is a rebased update: using now the new python logging.\nWhen we assume, that block image handling is a core functionality of dib and directly implement it in the main - things are getting somewhat easier.\nWhat do you think about this approach?","accounts_in_message":[],"_revision_number":6},{"id":"b09374c6523f22582dfcb770af2303b83deda957","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-16 21:00:00.000000000","message":"Patch Set 6:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/6/check-tripleo/gate-tripleo-ci-centos-7-nonha/e7f988e/ : FAILURE in 29m 32s","accounts_in_message":[],"_revision_number":6},{"id":"1a8e487dfe204b0584edebecae7c54ec1ea44889","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-16 21:22:32.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/6/check/gate-diskimage-builder-docs/724e682//doc/build/html/ : SUCCESS in 4m 00s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/6/check/gate-diskimage-builder-pep8/5ca7b87/ : SUCCESS in 7m 44s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/6/check/gate-diskimage-builder-python27/2bdbd95/ : SUCCESS in 3m 31s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/6/check/gate-diskimage-builder-python34/2694beb/ : SUCCESS in 7m 22s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/6/check/gate-dib-dsvm-functests-ubuntu-trusty/4843f63/ : SUCCESS in 39m 43s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/6/check/gate-dib-dsvm-functests-centos-7/5d3227f/ : SUCCESS in 34m 06s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/6/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/ccee9ee/ : SUCCESS in 6m 37s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/6/check/gate-dib-dsvm-functests-centos-7-extras-nv/7288c06/ : SUCCESS in 10m 14s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"ee33d74fb2d79866cd0e66a8bdc00f3cf61778f3","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-06-17 05:21:34.000000000","message":"Patch Set 6: Code-Review-1\n\n(2 comments)\n\nI like this!  I don\u0027t think it makes sense to overload this with python-element stuff; this seems to me as a sensible incremental change to bring in a lot of block-device functionality\n\ncouple of comments inline","accounts_in_message":[],"_revision_number":6},{"id":"b1001144ac10818771136fb6ce4ae37ab94ac7a1","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-06-17 05:23:29.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"c8dc785a4c5d4fbed81298e784f5fccd15e25f81","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-17 18:22:04.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"b059f7705b367d8186b46afa5c5ff298451cd5c2","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-17 18:42:05.000000000","message":"Patch Set 7:\n\nIan - great idea to use the entry points mechanism (never heard about before - had a look in your other patch for element-info to get an idea).\n\nThe calls in the main look much cleaner now.\n\nHad some problems to get this running with sudo: on Debian (my dev env), there is the need to explicitly re-configure the \u0027secure_path\u0027.\n\nI do not find any other sensible part to factor out: looks that this is the essence of a first block device refactoring step now.","accounts_in_message":[],"_revision_number":7},{"id":"f4cfc5a048956dc6e60063499557888e50201c2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-17 18:45:37.000000000","message":"Patch Set 7:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/7/check-tripleo/gate-tripleo-ci-centos-7-nonha/cd60dd3/ : FAILURE in 23m 16s","accounts_in_message":[],"_revision_number":7},{"id":"4db55645a4f527b08a0387118b00ec39bb605a4f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-17 18:59:41.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/7/check/gate-diskimage-builder-docs/85c2bda//doc/build/html/ : SUCCESS in 3m 48s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/7/check/gate-diskimage-builder-pep8/385c407/ : SUCCESS in 5m 50s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/7/check/gate-diskimage-builder-python27/2fd432c/ : SUCCESS in 4m 17s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/7/check/gate-diskimage-builder-python34/faece82/ : SUCCESS in 7m 00s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/7/check/gate-diskimage-builder-releasenotes/92c3bb6//releasenotes/build/html/ : SUCCESS in 7m 47s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/7/check/gate-dib-dsvm-functests-ubuntu-trusty/aecd1d7/ : FAILURE in 5m 30s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/7/check/gate-dib-dsvm-functests-centos-7/c6faf20/ : FAILURE in 4m 30s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/7/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/be64c87/ : FAILURE in 5m 28s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/7/check/gate-dib-dsvm-functests-centos-7-extras-nv/b85989e/ : FAILURE in 3m 42s (non-voting)","accounts_in_message":[],"_revision_number":7},{"id":"020a6d3703966d830c08453920d55f6ae6217bf6","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-17 19:25:52.000000000","message":"Patch Set 7:\n\nLooks that the sudo problems not only occur on Debian :-(\nAny idea how to fix this?","accounts_in_message":[],"_revision_number":7},{"id":"33b7a43bc9712fb54dd9bb0257aa2d19606cadaf","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-18 07:39:33.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"da33ed53a0bbeb538fd99bc608a5294dd7cd6a47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-18 08:00:34.000000000","message":"Patch Set 8: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/8/check/gate-diskimage-builder-docs/7a1b3c3//doc/build/html/ : SUCCESS in 2m 05s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-pep8/72f3772/ : SUCCESS in 3m 13s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-python27/37a6e61/ : SUCCESS in 3m 09s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-python34/d3b3b68/ : SUCCESS in 3m 06s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/8/check/gate-diskimage-builder-releasenotes/5f0316f//releasenotes/build/html/ : SUCCESS in 3m 11s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-ubuntu-trusty/1be8854/ : FAILURE in 11m 35s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-centos-7/f38a775/ : SUCCESS in 20m 28s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/9ee9e64/ : SUCCESS in 4m 28s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-centos-7-extras-nv/40ae692/ : SUCCESS in 4m 26s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"5439f3d537c4fb0cb5326912223997ec9104952d","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-18 08:19:30.000000000","message":"Patch Set 8:\n\nrecheck\n\nUbuntu Trusty mirror problem","accounts_in_message":[],"_revision_number":8},{"id":"a40bd4419b5b960ad88b7d504e85feb74bb93a4b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-18 08:45:15.000000000","message":"Patch Set 8:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/8/check/gate-diskimage-builder-docs/2cbfb2d//doc/build/html/ : SUCCESS in 2m 55s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-pep8/d61bd16/ : SUCCESS in 2m 39s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-python27/aa738e1/ : SUCCESS in 2m 03s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-python34/6cf06f0/ : SUCCESS in 3m 47s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/8/check/gate-diskimage-builder-releasenotes/b6c1199//releasenotes/build/html/ : SUCCESS in 1m 53s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-ubuntu-trusty/ca462f6/ : FAILURE in 14m 57s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-centos-7/9e9e9b6/ : SUCCESS in 25m 31s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/f48b45f/ : SUCCESS in 3m 23s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-centos-7-extras-nv/834566a/ : SUCCESS in 4m 05s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"3721460023f9bf04ee59e2c4eb4d74b1177c8712","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-18 09:29:49.000000000","message":"Patch Set 8:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/8/check-tripleo/gate-tripleo-ci-centos-7-nonha/9cbcf5d/ : SUCCESS in 1h 50m 01s","accounts_in_message":[],"_revision_number":8},{"id":"56ddd7da437fb7bb011b6885a16f3574c90220ae","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-18 12:42:21.000000000","message":"Patch Set 8:\n\nrecheck\n\nagain mirror problems Ubuntu Trusty creating Debian image.","accounts_in_message":[],"_revision_number":8},{"id":"0528cb977c705ff54fc1bff60faf88bb3b493bec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-18 13:05:13.000000000","message":"Patch Set 8: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/8/check/gate-diskimage-builder-docs/2eea4c2//doc/build/html/ : SUCCESS in 1m 53s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-pep8/db8ff67/ : SUCCESS in 2m 18s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-python27/883b11f/ : SUCCESS in 3m 11s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/8/check/gate-diskimage-builder-python34/57ca880/ : SUCCESS in 2m 53s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/8/check/gate-diskimage-builder-releasenotes/1d58c26//releasenotes/build/html/ : SUCCESS in 1m 53s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-ubuntu-trusty/6785c1f/ : SUCCESS in 19m 23s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-centos-7/6d62379/ : SUCCESS in 20m 33s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/d61db24/ : SUCCESS in 4m 15s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/8/check/gate-dib-dsvm-functests-centos-7-extras-nv/2195893/ : SUCCESS in 4m 22s (non-voting)","accounts_in_message":[],"_revision_number":8},{"id":"956382fe46e304ebda221e7238072db07c3cde34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-18 14:28:17.000000000","message":"Patch Set 8:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/8/check-tripleo/gate-tripleo-ci-centos-7-nonha/242fd8b/ : SUCCESS in 1h 45m 44s","accounts_in_message":[],"_revision_number":8},{"id":"24821c9db821efdf083253e20e8aff76e2a2c439","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-06-20 05:29:41.000000000","message":"Patch Set 8:\n\nSo the solution to the sudo problem seems to be \"don\u0027t call it with ssh\" which changeset 8 seems to address.  I think that\u0027s the right way forward -- just use sudo calls when required inside. \n\nJust a nit on LocalLoop with the __ variables; not clear what that\u0027s for and it\u0027 not our usual openstack-ish style.  other than that, I\u0027m think this is looking pretty good","accounts_in_message":[],"_revision_number":8},{"id":"86784a3a2c71e3574267a8cd95fec026fb18f383","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-06-20 05:30:02.000000000","message":"Patch Set 8:\n\nI mean \"don\u0027t call it with *sudo*\" ... doh!","accounts_in_message":[],"_revision_number":8},{"id":"8f1ff6e29b54ca1d75296d596a497c0d867ff8c3","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-20 07:13:23.000000000","message":"Patch Set 8:\n\nYes - patch set 8 addresses the sudo problem. (This works as long as there is no native python code that must be executed using root.)\n\nThe __ at the beginning is (in my perception) a widely used mechanism to mark the private (non public) API of a python class [1]. Sorry if I do not follow openstack-ish style here - but I find this very handy to have at least a convention that gives you something like a class access restriction.\nIf you don\u0027t think it\u0027s worth it, I\u0027ll remove them.\n\n[1] https://docs.python.org/2/tutorial/classes.html#tut-private","accounts_in_message":[],"_revision_number":8},{"id":"686f58eb2cdf6ff1f4cd5f2b818e75e2515e01d3","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-06-20 10:47:20.000000000","message":"Patch Set 8: Code-Review-1\n\n(1 comment)\n\nOne thing i noticed looking closer about the logging\n\n__ is a thing, but usually used minimally when you\u0027re really building much more abstract classes that you expect to be sub-classed in an API IMO.  For something like this, where the objects are mostly an organisational thing, I don\u0027t feel it\u0027s necessary and it\u0027s not a pattern we use","accounts_in_message":[],"_revision_number":8},{"id":"dca9ca5f40cd21fabd7ab5c09cae70e78b2e03e5","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-20 20:28:44.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"8bf7b7cd8962912004ca43ca6bf339718b3f14ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 20:39:43.000000000","message":"Patch Set 9: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/9/check/gate-diskimage-builder-docs/0244fd0//doc/build/html/ : SUCCESS in 2m 45s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/9/check/gate-diskimage-builder-pep8/4856633/ : SUCCESS in 3m 07s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/9/check/gate-diskimage-builder-python27/a662f5c/ : SUCCESS in 3m 14s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/9/check/gate-diskimage-builder-python34/28c6f75/ : SUCCESS in 3m 54s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/9/check/gate-diskimage-builder-releasenotes/05f4c44//releasenotes/build/html/ : SUCCESS in 3m 42s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-ubuntu-trusty/a5d5727/ : FAILURE in 2m 49s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-centos-7/8a1b2ba/ : FAILURE in 8m 54s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/ceb2c47/ : SUCCESS in 4m 32s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-centos-7-extras-nv/e265fbd/ : SUCCESS in 7m 32s (non-voting)","accounts_in_message":[],"_revision_number":9},{"id":"bf2b35d5d3032865dbea414523100c3da0ecd4c6","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-20 20:43:18.000000000","message":"Patch Set 9:\n\nFixed the logging (was a relic from the pre-python init logging era).\n\nAlso removed the underscores at the beginning of the private elements.\nFeels a little bit strange to me, because I\u0027m so used to it,\nbut want to concentrate on the patch now.\n\n\n\nSome minor notes for a possible later discussion:\no some nova classes use the schema\no looks there is a differentiation between classes and modules: looks common that local module functions start with an underline (e.g. element_dependency.py) - this is why the two locally used functions in Utils.py still make use of it.\no It is explicitly allowed in pep8:\n   Use one leading underscore only for non-public methods and instance variables. \n   To avoid name clashes with subclasses, use two leading underscores to invoke Python\u0027s name mangling rules.","accounts_in_message":[],"_revision_number":9},{"id":"ec17661db5f661bbcbaf202859b36791eaf4bfc0","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-20 20:44:29.000000000","message":"Patch Set 9:\n\nrecheck\n\nFedora mirror problem","accounts_in_message":[],"_revision_number":9},{"id":"d1e3abef7fd349371986f699ebe48541143d65e6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-20 21:11:35.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/9/check/gate-diskimage-builder-docs/34305c4//doc/build/html/ : SUCCESS in 2m 34s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/9/check/gate-diskimage-builder-pep8/a2a27c5/ : SUCCESS in 2m 39s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/9/check/gate-diskimage-builder-python27/eb4cfdf/ : SUCCESS in 3m 36s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/9/check/gate-diskimage-builder-python34/cbf054d/ : SUCCESS in 3m 39s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/9/check/gate-diskimage-builder-releasenotes/7d897bb//releasenotes/build/html/ : SUCCESS in 2m 24s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-ubuntu-trusty/6dda24c/ : SUCCESS in 22m 46s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-centos-7/f16b9ee/ : SUCCESS in 22m 09s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/1a6348e/ : SUCCESS in 5m 05s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/9/check/gate-dib-dsvm-functests-centos-7-extras-nv/9daf1e2/ : SUCCESS in 4m 30s (non-voting)","accounts_in_message":[],"_revision_number":9},{"id":"9ff6986d9552e056d07934d57b7e70d918f593ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-21 02:20:25.000000000","message":"Patch Set 9:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/9/check-tripleo/gate-tripleo-ci-centos-7-nonha/a044b20/ : SUCCESS in 1h 50m 02s","accounts_in_message":[],"_revision_number":9},{"id":"8f1e4bbea5ea94f883d5a6ba33a8a83cfe2b6f8a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-06-21 10:22:05.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"44e2be6b610cbdd029437e26a6437c7be660924f","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-22 16:59:33.000000000","message":"Patch Set 9: Code-Review-1\n\n(8 comments)","accounts_in_message":[],"_revision_number":9},{"id":"1c2cc8e7e0831739b79d5e6a107806a0322277bc","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-22 17:01:44.000000000","message":"Patch Set 9:\n\n(1 comment)","accounts_in_message":[],"_revision_number":9},{"id":"07541d3fa9105bacc25fea86beec7e93fd787bb4","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-23 19:34:58.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"d9b8a5c601ff13b9ebad0e4f53798dad53944344","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-23 19:47:40.000000000","message":"Patch Set 9:\n\n(10 comments)\n\nPlease see my comments inline.","accounts_in_message":[],"_revision_number":9},{"id":"098eb0e3242efec5d1bfab77fc3a08c454b72180","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-23 19:53:58.000000000","message":"Patch Set 10:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/10/check-tripleo/gate-tripleo-ci-centos-7-nonha/cf1f430/ : FAILURE in 18m 15s","accounts_in_message":[],"_revision_number":10},{"id":"157845dd34123304052143ab1d25e38430df1f45","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-23 20:33:38.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/10/check/gate-diskimage-builder-docs/2ecd4c8//doc/build/html/ : SUCCESS in 4m 37s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/10/check/gate-diskimage-builder-pep8/d966347/ : SUCCESS in 2m 46s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/10/check/gate-diskimage-builder-python27/b972cbf/ : SUCCESS in 3m 49s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/10/check/gate-diskimage-builder-python34/091675a/ : SUCCESS in 3m 46s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/10/check/gate-diskimage-builder-releasenotes/95b15ad//releasenotes/build/html/ : SUCCESS in 4m 25s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/10/check/gate-dib-dsvm-functests-ubuntu-trusty/0812a29/ : SUCCESS in 23m 11s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/10/check/gate-dib-dsvm-functests-centos-7/675c27e/ : SUCCESS in 30m 40s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/10/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/ebae49b/ : SUCCESS in 32m 44s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/10/check/gate-dib-dsvm-functests-centos-7-extras-nv/346dcaa/ : SUCCESS in 38m 53s (non-voting)","accounts_in_message":[],"_revision_number":10},{"id":"e2623fd12848ae844f652e4a7c7429f057351a3e","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-24 17:53:44.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"0918bdad1c75bc73bf7c3ac146340939367e77a7","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-24 18:00:47.000000000","message":"Patch Set 11:\n\nThe latest patch set moves the content of vm/block-device/10.. into the main: this functionality is used in any case - and not only for the vm element.\n\nP.S.: IMHO it is very important to check, if the created images are really usable. (Thought there was a patch out for this, but do not find it now).","accounts_in_message":[],"_revision_number":11},{"id":"0b801cddaa313b12b3b8d62ef41fc10f87b222c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-24 18:44:40.000000000","message":"Patch Set 11: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/11/check/gate-diskimage-builder-docs/6be70df//doc/build/html/ : SUCCESS in 7m 36s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/11/check/gate-diskimage-builder-pep8/cb965a6/ : SUCCESS in 4m 03s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/11/check/gate-diskimage-builder-python27/24a126f/ : SUCCESS in 4m 07s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/11/check/gate-diskimage-builder-python34/72a9cbc/ : SUCCESS in 4m 03s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/11/check/gate-diskimage-builder-releasenotes/53d99b7//releasenotes/build/html/ : SUCCESS in 5m 24s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/11/check/gate-dib-dsvm-functests-ubuntu-trusty/954ce51/ : SUCCESS in 34m 49s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/11/check/gate-dib-dsvm-functests-centos-7/178a07e/ : SUCCESS in 24m 27s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/11/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/3fd1b4a/ : SUCCESS in 3m 55s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/11/check/gate-dib-dsvm-functests-centos-7-extras-nv/ba7d900/ : SUCCESS in 5m 56s (non-voting)","accounts_in_message":[],"_revision_number":11},{"id":"df8d750d79c0e545524f5910dec338b5c9881c84","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-24 18:58:04.000000000","message":"Patch Set 11:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/11/check-tripleo/gate-tripleo-ci-centos-7-nonha/436d8c0/ : FAILURE in 38m 54s","accounts_in_message":[],"_revision_number":11},{"id":"740ae039b21d640b9cb5538b5d84b504d66f250a","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-29 05:52:36.000000000","message":"Uploaded patch set 12: Patch Set 11 was rebased.","accounts_in_message":[],"_revision_number":12},{"id":"8a5264d95c573f12d0560ad26c1e8f60b530ce08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-29 06:21:40.000000000","message":"Patch Set 12: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/12/check/gate-diskimage-builder-docs/b8e90bf//doc/build/html/ : SUCCESS in 4m 13s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/12/check/gate-diskimage-builder-pep8/4974ef2/ : SUCCESS in 5m 11s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/12/check/gate-diskimage-builder-python27/435bdd3/ : SUCCESS in 2m 50s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/12/check/gate-diskimage-builder-python34/188c400/ : SUCCESS in 4m 27s\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/12/check/gate-diskimage-builder-releasenotes/631a0b6//releasenotes/build/html/ : SUCCESS in 4m 10s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/12/check/gate-dib-dsvm-functests-ubuntu-trusty/d565c2a/ : SUCCESS in 28m 47s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/91/319591/12/check/gate-dib-dsvm-functests-ubuntu-xenial/58a6707/ : SUCCESS in 28m 52s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/12/check/gate-dib-dsvm-functests-centos-7/bd94b84/ : SUCCESS in 24m 21s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/12/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/7222b4c/ : SUCCESS in 9m 16s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/12/check/gate-dib-dsvm-functests-centos-7-extras-nv/b915f67/ : SUCCESS in 12m 06s (non-voting)","accounts_in_message":[],"_revision_number":12},{"id":"36f7a01ae578c14821d070b90c0e6baf576dc343","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-29 07:19:46.000000000","message":"Patch Set 12:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/91/319591/12/check-tripleo/gate-tripleo-ci-centos-7-nonha/b0b6353/ : FAILURE in 1h 26m 58s","accounts_in_message":[],"_revision_number":12},{"id":"6b114ba800f76efc0e4a7f1039e377acac31bf05","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-06-30 02:11:16.000000000","message":"Patch Set 12: Code-Review+2\n\nI feel like this is at the point we\u0027ve removed all \"common\" code and is a nice pythonic/OO approach to moving forward with handling the block devices.  I feel like we could iterate on this successfully.","accounts_in_message":[],"_revision_number":12},{"id":"78b86a185bb05072ee400db0f9876d937e3a7543","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-07-06 23:18:32.000000000","message":"Patch Set 12: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":12},{"id":"be659abef5de03a965be7ad8845df4e5c08396e5","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-13 21:22:23.000000000","message":"Patch Set 12: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"cb77135e1d04d5ef13c4deeaf506d2bdfe941d96","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-13 21:23:16.000000000","message":"Patch Set 12:\n\n(1 comment)","accounts_in_message":[],"_revision_number":12},{"id":"3af04ee01e7e4bd67e1c7e8817e69632eb4b6744","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-14 20:05:19.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"ef2b90de30c5dd2ff08fcfd41b7d2fcedf4f05af","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-14 20:06:09.000000000","message":"Patch Set 12:\n\n(5 comments)\n\nI like the idea to get rid of all the environment variables: now everything is passed in as command line parameter.","accounts_in_message":[],"_revision_number":12},{"id":"f5d47a223f5631989173c60e59ca9bd19879cdaa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 20:35:08.000000000","message":"Patch Set 13: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/13/check/gate-diskimage-builder-docs/2813e3c//doc/build/html/ : SUCCESS in 2m 44s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-pep8/2c1af17/ : SUCCESS in 2m 55s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python27/06fa271/ : SUCCESS in 2m 09s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python34/f8b233a/ : SUCCESS in 4m 17s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python35-nv/ec0fcb9/ : SUCCESS in 3m 49s (non-voting)\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/13/check/gate-diskimage-builder-releasenotes/80712e0//releasenotes/build/html/ : SUCCESS in 3m 35s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-trusty/e4d6ab5/ : SUCCESS in 17m 36s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-xenial/d435623/ : SUCCESS in 19m 34s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-centos-7/f5ea28e/ : FAILURE in 23m 15s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/b13586a/ : SUCCESS in 4m 49s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-centos-7-extras-nv/523eb32/ : SUCCESS in 7m 24s (non-voting)","accounts_in_message":[],"_revision_number":13},{"id":"af9583ca095d1f725dc4c3aef86ba41f7d5be899","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-14 20:46:26.000000000","message":"Patch Set 13:\n\nrecheck\nfedora mirror problem","accounts_in_message":[],"_revision_number":13},{"id":"9241f3fd172a13f6688bf400a14cc802fe011961","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 21:14:04.000000000","message":"Patch Set 13:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/13/check/gate-diskimage-builder-docs/44f8a44//doc/build/html/ : SUCCESS in 5m 00s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-pep8/3624a14/ : SUCCESS in 2m 37s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python27/0f91c19/ : SUCCESS in 5m 24s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python34/c3d1be5/ : SUCCESS in 2m 55s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python35-nv/df90417/ : SUCCESS in 3m 33s (non-voting)\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/13/check/gate-diskimage-builder-releasenotes/043af2e//releasenotes/build/html/ : SUCCESS in 2m 34s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-trusty/def4c4c/ : FAILURE in 18m 49s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-xenial/9ac3d5c/ : SUCCESS in 22m 07s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-centos-7/d6689f5/ : SUCCESS in 15m 25s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/3a6c1ad/ : SUCCESS in 9m 21s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-centos-7-extras-nv/7272c95/ : SUCCESS in 5m 47s (non-voting)","accounts_in_message":[],"_revision_number":13},{"id":"988449a289a227eeb7f223cf1461f233b5766482","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-14 21:41:00.000000000","message":"Patch Set 13:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/91/319591/13/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/8216c59/ : FAILURE in 1h 35m 28s","accounts_in_message":[],"_revision_number":13},{"id":"6610e5877f3b6cc1b5ae3b6d3b84dd9990b68014","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-15 04:01:06.000000000","message":"Patch Set 13:\n\nrecheck\nfedora mirror problem","accounts_in_message":[],"_revision_number":13},{"id":"be46e152eae4a09674faebcf253a823ae1aae364","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-15 04:44:04.000000000","message":"Patch Set 13: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/13/check/gate-diskimage-builder-docs/abf68cb//doc/build/html/ : SUCCESS in 3m 50s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-pep8/874fde0/ : SUCCESS in 3m 45s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python27/2f08d47/ : SUCCESS in 3m 57s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python34/baa1414/ : SUCCESS in 3m 33s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/91/319591/13/check/gate-diskimage-builder-python35-nv/18d2ee8/ : SUCCESS in 3m 22s (non-voting)\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/13/check/gate-diskimage-builder-releasenotes/e43d5d1//releasenotes/build/html/ : SUCCESS in 2m 41s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-trusty/4ce2d1d/ : SUCCESS in 21m 55s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-xenial/d6a6c7e/ : SUCCESS in 20m 29s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-centos-7/e68d37f/ : SUCCESS in 40m 07s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/075653f/ : SUCCESS in 10m 02s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/13/check/gate-dib-dsvm-functests-centos-7-extras-nv/219267b/ : SUCCESS in 11m 28s (non-voting)","accounts_in_message":[],"_revision_number":13},{"id":"b5acdb3ca4fbb1beba9c05cc787f2dd3e4667eef","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-07-15 05:22:13.000000000","message":"Patch Set 13: Code-Review-1\n\n(2 comments)\n\nsorry ... getting closer?!","accounts_in_message":[],"_revision_number":13},{"id":"a589d839cc2293258911763754dd1b2cc0e82587","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-15 05:47:44.000000000","message":"Patch Set 13:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/91/319591/13/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/f2491a2/ : FAILURE in 1h 46m 25s","accounts_in_message":[],"_revision_number":13},{"id":"4c8d74cbb265674ed3b702002eace33504043b41","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-15 15:37:56.000000000","message":"Uploaded patch set 14.","accounts_in_message":[],"_revision_number":14},{"id":"e743ecdef7f3d5e9a378592949b72d31aa507e9a","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-15 15:39:22.000000000","message":"Patch Set 13:\n\n(2 comments)","accounts_in_message":[],"_revision_number":13},{"id":"427c504cd0716775cbcce53f8d1036d59fb4e930","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-15 16:34:16.000000000","message":"Patch Set 14: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/91/319591/14/check/gate-diskimage-builder-docs/a5327a3//doc/build/html/ : SUCCESS in 2m 43s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/91/319591/14/check/gate-diskimage-builder-pep8/bd93a96/ : SUCCESS in 3m 49s\n- gate-diskimage-builder-python27 http://logs.openstack.org/91/319591/14/check/gate-diskimage-builder-python27/4b34901/ : SUCCESS in 4m 42s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/14/check/gate-diskimage-builder-python34/3900797/ : SUCCESS in 3m 52s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/91/319591/14/check/gate-diskimage-builder-python35-nv/92cdace/ : SUCCESS in 5m 14s (non-voting)\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/14/check/gate-diskimage-builder-releasenotes/0095c76//releasenotes/build/html/ : SUCCESS in 3m 49s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/91/319591/14/check/gate-dib-dsvm-functests-ubuntu-trusty/1c8d8a6/ : SUCCESS in 21m 07s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/91/319591/14/check/gate-dib-dsvm-functests-ubuntu-xenial/c2af32e/ : SUCCESS in 26m 14s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/14/check/gate-dib-dsvm-functests-centos-7/e298285/ : SUCCESS in 49m 24s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/14/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/6775d42/ : SUCCESS in 7m 58s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/14/check/gate-dib-dsvm-functests-centos-7-extras-nv/8326cc4/ : SUCCESS in 11m 08s (non-voting)","accounts_in_message":[],"_revision_number":14},{"id":"ab1fc7834a7143610d861669dc8dc6cb3a69e5da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-15 17:43:52.000000000","message":"Patch Set 14:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/91/319591/14/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/ae44589/ : FAILURE in 2h 01m 57s","accounts_in_message":[],"_revision_number":14},{"id":"1ac943dcaeddd81558f357bdf7f0974d399fc2b4","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-07-19 21:56:13.000000000","message":"Patch Set 14: Code-Review+2\n\ninterested as to why lint didn\u0027t pick it up","accounts_in_message":[],"_revision_number":14},{"id":"2feb997718db751a3c0f80539104cebbf86b7859","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-28 16:48:19.000000000","message":"Patch Set 14: Code-Review+1\n\nThis LGTM, I\u0027d like to first merge the spec, and also make a few images with this (we don\u0027t have any coverage for the bootloader / partitioning elements in CI)","accounts_in_message":[],"_revision_number":14},{"id":"483d64415d1eb8d9f4d35710bbef9c93c44278d6","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-28 17:51:01.000000000","message":"Patch Set 14: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":14},{"id":"ddd72e17534f4695916cb79e38e9e7559b36fc7a","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-08-23 19:45:28.000000000","message":"Uploaded patch set 15.","accounts_in_message":[],"_revision_number":15},{"id":"26f69aa9a3281e3d145de8b23cce6626ef562fa9","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-08-23 19:49:46.000000000","message":"Patch Set 14:\n\n(5 comments)","accounts_in_message":[],"_revision_number":14},{"id":"1bc1a33632046c644a134e3cd4f0991bfdebcdf6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-23 20:33:51.000000000","message":"Patch Set 15: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/91/319591/15/check/gate-diskimage-builder-docs-ubuntu-xenial/135f6cc//doc/build/html/ : SUCCESS in 2m 43s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/91/319591/15/check/gate-diskimage-builder-pep8-ubuntu-xenial/48c12d7/ : SUCCESS in 2m 43s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/91/319591/15/check/gate-diskimage-builder-python27-ubuntu-xenial/281cabd/ : SUCCESS in 3m 36s\n- gate-diskimage-builder-python34 http://logs.openstack.org/91/319591/15/check/gate-diskimage-builder-python34/d0d3dee/ : SUCCESS in 3m 08s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/91/319591/15/check/gate-diskimage-builder-python35-nv/71578ed/ : SUCCESS in 3m 40s (non-voting)\n- gate-diskimage-builder-releasenotes http://docs-draft.openstack.org/91/319591/15/check/gate-diskimage-builder-releasenotes/a43c7a5//releasenotes/build/html/ : SUCCESS in 3m 01s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/91/319591/15/check/gate-dib-dsvm-functests-ubuntu-xenial/825b178/ : SUCCESS in 22m 04s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/91/319591/15/check/gate-dib-dsvm-functests-centos-7/a6fb1c6/ : SUCCESS in 23m 00s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/91/319591/15/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/fb7ed53/ : SUCCESS in 5m 23s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/91/319591/15/check/gate-dib-dsvm-functests-centos-7-extras-nv/60f4b31/ : SUCCESS in 6m 31s (non-voting)","accounts_in_message":[],"_revision_number":15},{"id":"910ccaeb65f8f0106a9235da958fe8a00ee04a4f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-24 01:39:55.000000000","message":"Patch Set 15:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/91/319591/15/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/6c4e553/ : FAILURE in 1h 35m 14s","accounts_in_message":[],"_revision_number":15},{"id":"34d64e892715d0d95cc5b3ae520fc84c07d2d512","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-09-08 04:31:01.000000000","message":"Patch Set 15: Cherry Picked\n\nThis patchset was cherry picked to branch feature/v2 as commit 3d48a528c14f9038de4d00d9c7d08afda4830d8d","accounts_in_message":[],"_revision_number":15},{"id":"ab9087b5f45a6b181110ba13d2a410d2fe27d429","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-09-12 19:46:33.000000000","message":"Patch Set 15: Workflow-1\n\nW-1\u0027ing since it went in the v2 branch","accounts_in_message":[],"_revision_number":15},{"id":"df8038be0cf94702bc192efd253df39900f1db81","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-09-21 05:18:53.000000000","message":"Abandoned\n\nWas already merged in v2 branch.","accounts_in_message":[],"_revision_number":15}],"current_revision_number":15,"current_revision":"da76833660f752a68c459cf46cae268ea511a411","revisions":{"799d231a72e63e356568dfe50fe7442f890b2f4b":{"kind":"REWORK","_number":1,"created":"2016-05-21 20:44:08.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/1"}}},"commit":{"parents":[{"commit":"95c874abb98b4f9b4dab085be1be6c5c1909656d","subject":"Merge \"Add dhcp-all-interfaces.target for syncing units\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/95c874abb98b4f9b4dab085be1be6c5c1909656d"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 20:42:16.000000000","tz":120},"subject":"Refactor: loopdev handling / introducing element results and cleanup","message":"Refactor: loopdev handling / introducing element results and cleanup\n\nSometimes it is needed to pass the result of an element back to the\nmain script or to other elements.\nThe element that creates a resource should also delete, destroy,\numount or detach this resource afterwards.\n\nWhen a result of an element is needed, it is possible to use\neval_run_d to get mostly one result in an environment variable.  There\nwas no way, that an element script for cleanup was called when a\nproblem occurred.\n\nThis patch introduces a way of passing results back to the main\nscript: the element can call the function \u0027element_result_add\u0027 to do\nso.\n\nThis patch also introduces the phases \"umount\" and \"exit\".\nThe first is called when the image should be unmounted - the later\none is called if a problem occurred during the image building.\n\nUsing the one liner of creating and deleting the loop device here is\nto show the concept.\n\n(This is a extraction of one refactoring needed to implement the\npartitioning-parted and lvm2 elements.)\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/799d231a72e63e356568dfe50fe7442f890b2f4b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/799d231a72e63e356568dfe50fe7442f890b2f4b"}]},"branch":"refs/heads/master"},"1bd87baaf6f276ac1a4979aca7169dc4bcea7e67":{"kind":"REWORK","_number":2,"created":"2016-05-21 20:59:05.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/2"}}},"commit":{"parents":[{"commit":"95c874abb98b4f9b4dab085be1be6c5c1909656d","subject":"Merge \"Add dhcp-all-interfaces.target for syncing units\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/95c874abb98b4f9b4dab085be1be6c5c1909656d"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 20:58:33.000000000","tz":120},"subject":"Refactor: loopdev handling / introducing element results and cleanup","message":"Refactor: loopdev handling / introducing element results and cleanup\n\nSometimes it is needed to pass the result of an element back to the\nmain script or to other elements.\nThe element that creates a resource should also delete, destroy,\numount or detach this resource afterwards.\n\nWhen a result of an element is needed, it is possible to use\neval_run_d to get mostly one result in an environment variable.  There\nwas no way, that an element script for cleanup was called when a\nproblem occurred.\n\nThis patch introduces a way of passing results back to the main\nscript: the element can call the function \u0027element_result_add\u0027 to do\nso.\n\nThis patch also introduces the phases \"umount\" and \"exit\".\nThe first is called when the image should be unmounted - the later\none is called if a problem occurred during the image building.\n\nUsing the one liner of creating and deleting the loop device here is\nto show the concept.\n\n(This is a extraction of one refactoring needed to implement the\npartitioning-parted and lvm2 elements.)\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1bd87baaf6f276ac1a4979aca7169dc4bcea7e67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1bd87baaf6f276ac1a4979aca7169dc4bcea7e67"}]},"branch":"refs/heads/master"},"66b17dff21d3a42277b8f4a351d3ea07076dd1ce":{"kind":"REWORK","_number":3,"created":"2016-05-24 18:25:15.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/3"}}},"commit":{"parents":[{"commit":"95c874abb98b4f9b4dab085be1be6c5c1909656d","subject":"Merge \"Add dhcp-all-interfaces.target for syncing units\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/95c874abb98b4f9b4dab085be1be6c5c1909656d"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-24 18:03:49.000000000","tz":120},"subject":"Refactor: block-device handling","message":"Refactor: block-device handling\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into the new element.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\n(Implementation note: the historical way of passing arguments and\nelements with the help of dib-run-parts does not work here.  The order\nof the elements is needed.  Also it must be possible to provide a\ndifferent set of configuration parameters to each element. One element\ncan be theoretical occur more than once.)\n\nIn addition it introduces a concept, that when an error occurs each\nelement can perform some cleanup during the \u0027exit\u0027 phase.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/66b17dff21d3a42277b8f4a351d3ea07076dd1ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/66b17dff21d3a42277b8f4a351d3ea07076dd1ce"}]},"branch":"refs/heads/master"},"430909ac128a7cd796521fdfc23bcddac64932b6":{"kind":"REWORK","_number":4,"created":"2016-05-25 20:34:07.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/4"}}},"commit":{"parents":[{"commit":"95c874abb98b4f9b4dab085be1be6c5c1909656d","subject":"Merge \"Add dhcp-all-interfaces.target for syncing units\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/95c874abb98b4f9b4dab085be1be6c5c1909656d"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-25 20:32:45.000000000","tz":120},"subject":"Refactor: block-device handling","message":"Refactor: block-device handling\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a new element.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\n(Implementation note: the historical way of passing arguments and\nelements with the help of dib-run-parts does not work here.  The order\nof the elements is important.  Also it must be possible to provide a\ndifferent set of configuration parameters to each element. One element\ncan be theoretical occur more than once.)\n\nIn addition it introduces a concept, that when an error occurs each\nelement can perform some cleanup during the \u0027exit\u0027 phase.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/430909ac128a7cd796521fdfc23bcddac64932b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/430909ac128a7cd796521fdfc23bcddac64932b6"}]},"branch":"refs/heads/master"},"c937bee98ab4544961952c081f513fcc73062284":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2016-05-28 06:50:08.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/5"}}},"commit":{"parents":[{"commit":"5f4cac330320d7470463370a4b54fae285753b74","subject":"Merge \"Add a best-effort sudo safety check\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5f4cac330320d7470463370a4b54fae285753b74"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-27 13:48:43.000000000","tz":120},"subject":"Refactor: block-device handling","message":"Refactor: block-device handling\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a new element.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\n(Implementation note: the historical way of passing arguments and\nelements with the help of dib-run-parts does not work here.  The order\nof the elements is important.  Also it must be possible to provide a\ndifferent set of configuration parameters to each element. One element\ncan be theoretical occur more than once.)\n\nIn addition it introduces a concept, that when an error occurs each\nelement can perform some cleanup during the \u0027exit\u0027 phase.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/c937bee98ab4544961952c081f513fcc73062284"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/c937bee98ab4544961952c081f513fcc73062284"}]},"branch":"refs/heads/master"},"19db0131eff487c40f57eea7d385c4aa8dc870a3":{"kind":"REWORK","_number":6,"created":"2016-06-16 20:30:15.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/6"}}},"commit":{"parents":[{"commit":"8661dd1a3190990205099f545e1b6c14cf0417ce","subject":"Introspect logging testing more","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8661dd1a3190990205099f545e1b6c14cf0417ce"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-06-16 20:29:08.000000000","tz":120},"subject":"Refactor: block-device handling","message":"Refactor: block-device handling\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a new element.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/19db0131eff487c40f57eea7d385c4aa8dc870a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/19db0131eff487c40f57eea7d385c4aa8dc870a3"}]},"branch":"refs/heads/master"},"a1e7a530225eb5e10d7bce37781fa7aec9d49296":{"kind":"REWORK","_number":7,"created":"2016-06-17 18:22:04.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/7"}}},"commit":{"parents":[{"commit":"8661dd1a3190990205099f545e1b6c14cf0417ce","subject":"Introspect logging testing more","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8661dd1a3190990205099f545e1b6c14cf0417ce"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-06-17 18:18:23.000000000","tz":120},"subject":"Refactor: block-device handling (Local Loop)","message":"Refactor: block-device handling (Local Loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a1e7a530225eb5e10d7bce37781fa7aec9d49296"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a1e7a530225eb5e10d7bce37781fa7aec9d49296"}]},"branch":"refs/heads/master"},"968c48748e3c0ae5a89a13c311275d05bc4414c5":{"kind":"REWORK","_number":8,"created":"2016-06-18 07:39:33.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/8"}}},"commit":{"parents":[{"commit":"abe666f17eb6468383f7bf0ba3e2f3c28e024eeb","subject":"Merge \"Remove discover from test-requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/abe666f17eb6468383f7bf0ba3e2f3c28e024eeb"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-06-18 07:38:37.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/968c48748e3c0ae5a89a13c311275d05bc4414c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/968c48748e3c0ae5a89a13c311275d05bc4414c5"}]},"branch":"refs/heads/master"},"1ae60212c5fd4ef1b0211ae555bc4c22afdf45c9":{"kind":"REWORK","_number":9,"created":"2016-06-20 20:28:44.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/9"}}},"commit":{"parents":[{"commit":"abe666f17eb6468383f7bf0ba3e2f3c28e024eeb","subject":"Merge \"Remove discover from test-requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/abe666f17eb6468383f7bf0ba3e2f3c28e024eeb"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-06-20 18:41:17.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1ae60212c5fd4ef1b0211ae555bc4c22afdf45c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/1ae60212c5fd4ef1b0211ae555bc4c22afdf45c9"}]},"branch":"refs/heads/master"},"e3c53ee2afe731d9ae3542bccff164f4f26ecf62":{"kind":"REWORK","_number":10,"created":"2016-06-23 19:34:58.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/10"}}},"commit":{"parents":[{"commit":"abe666f17eb6468383f7bf0ba3e2f3c28e024eeb","subject":"Merge \"Remove discover from test-requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/abe666f17eb6468383f7bf0ba3e2f3c28e024eeb"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-06-23 19:34:42.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e3c53ee2afe731d9ae3542bccff164f4f26ecf62"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/e3c53ee2afe731d9ae3542bccff164f4f26ecf62"}]},"branch":"refs/heads/master"},"5628adcf7523914d8d4cfac02a779938bece398b":{"kind":"REWORK","_number":11,"created":"2016-06-24 17:53:44.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/11"}}},"commit":{"parents":[{"commit":"abe666f17eb6468383f7bf0ba3e2f3c28e024eeb","subject":"Merge \"Remove discover from test-requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/abe666f17eb6468383f7bf0ba3e2f3c28e024eeb"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-06-24 15:35:18.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5628adcf7523914d8d4cfac02a779938bece398b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5628adcf7523914d8d4cfac02a779938bece398b"}]},"branch":"refs/heads/master"},"c666df6236e30b7d5c010db25ae15112201e2a31":{"kind":"TRIVIAL_REBASE","_number":12,"created":"2016-06-29 05:52:36.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/12"}}},"commit":{"parents":[{"commit":"619a47dbb3fd8cc4e154db65e211bfb0f6483540","subject":"Merge \"Release notes for 1.18\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/619a47dbb3fd8cc4e154db65e211bfb0f6483540"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-06-29 05:03:20.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/c666df6236e30b7d5c010db25ae15112201e2a31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/c666df6236e30b7d5c010db25ae15112201e2a31"}]},"branch":"refs/heads/master"},"3ab286d64a98e9f455d34cc8db0b59d32e97c5b8":{"kind":"REWORK","_number":13,"created":"2016-07-14 20:05:19.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/13"}}},"commit":{"parents":[{"commit":"8fdbbc3413fb6a8958c8b283108ec4b85e0f218c","subject":"Merge \"Check sudoers file after editing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8fdbbc3413fb6a8958c8b283108ec4b85e0f218c"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-07-14 20:04:26.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3ab286d64a98e9f455d34cc8db0b59d32e97c5b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3ab286d64a98e9f455d34cc8db0b59d32e97c5b8"}]},"branch":"refs/heads/master"},"5587ff8c2780b08447295b1fb3b8289fb9bce6f7":{"kind":"REWORK","_number":14,"created":"2016-07-15 15:37:56.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/14","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/14","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/14"}}},"commit":{"parents":[{"commit":"8fdbbc3413fb6a8958c8b283108ec4b85e0f218c","subject":"Merge \"Check sudoers file after editing\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8fdbbc3413fb6a8958c8b283108ec4b85e0f218c"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-07-15 15:28:51.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5587ff8c2780b08447295b1fb3b8289fb9bce6f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/5587ff8c2780b08447295b1fb3b8289fb9bce6f7"}]},"branch":"refs/heads/master"},"da76833660f752a68c459cf46cae268ea511a411":{"kind":"REWORK","_number":15,"created":"2016-08-23 19:45:28.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/91/319591/15","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/91/319591/15","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/91/319591/15"}}},"commit":{"parents":[{"commit":"0ca20753cee235b1c5ce33af1d96a2c0267e9822","subject":"Merge \"Add \"audit\"package to yum-minimal\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/0ca20753cee235b1c5ce33af1d96a2c0267e9822"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-05-21 19:32:35.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-08-23 19:44:43.000000000","tz":120},"subject":"Refactor: block-device handling (local loop)","message":"Refactor: block-device handling (local loop)\n\nBlock device handling can be somewhat complex - especially\nwhen taking things like md, lvm or encryption into account.\n\nThis patch factors out the creation and deletion of the local\nloop image device handling into a python library.\n\nThe main propose of this patch is to implement the needed\ninfrastructure.  Based on this, more advanced functions can be added.\nExample: (advanced) partitioning, LVM, handling different boot\nscenarios (BIOS, UEFI, ...), possibility of handling multiple images\n(local loop image, iSCSI, physical hard disk, ...), handling of\ndifferent filesystems for different partitions / LVs.\n\nChange-Id: Ib626b36a00f8a5dc3dbde8df3e2619a2438eaaf1\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/da76833660f752a68c459cf46cae268ea511a411"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/da76833660f752a68c459cf46cae268ea511a411"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}