)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1b753811b5cf19f766c082e039cb74327ce82322","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vmud213 \u003cvinay50muddu@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-24 12:21:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Build wholedisk images capable of secure boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds capability to build wholedisk images which can boot in secured"},{"line_number":10,"context_line":"environments."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_894eca38","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":45},"updated":"2016-06-27 04:16:17.000000000","message":"s/secure boot/ UEFI secure boot/","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"075ca8edd6f2d3425a8122d9ee9a1ea0dd6ad31e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vmud213 \u003cvinay50muddu@yahoo.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-24 12:21:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Build wholedisk images capable of secure boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds capability to build wholedisk images which can boot in secured"},{"line_number":10,"context_line":"environments."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_99a858dd","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":45},"in_reply_to":"3aaa91ec_894eca38","updated":"2016-06-29 05:48:36.000000000","message":"Done","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1b753811b5cf19f766c082e039cb74327ce82322","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Build wholedisk images capable of secure boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds capability to build wholedisk images which can boot in secured"},{"line_number":10,"context_line":"environments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7208f8bd2266ccc5f25b9b332d1f3a9d97ef6a5e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_6949de30","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":13},"updated":"2016-06-27 04:16:17.000000000","message":"Add a comment on list of OSes where this patch will work.","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"075ca8edd6f2d3425a8122d9ee9a1ea0dd6ad31e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Build wholedisk images capable of secure boot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds capability to build wholedisk images which can boot in secured"},{"line_number":10,"context_line":"environments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7208f8bd2266ccc5f25b9b332d1f3a9d97ef6a5e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_d9aae0d1","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":13},"in_reply_to":"3aaa91ec_6949de30","updated":"2016-06-29 05:48:36.000000000","message":"Done","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1b753811b5cf19f766c082e039cb74327ce82322","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds capability to build wholedisk images which can boot in secured"},{"line_number":10,"context_line":"environments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7208f8bd2266ccc5f25b9b332d1f3a9d97ef6a5e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_29435614","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":11},"updated":"2016-06-27 04:16:17.000000000","message":"Add a \u0027Depends-on\u0027 header.\nDepends-On: If1fb0abe3507a0fe2b6f5266e0e2e5b32d628c45","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"075ca8edd6f2d3425a8122d9ee9a1ea0dd6ad31e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adds capability to build wholedisk images which can boot in secured"},{"line_number":10,"context_line":"environments."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7208f8bd2266ccc5f25b9b332d1f3a9d97ef6a5e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3aaa91ec_39ba0424","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":11},"in_reply_to":"3aaa91ec_29435614","updated":"2016-06-29 05:48:36.000000000","message":"Done","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"}],"elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1b753811b5cf19f766c082e039cb74327ce82322","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    sed -i \"s%search --no-floppy --fs-uuid --set\u003droot .*$%search --no-floppy --set\u003droot --label ${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_29dfd63a","line":265,"range":{"start_line":265,"start_character":2,"end_line":265,"end_character":43},"updated":"2016-06-27 04:16:17.000000000","message":"Why is this check required? Presence of /sys/firmware/efi meant the image is for UEFI.\n\nAll UEFI images should be made as UEFI secure boot capable images.","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"075ca8edd6f2d3425a8122d9ee9a1ea0dd6ad31e","unresolved":false,"context_lines":[{"line_number":262,"context_line":"    sed -i \"s%search --no-floppy --fs-uuid --set\u003droot .*$%search --no-floppy --set\u003droot --label ${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_792c8c4a","line":265,"range":{"start_line":265,"start_character":2,"end_line":265,"end_character":43},"in_reply_to":"3aaa91ec_29dfd63a","updated":"2016-06-29 05:48:36.000000000","message":"This is an already existing code here https://github.com/openstack/diskimage-builder/blob/master/elements/bootloader/finalise.d/50-bootloader#L191-L193 . i just made it execute only for BIOS capable images since for UEFI we need linuxefi and initrdefi.","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1b753811b5cf19f766c082e039cb74327ce82322","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            sed -i \"s%UUID\u003d[A-Za-z0-9\\-]*%LABEL\u003d${DIB_ROOT_LABEL}%\" /etc/fstab"},{"line_number":280,"context_line":"        fi"},{"line_number":281,"context_line":"        if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":282,"context_line":"            if [ -e /boot/efi/EFI/fedora/shim.efi ]; then"},{"line_number":283,"context_line":"                echo \"Copying /boot/efi/EFI/fedora/shim.efi to /boot/efi/EFI/BOOT/BOOTX64.EFI\""},{"line_number":284,"context_line":"                cp -f /boot/efi/EFI/fedora/shim.efi /boot/efi/EFI/BOOT/BOOTX64.EFI"},{"line_number":285,"context_line":"                [ -e $GRUB_CFG ] \u0026\u0026 echo \"Copying grub.cfg to EFI/fedora\" \u0026\u0026 cp -f $GRUB_CFG /boot/efi/EFI/fedora/grub.cfg"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_49aa2286","line":282,"range":{"start_line":282,"start_character":34,"end_line":282,"end_character":40},"updated":"2016-06-27 04:16:17.000000000","message":"Is this true only for fedora? Or this rule would apply to all redhat family of distros?","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"075ca8edd6f2d3425a8122d9ee9a1ea0dd6ad31e","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            sed -i \"s%UUID\u003d[A-Za-z0-9\\-]*%LABEL\u003d${DIB_ROOT_LABEL}%\" /etc/fstab"},{"line_number":280,"context_line":"        fi"},{"line_number":281,"context_line":"        if [ -n \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":282,"context_line":"            if [ -e /boot/efi/EFI/fedora/shim.efi ]; then"},{"line_number":283,"context_line":"                echo \"Copying /boot/efi/EFI/fedora/shim.efi to /boot/efi/EFI/BOOT/BOOTX64.EFI\""},{"line_number":284,"context_line":"                cp -f /boot/efi/EFI/fedora/shim.efi /boot/efi/EFI/BOOT/BOOTX64.EFI"},{"line_number":285,"context_line":"                [ -e $GRUB_CFG ] \u0026\u0026 echo \"Copying grub.cfg to EFI/fedora\" \u0026\u0026 cp -f $GRUB_CFG /boot/efi/EFI/fedora/grub.cfg"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3aaa91ec_9929783a","line":282,"range":{"start_line":282,"start_character":34,"end_line":282,"end_character":40},"in_reply_to":"3aaa91ec_49aa2286","updated":"2016-06-29 05:48:36.000000000","message":"I have tested it for fedora,centos and centos7. Need to rework on the logic to retrieve the destination path. Will add it in new patch.","commit_id":"d67647c12d7a5419285b6cacb40ae6fbc75bd808"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"d8bdbe734394b4e21423f48244b2f36a20a7f163","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"},{"line_number":269,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1aa78d24_813c0194","line":266,"updated":"2016-07-12 23:09:30.000000000","message":"What prompted this change? This should work currently?","commit_id":"e02c963f7267684bbab563e7922e581266d619c1"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"6160c79dcb5bf6a8dabb4b5bc903ce3978a779cc","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"},{"line_number":269,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1aa78d24_89c97e7c","line":266,"in_reply_to":"1aa78d24_813c0194","updated":"2016-07-14 04:39:16.000000000","message":"If i understand it correctly, u mean to ask why i need to check whether \"DIB_UEFI_SUPPORT\" is not set before editing the GRUB_CFG?\nI agree it works even without the conditional check. But i thought may be it\u0027l provide an extra check. Will wait and see for more comments and remove in the follow up patch accordingly.","commit_id":"e02c963f7267684bbab563e7922e581266d619c1"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"6c9f835f810d068177209a6fb4f084f8eafdea9f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"},{"line_number":269,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dada55a8_6b16b956","line":266,"in_reply_to":"1aa78d24_89c97e7c","updated":"2016-07-22 17:10:05.000000000","message":"What I mean is - this looks like stuff to edit when EFI is being used, but the conditional is so that this is only run when EFI is turned off. Maybe the conditional is just inverted?","commit_id":"e02c963f7267684bbab563e7922e581266d619c1"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1a933d91c64827c2b40d2b2b7bb0d9b494aac66a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"},{"line_number":269,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dada55a8_c0b1dbe1","line":266,"in_reply_to":"dada55a8_2e9fafb5","updated":"2016-07-27 08:46:18.000000000","message":"I want to search grub for \"linux\" or \"initrd\" if it is BIOS and \"linuxefi\" or \"initrdefi\" if it UEFI","commit_id":"e02c963f7267684bbab563e7922e581266d619c1"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"fa47e0869c5169b278bd5e5b45b6b43402efc8fa","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"},{"line_number":269,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dada55a8_2e9fafb5","line":266,"in_reply_to":"dada55a8_6b16b956","updated":"2016-07-22 17:14:55.000000000","message":"Just to clarify - What I am wondering is: if the conditional above is correct then there is a change of behavior for the case when UEFI is disabled (the code below). I\u0027m wondering why there is any change for that case since BIOS based images should remain the same","commit_id":"e02c963f7267684bbab563e7922e581266d619c1"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"1a933d91c64827c2b40d2b2b7bb0d9b494aac66a","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    sed -i \"s%root\u003dUUID\u003d[A-Za-z0-9\\-]*%root\u003dLABEL\u003d${DIB_ROOT_LABEL}%\" $GRUB_CFG"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    if [ -z \"${DIB_UEFI_SUPPORT:-}\" ]; then"},{"line_number":266,"context_line":"        # Fix efi specific instructions in grub config file"},{"line_number":267,"context_line":"        if [ -d /sys/firmware/efi ]; then"},{"line_number":268,"context_line":"            sed -i \u0027s%\\(initrd\\|linux\\)efi /boot%\\1 /boot%g\u0027 $GRUB_CFG"},{"line_number":269,"context_line":"        fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"dada55a8_60c74f64","line":266,"in_reply_to":"dada55a8_6b16b956","updated":"2016-07-27 08:46:18.000000000","message":"No. I want this to be edited when it is BIOS. This is already part of the base patch. Since we are also supporting UEFI now, i want this code part to be executed only if it is not UEFI, i.e BIOS.","commit_id":"e02c963f7267684bbab563e7922e581266d619c1"}]}