)]}'
{"doc/source/specs/README.rst":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This directory is used to hold approved design specifications for additions to"},{"line_number":10,"context_line":"the diskimage-builder project. Reviews of the specs are done in gerrit, using a"},{"line_number":11,"context_line":"similar workflow to how we review and merge changes to the code itself. For"},{"line_number":12,"context_line":"specific policies around specification review, refer to the end of this"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_cdff5432","line":9,"updated":"2016-06-30 21:04:52.000000000","message":"I wouldn\u0027t go for \u0027additions\u0027 (only). What I got from your description is a long term goal to have the complete specification available here.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"3ae5ea6e1573e42969a2df94f78d98ae01aea02e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This directory is used to hold approved design specifications for additions to"},{"line_number":10,"context_line":"the diskimage-builder project. Reviews of the specs are done in gerrit, using a"},{"line_number":11,"context_line":"similar workflow to how we review and merge changes to the code itself. For"},{"line_number":12,"context_line":"specific policies around specification review, refer to the end of this"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_77ceae84","line":9,"in_reply_to":"3aaa91ec_cdff5432","updated":"2016-07-03 16:36:19.000000000","message":"Agreed","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"a04831732dfab28076ca6a0353f5f4463c97514f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The layout of this directory is::"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  specs/v\u003cmajor_version\u003e/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Where there are two sub-directories:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_63a40fb9","line":17,"updated":"2016-07-14 17:09:29.000000000","message":"Agree with Greg here. I\u0027ve had experience with both ways, and having the major version numbering in a project like dib which does not bump major versions much, is a positive thing for planning.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The layout of this directory is::"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  specs/v\u003cmajor_version\u003e/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Where there are two sub-directories:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_cd22b4b8","line":17,"updated":"2016-06-30 21:04:52.000000000","message":"I would not go for any kind of version-ing here:\no When v7 is delivered 7 different directories must be scanned to get an overview.\no IMHO the version number when a feature was added is not interesting.\no At the time of the creation of a spec it might be unknown in which version it is implemented.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"3ae5ea6e1573e42969a2df94f78d98ae01aea02e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The layout of this directory is::"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  specs/v\u003cmajor_version\u003e/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Where there are two sub-directories:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_979cfa6a","line":17,"in_reply_to":"3aaa91ec_cd22b4b8","updated":"2016-07-03 16:36:19.000000000","message":"Practically for us this won\u0027t mean much, we bump major versions very rarely and I really really hope we can maintain that practice. When we do bump a major version though I think it is worth re-evaluating our approved but not yet implemented specs as they likely need to change. Additionally, I could see a lot of value in having a \u003cnext_major_version\u003e/approved specs dir (or proposals to it) so signal \u0027things that were going to want in a new version\u0027.\n\n\nI agree that post-implementation this is not particularly interesting. I think we could solve that pretty easily with symlinks or by using a single dir that we move specs in to after implementation - although that probably isn\u0027t worth it until we have more than 1 major version.\n\n\nWe really should know the major version a spec is targeted at. If we are planning a major version bump I think this should be seen as a \u0027huge deal\u0027 and we need to take in to consideration what specs are going in when. Its not a huge burden - it is simply what directory a spec lives in so it is fairly easy to change, but there definitely should be some consideration here IMO.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  specs/v\u003cmajor_version\u003e/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Where there are two sub-directories:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- specs/v\u003cmajor_version\u003e/approved: specifications approved but not yet"},{"line_number":22,"context_line":"  implemented"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_cd091433","line":19,"updated":"2016-06-30 21:04:52.000000000","message":"Later on you write about a third: backlog","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"1ccac6adfd4995f03d2d75b5b1632bfee6203d3b","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  specs/v\u003cmajor_version\u003e/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Where there are two sub-directories:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- specs/v\u003cmajor_version\u003e/approved: specifications approved but not yet"},{"line_number":22,"context_line":"  implemented"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_e22307a9","line":19,"in_reply_to":"3aaa91ec_cd091433","updated":"2016-07-03 16:25:04.000000000","message":"The backlog lives above the version dir","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"3ae5ea6e1573e42969a2df94f78d98ae01aea02e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  specs/v\u003cmajor_version\u003e/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Where there are two sub-directories:"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- specs/v\u003cmajor_version\u003e/approved: specifications approved but not yet"},{"line_number":22,"context_line":"  implemented"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_d7a5e2b5","line":19,"in_reply_to":"3aaa91ec_e22307a9","updated":"2016-07-03 16:36:19.000000000","message":"Will change this","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"f505d3b2960cf7b830005bc871daee6e74f0573f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"--------------------------------"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Developers proposing a specification should propose a new file in the"},{"line_number":29,"context_line":"``approved`` directory. diskimage-bulder-core will review the change in the"},{"line_number":30,"context_line":"usual manner for the project, and eventually it will get merged if a consensus"},{"line_number":31,"context_line":"is reached. The developer is then free to propose code reviews to implement"},{"line_number":32,"context_line":"their specification. These reviews should be sure to reference the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dada55a8_9d28d79b","line":29,"updated":"2016-07-21 15:58:55.000000000","message":"typo: bulder -\u003e builder","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"``approved`` directory. diskimage-bulder-core will review the change in the"},{"line_number":30,"context_line":"usual manner for the project, and eventually it will get merged if a consensus"},{"line_number":31,"context_line":"is reached. The developer is then free to propose code reviews to implement"},{"line_number":32,"context_line":"their specification. These reviews should be sure to reference the"},{"line_number":33,"context_line":"specification as the topic in the proposed reviews."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"When a specification has been implemented either the developer or someone"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_301c6b69","line":32,"updated":"2016-06-30 21:04:52.000000000","message":"Typo? the developer ... their ...","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"This directory structure allows you to see what we thought about doing,"},{"line_number":44,"context_line":"decided to do, and actually got done. Users interested in functionality in a"},{"line_number":45,"context_line":"given release should only refer to the ``implemented`` directory."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Example specifications"},{"line_number":48,"context_line":"----------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_50793792","line":45,"updated":"2016-06-30 21:04:52.000000000","message":"As already said: they have to refer to all implemented directories of earlier versions.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"claiming a spec, start by posting a review for the specification that moves it"},{"line_number":66,"context_line":"from this directory to the next active release. Please set yourself as the new"},{"line_number":67,"context_line":"`primary assignee` and maintain the original author in the `other contributors`"},{"line_number":68,"context_line":"list."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Specification review policies"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_d09367a1","line":68,"updated":"2016-06-30 21:04:52.000000000","message":"What about defining a \u0027deletion time point\u0027 (maybe default now() + 2y).  This would solve the housekeeping issue.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"b6570384b66603c5c1f34f23e26869318e70c086","unresolved":false,"context_lines":[{"line_number":65,"context_line":"claiming a spec, start by posting a review for the specification that moves it"},{"line_number":66,"context_line":"from this directory to the next active release. Please set yourself as the new"},{"line_number":67,"context_line":"`primary assignee` and maintain the original author in the `other contributors`"},{"line_number":68,"context_line":"list."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Specification review policies"},{"line_number":71,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_b776563c","line":68,"in_reply_to":"3aaa91ec_d09367a1","updated":"2016-07-03 16:39:05.000000000","message":"I think the deletion time point should be as simple as \u0027when this is not something we want\u0027. I think its totally fine for something to live in the backlog forever if it is still something we want, and also for something to get deleted a week later if we decide it no longer is desired.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"----------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Proposed changes which are trivial (very small amounts of code) and don\u0027t"},{"line_number":80,"context_line":"change any of our public APIs are sometimes not required to provide a"},{"line_number":81,"context_line":"specification."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_10e16f2a","line":80,"updated":"2016-06-30 21:04:52.000000000","message":"Who will decide what is \u0027trivial\u0027 and what is \nsometimes?","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"b4e1379ec3ec2f9e6c8a1b085a083c72c83171b6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"----------------------"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Proposed changes which are trivial (very small amounts of code) and don\u0027t"},{"line_number":80,"context_line":"change any of our public APIs are sometimes not required to provide a"},{"line_number":81,"context_line":"specification."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bacf61ea_2d9dd259","line":80,"in_reply_to":"3aaa91ec_10e16f2a","updated":"2016-07-28 16:55:28.000000000","message":"Yep, I\u0027m not sure its super easy to define, but I\u0027ll try to.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"}],"doc/source/specs/v1/approved/v1-template.rst":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Introduction paragraph -- why are we doing anything? A single paragraph of"},{"line_number":12,"context_line":"prose that operators can understand. The title and this first paragraph"},{"line_number":13,"context_line":"should be used as the subject line and body of the commit message"},{"line_number":14,"context_line":"respectively."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Some notes about the diskimabe-bulider spec process:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_2f6893f4","line":13,"updated":"2016-06-30 21:04:52.000000000","message":"commit message*s*?\nWhat I understand is, that this is a description of possible some patches. Correct?","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"should be used as the subject line and body of the commit message"},{"line_number":14,"context_line":"respectively."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Some notes about the diskimabe-bulider spec process:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Not all changes need a spec. For more information see"},{"line_number":19,"context_line":"  \u003cadd_url_here\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_cd6ab419","line":16,"updated":"2016-06-30 21:04:52.000000000","message":"Typo: bulider -\u003e builder","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"f505d3b2960cf7b830005bc871daee6e74f0573f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"should be used as the subject line and body of the commit message"},{"line_number":14,"context_line":"respectively."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Some notes about the diskimabe-bulider spec process:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Not all changes need a spec. For more information see"},{"line_number":19,"context_line":"  \u003cadd_url_here\u003e"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dada55a8_60f29807","line":16,"in_reply_to":"3aaa91ec_cd6ab419","updated":"2016-07-21 15:58:55.000000000","message":"Typo: diskimabe-bulider -\u003e diskimage-builder","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"* But, API changes are held to a much higher level of scrutiny."},{"line_number":32,"context_line":"  As soon as an API change merges, we must assume it could be in production"},{"line_number":33,"context_line":"  somewhere, and as such, we then need to support that API change forever."},{"line_number":34,"context_line":"  To avoid getting that wrong, we do want lots of details about API changes"},{"line_number":35,"context_line":"  upfront."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_500ad7d2","line":33,"updated":"2016-06-30 21:04:52.000000000","message":"see comment about missing deprecation process.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  will also allow inline feedback on the diagram itself."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Problem description"},{"line_number":57,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"A detailed description of the problem. What problem is this blueprint"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_d0924756","line":56,"updated":"2016-06-30 21:04:52.000000000","message":"It\u0027s not always a problem ;-)\nWhat about simply \u0027Description\u0027?","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"f505d3b2960cf7b830005bc871daee6e74f0573f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  will also allow inline feedback on the diagram itself."},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Problem description"},{"line_number":57,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"A detailed description of the problem. What problem is this blueprint"}],"source_content_type":"text/x-rst","patch_set":3,"id":"dada55a8_202ee0fa","line":56,"in_reply_to":"3aaa91ec_d0924756","updated":"2016-07-21 15:58:55.000000000","message":"That section looks fine.  It should be possible to formulate a \"problem to be solved\" for any reasonable spec (at least something along the lines of \"It is currently complicated to do \u003cmore-or-less-useful-thing\u003e...\" :-)","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"Aside from the API, are there other ways a user will interact with this"},{"line_number":106,"context_line":"feature?"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Performance Impact"},{"line_number":109,"context_line":"------------------"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"Describe any potential performance impact on the system, for example"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_7062733f","line":108,"updated":"2016-06-30 21:04:52.000000000","message":"IMHO this is two fold: once in the host system (during building), but also in the target system (i.e. faster booting).","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"Describe any potential performance impact on the system, for example"},{"line_number":112,"context_line":"how often will new code be called, does it perform any intense processing"},{"line_number":113,"context_line":"or data manipulation."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Implementation"},{"line_number":116,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3aaa91ec_f06f8328","line":114,"updated":"2016-06-30 21:04:52.000000000","message":"What about adding here:\n\nResources Impact\n----------------\n\nHost\n++++\n\nDescribe how this change influences the resource usage during the build process on the host system (CPU, RAM, HD space, ...)\n\nTarget\n++++++\n\nDescribe how this change influences the resource usage in the target system - especially the size.","commit_id":"b529d0be496c939a91e4a2e5840db639e25a09d0"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e7a3df3b0df669c975a05ace520c39fdf33ec91c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"should be used as the subject line and body of the commit message"},{"line_number":14,"context_line":"respectively."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Some notes about the diskimabe-bulider spec process:"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Not all changes need a spec. For more information see"},{"line_number":19,"context_line":"  \u003cadd_url_here\u003e"}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_6e282087","line":16,"range":{"start_line":16,"start_character":21,"end_line":16,"end_character":30},"updated":"2016-07-29 20:00:56.000000000","message":"nit: diskimage","commit_id":"76e85b6b600edac2cd1dce97aa239ef558b79e7d"},{"author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"change_message_id":"e7a3df3b0df669c975a05ace520c39fdf33ec91c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"other words, what\u0027s the scope of this effort?"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"At this point, if you would like to just get feedback on if the problem and"},{"line_number":79,"context_line":"proposed change fit in nova, you can stop here and post this for review to get"},{"line_number":80,"context_line":"preliminary feedback. If so please say:"},{"line_number":81,"context_line":"Posting to get preliminary feedback on the scope of this spec."},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bacf61ea_4e543cfe","line":79,"range":{"start_line":79,"start_character":23,"end_line":79,"end_character":27},"updated":"2016-07-29 20:00:56.000000000","message":"oops wrong project","commit_id":"76e85b6b600edac2cd1dce97aa239ef558b79e7d"}]}
