)]}'
{"id":"openstack%2Fdiskimage-builder~336109","triplet_id":"openstack%2Fdiskimage-builder~master~I7bd7e9fa94635621590f72702107e218155fef2a","project":"openstack/diskimage-builder","branch":"master","topic":"336109","hashtags":[],"change_id":"I7bd7e9fa94635621590f72702107e218155fef2a","subject":"Add specs dir","status":"MERGED","created":"2016-06-30 16:29:02.000000000","updated":"2016-09-12 21:44:13.000000000","submitted":"2016-09-12 21:44:13.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":25,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cb50326753f8bea4a0c474e03f7c8b24dd7aab43","_number":336109,"virtual_id_number":336109,"owner":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},{"value":2,"date":"2016-09-12 21:44:13.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"value":0,"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":0,"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},{"value":0,"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"all":[{"value":0,"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"value":2,"date":"2016-08-11 19:09:19.000000000","_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":1,"date":"2016-08-10 23:31:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},{"value":0,"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"all":[{"value":0,"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-12 21:39:22.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"value":0,"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"value":0,"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":0,"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},{"value":0,"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-06-30 21:04:52.000000000","updated_by":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"reviewer":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"state":"REVIEWER"},{"updated":"2016-07-01 06:03:49.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-07-07 06:01:04.000000000","updated_by":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"reviewer":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"state":"REVIEWER"},{"updated":"2016-07-14 17:09:29.000000000","updated_by":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"reviewer":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"state":"REVIEWER"},{"updated":"2016-08-10 23:31:08.000000000","updated_by":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"reviewer":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"state":"REVIEWER"},{"updated":"2016-08-11 19:09:19.000000000","updated_by":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"reviewer":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"state":"REVIEWER"},{"updated":"2016-09-12 21:44:13.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5ccf6ae03ba34c9cbe02ebe2a360e9a030938156","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-30 16:29:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ad2bb5ea84549daed8dba6433a3d7a542c829280","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-30 16:49:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/09/336109/1/check/gate-diskimage-builder-docs/3456ef1//doc/build/html/ : SUCCESS in 2m 27s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/09/336109/1/check/gate-diskimage-builder-pep8/8f7cc0b/ : SUCCESS in 3m 26s","accounts_in_message":[],"_revision_number":1},{"id":"51eebfc269e90688ed18156946244468b7e36775","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-30 17:38:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"753613b4dc6f615898243e98168d33ce3ee8b565","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-06-30 17:41:33.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"88812276a51c742c0efdb24ce5cae74bb58c56ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-30 17:49:54.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/09/336109/3/check/gate-diskimage-builder-docs/0e04f79//doc/build/html/ : SUCCESS in 2m 40s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/09/336109/3/check/gate-diskimage-builder-pep8/b83fe60/ : SUCCESS in 2m 39s","accounts_in_message":[],"_revision_number":3},{"id":"681753f9d679a55c3026a26759c4794c25bb6655","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-06-30 20:21:47.000000000","message":"Patch Set 3: Code-Review+1\n\nOn the one hand, I hate introducing unnecessary overhead when it comes to getting things done, and I\u0027ve seen the spec review process end up waaaaay in the weeds. On the other hand, we currently have a number of changes in flight which affect the core architecture of dib, and dib has taken on a life of its own outside tripleo. We also seem to have a lot of all but the most trivial changes get weighed down under a mix of useful comments and nice-to-haves.\n\nHaving a specs process could foster an idea of a shared direction for the project, which is something I\u0027d like to see. If we\u0027re all reviewing with common goals in mind (for the cycle, or in general) it might become easier for us to iterate more vs trying to get each change perfect prior to landing.\n\nAs I said before, I realize that the specs process itself can be prone to perfectionism and overpolishing, but for larger features it might be a great way to build consensus and have shared goals for the project, leading to better architectural decisions in the long run.","accounts_in_message":[],"_revision_number":3},{"id":"dc274182f60ef18fe54c9b552c30c651ebb5876c","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-06-30 20:24:36.000000000","message":"Patch Set 3:\n\nI\u0027m also going to casually propose that having a semi-regular meeting (or a slot in the tripleo meeting) could be useful in terms of contributors being on the same page.","accounts_in_message":[],"_revision_number":3},{"id":"1bbc6c823421f1a68cb9afa8760d577844850ef2","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-06-30 21:04:52.000000000","message":"Patch Set 3:\n\n(13 comments)\n\n+3 for the idea!\nEspecially that the specs should go with the source code!\n\nAfter reading this, some points are still open for me:\n\n1. What is a \u0027spec\u0027?\nWhen I interpret your documentation correctly, it is the description of one feature?\n    Example: \u0027It must be possible to create a VM image with an encrypted root disk.\u0027\nAs far as I understand you, the complete requirements management process should be documented.\n    Example: \u0027Design Decision: cryptsetup is used to encrypt the disk.\n              Reason: Available, stable, ...\u0027\nAnd from this there might be new requirements coming up:\n    Example: \u0027Req: DIB must support a block-device-post phase.\n              Reason: During this phase the disk encryption is installed.\u0027\nAnd so on and so forth....\n\n2. How do you want to document requirements and design decisions?\nTypically a set of requirements and design decisions is a directed graph. IMHO it is no that easy to write them down in a plain file.  Do you think references (like \u0027is implemented by\u0027) should be done in a standardized way? If so how?\n\n3. How many requirements and design decisions should go into one spec? When to split things? E.g. is is worth to introduce the block-device-post in a separate spec?\n\n4. I do not really like the idea to have the content and process in one file intermixed. The content (requirements) are something that should be there for a long term and describes what DIB can do. It is of no (or very limited) interest to have the authors, version, and historic API changes documented.\n\n5. IMHO there should be a process defined how to deprecate requirements (maybe same process with another directory?).\n\nMaybe my requirements to the requirements process:\no One place where all requirements and design decisions for the current implementation are documented.\no Easy to use references.","accounts_in_message":[],"_revision_number":3},{"id":"fa35df383965e4cb633846a7b8fb4b8db0085079","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-06-30 22:13:54.000000000","message":"Patch Set 3:\n\nAndreas,\n\nYou can find the general OpenStack documentation on the specs process here: https://wiki.openstack.org/wiki/Blueprints and one example of its implementation here: https://wiki.openstack.org/wiki/Ironic/Specs_Process Not saying we should follow either of those literally, but it gives us a frame of reference.","accounts_in_message":[],"_revision_number":3},{"id":"c28a0e96f4b8678f03850fb9ead8aa545f1aaf71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-30 22:24:30.000000000","message":"Patch Set 3:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/09/336109/3/check-tripleo/gate-tripleo-ci-centos-7-nonha/88fab39/ : SUCCESS in 1h 56m 40s","accounts_in_message":[],"_revision_number":3},{"id":"a594995adeeb4d4446f70f08b10d4e2e02b3e8d2","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-07-01 06:03:49.000000000","message":"Patch Set 3: Code-Review+1\n\nI think it\u0027s ok to have something in here like this to keep design documents.\n\nI think if you want to write a spec, that\u0027s great and will help you get your code reviewed because people can see the big picture.  But code is the best spec.\n\nOf course, if you throw a wall of code that touches everything nobody\u0027s going to review it.  but things broken up into digestible parts i feel get good airtime currently.","accounts_in_message":[],"_revision_number":3},{"id":"dc8a03d7c49cff51b171e238236518fc0a85220a","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-07-01 16:10:29.000000000","message":"Patch Set 3:\n\n\u003e I think if you want to write a spec, that\u0027s great and will help you\n \u003e get your code reviewed because people can see the big picture.  But\n \u003e code is the best spec.\n\nI\u0027m going to respectfully disagree with this.\n\n- The way reviews are presented to the reviewer, and the way in which reviews are often done is at a much lower level than \"conceptually, is this moving the project in the right direction?\"\n- Even when reviewing at a high level, reviewers aren\u0027t omniscient and might find it hard to get a sense of where you\u0027re going with the change.\n- Demanding code for broad-reaching changes that might get totally rejected by the community conceptually represents a high barrier of entry.\n- The direction of the project is driven more by first-in-best-dressed than by at least some degree of consensus among the key players.\n\nI don\u0027t think anyone is asking for specs for small changes, bug fixes, etc. What this is about is having a shared view of where the project is going.\n\n\n \u003e \n \u003e Of course, if you throw a wall of code that touches everything\n \u003e nobody\u0027s going to review it.  but things broken up into digestible\n \u003e parts i feel get good airtime currently.","accounts_in_message":[],"_revision_number":3},{"id":"1ccac6adfd4995f03d2d75b5b1632bfee6203d3b","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-03 16:25:04.000000000","message":"Patch Set 3:\n\n(1 comment)\n\nOne of the places our current process breaks down (which I should document in the commit msg) is a non-regular contributor trying to implement a large change. The core reviewers will likely have a lot of feedback in this scenario and the code-first approach means that they are forced to invest a lot of effort only to be asked to rewrite a lot of it (which can be pretty disheartening). The goal here is to just provide a clear and documented way for folks to discuss and get buy in on a change before writing code if they/we choose.\n\n@Andreas - IMO There isn\u0027t a goal for us to create more process around all changes in order to better document our decision process. Not to say that is a bad idea, but I don\u0027t think that is something causing us much of a problem at the moment and so the downsides (extra burden on contributors) outweigh the benefits.\n\nFor some added context: Most of the openstack projects have adopted this in some form and there\u0027s wide variety of implementations depending on the project. Some projects (such as nova) have taken an approach more similar to what you\u0027re describing (make this a process for all but very trivial changes and have blueprints and specs) and other projects only use specs for \u0027epics\u0027 (tripleo/infra seems to operate this way). At a minimum I\u0027d really like to take the approach of \u0027as little process as is necessary\u0027 and start of with something very lightweight. If we like it and want more then we can add on more but I don\u0027t want to kill this idea from the start by over-prescribing process.","accounts_in_message":[],"_revision_number":3},{"id":"3ae5ea6e1573e42969a2df94f78d98ae01aea02e","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-03 16:36:19.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"b6570384b66603c5c1f34f23e26869318e70c086","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-03 16:39:05.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"54404b5713547b61f5d7cd5b93892769420324cf","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-03 19:15:08.000000000","message":"Patch Set 3:\n\nThere was for me a basic misunderstanding of \u0027spec\u0027.  Based on your answers and the example \u0027spec\u0027 my wording here would be \u0027change request\u0027 - but now that this is clear, I\u0027m fine with this.\n++ for the lightweight process and the reasoning behind.\nMaybe you can copy\u0026paste the paragraph from gerrit to the README.rst: IMHO it is good to have the reasons and goal documented?","accounts_in_message":[],"_revision_number":3},{"id":"2a912cfc96dce11a38813caf4803d1f85434ebd8","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-07-06 22:49:22.000000000","message":"Patch Set 3: Code-Review+2\n\nWe are already starting to see some useful specs docs being proposed, so I\u0027m upgrading my vote here.","accounts_in_message":[],"_revision_number":3},{"id":"1c46c115aeb856c2a7ecd837aea407ab3361d529","author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"date":"2016-07-07 06:01:04.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"0eb67c43019485a5ea4de8526553902fc2ff1fad","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-07 07:31:39.000000000","message":"Patch Set 3:\n\nAfter three specs already written, I\u0027m fine with this.\n\nFrom my last comment there is one point that I think is important (and maybe more important here than in other projects): the resource usage on host and target.\nIMHO it should be clear, if and how e.g. the size of the resulting image is influenced by the proposed change.\nBecause creating images is already a lengthy and resource hungry process, also the resources needed on the host need to be documented.\n\nCan you please think about this?\n\n\nAppendix: My reasons\n1. During the implementation of a possible new partitioning [1] I realized, that currently the partitioning is done a little bit randomly.  Implementing things correctly here, means possible adding about 1MiB to the final image size - but possible improve the write speed of the target VM about factor 3.\n2. While evaluating Yolanda\u0027s LVM patch [2] I realized, that the current implementation doubles the hard disk usage.\nIMHO those things are worth mentioning - and if there would be a separate section, authors cannot forget.\n\n[1] https://review.openstack.org/322671\n[2] https://review.openstack.org/252041","accounts_in_message":[],"_revision_number":3},{"id":"a04831732dfab28076ca6a0353f5f4463c97514f","author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"date":"2016-07-14 17:09:29.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)\n\nSeems like there are a few more refinements, like changing \u0027additions\u0027 to something else, that could be done before this lands. Otherwise, great work!","accounts_in_message":[],"_revision_number":3},{"id":"f505d3b2960cf7b830005bc871daee6e74f0573f","author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"date":"2016-07-21 15:58:55.000000000","message":"Patch Set 3: Code-Review+1\n\n(3 comments)\n\nLooks basically fine modulo a few typos (see inline).","accounts_in_message":[],"_revision_number":3},{"id":"b4e1379ec3ec2f9e6c8a1b085a083c72c83171b6","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-28 16:55:28.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4657f9bf4f852fdc9a533a5c08347c9420b52290","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-28 17:01:56.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"42989ce3f0b97439c0fc629492c323be0dac911c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-28 19:52:34.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/09/336109/4/check/gate-diskimage-builder-docs-ubuntu-xenial/dec5426//doc/build/html/ : SUCCESS in 4m 19s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/09/336109/4/check/gate-diskimage-builder-pep8-ubuntu-xenial/f41b544/ : SUCCESS in 4m 00s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/09/336109/4/check/gate-diskimage-builder-python27-ubuntu-xenial/6e90a25/ : SUCCESS in 5m 29s","accounts_in_message":[],"_revision_number":4},{"id":"f2991d88bd6e5a05640a7e2e548c7b78d3132ff3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-28 22:03:06.000000000","message":"Patch Set 4:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/09/336109/4/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/de02978/ : SUCCESS in 2h 02m 03s","accounts_in_message":[],"_revision_number":4},{"id":"aee7816635fce663e0404db06cbda5ef9c97aed6","author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"date":"2016-07-29 15:15:48.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"e7a3df3b0df669c975a05ace520c39fdf33ec91c","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-07-29 20:00:56.000000000","message":"Patch Set 4: Code-Review+1\n\n(2 comments)\n\nCouple of nits in the doc, should be ready to go after that.","accounts_in_message":[],"_revision_number":4},{"id":"8bfa15a15957d83c359493e95040647412c4b7d6","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-08-10 22:05:01.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"b48ae9704a177f28fe7fc7a85e924d191d0e017b","author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"date":"2016-08-10 23:31:08.000000000","message":"Patch Set 5: Code-Review+1","accounts_in_message":[],"_revision_number":5},{"id":"ce11fbf3508345705f085dbb42f867d7fcec89ae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-11 00:43:39.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/09/336109/5/check/gate-diskimage-builder-docs-ubuntu-xenial/a12e559//doc/build/html/ : SUCCESS in 4m 51s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/09/336109/5/check/gate-diskimage-builder-pep8-ubuntu-xenial/26bcf5f/ : SUCCESS in 5m 16s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/09/336109/5/check/gate-diskimage-builder-python27-ubuntu-xenial/3e67844/ : SUCCESS in 2m 19s","accounts_in_message":[],"_revision_number":5},{"id":"7af7f54bf9e58f9aad4bc234a693f7513755abfd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-11 00:54:48.000000000","message":"Patch Set 5:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/09/336109/5/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/52e4523/ : FAILURE in 2h 49m 20s","accounts_in_message":[],"_revision_number":5},{"id":"2391c030fd9d99991587e2d44088e3128bfedaa3","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-08-11 19:09:19.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"21bfab9cccee376da3c8340c1ecc12b5fe88494e","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-09-12 21:39:22.000000000","message":"Patch Set 5: Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"26ab806ad9f439c4490245c68bff3e3414619d07","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 21:39:33.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"6c57421180e7f8f0a3360442f81339a5f028aa79","date":"2016-09-12 21:44:13.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":5},{"id":"beb827a3e58cee10ca5c4f632b8659f959c6bbd5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 21:44:13.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/09/336109/5/gate/gate-diskimage-builder-docs-ubuntu-xenial/1e98be8//doc/build/html/ : SUCCESS in 4m 31s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/09/336109/5/gate/gate-diskimage-builder-pep8-ubuntu-xenial/9f2eee4/ : SUCCESS in 3m 30s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/09/336109/5/gate/gate-diskimage-builder-python27-ubuntu-xenial/e086d9d/ : SUCCESS in 3m 07s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b59ae024312be545c365c3b11912c1faac07337f","revisions":{"d50e5ccc9db48e56e57a937ea1d88686c19ddcf6":{"kind":"REWORK","_number":1,"created":"2016-06-30 16:29:02.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/09/336109/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/09/336109/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/1"}}},"commit":{"parents":[{"commit":"908ca1d079c4a391c8b2d2ede815d6531fdb2793","subject":"Merge \"dmidecode does not exist for ppc64/ppc64el\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/908ca1d079c4a391c8b2d2ede815d6531fdb2793"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 16:27:20.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 16:27:20.000000000","tz":0},"subject":"Add specs dir","message":"Add specs dir\n\nCurrently we do not have a dib-specific specs repository. Technically,\nwe are part of the tripleo-specs repository but dib-core does not imply\ntripleo-specs core. To fix this and to encourage the use of specs lets\ncreate a specs process that lives right in tree.\n\nChange-Id: I7bd7e9fa94635621590f72702107e218155fef2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d50e5ccc9db48e56e57a937ea1d88686c19ddcf6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d50e5ccc9db48e56e57a937ea1d88686c19ddcf6"}]},"branch":"refs/heads/master"},"bb35ecab7dec2775f8fa19e5ff35ae14d6bfdfab":{"kind":"REWORK","_number":2,"created":"2016-06-30 17:38:21.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/09/336109/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/09/336109/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/2"}}},"commit":{"parents":[{"commit":"908ca1d079c4a391c8b2d2ede815d6531fdb2793","subject":"Merge \"dmidecode does not exist for ppc64/ppc64el\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/908ca1d079c4a391c8b2d2ede815d6531fdb2793"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 16:27:20.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 17:38:15.000000000","tz":0},"subject":"Add specs dir","message":"Add specs dir\n\nCurrently we do not have a dib-specific specs repository. Technically,\nwe are part of the tripleo-specs repository but dib-core does not imply\ntripleo-specs core. To fix this and to encourage the use of specs lets\ncreate a specs process that lives right in tree.\n\nChange-Id: I7bd7e9fa94635621590f72702107e218155fef2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/bb35ecab7dec2775f8fa19e5ff35ae14d6bfdfab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/bb35ecab7dec2775f8fa19e5ff35ae14d6bfdfab"}]},"branch":"refs/heads/master"},"b529d0be496c939a91e4a2e5840db639e25a09d0":{"kind":"REWORK","_number":3,"created":"2016-06-30 17:41:33.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/09/336109/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/09/336109/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/3"}}},"commit":{"parents":[{"commit":"908ca1d079c4a391c8b2d2ede815d6531fdb2793","subject":"Merge \"dmidecode does not exist for ppc64/ppc64el\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/908ca1d079c4a391c8b2d2ede815d6531fdb2793"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 16:27:20.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 17:41:27.000000000","tz":0},"subject":"Add specs dir","message":"Add specs dir\n\nCurrently we do not have a dib-specific specs repository. Technically,\nwe are part of the tripleo-specs repository but dib-core does not imply\ntripleo-specs core. To fix this and to encourage the use of specs lets\ncreate a specs process that lives right in tree.\n\nChange-Id: I7bd7e9fa94635621590f72702107e218155fef2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b529d0be496c939a91e4a2e5840db639e25a09d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b529d0be496c939a91e4a2e5840db639e25a09d0"}]},"branch":"refs/heads/master"},"76e85b6b600edac2cd1dce97aa239ef558b79e7d":{"kind":"REWORK","_number":4,"created":"2016-07-28 17:01:56.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/09/336109/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/09/336109/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/4"}}},"commit":{"parents":[{"commit":"908ca1d079c4a391c8b2d2ede815d6531fdb2793","subject":"Merge \"dmidecode does not exist for ppc64/ppc64el\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/908ca1d079c4a391c8b2d2ede815d6531fdb2793"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 16:27:20.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-07-28 17:01:50.000000000","tz":0},"subject":"Add specs dir","message":"Add specs dir\n\nCurrently we do not have a dib-specific specs repository. Technically,\nwe are part of the tripleo-specs repository but dib-core does not imply\ntripleo-specs core. To fix this and to encourage the use of specs lets\ncreate a specs process that lives right in tree.\n\nChange-Id: I7bd7e9fa94635621590f72702107e218155fef2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/76e85b6b600edac2cd1dce97aa239ef558b79e7d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/76e85b6b600edac2cd1dce97aa239ef558b79e7d"}]},"branch":"refs/heads/master"},"b59ae024312be545c365c3b11912c1faac07337f":{"kind":"REWORK","_number":5,"created":"2016-08-10 22:05:01.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/09/336109/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/09/336109/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/09/336109/5"}}},"commit":{"parents":[{"commit":"908ca1d079c4a391c8b2d2ede815d6531fdb2793","subject":"Merge \"dmidecode does not exist for ppc64/ppc64el\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/908ca1d079c4a391c8b2d2ede815d6531fdb2793"}]}],"author":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-06-30 16:27:20.000000000","tz":0},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-08-10 22:05:00.000000000","tz":0},"subject":"Add specs dir","message":"Add specs dir\n\nCurrently we do not have a dib-specific specs repository. Technically,\nwe are part of the tripleo-specs repository but dib-core does not imply\ntripleo-specs core. To fix this and to encourage the use of specs lets\ncreate a specs process that lives right in tree.\n\nChange-Id: I7bd7e9fa94635621590f72702107e218155fef2a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b59ae024312be545c365c3b11912c1faac07337f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/b59ae024312be545c365c3b11912c1faac07337f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}