)]}'
{"id":"openstack%2Fdiskimage-builder~336946","triplet_id":"openstack%2Fdiskimage-builder~master~I0a43e247fb9e258e3983db35362f627416983773","project":"openstack/diskimage-builder","branch":"master","topic":"block-device/refactor/050-block-device-overview-spec","hashtags":[],"change_id":"I0a43e247fb9e258e3983db35362f627416983773","subject":"Spec for changing the block device handling","status":"MERGED","created":"2016-07-03 20:47:46.000000000","updated":"2016-09-12 21:44:20.000000000","submitted":"2016-09-12 21:44:20.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"25cbcb4fc00349d00fdeb1bfdb69e1883e9d5baa","_number":336946,"virtual_id_number":336946,"owner":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":0,"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"value":2,"date":"2016-09-12 21:44:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"all":[{"value":0,"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":2,"date":"2016-08-30 18:13:02.000000000","_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":0,"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-22 16:16:44.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"all":[{"value":0,"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"value":0,"date":"2016-09-01 08:56:28.000000000","_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-12 21:39:35.000000000","_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-30 18:13:02.000000000","updated_by":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"reviewer":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"state":"REVIEWER"},{"updated":"2016-09-01 08:56:28.000000000","updated_by":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"reviewer":{"_account_id":6449,"name":"Chris Jones","email":"cmsj@tenshu.net","username":"cmsj"},"state":"REVIEWER"},{"updated":"2016-09-12 21:39:35.000000000","updated_by":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"reviewer":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"state":"REVIEWER"},{"updated":"2016-09-12 21:44:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a1c1ccdca64cf9a85b335e4ef03336350258e84e","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-03 20:47:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"270ab0b36ad3a17ca320cd238c0e8211e42b569d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-03 20:52:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/46/336946/1/check/gate-diskimage-builder-docs/e2685b3//doc/build/html/ : SUCCESS in 3m 04s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/46/336946/1/check/gate-diskimage-builder-pep8/690a87a/ : SUCCESS in 4m 15s","accounts_in_message":[],"_revision_number":1},{"id":"c465652889f139f627cc1935176d7a91bee69b33","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-03 20:53:21.000000000","message":"Patch Set 1:\n\nParts of this is already discussed and implemented. But because more changes will follow, it make IMHO sense to have this (also) as a formal spec.\nSpecs for the already implemented changes (local loop device and partitioning) will follow.","accounts_in_message":[],"_revision_number":1},{"id":"653a64731fca648898db4d951650a39dc7ea3b01","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-03 22:32:18.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-nonha http://logs.openstack.org/46/336946/1/check-tripleo/gate-tripleo-ci-centos-7-nonha/e9b8b56/ : SUCCESS in 1h 44m 20s","accounts_in_message":[],"_revision_number":1},{"id":"a804f46c5ba8806228b739fc382de2dc7285d428","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-07-05 18:05:24.000000000","message":"Patch Set 1:\n\nWill circle back and review this properly soon, but great to see this!","accounts_in_message":[],"_revision_number":1},{"id":"498c5f1e3f9e4843ac1e9160621294cb69db08e6","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-07-06 22:48:02.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nNice overview! I\u0027m overall on board, just want to clear one thing up.\n\nOne assumption made in the implementation of this spec is that we\u0027re moving further in the direction of using python vs what has traditionally been a fairly bash-heavy project. I\u0027m not opposed per se, but it\u0027s something worth some thought.","accounts_in_message":[],"_revision_number":1},{"id":"3b563cbcf9e9b2d348518c6447c8c9934e15d4dc","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-13 21:19:30.000000000","message":"Patch Set 1:\n\nSomething I am missing (which stephanie hit on in some of the element reviews) is how does this effect the user interface for selecting the block device layout? Right now we use elements as a way to select between making no partitions, making a bootloader partition, etc and then env vars on top of that. I think your patches define a json config that is read in from env var? Can we get some of that documented (vaguely) in the API impact since this is a new interface which is probably worth some discussion.","accounts_in_message":[],"_revision_number":1},{"id":"6932d6a67641f733deef3b7a21b4e7408a76de9d","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-16 06:05:22.000000000","message":"Patch Set 1:\n\n(2 comments)\n\n@Stephanie: Yes - this is a small step using more python and less bash. But IMHO it will stay a mix of both for quiet a while :-)\n\n@Greg: because of the somewhat special case here (implementation was done at a time where there was no spec process), do you think, that the description in the implementation patch [1] is enough or should this be summarized here again?\n\n[1] https://review.openstack.org/#/c/319591/14/doc/source/user_guide/building_an_image.rst","accounts_in_message":[],"_revision_number":1},{"id":"22b2f880b49b6bd374e0f5a9ec45bb29a323ff9b","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2016-07-16 06:05:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5119517c913a40b2d720515fa40a210e96cd566b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-16 06:26:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs http://docs-draft.openstack.org/46/336946/2/check/gate-diskimage-builder-docs/fbb0ab4//doc/build/html/ : SUCCESS in 2m 39s\n- gate-diskimage-builder-pep8 http://logs.openstack.org/46/336946/2/check/gate-diskimage-builder-pep8/a6b9757/ : SUCCESS in 2m 56s","accounts_in_message":[],"_revision_number":2},{"id":"d347ad00292ea5ac3c7b9fb559beacf18c4f59e4","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-25 00:24:53.000000000","message":"Patch Set 2:\n\nandreas - a description in the implementation is totally fine, thanks","accounts_in_message":[],"_revision_number":2},{"id":"e1f98f43c0a434cb0af8a827622305997bb8285a","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-07-28 16:40:18.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM, this needs to either depends-on or wait until the initial spec patch merges","accounts_in_message":[],"_revision_number":2},{"id":"a0eb89371c20b9f755a7705c551c9befb27b81c3","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-08-22 16:16:23.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"5e2379bd9ecf869eff5b7a3498435199d26a2e7c","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-08-22 16:16:44.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"814ca12d624910f6bbfff9b97b5208b5f3c5770a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-22 17:20:15.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/46/336946/3/check/gate-diskimage-builder-docs-ubuntu-xenial/6537c3c//doc/build/html/ : SUCCESS in 2m 22s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/46/336946/3/check/gate-diskimage-builder-pep8-ubuntu-xenial/c525e6a/ : SUCCESS in 2m 36s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/46/336946/3/check/gate-diskimage-builder-python27-ubuntu-xenial/919490f/ : SUCCESS in 2m 17s","accounts_in_message":[],"_revision_number":3},{"id":"affb772a69a923da84ada2fd478872189179184a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-22 18:09:44.000000000","message":"Patch Set 3:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/46/336946/3/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/dee4cb8/ : FAILURE in 1h 35m 40s","accounts_in_message":[],"_revision_number":3},{"id":"1d0e714ba5ed17948172b8681f8fe4df96c9ea54","author":{"_account_id":12459,"name":"Stephanie Miller","email":"stephane@alum.mit.edu","username":"cinerama"},"date":"2016-08-30 18:13:02.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"24a015eb23ce739011cdedec261f86e0e370ad77","author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"date":"2016-09-12 21:39:35.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"c4ec1b77e1a7bcf9f5ceb85f649ea368dace81f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 21:39:46.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"9b60a5553d0765323570a027139a8a1edd1ca46a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-12 21:44:19.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/46/336946/3/gate/gate-diskimage-builder-docs-ubuntu-xenial/dbdd1e5//doc/build/html/ : SUCCESS in 1m 56s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/46/336946/3/gate/gate-diskimage-builder-pep8-ubuntu-xenial/da4225e/ : SUCCESS in 2m 22s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/46/336946/3/gate/gate-diskimage-builder-python27-ubuntu-xenial/a35577b/ : SUCCESS in 2m 06s","accounts_in_message":[],"_revision_number":3},{"id":"4c18c3946dd314177f1fe59bc6db4da1f13095e7","date":"2016-09-12 21:44:20.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6a5da7e157347d2c7bb103eda43e8988c4be655e","revisions":{"f9dd6e6f9bd6ae4c1fc9e867ee06cdc8f58029cb":{"kind":"REWORK","_number":1,"created":"2016-07-03 20:47:46.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/46/336946/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/46/336946/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/1"}}},"commit":{"parents":[{"commit":"097240c226857a72848726017322bda30dfe645c","subject":"Export YUM variable in centos bases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/097240c226857a72848726017322bda30dfe645c"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-07-03 20:38:08.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-07-03 20:46:15.000000000","tz":120},"subject":"Spec for changing the block device handling","message":"Spec for changing the block device handling\n\nDuring the creation of a disk image (e.g. for a VM), there is the need\nto create, setup, configure and afterwards detach some kind of storage\nwhere the newly installed OS can be copied to or directly installed\nin.\n\nChange-Id: I0a43e247fb9e258e3983db35362f627416983773\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/f9dd6e6f9bd6ae4c1fc9e867ee06cdc8f58029cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/f9dd6e6f9bd6ae4c1fc9e867ee06cdc8f58029cb"}]},"branch":"refs/heads/master"},"a68caf800a2a2db405a3cb06064f62846a842083":{"kind":"REWORK","_number":2,"created":"2016-07-16 06:05:54.000000000","uploader":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"ref":"refs/changes/46/336946/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/46/336946/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/2"}}},"commit":{"parents":[{"commit":"097240c226857a72848726017322bda30dfe645c","subject":"Export YUM variable in centos bases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/097240c226857a72848726017322bda30dfe645c"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-07-03 20:38:08.000000000","tz":120},"committer":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-07-16 06:05:30.000000000","tz":120},"subject":"Spec for changing the block device handling","message":"Spec for changing the block device handling\n\nDuring the creation of a disk image (e.g. for a VM), there is the need\nto create, setup, configure and afterwards detach some kind of storage\nwhere the newly installed OS can be copied to or directly installed\nin.\n\nChange-Id: I0a43e247fb9e258e3983db35362f627416983773\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a68caf800a2a2db405a3cb06064f62846a842083"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/a68caf800a2a2db405a3cb06064f62846a842083"}]},"branch":"refs/heads/master"},"6a5da7e157347d2c7bb103eda43e8988c4be655e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-08-22 16:16:23.000000000","uploader":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"ref":"refs/changes/46/336946/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/46/336946/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/46/336946/3"}}},"commit":{"parents":[{"commit":"097240c226857a72848726017322bda30dfe645c","subject":"Export YUM variable in centos bases","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/097240c226857a72848726017322bda30dfe645c"}]}],"author":{"name":"Andreas Florath","email":"andreas@florath.net","date":"2016-07-03 20:38:08.000000000","tz":120},"committer":{"name":"Gregory Haynes","email":"greg@greghaynes.net","date":"2016-08-22 16:16:00.000000000","tz":0},"subject":"Spec for changing the block device handling","message":"Spec for changing the block device handling\n\nDuring the creation of a disk image (e.g. for a VM), there is the need\nto create, setup, configure and afterwards detach some kind of storage\nwhere the newly installed OS can be copied to or directly installed\nin.\n\nChange-Id: I0a43e247fb9e258e3983db35362f627416983773\nDepends-On: I7bd7e9fa94635621590f72702107e218155fef2a\nSigned-off-by: Andreas Florath \u003candreas@florath.net\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6a5da7e157347d2c7bb103eda43e8988c4be655e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/6a5da7e157347d2c7bb103eda43e8988c4be655e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}