)]}'
{"elements/source-repositories/README.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"294572c1c9f6f97818d7de8647c7fa64133c8497","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"``location``"},{"line_number":25,"context_line":"  Resource to fetch sources from. For ``zuul`` or ``git`` the location is"},{"line_number":26,"context_line":"  cloned. For ``tar`` it is extracted."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"``ref`` (optional). Meaning depends on the ``type``:"},{"line_number":29,"context_line":"  ``file``: unused/ignored."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_8246644d","line":26,"updated":"2016-09-01 04:56:33.000000000","message":"\"zuul\" needs way more explanation for someone not familiar with what zuul even is","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"0de91c3345c703c236bba6b9b82e0203c3d16995","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"``location``"},{"line_number":25,"context_line":"  Resource to fetch sources from. For ``zuul`` or ``git`` the location is"},{"line_number":26,"context_line":"  cloned. For ``tar`` it is extracted."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"``ref`` (optional). Meaning depends on the ``type``:"},{"line_number":29,"context_line":"  ``file``: unused/ignored."}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa7ab95a_f6cc4163","line":26,"in_reply_to":"fa7ab95a_8246644d","updated":"2016-09-01 11:52:44.000000000","message":"Agreed, will update.","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"}],"elements/source-repositories/extra-data.d/98-source-repositories":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"294572c1c9f6f97818d7de8647c7fa64133c8497","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            REPOTYPE\u003d${!REPOTYPE_OVERRIDE:-$REPOTYPE}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            if [ \"${SOURCE_REPOSITORIES_USE_ZUUL_FOR_GIT:-\"0\"}\" \u003d\u003d \"1\" ] \u0026\u0026 [ \"${REPOTYPE}\" \u003d\u003d \"git\" ]; then"},{"line_number":84,"context_line":"                echo \"Using zuul provider instead of git, as requested.\""},{"line_number":85,"context_line":"                REPOTYPE\u003d\"zuul\""},{"line_number":86,"context_line":"            fi"},{"line_number":87,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa7ab95a_2213d85d","line":84,"updated":"2016-09-01 04:56:33.000000000","message":"Presumably, you want to turn this on in the gate to get generic Depends-On: without having to change all the repo references?  This needs a big documentation addition\n\nLet\u0027s not pollute the output with this every time especially if it\u0027s in infra builds.  maybe something like showing the url as zuul+git:// or something similar would reduce the output","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"0de91c3345c703c236bba6b9b82e0203c3d16995","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            REPOTYPE\u003d${!REPOTYPE_OVERRIDE:-$REPOTYPE}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            if [ \"${SOURCE_REPOSITORIES_USE_ZUUL_FOR_GIT:-\"0\"}\" \u003d\u003d \"1\" ] \u0026\u0026 [ \"${REPOTYPE}\" \u003d\u003d \"git\" ]; then"},{"line_number":84,"context_line":"                echo \"Using zuul provider instead of git, as requested.\""},{"line_number":85,"context_line":"                REPOTYPE\u003d\"zuul\""},{"line_number":86,"context_line":"            fi"},{"line_number":87,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa7ab95a_96d135d0","line":84,"in_reply_to":"fa7ab95a_2213d85d","updated":"2016-09-01 11:52:44.000000000","message":"Yes that\u0027s the idea, using this in the gate. That was going to be done via run_functests\u0027s -z flag. This way, not everyone needed to have zuul-cloner installed to be able to run the tests.","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"294572c1c9f6f97818d7de8647c7fa64133c8497","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                if [ ! -e ${ZUUL_CLONER} ]; then"},{"line_number":116,"context_line":"                    echo \"Error: zuul-cloner does not exist at ${ZUUL_CLONER}\""},{"line_number":117,"context_line":"                    exit 1"},{"line_number":118,"context_line":"                fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"                ZUUL_GIT_BASE_URL\u003d${ZUUL_GIT_BASE_URL:-\"$(echo ${REPOLOCATION} | cut -d\u0027/\u0027 -f1-3)\"}"},{"line_number":121,"context_line":"                ZUUL_GIT_PROJECT\u003d${ZUUL_GIT_PROJECT:-\"$(echo ${REPOLOCATION} | cut -d\u0027/\u0027 -f4-)\"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa7ab95a_e21f3059","line":118,"updated":"2016-09-01 04:56:33.000000000","message":"This path is wrong ... it probably only works on infra hosts where zuul-env is setup as the virtualenv.\n\nI think our only choice here is to include zuul in the requirements.txt file so that zuul-cloner is available in the path from our own virtualenv","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"0de91c3345c703c236bba6b9b82e0203c3d16995","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                if [ ! -e ${ZUUL_CLONER} ]; then"},{"line_number":116,"context_line":"                    echo \"Error: zuul-cloner does not exist at ${ZUUL_CLONER}\""},{"line_number":117,"context_line":"                    exit 1"},{"line_number":118,"context_line":"                fi"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"                ZUUL_GIT_BASE_URL\u003d${ZUUL_GIT_BASE_URL:-\"$(echo ${REPOLOCATION} | cut -d\u0027/\u0027 -f1-3)\"}"},{"line_number":121,"context_line":"                ZUUL_GIT_PROJECT\u003d${ZUUL_GIT_PROJECT:-\"$(echo ${REPOLOCATION} | cut -d\u0027/\u0027 -f4-)\"}"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa7ab95a_96e8557e","line":118,"in_reply_to":"fa7ab95a_e21f3059","updated":"2016-09-01 11:52:44.000000000","message":"That\u0027s a good idea.","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"294572c1c9f6f97818d7de8647c7fa64133c8497","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                ZUUL_GIT_PROJECT\u003d${ZUUL_GIT_PROJECT:-\"$(echo ${REPOLOCATION} | cut -d\u0027/\u0027 -f4-)\"}"},{"line_number":122,"context_line":"                # NOTE(mmitchell): Zuul handles caching on it\u0027s own, so simply invoke it."},{"line_number":123,"context_line":"                echo \"Derived ZUUL_GIT_BASE_URL: ${ZUUL_GIT_BASE_URL}\""},{"line_number":124,"context_line":"                echo \"Derived ZUUL_GIT_PROJECT: ${ZUUL_GIT_PROJECT}\""},{"line_number":125,"context_line":"                ${ZUUL_CLONER} --workspace /tmp --cache-dir ${ZUUL_CACHE_DIR:-\"/opt/git\"} \\"},{"line_number":126,"context_line":"                    ${ZUUL_GIT_BASE_URL} ${ZUUL_GIT_PROJECT}"},{"line_number":127,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa7ab95a_223af8cd","line":124,"updated":"2016-09-01 04:56:33.000000000","message":"again let\u0027s keep output minimal, the url thing would work here i think","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"0de91c3345c703c236bba6b9b82e0203c3d16995","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                ZUUL_GIT_PROJECT\u003d${ZUUL_GIT_PROJECT:-\"$(echo ${REPOLOCATION} | cut -d\u0027/\u0027 -f4-)\"}"},{"line_number":122,"context_line":"                # NOTE(mmitchell): Zuul handles caching on it\u0027s own, so simply invoke it."},{"line_number":123,"context_line":"                echo \"Derived ZUUL_GIT_BASE_URL: ${ZUUL_GIT_BASE_URL}\""},{"line_number":124,"context_line":"                echo \"Derived ZUUL_GIT_PROJECT: ${ZUUL_GIT_PROJECT}\""},{"line_number":125,"context_line":"                ${ZUUL_CLONER} --workspace /tmp --cache-dir ${ZUUL_CACHE_DIR:-\"/opt/git\"} \\"},{"line_number":126,"context_line":"                    ${ZUUL_GIT_BASE_URL} ${ZUUL_GIT_PROJECT}"},{"line_number":127,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa7ab95a_16fd253a","line":124,"in_reply_to":"fa7ab95a_223af8cd","updated":"2016-09-01 11:52:44.000000000","message":"Agreed.","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"}],"tests/run_functests.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"294572c1c9f6f97818d7de8647c7fa64133c8497","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            echo"},{"line_number":133,"context_line":"            exit 0"},{"line_number":134,"context_line":"            ;;"},{"line_number":135,"context_line":"        z)"},{"line_number":136,"context_line":"            echo \"Using zuul-cloner for git source-repositories.\""},{"line_number":137,"context_line":"            USE_ZUUL_CLONER\u003d1"},{"line_number":138,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa7ab95a_626240da","line":135,"updated":"2016-09-01 04:56:33.000000000","message":"I\u0027d really prefer to not see this as a separate flag.  The idea is someone running ./run_functests.sh runs all the tests -- not that they have to run them twice (once with and once without -z) to get coverage.\n\ni think just one of the source-repositories files using zuul would be test enough?","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"0de91c3345c703c236bba6b9b82e0203c3d16995","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            echo"},{"line_number":133,"context_line":"            exit 0"},{"line_number":134,"context_line":"            ;;"},{"line_number":135,"context_line":"        z)"},{"line_number":136,"context_line":"            echo \"Using zuul-cloner for git source-repositories.\""},{"line_number":137,"context_line":"            USE_ZUUL_CLONER\u003d1"},{"line_number":138,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa7ab95a_7666712a","line":135,"in_reply_to":"fa7ab95a_626240da","updated":"2016-09-01 11:52:44.000000000","message":"The idea was with that flag, any project that is currently declared as a git dependency would benefit from that feature. That currently means ironic-agent and glean.","commit_id":"6c0b2e0de63415dab2fac2b944479d4368b10f7b"}]}