)]}'
{"elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"189c789670fa4c9473afa8c03e7b8ab8844ce458","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Configure grub. Note that the various conditionals here are to handle"},{"line_number":4,"context_line":"# different distributions gracefully."},{"line_number":5,"context_line":"# 2016-09-22: Architecture support for s390x"},{"line_number":6,"context_line":"#   IBM Corp., Holger Smolinski, \u003csmolinski@de.ibm.com\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"if [ ${DIB_DEBUG_TRACE:-1} -gt 0 ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa6399be_a2f5ed57","line":5,"updated":"2016-10-13 16:45:46.000000000","message":"Please don\u0027t do this.  The git history is sufficient for tracking who made what changes when.","commit_id":"18800f97ecf53697d13fa185c667874cb98ab0e3"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"189c789670fa4c9473afa8c03e7b8ab8844ce458","unresolved":false,"context_lines":[{"line_number":16,"context_line":"PART_DEV\u003d$IMAGE_BLOCK_DEVICE"},{"line_number":17,"context_line":"if [ \"$ARCH\" \u003d\u003d \"s390x\" ]; then"},{"line_number":18,"context_line":"    if [[ \"$IMAGE_BLOCKDEVICE\" \u003d~ \"loop\" ]]; then"},{"line_number":19,"context_line":"      BOOT_DEV\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -e\"s#\\(loop[0-9]\\+\\)\\(p[1-9]\\)$#\\1#\" )"},{"line_number":20,"context_line":"        if [ \"${BOOT_DEV}\" !\u003d \"${IMAGE_BLOCK_DEVICE}\" ]; then"},{"line_number":21,"context_line":"            PART_NO\u003d$(echo $IMAGE_BLOCK_DEVICE | sed -er\"#${BOOT_DEV}p\\([1-9]\\+\\)$#\\1#\")"},{"line_number":22,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fa6399be_e2d445be","line":19,"updated":"2016-10-13 16:45:46.000000000","message":"Nit: This indentation is still wrong.","commit_id":"18800f97ecf53697d13fa185c667874cb98ab0e3"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"518f03576a0c0e9dbade2bfadd251c3de8dfaf08","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    if [ \"$ARCH\" !\u003d \"s390x\" ]; then"},{"line_number":80,"context_line":"        die \"Unsupported Platform for zipl\""},{"line_number":81,"context_line":"    fi"},{"line_number":82,"context_line":"    install-packages s390-tools parted"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if [ -f /etc/zipl.conf ]; then"},{"line_number":85,"context_line":"        cat /etc/zipl.conf"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ba5da102_b03bac9b","line":82,"updated":"2016-10-31 13:50:43.000000000","message":"Can you do this with package-installs (see http://docs.openstack.org/developer/diskimage-builder/elements/package-installs/README.html)? You should be able to specify arch there and then use pkg-map to disable it for non-ubuntu distros.","commit_id":"8eeb55eefdf7ef0032f0c38e7726cfdc610f8b97"}],"elements/bootloader/package-installs.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1e7f4b3a171946cbe2b4112f5915445352e217c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"parted:"},{"line_number":2,"context_line":"  arch:"},{"line_number":3,"context_line":"    - s390x"},{"line_number":4,"context_line":"s390-tools:"},{"line_number":5,"context_line":"  arch:"},{"line_number":6,"context_line":"    - s390x"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_cd467b4e","line":3,"updated":"2016-11-17 23:20:35.000000000","message":"hmm, this is not supposed to be a sub-list, it\u0027s supposed to be a comma separated list e.g.\n\n parted:\n   arch: s390x\n\nthe question is does this work just to yaml trickery, or are we just interpreting arch: as a blank list with this format?","commit_id":"58f67dff6bed76aeb88747b343ca05e7f27c41c0"}],"elements/bootloader/pkg-map":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"f5d1c1c3c02418f8ad816743c4d8ecfb9b185675","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    },"},{"line_number":16,"context_line":"    \"debian\": {"},{"line_number":17,"context_line":"      \"parted\": \"parted\","},{"line_number":18,"context_line":"      \"s390-tools\", \"s390-tools\""},{"line_number":19,"context_line":"    }"},{"line_number":20,"context_line":"  },"},{"line_number":21,"context_line":"  \"default\": {"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3a71b18c_8b212cfe","line":18,"updated":"2016-12-02 15:43:12.000000000","message":"This needs to have a \u0027:\u0027 instead if \u0027,\u0027","commit_id":"b12bf8bdd37907d44680779cb17c4e419a223392"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"cd0a4bc9aea41cfce5298d44b190e1788cf2fb1b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"dkms_package\": \"dkms\","},{"line_number":23,"context_line":"    \"extlinux\": \"extlinux\","},{"line_number":24,"context_line":"    \"grub-pc\": \"grub-pc\","},{"line_number":25,"context_line":"    \"parted\": \"\","},{"line_number":26,"context_line":"    \"s390-tools\": \"\""},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a3c09a3_2e09eadd","line":25,"updated":"2017-01-16 17:55:40.000000000","message":"I think its better to fail due to a missing package (which gives a nice error message) rather than to silently not install these packages on other distros. IOW lets not make any changes to this file.","commit_id":"8b11275169d95c9fbea70b170d4b6b7925bd503d"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"aa3cc76da9e6faf0896349c2dcd86084a1cc5455","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"dkms_package\": \"dkms\","},{"line_number":23,"context_line":"    \"extlinux\": \"extlinux\","},{"line_number":24,"context_line":"    \"grub-pc\": \"grub-pc\","},{"line_number":25,"context_line":"    \"parted\": \"\","},{"line_number":26,"context_line":"    \"s390-tools\": \"\""},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"fa31d9ce_c7531438","line":25,"in_reply_to":"3a461143_419eabb9","updated":"2017-02-17 17:33:32.000000000","message":"By default a mapping of \"x\": \"x\" is assumed, so you should be able to make no changes in this file and it should \u0027just work\u0027.","commit_id":"8b11275169d95c9fbea70b170d4b6b7925bd503d"},{"author":{"_account_id":23745,"name":"Holger Smolinski","email":"holger@smolinski.name","username":"holgersmo"},"change_message_id":"28ea14d3c13fb8ae00f85c90f918d59a31a42b13","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    \"dkms_package\": \"dkms\","},{"line_number":23,"context_line":"    \"extlinux\": \"extlinux\","},{"line_number":24,"context_line":"    \"grub-pc\": \"grub-pc\","},{"line_number":25,"context_line":"    \"parted\": \"\","},{"line_number":26,"context_line":"    \"s390-tools\": \"\""},{"line_number":27,"context_line":"  }"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3a461143_419eabb9","line":25,"in_reply_to":"7a3c09a3_2e09eadd","updated":"2017-02-02 10:11:37.000000000","message":"YOU took ages to comment??? I did. Sorry for my oversight. What do you propose? Just leave the parted and s390-tools out of the default section? I think, I did that before, but then one of the verification tests failed - if I remember correctly because there was no default entry for these pkgs. Definitely we have to add the s390-tools and parted to the debian section for s390x.","commit_id":"8b11275169d95c9fbea70b170d4b6b7925bd503d"}]}