)]}'
{"elements/dhcp-all-interfaces/install.d/dhcp-all-interfaces.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f512b4d5316bbfd48a095ae66087605f3c431c15","unresolved":false,"context_lines":[{"line_number":16,"context_line":"elif [ -d \"/etc/sysconfig/network-scripts/\" ]; then"},{"line_number":17,"context_line":"    CONF_TYPE\u003d\"netscripts\""},{"line_number":18,"context_line":"    SCRIPTS_PATH\u003d\"/etc/sysconfig/network-scripts/\""},{"line_number":19,"context_line":"elif [ -d \"/etc/sysconfig/network/\" ]; then"},{"line_number":20,"context_line":"    CONF_TYPE\u003d\"netscripts\""},{"line_number":21,"context_line":"    SCRIPTS_PATH\u003d\"/etc/sysconfig/network/\""},{"line_number":22,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba5da102_77865c66","line":19,"updated":"2016-10-31 23:44:07.000000000","message":"something about this path isn\u0027t adding up for me ... i thought ubuntu was \"/etc/network/interfaces.d/\" ; that\u0027s at least what simple-init is clearing out for glean [1]?  trusty images i have don\u0027t have /etc/sysconfig?\n\nmaybe there is something going on here i\u0027m missing...?\n\n[1] https://git.openstack.org/cgit/openstack/diskimage-builder/tree/elements/simple-init/install.d/60-simple-init-remove-interfaces","commit_id":"d86c32b48676d2e2ac30430790948e4441e64f22"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"4dac9a47495d2946e4cfdfac806b0825e5840d2e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if [ \"$CONF_TYPE\" \u003d\u003d \"eni\" ]; then"},{"line_number":49,"context_line":"        printf \"auto $interface\\niface $interface inet dhcp\\n\\n\" \u003e\u003e$ENI_FILE"},{"line_number":50,"context_line":"    elif [ \"$CONF_TYPE\" \u003d\u003d \"netscripts\" ]; then"},{"line_number":51,"context_line":"        printf \"DEVICE\u003d\\\"$interface\\\"\\nBOOTPROTO\u003d\\\"dhcp\\\"\\nONBOOT\u003d\\\"yes\\\"\\nTYPE\u003d\\\"Ethernet\\\"\" \u003e\"${SCRIPTS_PATH}ifcfg-$interface\""},{"line_number":52,"context_line":"    fi"},{"line_number":53,"context_line":"    echo \"Configured $1\""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba5da102_4ee1becf","line":51,"updated":"2016-11-01 09:21:50.000000000","message":"SUSE\u0027s ifcfg format does not understand \"DEVICE\" or \"ONBOOT\" or \"TYPE\". It will not crash or anything and it will use DHCP because of the BOOTPROTO option. Please see \u0027man ifcfg\u0027. A valid SUSE configuration would be\n\nBOOTPROTO\u003ddhcp\nSTARTMODE\u003dauto\n\nI understand it\u0027s easier to mirror the RedHat configuration so you don\u0027t make a lot of code changes but in this case it\u0027s simple enough to distinguish the two cases (perhaps based on the SCRIPTS_PATH variable) and produce a valid SUSE configuration so I will give this a -1.","commit_id":"df691d03a5293d684ea2374137cff026bfa7f658"},{"author":{"_account_id":16690,"name":"Noam Angel","email":"noama@nvidia.com","username":"noama"},"change_message_id":"19719e362dc4e4b1098973535c0cad33c5466772","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    if [ \"$CONF_TYPE\" \u003d\u003d \"eni\" ]; then"},{"line_number":49,"context_line":"        printf \"auto $interface\\niface $interface inet dhcp\\n\\n\" \u003e\u003e$ENI_FILE"},{"line_number":50,"context_line":"    elif [ \"$CONF_TYPE\" \u003d\u003d \"netscripts\" ]; then"},{"line_number":51,"context_line":"        printf \"DEVICE\u003d\\\"$interface\\\"\\nBOOTPROTO\u003d\\\"dhcp\\\"\\nONBOOT\u003d\\\"yes\\\"\\nTYPE\u003d\\\"Ethernet\\\"\" \u003e\"${SCRIPTS_PATH}ifcfg-$interface\""},{"line_number":52,"context_line":"    fi"},{"line_number":53,"context_line":"    echo \"Configured $1\""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"ba5da102_24890927","line":51,"in_reply_to":"ba5da102_4ee1becf","updated":"2016-11-01 10:17:39.000000000","message":"Done","commit_id":"df691d03a5293d684ea2374137cff026bfa7f658"}]}