)]}'
{"diskimage_builder/elements/ibft-interfaces/README.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"381ae62c453fb45ea650bcbe5476630b94abde12","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Initialize network interfaces with information provided through iBFT."},{"line_number":6,"context_line":"Requires the ``iscsistart`` utility to be available."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. warning:: Only implemented for systemd-based systems."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_ce0f7d2a","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":52},"updated":"2018-11-19 02:26:25.000000000","message":"Usually we keep elements self-contained ... although the iscsi stuff being in the base images is a bit of weird corner case I guess, as it\u0027s been there for a long time, but is really probably not supposed to be there.\n\ni\u0027d probably prefer it if this had a correct package-installs setup for the tools, so that if we ever try to remove the iscsi bits from base images this wouldn\u0027t break...","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"964f7468fb365a18618ed91d3c78d851e7c036be","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Initialize network interfaces with information provided through iBFT."},{"line_number":6,"context_line":"Requires the ``iscsistart`` utility to be available."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. warning:: Only implemented for systemd-based systems."}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_3d9dec6a","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":52},"in_reply_to":"3f79a3b5_ce0f7d2a","updated":"2018-11-20 10:21:16.000000000","message":"Done","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"}],"diskimage_builder/elements/ibft-interfaces/post-install.d/70-init-ibft-interfaces":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"381ae62c453fb45ea650bcbe5476630b94abde12","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        systemctl enable init-ibft-interfaces.service"},{"line_number":12,"context_line":"        ;;"},{"line_number":13,"context_line":"    *)"},{"line_number":14,"context_line":"        echo \"WARNING: ibft-interfaces element only supports systemd\""},{"line_number":15,"context_line":"        ;;"},{"line_number":16,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_2e015104","line":14,"updated":"2018-11-19 02:26:25.000000000","message":"I would prefer to see this exit -1 at this point; although I\u0027m aware we don\u0027t have a good way currently of saying \"this element only works on platform X, otherwise skip\" ... it is something we\u0027ve wanted before ... but in this case anyway I think an error exit is appropriate.","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"964f7468fb365a18618ed91d3c78d851e7c036be","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        systemctl enable init-ibft-interfaces.service"},{"line_number":12,"context_line":"        ;;"},{"line_number":13,"context_line":"    *)"},{"line_number":14,"context_line":"        echo \"WARNING: ibft-interfaces element only supports systemd\""},{"line_number":15,"context_line":"        ;;"},{"line_number":16,"context_line":"esac"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"3f79a3b5_9d768040","line":14,"in_reply_to":"3f79a3b5_2e015104","updated":"2018-11-20 10:21:16.000000000","message":"I\u0027d prefer not to do that. In this case we cannot really depend on this element anywhere where systemd support is optional, like in the ironic-agent element. I\u0027d prefer to treat this as TODO for somebody to come and implement. But let me see if I can come up with something for other systems.","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"}],"diskimage_builder/elements/ibft-interfaces/static/usr/local/sbin/init-ibft-interfaces.sh":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"cc3ff4363c25cb775250bb948688b003e5ce1b49","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    exit 1"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"modprobe -b iscsi_boot_sysfs || echo \"cannot modprobe iscsi_boot_sysfs\""},{"line_number":15,"context_line":"modprobe -b iscsi_ibft || echo \"cannot modprobe iscsi_ibft\""},{"line_number":16,"context_line":"modprobe -b iscsi_tcp || echo \"cannot modprobe iscsi_tcp\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f79a3b5_0d601ecf","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":8},"updated":"2018-09-26 14:31:29.000000000","message":"we have a modprobe element. It allows to create a folder modprobe.d and then you can enable/disable modules on demand. Why not depend on that, instead of doing the modprobe on the script?","commit_id":"135bbbfadb6ee391d079da318841e0ea5d1b3dbf"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"2c1bbbb6d482e1b619285a7f235ba8ea0eae47b7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    exit 1"},{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"modprobe -b iscsi_boot_sysfs || echo \"cannot modprobe iscsi_boot_sysfs\""},{"line_number":15,"context_line":"modprobe -b iscsi_ibft || echo \"cannot modprobe iscsi_ibft\""},{"line_number":16,"context_line":"modprobe -b iscsi_tcp || echo \"cannot modprobe iscsi_tcp\""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f79a3b5_48e36407","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":8},"in_reply_to":"3f79a3b5_0d601ecf","updated":"2018-09-26 15:11:26.000000000","message":"maybe I miss something, but I don\u0027t see how to insert a module via modprobe.d, only how to blacklist modules or change their parameters. could you paste an example file?","commit_id":"135bbbfadb6ee391d079da318841e0ea5d1b3dbf"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"381ae62c453fb45ea650bcbe5476630b94abde12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3f79a3b5_68018008","line":3,"updated":"2018-11-19 02:26:25.000000000","message":"You should remove this to avoid confusion; this is not a script executed by dib but a shell script executed by systemd; it\u0027s probably appropriate to just set \"-x\" always for debugging","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"964f7468fb365a18618ed91d3c78d851e7c036be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":4,"context_line":"    set -x"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"set -eu"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3f79a3b5_7db924c3","line":3,"in_reply_to":"3f79a3b5_68018008","updated":"2018-11-20 10:21:16.000000000","message":"Done","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"381ae62c453fb45ea650bcbe5476630b94abde12","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if iscsistart -f; then"},{"line_number":16,"context_line":"    iscsistart -N || echo \"cannot configure iBFT devices\""},{"line_number":17,"context_line":"    # Make sure the events for new devices are processed"},{"line_number":18,"context_line":"    udevadm settle"},{"line_number":19,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3f79a3b5_6ef7492a","line":16,"updated":"2018-11-19 02:26:25.000000000","message":"should this actually then exit with a failure?","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"964f7468fb365a18618ed91d3c78d851e7c036be","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if iscsistart -f; then"},{"line_number":16,"context_line":"    iscsistart -N || echo \"cannot configure iBFT devices\""},{"line_number":17,"context_line":"    # Make sure the events for new devices are processed"},{"line_number":18,"context_line":"    udevadm settle"},{"line_number":19,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":11,"id":"3f79a3b5_1dd6f0f9","line":16,"in_reply_to":"3f79a3b5_6ef7492a","updated":"2018-11-20 10:21:16.000000000","message":"Done","commit_id":"9f39a7bf9386d6ac832a9b39448c77fbc3d338cb"}],"elements/dhcp-all-interfaces/install.d/dhcp-all-interfaces.sh":[{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"25cff832939c568540b41be493b3407528082985","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    if iscsistart -f; then"},{"line_number":36,"context_line":"        iscsistart -N || echo \"cannot configure iBFT devices\""},{"line_number":37,"context_line":"        sleep 5"},{"line_number":38,"context_line":"    fi"},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a71b18c_328efc78","line":37,"updated":"2016-12-01 18:49:43.000000000","message":"Can we get a comment for why we need this sleep?","commit_id":"c801ec5714205d711fefa9335fab8be9e9bab27d"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d109c478804ddfc1de90e9722eb5633618bc7f3a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    if iscsistart -f; then"},{"line_number":36,"context_line":"        iscsistart -N || echo \"cannot configure iBFT devices\""},{"line_number":37,"context_line":"        # Give the devices some time to show up and get picked"},{"line_number":38,"context_line":"        sleep 5"},{"line_number":39,"context_line":"        # Make sure the events for new devices are processed"},{"line_number":40,"context_line":"        udevadm settle"},{"line_number":41,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_391070a8","line":38,"updated":"2016-12-14 06:26:06.000000000","message":"is this not done for every interface that comes up?  doing a modprobe and waiting 5 seconds really does not seem to be the type of thing you want to do for all interfaces?  it\u0027s the type of thing that comes back to bite when someone says \"i\u0027ve got 10 interfaces and boot was delayed by a minute...\"","commit_id":"eae4534063dfd90775c2f31a531570f4c2dca61a"}]}