)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"17e0d4bfe721ab9518f6b54fe19e136165ad9f0a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"redhat-common add option to select networking service NetworkManager/network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On rhel distro (fedora/rhel/centos) there is 2 networking services."},{"line_number":10,"context_line":"This patch adds an option to select which of the 2 option to disalbe and"},{"line_number":11,"context_line":"the secondary will be disabled. In some case both networking manager is"},{"line_number":12,"context_line":"enabled and it cuase issues, Also some user probably want to use the new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_0e2f1ba2","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":44},"updated":"2016-11-05 12:38:22.000000000","message":"Nit - s/is/are/","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"17e0d4bfe721ab9518f6b54fe19e136165ad9f0a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"redhat-common add option to select networking service NetworkManager/network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On rhel distro (fedora/rhel/centos) there is 2 networking services."},{"line_number":10,"context_line":"This patch adds an option to select which of the 2 option to disalbe and"},{"line_number":11,"context_line":"the secondary will be disabled. In some case both networking manager is"},{"line_number":12,"context_line":"enabled and it cuase issues, Also some user probably want to use the new"},{"line_number":13,"context_line":"service \"NetworkingManager\". in param \"DIB_NETWORK_MANAGER\" case specified"},{"line_number":14,"context_line":"one of the neworking service will be enabled and the secondary will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_ae162f53","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":31},"updated":"2016-11-05 12:38:22.000000000","message":"Perhaps -  \"This patch adds an option to select which networking service to enable, the one not selected will be disabled.\"","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"db9ba56016e46aab9359294a88bcb2515c9a5217","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On rhel distro (fedora/rhel/centos) there is 2 networking services."},{"line_number":10,"context_line":"This patch adds an option to select which of the 2 option to disalbe and"},{"line_number":11,"context_line":"the secondary will be disabled. In some case both networking manager is"},{"line_number":12,"context_line":"enabled and it cuase issues, Also some user probably want to use the new"},{"line_number":13,"context_line":"service \"NetworkingManager\". in param \"DIB_NETWORK_MANAGER\" case specified"},{"line_number":14,"context_line":"one of the neworking service will be enabled and the secondary will be"},{"line_number":15,"context_line":"disabled, in case user did not specify this param none of this code will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_5671afdf","line":12,"range":{"start_line":11,"start_character":32,"end_line":12,"end_character":27},"updated":"2016-11-04 20:50:51.000000000","message":"Links to bug reports, please.","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"17e0d4bfe721ab9518f6b54fe19e136165ad9f0a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"On rhel distro (fedora/rhel/centos) there is 2 networking services."},{"line_number":10,"context_line":"This patch adds an option to select which of the 2 option to disalbe and"},{"line_number":11,"context_line":"the secondary will be disabled. In some case both networking manager is"},{"line_number":12,"context_line":"enabled and it cuase issues, Also some user probably want to use the new"},{"line_number":13,"context_line":"service \"NetworkingManager\". in param \"DIB_NETWORK_MANAGER\" case specified"},{"line_number":14,"context_line":"one of the neworking service will be enabled and the secondary will be"},{"line_number":15,"context_line":"disabled, in case user did not specify this param none of this code will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_2e03ff10","line":12,"range":{"start_line":12,"start_character":15,"end_line":12,"end_character":20},"updated":"2016-11-05 12:38:22.000000000","message":"Typo - cause","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"17e0d4bfe721ab9518f6b54fe19e136165ad9f0a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch adds an option to select which of the 2 option to disalbe and"},{"line_number":11,"context_line":"the secondary will be disabled. In some case both networking manager is"},{"line_number":12,"context_line":"enabled and it cuase issues, Also some user probably want to use the new"},{"line_number":13,"context_line":"service \"NetworkingManager\". in param \"DIB_NETWORK_MANAGER\" case specified"},{"line_number":14,"context_line":"one of the neworking service will be enabled and the secondary will be"},{"line_number":15,"context_line":"disabled, in case user did not specify this param none of this code will"},{"line_number":16,"context_line":"run."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_ce0b632a","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":27},"updated":"2016-11-05 12:38:22.000000000","message":"\"NetworkManager\"","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"17e0d4bfe721ab9518f6b54fe19e136165ad9f0a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"This patch adds an option to select which of the 2 option to disalbe and"},{"line_number":11,"context_line":"the secondary will be disabled. In some case both networking manager is"},{"line_number":12,"context_line":"enabled and it cuase issues, Also some user probably want to use the new"},{"line_number":13,"context_line":"service \"NetworkingManager\". in param \"DIB_NETWORK_MANAGER\" case specified"},{"line_number":14,"context_line":"one of the neworking service will be enabled and the secondary will be"},{"line_number":15,"context_line":"disabled, in case user did not specify this param none of this code will"},{"line_number":16,"context_line":"run."},{"line_number":17,"context_line":"Example: DIB_NETWORK_MANAGER\u003dNetworkManager / DIB_NETWORK_MANAGER\u003dnetwork"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba5da102_6903310e","line":15,"range":{"start_line":13,"start_character":29,"end_line":15,"end_character":9},"updated":"2016-11-05 12:38:22.000000000","message":"Perhaps - \"The parameter \"DIB_NETWORK_MANAGER\" specifies which of the networking services to enable, the other will be disabled.  If neither is specified then no networking service will run.","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"80235011b3e406616c41f366125768203b89028b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"redhat-common add option to select networking service NetworkManager/network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On rhel distro (fedora/rhel/centos) there are 2 networking services."},{"line_number":10,"context_line":"This patch adds an option to select which of the 2 option to enable and"},{"line_number":11,"context_line":"the one not selected will be disabled."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a77a97e_beed61f1","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":7},"updated":"2016-11-15 22:33:38.000000000","message":"I guess it would be more correct to say \"Red Hat\" distros, since RHEL is a product acronym, but it\u0027s not important to be so pedantically correct in a commit message.","commit_id":"eacfb5015e2d076c79b29f6114dfb9a9babd6eae"}],"elements/redhat-common/README.rst":[{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"b92e9beb69b4f8f8dff0e9caf49a192946080eed","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  :Default: None"},{"line_number":36,"context_line":"  :Description: in case specify networking service will make sure other"},{"line_number":37,"context_line":"   networking service disable and will enable only the desired one."},{"line_number":38,"context_line":"   in case user did not specify this param the default networking service will"},{"line_number":39,"context_line":"   be used."},{"line_number":40,"context_line":"  :Example: DIB_NETWORK_MANAGER\u003dNetworkManager / DIB_NETWORK_MANAGER\u003dnetwork"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_940d003a","line":39,"range":{"start_line":38,"start_character":43,"end_line":39,"end_character":11},"updated":"2016-11-04 20:52:35.000000000","message":"What is that default?","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"17e0d4bfe721ab9518f6b54fe19e136165ad9f0a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  :Default: None"},{"line_number":36,"context_line":"  :Description: in case specify networking service will make sure other"},{"line_number":37,"context_line":"   networking service disable and will enable only the desired one."},{"line_number":38,"context_line":"   in case user did not specify this param the default networking service will"},{"line_number":39,"context_line":"   be used."},{"line_number":40,"context_line":"  :Example: DIB_NETWORK_MANAGER\u003dNetworkManager / DIB_NETWORK_MANAGER\u003dnetwork"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba5da102_8e3a4be6","line":39,"range":{"start_line":38,"start_character":43,"end_line":39,"end_character":11},"in_reply_to":"ba5da102_940d003a","updated":"2016-11-05 12:38:22.000000000","message":"Please clean up description and add an example in here.  Suggestion:\n:Description: Specify the networking service to be used, either \u0027network\u0027 or \u0027NetworkManager\u0027.  The specified service will be enabled and the other service will be disabled.  If neither is set, no networking service will run.\n:Example: DIB_NETWORK_MANAGER\u003dNetworkManager","commit_id":"4b1bf85155196345f5884f395d64aa93035f2186"},{"author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"change_message_id":"6f3430727daf1b3f94536d3aa3df88b25ad95227","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  :Description: Specify the networking service to be used, either \u0027network\u0027 or \u0027NetworkManager\u0027."},{"line_number":37,"context_line":"   The specified service will be enabled and the other service will be disabled."},{"line_number":38,"context_line":"   If neither is set, No networking service will be enforced."},{"line_number":39,"context_line":"  :Example: DIB_NETWORK_MANAGER\u003dNetworkManager / DIB_RHEL_NETWORK_SERVICE\u003dnetwork"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba5da102_69c5e759","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":31},"updated":"2016-11-06 19:22:30.000000000","message":"Should be DIB_RHEL_NETWORK_SERVICE","commit_id":"01bc297c5c237d5e2cd8879cb007c9a7302427b6"},{"author":{"_account_id":12398,"name":"Dan Sneddon","email":"dsneddon@redhat.com","username":"dsneddon"},"change_message_id":"80235011b3e406616c41f366125768203b89028b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"   true, the bits that cleanup old kernels will not be executed."},{"line_number":31,"context_line":"  :Example: DIB_DISABLE_KERNEL_CLEANUP\u003d1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DIB_FORCE_NETWORK_SERVICE"},{"line_number":34,"context_line":"  :Required: No"},{"line_number":35,"context_line":"  :Default: None"},{"line_number":36,"context_line":"  :Description: Specify the networking service to be used, either \u0027network\u0027 or \u0027NetworkManager\u0027."},{"line_number":37,"context_line":"   The specified service will be enabled and the other service will be disabled."},{"line_number":38,"context_line":"   If neither is set, No networking service will be enforced."},{"line_number":39,"context_line":"  :Example: DIB_FORCE_NETWORK_SERVICE\u003dNetworkManager / DIB_FORCE_NETWORK_SERVICE\u003dnetwork"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7a77a97e_5e7d2d1b","line":39,"range":{"start_line":33,"start_character":0,"end_line":39,"end_character":88},"updated":"2016-11-15 22:33:38.000000000","message":"Thank you for the README addition, much appreciated!","commit_id":"eacfb5015e2d076c79b29f6114dfb9a9babd6eae"}],"elements/redhat-common/environment.d/50-redhat-common":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"678fa36c607d2b756fe0b3fa014c3fe52fba5bdf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export DIB_DISABLE_KERNEL_CLEANUP\u003d${DIB_DISABLE_KERNEL_CLEANUP:-0}"},{"line_number":2,"context_line":"export DIB_RHEL_NETWORK_SERVICE\u003d${DIB_RHEL_NETWORK_SERVICE:-\"\"}"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a77a97e_76f2459c","line":2,"updated":"2016-11-14 23:44:26.000000000","message":"is this maybe a bit misnamed?  seems that it can apply to more than RHEL (fedora \u0026 centos too right?)  they\u0027re all using redhat-common","commit_id":"ff40976ffe2122a098c1e979b75eb43ec8bdb8f7"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"cd052b1ab2f2dd237a91f4eee4eeaa7b26a8e1b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"export DIB_DISABLE_KERNEL_CLEANUP\u003d${DIB_DISABLE_KERNEL_CLEANUP:-0}"},{"line_number":2,"context_line":"export DIB_FORCE_NETWORK_SERVICE\u003d${DIB_FORCE_NETWORK_SERVICE:-\"\"}"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"7a77a97e_7b49acb6","line":2,"updated":"2016-11-17 19:37:44.000000000","message":"Sorry, I know you just renamed this, but this is somewhat RH specific (just not RHEL), does DIB_FORCE_RH_NETWORK_SERVICE work?","commit_id":"f0499377f7a7fdd87dee25564ce8d40dd4740e7b"}]}
