)]}'
{"id":"openstack%2Fdiskimage-builder~396607","triplet_id":"openstack%2Fdiskimage-builder~master~Idbef10b9b7aef0dcf0bafeb0f1cf6288d226297b","project":"openstack/diskimage-builder","branch":"master","topic":"bug/1641106","hashtags":[],"change_id":"Idbef10b9b7aef0dcf0bafeb0f1cf6288d226297b","subject":"Include lsb_release on redhat/centos7 images","status":"ABANDONED","created":"2016-11-11 12:16:18.000000000","updated":"2016-11-12 11:30:31.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d90b7fb66e8b8e2676ddba2a70197ed46ce1761b","_number":396607,"virtual_id_number":396607,"owner":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":1,"date":"2016-11-11 14:57:54.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-11-11 13:56:44.000000000","_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"date":"2016-11-11 20:11:52.000000000","_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"all":[{"value":-1,"date":"2016-11-11 20:34:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":-1,"date":"2016-11-11 19:30:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},{"_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"},{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-11 14:57:54.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-11-11 19:30:55.000000000","updated_by":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"reviewer":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"state":"REVIEWER"},{"updated":"2016-11-11 20:11:52.000000000","updated_by":{"_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"},"reviewer":{"_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"},"state":"REVIEWER"},{"updated":"2016-11-11 20:34:24.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"}],"messages":[{"id":"bfe867da56195c9307d3b749e0ce0d98a541f09f","author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"date":"2016-11-11 12:16:18.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"38da3684fd7b4559d5cac40eacd7709903f32d39","author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"date":"2016-11-11 13:56:44.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"ef47167d701113d0f01b64b73443663fb3e2060a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-11 14:11:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/07/396607/1/check/gate-diskimage-builder-docs-ubuntu-xenial/9835c91//doc/build/html/ : SUCCESS in 54s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-pep8-ubuntu-xenial/1ce31e1/ : SUCCESS in 1m 34s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-python27-ubuntu-xenial/5c180f7/ : SUCCESS in 1m 11s\n- gate-diskimage-builder-python34 http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-python34/c29be5a/ : SUCCESS in 1m 04s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-python35-nv/a3b034f/ : SUCCESS in 1m 37s (non-voting)\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-ubuntu-trusty/00bd6e2/ : SUCCESS in 40m 09s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-ubuntu-xenial/d18adb6/ : SUCCESS in 28m 14s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-centos-7/7a88337/ : FAILURE in 1m 47s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/442b965/ : SUCCESS in 9m 33s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-centos-7-extras-nv/3816720/ : SUCCESS in 11m 50s (non-voting)\n- gate-dsvm-nodepool-src-diskimage-builder-nv http://logs.openstack.org/07/396607/1/check/gate-dsvm-nodepool-src-diskimage-builder-nv/bb5dfb7/ : FAILURE in 56m 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"b1b17ebe015c02089f3a5cbf4ee352f67dc8dd0d","author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"date":"2016-11-11 14:20:47.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"108a28c6c6258c8723cba05a57e4ca37a59b3c70","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-11 14:57:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/07/396607/1/check/gate-diskimage-builder-docs-ubuntu-xenial/c35b816//doc/build/html/ : SUCCESS in 44s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-pep8-ubuntu-xenial/28026d4/ : SUCCESS in 53s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-python27-ubuntu-xenial/e01e618/ : SUCCESS in 42s\n- gate-diskimage-builder-python34 http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-python34/9159c8e/ : SUCCESS in 48s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/07/396607/1/check/gate-diskimage-builder-python35-nv/0e53b57/ : SUCCESS in 1m 11s (non-voting)\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-ubuntu-trusty/19029a4/ : SUCCESS in 36m 51s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-ubuntu-xenial/955a1a9/ : SUCCESS in 25m 35s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-centos-7/a341d40/ : SUCCESS in 26m 54s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/82401b5/ : SUCCESS in 7m 09s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/07/396607/1/check/gate-dib-dsvm-functests-centos-7-extras-nv/687c2ad/ : SUCCESS in 7m 36s (non-voting)\n- gate-dsvm-nodepool-src-diskimage-builder-nv http://logs.openstack.org/07/396607/1/check/gate-dsvm-nodepool-src-diskimage-builder-nv/7b5cf48/ : SUCCESS in 26m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"de6b17a614366bd6953fc750fed061afbf451fb7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-11 15:21:02.000000000","message":"Patch Set 1:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/07/396607/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/e2a4a00/ : SUCCESS in 2h 12m 18s","accounts_in_message":[],"_revision_number":1},{"id":"a1e3cda383fae00373265c8130f0332dbd121866","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2016-11-11 19:30:55.000000000","message":"Patch Set 1: Code-Review-1\n\nThis should be explicit dependency where it is actually used, in tripleo element using lsb_release.\n\nPackaging fix is https://review.rdoproject.org/r/3671\ncould be also in the package list for the tripleo image but not in DIB.","accounts_in_message":[],"_revision_number":1},{"id":"4153e97a7ddd6100643fff3c2e09ece32f9d88a2","author":{"_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"},"date":"2016-11-11 20:11:52.000000000","message":"Patch Set 1:\n\nIf we want to fix this where Alan suggests, it\u0027s not a packaging fix.  The right fix is to apply this:  https://review.openstack.org/396759","accounts_in_message":[],"_revision_number":1},{"id":"09378802887a7df01ba91801039a59666f0ce012","author":{"_account_id":9979,"name":"Mike Burns","email":"mburns@redhat.com","username":"mburns"},"date":"2016-11-11 20:12:18.000000000","message":"Patch Set 1:\n\nFWIW, I have no strong opinion either way, happy to have this fix or the other one...","accounts_in_message":[],"_revision_number":1},{"id":"f670d2a427e70c676125ab477b9f5106965f460e","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2016-11-11 20:34:24.000000000","message":"Patch Set 1: Code-Review-1\n\nIIRC, this actually pulls in quite a few packages and it isn\u0027t necessarily required.  I\u0027d rather go with https://review.openstack.org/#/c/396759 which installs it in the element that needs it.","accounts_in_message":[],"_revision_number":1},{"id":"ea21b9c89e3669dc5a0d37b29a1405b09be4cf38","author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"date":"2016-11-12 11:29:08.000000000","message":"Patch Set 1:\n\nThe other OS elements appeared to include LSB so I figured it should be considered part of the base OS. However after picking through the element deps again I\u0027m not convinced it\u0027s included in every OS element - opensuse definitely has it, but ubuntu doesn\u0027t AFAICT.\n\nSo I agree the dep should be defined where it\u0027s used and https://review.openstack.org/#/c/396759 is the better option.","accounts_in_message":[],"_revision_number":1},{"id":"43b0a64a8d71d1a5b1837f876bf53f46501d078a","author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"date":"2016-11-12 11:30:31.000000000","message":"Abandoned\n\nGot with https://review.openstack.org/#/c/396759 instead","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3ac1e520d668f59895b46a4152401d149a615882","revisions":{"3ac1e520d668f59895b46a4152401d149a615882":{"kind":"REWORK","_number":1,"created":"2016-11-11 12:16:18.000000000","uploader":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"ref":"refs/changes/07/396607/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/07/396607/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/07/396607/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/07/396607/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/07/396607/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/07/396607/1"}}},"commit":{"parents":[{"commit":"587d14feed3cfdc6df9bf2d31898d5c81a377710","subject":"Merge \"dhcp-all-interfaces: support Centos/RHEL 6\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/587d14feed3cfdc6df9bf2d31898d5c81a377710"}]}],"author":{"name":"Oliver Walsh","email":"owalsh@redhat.com","date":"2016-11-11 12:05:43.000000000","tz":0},"committer":{"name":"Oliver Walsh","email":"owalsh@redhat.com","date":"2016-11-11 12:05:43.000000000","tz":0},"subject":"Include lsb_release on redhat/centos7 images","message":"Include lsb_release on redhat/centos7 images\n\nTripleO deployment fails if lsb_release does not exist.\nTypically it does exist as a transitive dependency of Ceph but this needs to be\nan explicit dependency as Ceph is optional.\n\nChange-Id: Idbef10b9b7aef0dcf0bafeb0f1cf6288d226297b\nCloses-Bug: #1641106\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3ac1e520d668f59895b46a4152401d149a615882"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/3ac1e520d668f59895b46a4152401d149a615882"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}