)]}'
{"elements/sysctl/bin/sysctl-set-value":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0f7bbb884809a5c66774e1bef2e0c2faa14f65ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a71b18c_d65c201b","line":2,"updated":"2016-12-06 20:16:10.000000000","message":"I hate to be picky here, but this does not seems backwards compatible\n\nThis (sysctl-set-value) is installed in /usr/local/bin and presumably supposed to be there on the final system for use at some later point?\n\nAs you say, it doesn\u0027t make any sense to use it *during* the build, because you\u0027re setting the wrong values on the host kernel.  but using this on a live system will not set the values as presumably the caller expects.\n\nI don\u0027t know what we\u0027re going for here?  compatibility with other things, or making up our own thing?\n\nIf it\u0027s compatability, then this doesn\u0027t seem compatible.  \n\nIf we\u0027re making up our own thing, then I\u0027d prefer to get rid of the symlink as it\u0027s quite confusing, and make sure the README.rst for the element is updated with just sysctl-write-value\n\nIn fact that doesn\u0027t seem very dib-ish anyway -- a more common pattern would be having a conf snippet in each element that wanted it, and then having this element concatentate them into the final sysctl.conf in the final system.  but yeah ... that\u0027s very different again.","commit_id":"44b89f83fdcdb438be4e1d7910793d419285dbee"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"db3d8c076e27399c6285559d3ef99a99d6b9ea8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a71b18c_c4f1ca96","line":2,"in_reply_to":"3a71b18c_d65c201b","updated":"2016-12-06 21:28:33.000000000","message":"Yeah, it is a bit confusing.\nThis is not the same as the version in tripleo-image-elements, this is a newly created element in DIB (though it has the same name which I found a bit odd).\nThis version does not get installed in /usr/local/bin, that is the tripleo version (left unchanged).\n\nSo, yes, removing sysctl-set-value all together is probably the right answer here, but the concern was raised if someone is using that call to set the individual sysctl files as the \"set\" version validated there were not conflicting settings from different elements.\n\nSo, open to suggestion, I was just trying to fix a broken set of scripts.  Personally I would lean towards giving this element a different name, but it was here already.","commit_id":"44b89f83fdcdb438be4e1d7910793d419285dbee"}],"elements/sysctl/bin/sysctl-write-value":[{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"188aa3741c0a858f4cf83ce91fa9f80a96441ef9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# $COMMENT"},{"line_number":40,"context_line":"$NAME \u003d $VALUE"},{"line_number":41,"context_line":"EOF_CAT"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_320baed7","line":42,"updated":"2016-12-06 15:21:11.000000000","message":"Should this \"else\" block be indented properly?","commit_id":"44b89f83fdcdb438be4e1d7910793d419285dbee"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a0d72661e6dcf1f3c205ed0f9dfafceeb88cdac7","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# $COMMENT"},{"line_number":40,"context_line":"$NAME \u003d $VALUE"},{"line_number":41,"context_line":"EOF_CAT"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_f4191b23","line":42,"in_reply_to":"3a71b18c_320baed7","updated":"2016-12-06 18:18:10.000000000","message":"With this method of creating a file it would include the indention in the resulting file, so I left it without the indention.","commit_id":"44b89f83fdcdb438be4e1d7910793d419285dbee"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"a0afa2d8520917110ca58a898f9b199812988713","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# $COMMENT"},{"line_number":40,"context_line":"$NAME \u003d $VALUE"},{"line_number":41,"context_line":"EOF_CAT"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_3f119252","line":42,"in_reply_to":"3a71b18c_f4191b23","updated":"2016-12-07 09:45:31.000000000","message":"True but if you use \u003c\u003c-EOF_CAT instead of \u003c\u003cEOF_CAT and tabs for indentation, the result should be good. Anyway, it doesn\u0027t matter much :)","commit_id":"44b89f83fdcdb438be4e1d7910793d419285dbee"}]}