)]}'
{"elements/debootstrap/install.d/10-debian-networking":[{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"2a29476cfba110f3511a323e0ce84227f2d7bb39","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# cloud images expect eth0 and eth1 to use dhcp."},{"line_number":28,"context_line":"mkdir -p /etc/network/interfaces.d"},{"line_number":29,"context_line":"if ! grep -E -q \u0027source(-directory) /etc/network/interfaces.d/*\u0027; then"},{"line_number":30,"context_line":"\techo \"source /etc/network/interfaces.d/*\" \u003e\u003e /etc/network/interfaces"},{"line_number":31,"context_line":"\techo \u0027Network configuration set to source /etc/network/interfaces.d/*\u0027"},{"line_number":32,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a71b18c_47322ea8","line":29,"range":{"start_line":29,"start_character":49,"end_line":29,"end_character":59},"updated":"2016-12-06 15:02:47.000000000","message":"Won\u0027t this hang? I can\u0027t see any argument of which file it should actually grep. :-)","commit_id":"de60a0c81481f93b143ce48528fb672dd2c5c409"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"237538ad52f9e8ac44e39dae57dc7e7aefe47dcd","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# cloud images expect eth0 and eth1 to use dhcp."},{"line_number":28,"context_line":"mkdir -p /etc/network/interfaces.d"},{"line_number":29,"context_line":"if ! grep -E -q \u0027source(-directory) /etc/network/interfaces.d/*\u0027; then"},{"line_number":30,"context_line":"\techo \"source /etc/network/interfaces.d/*\" \u003e\u003e /etc/network/interfaces"},{"line_number":31,"context_line":"\techo \u0027Network configuration set to source /etc/network/interfaces.d/*\u0027"},{"line_number":32,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a71b18c_c7939e59","line":29,"range":{"start_line":29,"start_character":49,"end_line":29,"end_character":59},"in_reply_to":"3a71b18c_47322ea8","updated":"2016-12-06 15:04:40.000000000","message":"One day the issue of copy pasting losing data will be fixed once for all!  Sorry :(","commit_id":"de60a0c81481f93b143ce48528fb672dd2c5c409"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"5b2315a53b045691dbb6ce37d94747562fa0e7e4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# cloud images expect eth0 and eth1 to use dhcp."},{"line_number":28,"context_line":"mkdir -p /etc/network/interfaces.d"},{"line_number":29,"context_line":"if ! grep -E -q \u0027source(-directory) /etc/network/interfaces.d/*\u0027 /etc/network/interfaces; then"},{"line_number":30,"context_line":"\techo \"source /etc/network/interfaces.d/*\" \u003e\u003e /etc/network/interfaces"},{"line_number":31,"context_line":"\techo \u0027Network configuration set to source /etc/network/interfaces.d/*\u0027"},{"line_number":32,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_85f085cb","line":29,"updated":"2016-12-07 16:17:52.000000000","message":"\u003e (source|source-directory)\n\u003e this syntax source(-directory) did not work for me\n\nI forgot to make the -directory part optional with a trailing question mark, which I think was the reason I have used extended regular expression (-E to grep).\n\nChanging it to (source|source-directory) as you suggested","commit_id":"a25e68f38d0fab5680415b2f4cf154eb05e6f9fd"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"8b196aa477832aea053a0c65fd30a2146c19c9bd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# cloud images expect eth0 and eth1 to use dhcp."},{"line_number":28,"context_line":"mkdir -p /etc/network/interfaces.d"},{"line_number":29,"context_line":"if ! grep -E -q \u0027source(-directory) /etc/network/interfaces.d/*\u0027 /etc/network/interfaces; then"},{"line_number":30,"context_line":"\techo \"source /etc/network/interfaces.d/*\" \u003e\u003e /etc/network/interfaces"},{"line_number":31,"context_line":"\techo \u0027Network configuration set to source /etc/network/interfaces.d/*\u0027"},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":"for interface in eth0 eth1; do"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_12d6b227","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":1},"updated":"2016-12-06 15:22:24.000000000","message":"You\u0027re also mixing tabs and spaces based on how gerrit is marking up these two lines.","commit_id":"a25e68f38d0fab5680415b2f4cf154eb05e6f9fd"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"5b2315a53b045691dbb6ce37d94747562fa0e7e4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# cloud images expect eth0 and eth1 to use dhcp."},{"line_number":28,"context_line":"mkdir -p /etc/network/interfaces.d"},{"line_number":29,"context_line":"if ! grep -E -q \u0027source(-directory) /etc/network/interfaces.d/*\u0027 /etc/network/interfaces; then"},{"line_number":30,"context_line":"\techo \"source /etc/network/interfaces.d/*\" \u003e\u003e /etc/network/interfaces"},{"line_number":31,"context_line":"\techo \u0027Network configuration set to source /etc/network/interfaces.d/*\u0027"},{"line_number":32,"context_line":"fi"},{"line_number":33,"context_line":"for interface in eth0 eth1; do"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_2545f116","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":1},"in_reply_to":"3a71b18c_12d6b227","updated":"2016-12-07 16:17:52.000000000","message":"Done","commit_id":"a25e68f38d0fab5680415b2f4cf154eb05e6f9fd"},{"author":{"_account_id":2475,"name":"Antoine Musso","email":"hashar@free.fr","username":"hashar"},"change_message_id":"c98f1452b7c0df81106ba9fa3d71cc676050fdad","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# cloud images expect eth0 and eth1 to use dhcp."},{"line_number":28,"context_line":"mkdir -p /etc/network/interfaces.d"},{"line_number":29,"context_line":"if ! grep -E -q \u0027(source|source-directory) /etc/network/interfaces.d/\\*\u0027 /etc/network/interfaces; then"},{"line_number":30,"context_line":"    echo \"source /etc/network/interfaces.d/*\" \u003e\u003e /etc/network/interfaces"},{"line_number":31,"context_line":"    echo \u0027Network configuration set to source /etc/network/interfaces.d/*\u0027"},{"line_number":32,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a71b18c_e5ca191a","line":29,"updated":"2016-12-07 16:21:30.000000000","message":"Tested against a file having:\n\n source /etc/network/interfaces.d/*\n source-directory /etc/network/interfaces.d/*\n source /etc/network/interfaces.d////\n\nOutcome:\n\n $ grep -E \u0027(source|source-directory) /etc/network/interfaces.d/\\*\u0027 interfaces \n source /etc/network/interfaces.d/*\n source-directory /etc/network/interfaces.d/*\n $\n\nThe /(source|source-directory)/  is straightforward compared to an optional group /source(-directory)?/\n\nI also escaped the trailing star, else it would have caught the 3rd line in the example above (which has four trailing slashes).","commit_id":"b6c394ceee6f1462e9cc008006ec87f0650f03aa"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"97a333025a680c1c8abc7d097b1347b5a012d479","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# cloud images expect eth0 and eth1 to use dhcp."},{"line_number":28,"context_line":"mkdir -p /etc/network/interfaces.d"},{"line_number":29,"context_line":"if ! grep -E -q \u0027(source|source-directory) /etc/network/interfaces.d/\\*\u0027 /etc/network/interfaces; then"},{"line_number":30,"context_line":"    echo \"source /etc/network/interfaces.d/*\" \u003e\u003e /etc/network/interfaces"},{"line_number":31,"context_line":"    echo \u0027Network configuration set to source /etc/network/interfaces.d/*\u0027"},{"line_number":32,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a71b18c_859245f5","line":29,"in_reply_to":"3a71b18c_e5ca191a","updated":"2016-12-07 16:23:56.000000000","message":"Ah ha, that is why it didn\u0027t work earlier:\n\ngrep -E -q \u0027source(|-directory)\u0027 will match both cases, your earlier work omitted the pipe.","commit_id":"b6c394ceee6f1462e9cc008006ec87f0650f03aa"}]}