)]}'
{"elements/sysctl/extra-data.d/10-sysctl-copy":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6edc70658dbb30ea52d5834f10763bbd763c4f4b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ -d \"$DIR/$ELEMENT/sysctl.d/\" ]; then"},{"line_number":14,"context_line":"            # Check for any conflicting sysctl settings"},{"line_number":15,"context_line":"            sudo awk \u0027BEGIN {FS \u003d \"\u003d\" }"},{"line_number":16,"context_line":"                !/^#|^;/ \u0026\u0026 /\u003d/ { # Not comment [#;] lines, must have an \u0027\u003d\u0027"},{"line_number":17,"context_line":"                    if (seen[$1]++) # Look for duplicate variables"},{"line_number":18,"context_line":"                        {print \"ERROR: Duplicate sysctl variable\", $1"},{"line_number":19,"context_line":"                         exit 1}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a71b18c_ade10e2c","line":16,"updated":"2016-12-07 00:30:08.000000000","message":"code golf, but you could remove a level of nesting by making this just \"continue\" if it matches a bad line?","commit_id":"676d203bc2184618ba43bd62b88900d1372e1c1b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e4b4810899a8082d748c7488a0972c9dd6a8e2a9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        if [ -d \"$DIR/$ELEMENT/sysctl.d/\" ]; then"},{"line_number":14,"context_line":"            # Check for any conflicting sysctl settings"},{"line_number":15,"context_line":"            sudo awk \u0027BEGIN {FS \u003d \"\u003d\" }"},{"line_number":16,"context_line":"                !/^#|^;/ \u0026\u0026 /\u003d/ { # Not comment [#;] lines, must have an \u0027\u003d\u0027"},{"line_number":17,"context_line":"                    if (seen[$1]++) # Look for duplicate variables"},{"line_number":18,"context_line":"                        {print \"ERROR: Duplicate sysctl variable\", $1"},{"line_number":19,"context_line":"                         exit 1}"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"3a71b18c_8d19b224","line":16,"in_reply_to":"3a71b18c_ade10e2c","updated":"2016-12-07 00:38:34.000000000","message":"I\u0027m not sure I follow you.  In awk \u0027continue\u0027 can only be used in loops (for, while, do), which I am not using here.\nThis line is the match conditional line which does skip the record if it is comment or doesn\u0027t have an \u0027\u003d\u0027.","commit_id":"676d203bc2184618ba43bd62b88900d1372e1c1b"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"e31529b8cd2eddd109c45d89ac4e2c51f5d575ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"for ELEMENT in $IMAGE_ELEMENT ; do"},{"line_number":12,"context_line":"    for DIR in ${ELEMENTS_PATH//:/ }; do"},{"line_number":13,"context_line":"        if [ -d \"$DIR/$ELEMENT/sysctl.d/\" ]; then"},{"line_number":14,"context_line":"            # Check for any conflicting sysctl settings"},{"line_number":15,"context_line":"            sudo awk \u0027BEGIN {FS \u003d \"\u003d\" } # dib-lint: safe_sudo"},{"line_number":16,"context_line":"                !/^#|^;/ \u0026\u0026 /\u003d/ { # Not comment [#;] lines, must have an \u0027\u003d\u0027"},{"line_number":17,"context_line":"                    if (seen[$1]++) # Look for duplicate variables"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"7a3c09a3_cd30a2eb","line":14,"updated":"2017-01-14 20:52:17.000000000","message":"I\u0027m not sure if this check is needed or should be there.\n\nE.g. in a DIB created Ubuntu image, there are the system setting for use_tempaddr as well as some from DIB:\n\n$ rgrep _temp /etc/sysctl.d/\n/etc/sysctl.d/99-cloudimg-ipv6.conf:net.ipv6.conf.all.use_tempaddr\u003d0\n/etc/sysctl.d/99-cloudimg-ipv6.conf:net.ipv6.conf.default.use_tempaddr\u003d0\n/etc/sysctl.d/10-ipv6-privacy.conf:net.ipv6.conf.all.use_tempaddr \u003d 2\n/etc/sysctl.d/10-ipv6-privacy.conf:net.ipv6.conf.default.use_tempaddr \u003d 2\n\nSo it might be fine to have the same key more than once.","commit_id":"db26d08c8420256506459a26526c3fecb09c012c"}]}