)]}'
{"id":"openstack%2Fdiskimage-builder~409947","triplet_id":"openstack%2Fdiskimage-builder~master~I434ed2e084d4477dc7a2b7827164586f8ea0c1e3","project":"openstack/diskimage-builder","branch":"master","topic":"bug/1649409","hashtags":[],"change_id":"I434ed2e084d4477dc7a2b7827164586f8ea0c1e3","subject":"Use %i instead of %I in dhcp-interface@.service","status":"MERGED","created":"2016-12-12 21:49:06.000000000","updated":"2017-01-26 23:02:15.000000000","submitted":"2017-01-26 23:02:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0491d290524a5bef9913fddeccc59c29b23f6c77","_number":409947,"virtual_id_number":409947,"owner":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"value":0,"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":2,"date":"2017-01-26 23:02:15.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"all":[{"value":2,"date":"2017-01-26 22:16:56.000000000","_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":2,"date":"2017-01-18 05:41:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2017-01-25 13:27:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"value":1,"date":"2017-01-18 16:18:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"all":[{"value":1,"date":"2017-01-26 22:17:13.000000000","_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"value":0,"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-01-18 05:41:52.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2017-01-18 16:18:05.000000000","updated_by":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"reviewer":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"state":"REVIEWER"},{"updated":"2017-01-25 13:27:00.000000000","updated_by":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"reviewer":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"state":"REVIEWER"},{"updated":"2017-01-26 22:17:13.000000000","updated_by":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"reviewer":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"state":"REVIEWER"},{"updated":"2017-01-26 23:02:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dd80d8805caf82594f6b5817c7cdd4e894a1376b","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2016-12-12 21:49:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4bc4094b59ef6bb9bf22f9bc69d15cb17adee1ec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-12 22:26:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://logs.openstack.org/47/409947/1/check/gate-diskimage-builder-docs-ubuntu-xenial/0dd130f/ : FAILURE in 12m 26s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/47/409947/1/check/gate-diskimage-builder-pep8-ubuntu-xenial/0561f48/ : SUCCESS in 2m 18s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/47/409947/1/check/gate-diskimage-builder-python27-ubuntu-xenial/80a85ad/ : SUCCESS in 48s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/47/409947/1/check/gate-diskimage-builder-python35-nv/3356dc3/ : SUCCESS in 1m 25s (non-voting)\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-ubuntu-trusty/81ed723/ : POST_FAILURE in 26m 10s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-ubuntu-xenial/0a1e301/ : SUCCESS in 28m 14s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-centos-7/aef7efc/ : SUCCESS in 36m 02s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/a1fe5bc/ : SUCCESS in 5m 57s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-centos-7-extras-nv/642edfb/ : SUCCESS in 18m 15s (non-voting)\n- gate-dsvm-nodepool-src-diskimage-builder-nv http://logs.openstack.org/47/409947/1/check/gate-dsvm-nodepool-src-diskimage-builder-nv/4e1fe6e/ : SUCCESS in 34m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8928514786db9791aba3d48eb43f9de73fb91ee2","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2016-12-12 22:47:52.000000000","message":"Patch Set 1:\n\nrecheck git failure","accounts_in_message":[],"_revision_number":1},{"id":"09a68dbde646fbd0283565d87a8b93fef73d9987","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-12 23:24:37.000000000","message":"Patch Set 1:\n\nBuild failed (check-tripleo pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/47/409947/1/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/aea868c/ : FAILURE in 1h 35m 09s","accounts_in_message":[],"_revision_number":1},{"id":"070371d765d948ea6941d5e3a6e6ca657c40c12b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-12 23:25:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/47/409947/1/check/gate-diskimage-builder-docs-ubuntu-xenial/65948ec//doc/build/html/ : SUCCESS in 51s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/47/409947/1/check/gate-diskimage-builder-pep8-ubuntu-xenial/466870e/ : SUCCESS in 1m 42s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/47/409947/1/check/gate-diskimage-builder-python27-ubuntu-xenial/ab84181/ : SUCCESS in 1m 16s\n- gate-diskimage-builder-python35-nv http://logs.openstack.org/47/409947/1/check/gate-diskimage-builder-python35-nv/3de7a62/ : SUCCESS in 1m 00s (non-voting)\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-ubuntu-trusty/f05c5cc/ : SUCCESS in 26m 10s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-ubuntu-xenial/f575a26/ : SUCCESS in 30m 36s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-centos-7/b268545/ : SUCCESS in 27m 58s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/2e93ee5/ : SUCCESS in 6m 24s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/47/409947/1/check/gate-dib-dsvm-functests-centos-7-extras-nv/c4fb0c3/ : SUCCESS in 8m 34s (non-voting)\n- gate-dsvm-nodepool-src-diskimage-builder-nv http://logs.openstack.org/47/409947/1/check/gate-dsvm-nodepool-src-diskimage-builder-nv/45805de/ : SUCCESS in 34m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f95532aad1d0db68f828c1ab524c975e4e724809","author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"date":"2016-12-13 12:21:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"1967304832e27c1dccd3b8c42c52b4157aa46202","author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"date":"2016-12-13 14:49:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"7d209e11fbe072e973081dd46d9f270eb8160b8a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-12-13 22:38:19.000000000","message":"Patch Set 1: Code-Review-1\n\nsomething isn\u0027t adding up for me here.  \n\nThe escaping rules are that \"/\" gets turned into a \"-\" and everything else gets turned into a hex char.  Thus it is reversing this, and it\u0027s \"unescaping\" \"br-isolated\" to \"br/isolated\" but the original was never escaped to begin with.\n\nSo the question seems to be more why the interface name isn\u0027t escaped?\n\nMy first thought here is that udev should be escaping the device name.  searching \"udev systemd escape\" turned up\n\n https://bugzilla.redhat.com/show_bug.cgi?id\u003d1020887\n\nwhich seems to be almost our exact problem here (and, unfortunately, seems unresolved)?  \n\nAm I missing something?","accounts_in_message":[],"_revision_number":1},{"id":"14d412e4dae65026c376c8f87f016b88e2694989","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-12-13 22:42:03.000000000","message":"Patch Set 1:\n\nfor example, on my system i have a virbr0-nic attached to a bridge, that comes up as\n\n sys-subsystem-net-devices-virbr0\\x2dnic.device loaded active plugged   /sys/subsystem/net/devices/virbr0-nic\n\n(but i guess that comes from inside systemd being a /sys/ node?  I dunno).  But I think we should definitely be trying to match on the escaped name, and figure out why we\u0027re not getting that?","accounts_in_message":[],"_revision_number":1},{"id":"41f623f1f93cc423f21fa5f6c1d8f748f167161f","author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"date":"2016-12-14 22:43:56.000000000","message":"Patch Set 1: -Code-Review\n\nI think this fix is correct.  systemd service files seem to use either %i or %I depending on the desired output and if the potential escape chars should be reversed (%I).  Device names appear to use %i to avoid the unescaping when the name is used in places other than the description, for example teamd@.service:\n[Unit]\nDescription\u003dTeam Daemon for device %I\n[Service]\nBusName\u003dorg.libteam.teamd.%i\nExecStart\u003d/usr/bin/teamd -U -D -o -t %i -f /run/teamd/%i.conf\n\nAlso serial-getty@.service:\nDescription\u003dSerial Getty on %I\nBindsTo\u003ddev-%i.device\nAfter\u003ddev-%i.device systemd-user-sessions.service plymouth-quit-wait.service\n\nThere is some discussion on the use of %i and %I here: http://0pointer.de/blog/projects/instances.html","accounts_in_message":[],"_revision_number":1},{"id":"70213c52c51e00770de72b4e50d3ab337c21df0a","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-12-19 04:39:46.000000000","message":"Patch Set 1:\n\nI dunno, the comment in the bug says\n\n Note that SYSTEMD_WANTS in udev rules expects properly escape unit names,\n but also takes unescaped ones, which when that is detected are \n automatically escaped.\n\nAs noted in [2]; it seems like the auto-detection of escaping is not working?  It sees \"br-XYZ\" and just assumes it is already escaped, I guess, due to the \"-\" in it.  \n\nsystemd expects the name coming in to be properly escaped to its rules, but our rule is violating that assumption.\n\nThe problem is, as mentioned in that bug, I don\u0027t see how to actually escape it properly in the udev rule (essentially, not rely on systemd to autoescape it).  Unfortunately, that bug never reached a resolution.  I\u0027d appreciate it we can get spend a little time on investigation to get clarity on how to handle this.\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1020887#c6\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1020887#c8","accounts_in_message":[],"_revision_number":1},{"id":"94584c87025af2a452bddf1c1e06a0193140b5aa","author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"date":"2017-01-10 08:34:08.000000000","message":"Patch Set 1:\n\nHi all.\n\nSo my understanding is that you sometime have to encode path in the unit file name.  This is not doable so %I exists to \"unescape\" them to get back the file path (completly random example):\n\n @-dev-tty -\u003e %I -\u003e /dev/tty  (systemd-escape -u -- -dev-tty)\n\nin our case @br-ctl -\u003e %I -\u003e br/ctl  (systemd-escape -u br-ctl -\u003e br/ctl)\n\nas br-ctl is not to be unescaped (it\u0027s not a path and will never have any non ascii char), %i must be used.\n\nSo I\u0027m not sure I see the problem here.","accounts_in_message":[],"_revision_number":1},{"id":"86ead7155d3f2b44f50b0ebc315f834e632774e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-12 16:01:57.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"8903418ab8a281fcb0bc4d27fb361c19083ed822","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2017-01-17 23:26:46.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"01c01e1420800ca41fdae90771068fa1bc114d92","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2017-01-17 23:27:52.000000000","message":"Patch Set 2:\n\nI\u0027ve tried to expand the commit message with the results of Bob and Sofer\u0027s investigations.","accounts_in_message":[],"_revision_number":2},{"id":"39ce2fd8a4db11a6746b6733a2253d49cbd0ddd5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-18 00:08:02.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/47/409947/2/check/gate-diskimage-builder-docs-ubuntu-xenial/988a617//doc/build/html/ : SUCCESS in 1m 35s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/47/409947/2/check/gate-diskimage-builder-pep8-ubuntu-xenial/2d6a189/ : SUCCESS in 1m 10s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/47/409947/2/check/gate-diskimage-builder-python27-ubuntu-xenial/2728f76/ : SUCCESS in 1m 26s\n- gate-diskimage-builder-python35 http://logs.openstack.org/47/409947/2/check/gate-diskimage-builder-python35/d0314b5/ : SUCCESS in 1m 20s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/47/409947/2/check/gate-dib-dsvm-functests-ubuntu-trusty/f8d8cf1/ : SUCCESS in 32m 16s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/47/409947/2/check/gate-dib-dsvm-functests-ubuntu-xenial/e3314d2/ : SUCCESS in 33m 25s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/47/409947/2/check/gate-dib-dsvm-functests-centos-7/57cf4b9/ : SUCCESS in 33m 41s\n- gate-dib-dsvm-functests-ubuntu-trusty-extras-nv http://logs.openstack.org/47/409947/2/check/gate-dib-dsvm-functests-ubuntu-trusty-extras-nv/5219e41/ : SUCCESS in 13m 21s (non-voting)\n- gate-dib-dsvm-functests-centos-7-extras-nv http://logs.openstack.org/47/409947/2/check/gate-dib-dsvm-functests-centos-7-extras-nv/ee617de/ : SUCCESS in 14m 33s (non-voting)\n- gate-dib-dsvm-functests-ubuntu-xenial-extras-nv http://logs.openstack.org/47/409947/2/check/gate-dib-dsvm-functests-ubuntu-xenial-extras-nv/c76451b/ : SUCCESS in 13m 15s (non-voting)\n- gate-dsvm-nodepool-debian-src-nv http://logs.openstack.org/47/409947/2/check/gate-dsvm-nodepool-debian-src-nv/dde2360/ : SUCCESS in 33m 11s (non-voting)\n- gate-dsvm-nodepool-redhat-src-nv http://logs.openstack.org/47/409947/2/check/gate-dsvm-nodepool-redhat-src-nv/5cfa07b/ : SUCCESS in 38m 24s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"66e6ffe917b322a64e13ed1c5b277b0b27d18e02","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2017-01-18 05:41:52.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"3329f9cf8b6ec9fcae93beda012d3281a64ba9d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-18 05:52:06.000000000","message":"Patch Set 2:\n\nBuild succeeded (check-tripleo pipeline).\n\n- gate-tripleo-ci-centos-7-ovb-nonha http://logs.openstack.org/47/409947/2/check-tripleo/gate-tripleo-ci-centos-7-ovb-nonha/b50fdf6/ : SUCCESS in 2h 07m 42s","accounts_in_message":[],"_revision_number":2},{"id":"32badcfca7c097d87e9e851a046488d11e8daafb","author":{"_account_id":21909,"name":"Bob Fournier","email":"bfournie@redhat.com","username":"bfournie"},"date":"2017-01-18 16:18:05.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"25dfc3427d098585188b886eb72733d6d33f83f2","author":{"_account_id":8297,"name":"Sofer Athlan-Guyot","email":"sathlang@redhat.com","username":"chem"},"date":"2017-01-25 13:27:00.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ed2eed296805beb16b94ef1b9132416f28f6c1af","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2017-01-26 22:16:56.000000000","message":"Patch Set 2: Code-Review+2\n\nFor the files: I\u0027m sure lowercase %i is correct here.\n\n1) Test using up-to date Ubuntu Xenial\n\u003d\u003d\u003d /etc/systemd/system/test-escape@.service\n[Unit]\nAfter\u003dnetwork.target\n\n[Service]\nType\u003dsimple\nExecStart\u003d/tmp/logme \"%i\" \"%I\"\n\u003d\u003d\u003d\n\n\u003d\u003d\u003d /tmp/logme\n#!/bin/bash\n\necho Parameter \u003e\u003e/tmp/called.log\necho \"lowercase i [$1]\" \u003e\u003e/tmp/called.log\necho \"uppercase i [$2]\" \u003e\u003e/tmp/called.log\n\u003d\u003d\u003d\n\n\u003d\u003d\u003d /tmp/called.log\nParameter\nlowercase i [br-internal]\nuppercase i [br/internal]\n\n2) Source code of systemd (clone of today\u0027s master):\n\n\u003d\u003d\u003d ./src/core/unit-printf.c:272\n                { \u0027i\u0027, specifier_string,              u-\u003einstance },\n                { \u0027I\u0027, specifier_instance_unescaped,  NULL },\n\u003d\u003d\u003d ./src/core/unit-printf.c:62\nstatic int specifier_instance_unescaped(char specifier, void *data, void *userdata, char **ret) {\n        [...]\n        return unit_name_unescape(strempty(u-\u003einstance), ret);\n}\n\u003d\u003d\u003d src/basic/unit-name.c:346\nint unit_name_unescape(const char *f, char **ret) {\n[...]\n        for (t \u003d r; *f; f++) {\n                if (*f \u003d\u003d \u0027-\u0027)\n                        *(t++) \u003d \u0027/\u0027;\n                else if (*f \u003d\u003d \u0027\\\\\u0027) {","accounts_in_message":[],"_revision_number":2},{"id":"28a76e85e6f001b2da4acc99ebb69689de3743a5","author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"date":"2017-01-26 22:17:13.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"c0782d2c4fbaae723be999cca070450c15cab728","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-26 22:17:24.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a2b891798245bb40773582a4bc4f6c57786d1693","date":"2017-01-26 23:02:15.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"6d769d2da2b2e32abbc7bd26636d1702e6dcb43a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-26 23:02:15.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-diskimage-builder-docs-ubuntu-xenial http://docs-draft.openstack.org/47/409947/2/gate/gate-diskimage-builder-docs-ubuntu-xenial/6b51ba2//doc/build/html/ : SUCCESS in 1m 20s\n- gate-diskimage-builder-pep8-ubuntu-xenial http://logs.openstack.org/47/409947/2/gate/gate-diskimage-builder-pep8-ubuntu-xenial/de298e8/ : SUCCESS in 3m 07s\n- gate-diskimage-builder-python27-ubuntu-xenial http://logs.openstack.org/47/409947/2/gate/gate-diskimage-builder-python27-ubuntu-xenial/ebc4090/ : SUCCESS in 1m 19s\n- gate-diskimage-builder-python35 http://logs.openstack.org/47/409947/2/gate/gate-diskimage-builder-python35/575737e/ : SUCCESS in 56s\n- gate-dib-dsvm-functests-ubuntu-trusty http://logs.openstack.org/47/409947/2/gate/gate-dib-dsvm-functests-ubuntu-trusty/da6dcc6/ : SUCCESS in 30m 38s\n- gate-dib-dsvm-functests-ubuntu-xenial http://logs.openstack.org/47/409947/2/gate/gate-dib-dsvm-functests-ubuntu-xenial/7f102b3/ : SUCCESS in 38m 25s\n- gate-dib-dsvm-functests-centos-7 http://logs.openstack.org/47/409947/2/gate/gate-dib-dsvm-functests-centos-7/4d090a0/ : SUCCESS in 42m 43s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d20754f6ed0b76ebf695c4eadf877edce0536464","revisions":{"7d897e8e7643056e1af2a3feac78d1e37a36eef0":{"kind":"REWORK","_number":1,"created":"2016-12-12 21:49:06.000000000","uploader":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"ref":"refs/changes/47/409947/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/47/409947/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/1"}}},"commit":{"parents":[{"commit":"8c74c8e409adf21094a5973bef84a02ba8876464","subject":"Merge \"Delete deprecated Hacking in tox.ini\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/8c74c8e409adf21094a5973bef84a02ba8876464"}]}],"author":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2016-12-12 21:46:25.000000000","tz":-360},"committer":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2016-12-12 21:46:25.000000000","tz":-360},"subject":"Use %i instead of %I in dhcp-interface@.service","message":"Use %i instead of %I in dhcp-interface@.service\n\nPer the bug report, %I results in -\u0027s in the interface name being\nreplaced with /\u0027s, which means when we try to look up the interface\nby path in dhcp-all-interfaces.sh we end up at an invalid path.\nUsing %i instead should fix the problem.\n\nSee https://www.freedesktop.org/software/systemd/man/systemd.unit.html\n\nChange-Id: I434ed2e084d4477dc7a2b7827164586f8ea0c1e3\nCloses-Bug: 1649409\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/7d897e8e7643056e1af2a3feac78d1e37a36eef0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/7d897e8e7643056e1af2a3feac78d1e37a36eef0"}]},"branch":"refs/heads/master"},"d20754f6ed0b76ebf695c4eadf877edce0536464":{"kind":"REWORK","_number":2,"created":"2017-01-17 23:26:46.000000000","uploader":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"ref":"refs/changes/47/409947/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/diskimage-builder","ref":"refs/changes/47/409947/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/diskimage-builder refs/changes/47/409947/2"}}},"commit":{"parents":[{"commit":"359892aa4b103df521886f637cf389238fba2de5","subject":"Merge \"update pkg-map entries for python3\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/359892aa4b103df521886f637cf389238fba2de5"}]}],"author":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2016-12-12 21:46:25.000000000","tz":-360},"committer":{"name":"Ben Nemec","email":"bnemec@redhat.com","date":"2017-01-17 23:24:07.000000000","tz":-360},"subject":"Use %i instead of %I in dhcp-interface@.service","message":"Use %i instead of %I in dhcp-interface@.service\n\nPer the bug report, %I results in -\u0027s in the interface name being\nreplaced with /\u0027s, which means when we try to look up the interface\nby path in dhcp-all-interfaces.sh we end up at an invalid path.\nUsing %i instead should fix the problem.\n\nSee https://www.freedesktop.org/software/systemd/man/systemd.unit.html\n\nEssentially what is happening is that we start with a name like\nbr-ex that wasn\u0027t escaped in the first place.  However, because of\nthe - it looks like it could have been escaped to systemd.  When\nwe use %I, which tries to unescape escaped values, it unescapes a\nvalue that was already not escaped.\n\nChange-Id: I434ed2e084d4477dc7a2b7827164586f8ea0c1e3\nCloses-Bug: 1649409\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d20754f6ed0b76ebf695c4eadf877edce0536464"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/diskimage-builder/commit/d20754f6ed0b76ebf695c4eadf877edce0536464"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}