)]}'
{"lib/common-functions":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"c2234769bff5d38211142fd3806a275d3a9f9b6d","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        if [ -n \"$2\" ]; then"},{"line_number":198,"context_line":"            dib-run-parts ${TMP_HOOKS_PATH}/$1.d | tee $2"},{"line_number":199,"context_line":"            if [[ ${PIPESTATUS[0]} !\u003d 0 ]]; then"},{"line_number":200,"context_line":"                return 1"},{"line_number":201,"context_line":"            fi"},{"line_number":202,"context_line":"        else"},{"line_number":203,"context_line":"            dib-run-parts ${TMP_HOOKS_PATH}/$1.d"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a6eadb0_6f23cc58","line":200,"updated":"2016-12-21 08:25:00.000000000","message":"leaves VIRTUAL_ENV unset.","commit_id":"8206f2bff7307cb3049a86d40f9ce624be71fdf6"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2901cfcc4f0f822c11afae5bbb19882950b21295","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        if [ -n \"$2\" ]; then"},{"line_number":198,"context_line":"            dib-run-parts ${TMP_HOOKS_PATH}/$1.d | tee $2"},{"line_number":199,"context_line":"            if [[ ${PIPESTATUS[0]} !\u003d 0 ]]; then"},{"line_number":200,"context_line":"                return 1"},{"line_number":201,"context_line":"            fi"},{"line_number":202,"context_line":"        else"},{"line_number":203,"context_line":"            dib-run-parts ${TMP_HOOKS_PATH}/$1.d"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da4df55a_c51c3a7a","line":200,"updated":"2016-12-21 21:41:13.000000000","message":"leaves VIRTUAL_ENV unset","commit_id":"4a9333fa6409363e9b117e4190f79b881694d868"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fde7be2b54e5d050a1abf9712fffb673a42e2842","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    unset VIRTUAL_ENV"},{"line_number":196,"context_line":"    if [ -d ${TMP_HOOKS_PATH}/$1.d ] ; then"},{"line_number":197,"context_line":"        if [ -n \"$2\" ]; then"},{"line_number":198,"context_line":"            dib-run-parts ${TMP_HOOKS_PATH}/$1.d | tee $2"},{"line_number":199,"context_line":"            if [[ ${PIPESTATUS[0]} !\u003d 0 ]]; then"},{"line_number":200,"context_line":"                if [ -n \"$venv\" ]; then"},{"line_number":201,"context_line":"                    export VIRTUAL_ENV\u003d$venv"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da4df55a_ab038575","line":198,"updated":"2016-12-21 22:24:42.000000000","message":"why would we not just do \n\n env -u VIRTUAL_ENV dib-run-parts ... ?","commit_id":"ce1a7644b58561f7d5fa7e22c1a863e9d633a9d1"}],"lib/img-functions":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"2901cfcc4f0f822c11afae5bbb19882950b21295","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      trap \"check_break after-error $in_target_arg ${break_cmd:-bash}\" ERR"},{"line_number":86,"context_line":"      run_in_target dib-run-parts /tmp/in_target.d/$1.d"},{"line_number":87,"context_line":"      trap - ERR"},{"line_number":88,"context_line":"      check_break after-$1 run_in_target bash"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"      if [ -n \"$venv\" ]; then"},{"line_number":91,"context_line":"        export VIRTUAL_ENV\u003d$venv"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"da4df55a_05400256","line":88,"updated":"2016-12-21 21:41:13.000000000","message":"Is it intentional that check_brack here is within the virtual_env unset where in the other file, and first check_break here happen outside?","commit_id":"4a9333fa6409363e9b117e4190f79b881694d868"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fde7be2b54e5d050a1abf9712fffb673a42e2842","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      check_break before-$1 run_in_target bash"},{"line_number":84,"context_line":"      [ -z \"$break_outside_target\" ] \u0026\u0026 in_target_arg\u003d\"run_in_target\" || in_target_arg\u003d"},{"line_number":85,"context_line":"      trap \"check_break after-error $in_target_arg ${break_cmd:-bash}\" ERR"},{"line_number":86,"context_line":"      run_in_target dib-run-parts /tmp/in_target.d/$1.d"},{"line_number":87,"context_line":"      trap - ERR"},{"line_number":88,"context_line":"      check_break after-$1 run_in_target bash"},{"line_number":89,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da4df55a_ab2aa5e5","line":86,"updated":"2016-12-21 22:24:42.000000000","message":"here, it seems like we should add the -u VIRTUAL_ENV to run_in_target chroot call?","commit_id":"ce1a7644b58561f7d5fa7e22c1a863e9d633a9d1"},{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"d8532d12ef0cacb831d33789380123705b02c7c0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    export HOME\u003d/root"},{"line_number":61,"context_line":"    # Force an empty TMPDIR inside the chroot. There is no need to use an user"},{"line_number":62,"context_line":"    # defined tmp dir which may not exist in the chroot."},{"line_number":63,"context_line":"    # Bug: #1330290"},{"line_number":64,"context_line":"    # Force the inclusion of a typical set of dirs in PATH, this is needed for guest"},{"line_number":65,"context_line":"    # distros that have path elements not in the host PATH."},{"line_number":66,"context_line":"    sudo -E chroot $TMP_MOUNT_PATH env -u TMPDIR -u VIRTUAL_ENV PATH\u003d\"\\$PATH:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\" sh -c \"$cmd\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"da4df55a_f07bb979","line":63,"updated":"2016-12-22 00:35:53.000000000","message":"nit: a similar comment/bug for why we\u0027re excluding VIRTUAL_ENV would be useful.","commit_id":"54b2733ad8b5807fdae1267c5475d4a0fba38237"}]}