)]}'
{"lib/img-functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f30df6813d1127a21427e67281deae0831fbca61","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    export HOME\u003d/root"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    local vars"},{"line_number":63,"context_line":"    for X in ${!DIB_*} $!ARCH $!FS_TYPE $!IMAGE_BLOCK_DEVICE $!IMAGE_NAME; do"},{"line_number":64,"context_line":"        case \"$X\" in"},{"line_number":65,"context_line":"            DIB_ARGS|DIB_ENV)"},{"line_number":66,"context_line":"                continue"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5201f7_21f9584e","line":63,"updated":"2017-01-10 01:48:15.000000000","message":"Is \"$!\" some bash trick I don\u0027t know about?\n\n${!ARCH} would substitute the value of ARCH as the variable name, but AFAICT this is working because $! (last background process) happens to expand to nothing at this point.\n\nbut I think we just want the raw strings","commit_id":"0946e83b9f5a7add387628c1eee050208a775aaf"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"c4226433a7cbb2a12512fd9a9247e8e3df6ed840","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    export HOME\u003d/root"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    local vars"},{"line_number":63,"context_line":"    for X in ${!DIB_*} $!ARCH $!FS_TYPE $!IMAGE_BLOCK_DEVICE $!IMAGE_NAME; do"},{"line_number":64,"context_line":"        case \"$X\" in"},{"line_number":65,"context_line":"            DIB_ARGS|DIB_ENV)"},{"line_number":66,"context_line":"                continue"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5201f7_2ae0f095","line":63,"in_reply_to":"ba5201f7_21f9584e","updated":"2017-01-11 16:58:31.000000000","message":"I picked it up from https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html","commit_id":"0946e83b9f5a7add387628c1eee050208a775aaf"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ebfe16f2c9909004ff0107efe6074c971b1a5b0d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    export HOME\u003d/root"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    local vars"},{"line_number":63,"context_line":"    for X in ${!DIB_*} $!ARCH $!FS_TYPE $!IMAGE_BLOCK_DEVICE $!IMAGE_NAME; do"},{"line_number":64,"context_line":"        case \"$X\" in"},{"line_number":65,"context_line":"            DIB_ARGS|DIB_ENV)"},{"line_number":66,"context_line":"                continue"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"7a3c09a3_6281be8f","line":63,"in_reply_to":"ba5201f7_2ae0f095","updated":"2017-01-12 22:35:37.000000000","message":"but what is it trying to do?  indrect expansion?  because even if that did work, i\u0027m not sure it\u0027s what you want.\n\nbut yeah, i\u0027m 99% sure the $! just gets matched as is, and indirect-expansion only applies within {}\u0027s\n\n $ cat test.sh \n FOO\u003dBAR\n BAR\u003dhello\n echo $!FOO\n echo ${!FOO}\n\n $ bash -x ./test.sh \n + FOO\u003dBAR\n + BAR\u003dhello\n + echo FOO\n FOO\n + echo hello\n hello\n\nI agree that the man page actually suggests that the { is totally optional, even though I don\u0027t think it is for the expansion case.  I\u0027m avoiding the temptation to yak-shave in the bash source code atm :)","commit_id":"0946e83b9f5a7add387628c1eee050208a775aaf"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f30df6813d1127a21427e67281deae0831fbca61","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    local vars"},{"line_number":63,"context_line":"    for X in ${!DIB_*} $!ARCH $!FS_TYPE $!IMAGE_BLOCK_DEVICE $!IMAGE_NAME; do"},{"line_number":64,"context_line":"        case \"$X\" in"},{"line_number":65,"context_line":"            DIB_ARGS|DIB_ENV)"},{"line_number":66,"context_line":"                continue"},{"line_number":67,"context_line":"            ;;"},{"line_number":68,"context_line":"        esac"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"ba5201f7_c176ccd7","line":65,"updated":"2017-01-10 01:48:15.000000000","message":"I\u0027d like a comment to say that this is the list of DIB_ arguments we explicitly want to filter out.  obviously if we\u0027d though fully we\u0027d have a defined name-space that was for things passed into the chroot and avoid things like this","commit_id":"0946e83b9f5a7add387628c1eee050208a775aaf"}]}
