)]}'
{"diskimage_builder/block_device/level1/partitioning.py":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"6f9af298adaa91f957857531b9c5c2da8f077b04","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            return"},{"line_number":188,"context_line":"        # If running inside Docker, make our nodes manually, because udev"},{"line_number":189,"context_line":"        # will not be working."},{"line_number":190,"context_line":"        if os.path.exists(\"/.dockerenv\"):"},{"line_number":191,"context_line":"            # kpartx cannot run in sync mode in docker."},{"line_number":192,"context_line":"            self._exec_sudo([\"kpartx\", \"-av\", device_path])"},{"line_number":193,"context_line":"            self._exec_sudo([\"dmsetup\", \"--noudevsync\", \"mknodes\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_9a16a753","line":190,"range":{"start_line":190,"start_character":29,"end_line":190,"end_character":38},"updated":"2017-01-27 14:44:20.000000000","message":"i wonder if we can move it to some constant or env var. Although it may not change, i think it\u0027s too specific to be just embedded in the code","commit_id":"1473e3c6cca1abdad7a984cd7d598f4b350182f6"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"9b729dfab17368733d3dc5e6a5a52237e14c6a6f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"            return"},{"line_number":188,"context_line":"        # If running inside Docker, make our nodes manually, because udev"},{"line_number":189,"context_line":"        # will not be working."},{"line_number":190,"context_line":"        if os.path.exists(\"/.dockerenv\"):"},{"line_number":191,"context_line":"            # kpartx cannot run in sync mode in docker."},{"line_number":192,"context_line":"            self._exec_sudo([\"kpartx\", \"-av\", device_path])"},{"line_number":193,"context_line":"            self._exec_sudo([\"dmsetup\", \"--noudevsync\", \"mknodes\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_645959fe","line":190,"range":{"start_line":190,"start_character":29,"end_line":190,"end_character":38},"in_reply_to":"3a461143_9a16a753","updated":"2017-01-27 18:28:19.000000000","message":"What I understand correctly from different sources, that there is no reliable way to detect if running in a docker or not.  There are IMHO two \u0027typical\u0027 ways of checking:\no Check for the existence of /.dockerenv\no Check if the \u0027second\u0027 part (with delimiter \u0027/\u0027 is either lxc or docker\n\nI have no idea which is more reliable...\n\nWe could implement both and bail out if they indicate different results.\n\n(Hint: I\u0027m not the author of the original source code - I \njust ported it.)","commit_id":"1473e3c6cca1abdad7a984cd7d598f4b350182f6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3d45771bd8ab43bd6a640c0ebc8a3b8b1f6c52dc","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if rval !\u003d 0:"},{"line_number":160,"context_line":"            logger.error(\"Calling [%s] failed with [%s]\" %"},{"line_number":161,"context_line":"                         (\" \".join(sudo_cmd), rval))"},{"line_number":162,"context_line":"            logger.error(\"Trying to continue\")"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _all_part_devices_exist(self, expected_part_devices):"},{"line_number":165,"context_line":"        for part_device in expected_part_devices:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_04264768","line":162,"updated":"2017-03-07 04:25:03.000000000","message":"Little concerned we have yet another subprocess runner and this one doesn\u0027t trace the output; it took some work in I5442f544ff0ef3ddffdbe6b898d178548d699a41 for example to untangle that.  let\u0027s just keep and eye out for more like this","commit_id":"f1c51e8b876e9b7a597fcf45177ae6290bd22966"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"e75a8b8b2d7229ddb21461f4d9edbb47d8fdf1f1","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        if rval !\u003d 0:"},{"line_number":160,"context_line":"            logger.error(\"Calling [%s] failed with [%s]\" %"},{"line_number":161,"context_line":"                         (\" \".join(sudo_cmd), rval))"},{"line_number":162,"context_line":"            logger.error(\"Trying to continue\")"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _all_part_devices_exist(self, expected_part_devices):"},{"line_number":165,"context_line":"        for part_device in expected_part_devices:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_9a736c4d","line":162,"in_reply_to":"9a30ddce_04264768","updated":"2017-03-07 05:58:10.000000000","message":"What is the priority here? Should we merge first of factor this out?","commit_id":"f1c51e8b876e9b7a597fcf45177ae6290bd22966"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3d45771bd8ab43bd6a640c0ebc8a3b8b1f6c52dc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        These calls are highly distribution and version specific. Here"},{"line_number":181,"context_line":"        a couple of different methods are used to get the best result."},{"line_number":182,"context_line":"        \"\"\""},{"line_number":183,"context_line":"        self._exec_sudo([\"partprobe\", device_path])"},{"line_number":184,"context_line":"        self._exec_sudo([\"udevadm\", \"settle\"])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if self._all_part_devices_exist(partition_devices):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a30ddce_c4d26f34","line":183,"updated":"2017-03-07 04:25:03.000000000","message":"ok so this is the interesting bit, as this fails on trusty.  let\u0027s get a good ci run to evaluate this","commit_id":"f1c51e8b876e9b7a597fcf45177ae6290bd22966"}]}