)]}'
{"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"c488b0fd9123fdb0d84312a8206e8cbdeee5a324","unresolved":false,"context_lines":[{"line_number":41,"context_line":"       call it is possible to e.g. query information from the (partially"},{"line_number":42,"context_line":"       automatic generated) internal state like root-label."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    cmd_getval: retrive information about the (internal) block device"},{"line_number":45,"context_line":"       state like the block image device (for bootloader) or the"},{"line_number":46,"context_line":"       root-label (for writing fstab)."},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_f0b84a2c","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":23},"updated":"2017-02-15 10:26:00.000000000","message":"retrieve","commit_id":"1b26b080ee6fd0f032f8b8e719bc2b9a3c63d6ee"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"c488b0fd9123fdb0d84312a8206e8cbdeee5a324","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    name: image0"},{"line_number":94,"context_line":"    mkfs:"},{"line_number":95,"context_line":"      mount:"},{"line_number":96,"context_line":"        mount_point: /"},{"line_number":97,"context_line":"\"\"\""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _merge_into_config(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_108b1e69","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":19},"updated":"2017-02-15 10:26:00.000000000","message":"is there a possibility to provide flags for the mountpoint, like nosuid, noexec, etc?","commit_id":"1b26b080ee6fd0f032f8b8e719bc2b9a3c63d6ee"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"c488b0fd9123fdb0d84312a8206e8cbdeee5a324","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                else:"},{"line_number":302,"context_line":"                    diskid \u003d \"UUID\u003d%s\" % fs_val[\u0027uuid\u0027]"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"                fstab_fd.write(\"%s %s %s defaults 0 1\\n\""},{"line_number":305,"context_line":"                               % (diskid, mp, fs_val[\u0027fstype\u0027]))"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"        target_etc_dir \u003d os.path.join(self.params[\u0027build-dir\u0027], \u0027built\u0027, \u0027etc\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_70253a5a","line":304,"range":{"start_line":304,"start_character":41,"end_line":304,"end_character":49},"updated":"2017-02-15 10:26:00.000000000","message":"options, dump-freq and pass-num shall not be hardcoded here, it is needed to be configurable depending on the partition","commit_id":"1b26b080ee6fd0f032f8b8e719bc2b9a3c63d6ee"}],"diskimage_builder/block_device/level3/__init__.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3d683a7dac8c7c504053821761f171f84c47370b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Andreas Florath (andreas@florath.net)"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a30ddce_4a53bde1","line":1,"updated":"2017-03-07 20:17:34.000000000","message":"i don\u0027t know why this is saying it\u0027s copied from 15-zypper-fstab.  that\u0027s probably just a git/gerrit artifact i guess","commit_id":"defc4c57ceaf4155de196d0a3e509f53643087c0"}],"diskimage_builder/lib/disk-image-create":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3d683a7dac8c7c504053821761f171f84c47370b","unresolved":false,"context_lines":[{"line_number":274,"context_line":"BLOCK_DEVICE_CONFIG_YAML\u003d${TMP_BUILD_DIR}/block-device/config.yaml"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# Handle block device configuration from an element"},{"line_number":277,"context_line":"for ELEMENT in ${IMAGE_ELEMENT}; do"},{"line_number":278,"context_line":"    for EPATH in $(echo ${ELEMENTS_PATH} | tr \":\" \" \"); do"},{"line_number":279,"context_line":"        BLOCK_DEVICE_CFG_PATH\u003d${EPATH}/${ELEMENT}/block-device-config.yaml"},{"line_number":280,"context_line":"        if [ -e ${BLOCK_DEVICE_CFG_PATH} ]; then"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9a30ddce_2a1e8963","line":277,"updated":"2017-03-07 20:17:34.000000000","message":"i should have picked this up before but this should be walking our image element array.\n\ni think the best thing to do is to move this into a function anyway, to keep it together.\n\ninside that function you can replace this with\n\n eval declare -A image_elements\u003d($(get_image_element_array))\n for i in \"{$!image_elements[@]}\"; do\n   local bdpath\u003d${image_elements[$i]}/block-device-config.yaml\n   if [ -e ${bdpath} ];\n    ...\n\nThat way overrides are processed correctly","commit_id":"defc4c57ceaf4155de196d0a3e509f53643087c0"}],"diskimage_builder/lib/img-functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3d683a7dac8c7c504053821761f171f84c47370b","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"function cleanup () {"},{"line_number":53,"context_line":"    dib-block-device --phase\u003dumount \\"},{"line_number":54,"context_line":"\t\t     --params\u003d\"${DIB_BLOCK_DEVICE_PARAMS_YAML}\""},{"line_number":55,"context_line":"    unmount_image"},{"line_number":56,"context_line":"    cleanup_build_dir"},{"line_number":57,"context_line":"    cleanup_image_dir"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"9a30ddce_caaa4dd4","line":54,"updated":"2017-03-07 20:17:34.000000000","message":"tabs\n\nwhy does the linter not find this?","commit_id":"defc4c57ceaf4155de196d0a3e509f53643087c0"}],"diskimage_builder/tests/functional/test_blockdevice_utils.py":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"de7853ecbf2c9b8d3290755fe9905b9e863313ac","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\"Call parse_abs_size_spec with a completely broken unit spec\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertRaises(RuntimeError, parse_abs_size_spec, \"_+!HuHi+-\u003d\")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sort_mount_points(self):"},{"line_number":53,"context_line":"        \"\"\"Run sort_mount_points with a set of paths\"\"\""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da36d5c6_7f210a4d","line":51,"updated":"2017-02-21 15:39:01.000000000","message":"i miss some testing on the fstab feature...","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"30de90f9a01540a66991b53569d61002ff789e53","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\"Call parse_abs_size_spec with a completely broken unit spec\"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.assertRaises(RuntimeError, parse_abs_size_spec, \"_+!HuHi+-\u003d\")"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sort_mount_points(self):"},{"line_number":53,"context_line":"        \"\"\"Run sort_mount_points with a set of paths\"\"\""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da36d5c6_5cc6064a","line":51,"in_reply_to":"da36d5c6_7f210a4d","updated":"2017-02-21 21:17:16.000000000","message":"Which tests are you thinking about? Can you give an example? (Please note that the complete block-device layer is used in each an every disk-image-create run in CI.)","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"}],"doc/source/user_guide/building_an_image.rst":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"de7853ecbf2c9b8d3290755fe9905b9e863313ac","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                  mount_point: /"},{"line_number":98,"context_line":"                  fstab:"},{"line_number":99,"context_line":"                    options: \"errors\u003dremount-ro\""},{"line_number":100,"context_line":"                    fsck-passno: 1\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The default when not using the `vm` element is:"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da36d5c6_bfa0e2a0","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":24},"updated":"2017-02-21 15:39:01.000000000","message":"maybe mention the dump-freq as well? also, i think it could be nice if you specify which of the parameters are mandatory/optional, and the default values they take, i mean, if i don\u0027t specify fstab, what shall i get on my /etc/fstab file?","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"30de90f9a01540a66991b53569d61002ff789e53","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                  mount_point: /"},{"line_number":98,"context_line":"                  fstab:"},{"line_number":99,"context_line":"                    options: \"errors\u003dremount-ro\""},{"line_number":100,"context_line":"                    fsck-passno: 1\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The default when not using the `vm` element is:"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"da36d5c6_9c8f9ecb","line":100,"range":{"start_line":100,"start_character":20,"end_line":100,"end_character":24},"in_reply_to":"da36d5c6_bfa0e2a0","updated":"2017-02-21 21:17:16.000000000","message":"The idea here is to give a first impression how the block-device layers can be used - and I\u0027m using as two examples - the configuration that is really used in case of a VM or not a VM.\nAlso all the other levels do not list the complete option set here (this would be too long and you\u0027ll miss the idea behind).  The details about each module are given later in this file.  Example: fstab with all possible options, if mandatory or optional and possible default values are given starting with line 430.","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"de7853ecbf2c9b8d3290755fe9905b9e863313ac","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            mount:"},{"line_number":112,"context_line":"              mount_point: /"},{"line_number":113,"context_line":"              fstab:"},{"line_number":114,"context_line":"              options: \"errors\u003dremount-ro\""},{"line_number":115,"context_line":"              fsck-passno: 1\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"There are a lot of different options for the different levels.  The"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da36d5c6_ffb6dada","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":42},"updated":"2017-02-21 15:39:01.000000000","message":"Also, error in indentation here. Options go a level deeper than fstab","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"de7853ecbf2c9b8d3290755fe9905b9e863313ac","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            mount:"},{"line_number":112,"context_line":"              mount_point: /"},{"line_number":113,"context_line":"              fstab:"},{"line_number":114,"context_line":"              options: \"errors\u003dremount-ro\""},{"line_number":115,"context_line":"              fsck-passno: 1\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"There are a lot of different options for the different levels.  The"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da36d5c6_9f9f9e4f","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":30},"updated":"2017-02-21 15:39:01.000000000","message":"i\u0027ve always seen the standard entry for /etc/fstab as \"defaults\", not as \"errors\u003dremount-ro\". Maybe it\u0027s a sane default, but can you clarify why? if no dump-freq is specified, which value is taken?","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"30de90f9a01540a66991b53569d61002ff789e53","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            mount:"},{"line_number":112,"context_line":"              mount_point: /"},{"line_number":113,"context_line":"              fstab:"},{"line_number":114,"context_line":"              options: \"errors\u003dremount-ro\""},{"line_number":115,"context_line":"              fsck-passno: 1\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"There are a lot of different options for the different levels.  The"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da36d5c6_b7a1ddab","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":30},"in_reply_to":"da36d5c6_9f9f9e4f","updated":"2017-02-21 21:17:16.000000000","message":"The \u0027remount\u0027 is something that is used to be in dib:\n\nhttps://git.openstack.org/cgit/openstack/diskimage-builder/tree/elements/debootstrap/install.d/15-cleanup-debootstrap?h\u003d1.27.0\n\nor\n\nhttps://git.openstack.org/cgit/openstack/diskimage-builder/tree/elements/yum-minimal/install.d/15-base-fstab?h\u003d1.27.0\n\nI want to be \u0027compatible\u0027 here - but I don\u0027t mind: I can also replace this with \u0027default\u0027.\n\nThe fstab documentation starts at line 430. Please look there for other options and defaults.","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"30de90f9a01540a66991b53569d61002ff789e53","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            mount:"},{"line_number":112,"context_line":"              mount_point: /"},{"line_number":113,"context_line":"              fstab:"},{"line_number":114,"context_line":"              options: \"errors\u003dremount-ro\""},{"line_number":115,"context_line":"              fsck-passno: 1\u0027"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"There are a lot of different options for the different levels.  The"}],"source_content_type":"text/x-rst","patch_set":9,"id":"da36d5c6_f7ab5587","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":42},"in_reply_to":"da36d5c6_ffb6dada","updated":"2017-02-21 21:17:16.000000000","message":"Thanks - fixed.","commit_id":"b8e4215102c223b789234804c0f899b361c2f8f5"}]}