)]}'
{"diskimage_builder/block_device/level1/__init__.py":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"41817840120da5b68c21158c47f653b2564c77ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"1f013ff3_735b1b87","updated":"2017-05-14 13:25:38.000000000","message":"It looks that this file is not needed at all any longer - since the stevedore plugin mechanism is used.","commit_id":"d1d3ab57326fc3f851cf8cf4d4b7b329f4025394"}],"diskimage_builder/block_device/level1/lvm.py":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"41817840120da5b68c21158c47f653b2564c77ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"1f013ff3_93f4675d","updated":"2017-05-14 13:25:38.000000000","message":"The source code needs IMHO some refactoring, like (but not limited to):\n* common base class (ABC?): Pvs, Vgs, Lvs share about 80% of the variables / methods.\n* The config check, node handling and functionality should be done in the separate classes (i.e. the Lvm class should be not more than a container - instead of one class does all)\n* Currently the rollback is completely ignored. I think that in some error conditions rollback is needed.\n* Similar here: because exec_sudo has a new interface, there is the need to catch the \u0027new\u0027 exception and handle this (especially but not limited to) resource handling.\n* Some comments would help :-)","commit_id":"d1d3ab57326fc3f851cf8cf4d4b7b329f4025394"}],"diskimage_builder/block_device/level2/mkfs.py":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"653d24166fb836234969aa08bdad559290b13f2a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if self.type in (\u0027ext2\u0027, \u0027ext3\u0027, \u0027ext4\u0027, \u0027xfs\u0027):"},{"line_number":132,"context_line":"            cmd.append(\u0027-q\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if self.base in result[\u0027lvs\u0027]:"},{"line_number":135,"context_line":"            search_key \u003d \u0027lvs\u0027"},{"line_number":136,"context_line":"        elif self.base in result[\u0027blockdev\u0027]:"},{"line_number":137,"context_line":"            search_key \u003d \u0027blockdev\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a1ced50_aabb750d","line":134,"updated":"2017-03-17 06:48:28.000000000","message":"Just a remark: things of this should never happen!\nThe modules must be designed independently. Why do you need this? Why don\u0027t you put the results for LVM (additionally) into the \u0027blockdev\u0027 (the result of LVM should be a block-device)?","commit_id":"23a2cb025964d1a7037514e655353874120ffc63"}],"diskimage_builder/elements/debian-minimal/test-elements/stable-vm-with-volumes/environment.d/10-set-distro-and-filesystem.bash":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"41817840120da5b68c21158c47f653b2564c77ae","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        options: [\"--force\"]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    lvs:"},{"line_number":25,"context_line":"      - name: lv_root"},{"line_number":26,"context_line":"        base: vg"},{"line_number":27,"context_line":"        size: 1800M"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":37,"id":"1f013ff3_33559351","line":25,"updated":"2017-05-14 13:25:38.000000000","message":"This is nice and clean here; but currently does not test, if the tree-like configuration works.  Maybe one or two should be modified in the way that the complete mkfs block is put in here.","commit_id":"d1d3ab57326fc3f851cf8cf4d4b7b329f4025394"}],"doc/source/user_guide/building_an_image.rst":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":354,"context_line":"Module: Lvm"},{"line_number":355,"context_line":"···········"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"This module generates volumes on existing partitions. This means that it is"},{"line_number":358,"context_line":"possible to take any previous created partition, and create volumes information"},{"line_number":359,"context_line":"in it."},{"line_number":360,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_d64784bc","line":357,"updated":"2017-03-23 21:57:20.000000000","message":"s/partitions/block devices/\n\nThe level1 modules get one or more block devices and generates one or more block devices.  It should be possible to create lvm e.g. on MD or encrypted devices; even inside other LVMs.\n\n(This is valid for the rest of the module description.)","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"There are the following key / value pairs to define one set of volumes:"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"base"},{"line_number":366,"context_line":"    (mandatory) The base partitions where to create the volumes in. As volume"},{"line_number":367,"context_line":"    groups can be created on diferent physical devices (and partitions), this"},{"line_number":368,"context_line":"    needs to be a list of partitions to use."}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_d6aae417","line":365,"updated":"2017-03-23 21:57:20.000000000","message":"I\u0027m a little bit confused here: why are you having this at this level? I\u0027d expect that this would be part of the pvs.","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"base"},{"line_number":366,"context_line":"    (mandatory) The base partitions where to create the volumes in. As volume"},{"line_number":367,"context_line":"    groups can be created on diferent physical devices (and partitions), this"},{"line_number":368,"context_line":"    needs to be a list of partitions to use."},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"name"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_560db48e","line":367,"updated":"2017-03-23 21:57:20.000000000","message":"s/diferent/different/\ns/physical devices (and partitions)/block devices/","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"name"},{"line_number":371,"context_line":"    (mandatory) The name of the lvm structure. With the help of this name,"},{"line_number":372,"context_line":"    the lvm can later be referenced, e.g. when creating a file system."},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"pvs"},{"line_number":375,"context_line":"    (mandatory) A list of dictionaries. Each dictionary describe one"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_f6684822","line":372,"updated":"2017-03-23 21:57:20.000000000","message":"This I do not understand: how do you create a file system in this kind of structure?","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    the lvm can later be referenced, e.g. when creating a file system."},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"pvs"},{"line_number":375,"context_line":"    (mandatory) A list of dictionaries. Each dictionary describe one"},{"line_number":376,"context_line":"    physical volume."},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"vgs"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_3660f032","line":375,"updated":"2017-03-23 21:57:20.000000000","message":"s/describe/describes/\n\n*some* times in the next lines","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"vgs"},{"line_number":379,"context_line":"    (mandatory) A list of dictionaries. Each dictionary describe one volume"},{"line_number":380,"context_line":"    group."},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"lvs"},{"line_number":383,"context_line":"    (mandatory) A list of dictionaries. Each dictionary describe one logical"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_b6e08098","line":380,"updated":"2017-03-23 21:57:20.000000000","message":"So it is possible with one LVM (\u0027top level\u0027) entry to describe many physical volumes?\nIt is also possible to have multiple LVM elements?","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    name, the physical volume can later be referenced, e.g. when creating"},{"line_number":391,"context_line":"    a volume group."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"device"},{"line_number":394,"context_line":"    (mandatory) The name of the partition where the physical volume"},{"line_number":395,"context_line":"    needs to be created."},{"line_number":396,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_d62d44a9","line":393,"updated":"2017-03-23 21:57:20.000000000","message":"Is this the same as \u0027base\u0027? Do not really understand...","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    the volume group can later be referenced, e.g. when creating a logical"},{"line_number":406,"context_line":"    volume."},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"pvs"},{"line_number":409,"context_line":"    (mandatory) The name(s) of the physical volumes where the volume groups"},{"line_number":410,"context_line":"    needs to be created. As a volume group can be created on one or more"},{"line_number":411,"context_line":"    physical volumes, this needs to be a list."}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_3126bab9","line":408,"updated":"2017-03-23 21:57:20.000000000","message":"Same here: is this the \u0027base\u0027?","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    the logical volume can later be referenced, e.g. when creating a"},{"line_number":422,"context_line":"    filesystem."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"vgs"},{"line_number":425,"context_line":"    (mandatory) The name of the volume group where the logical volume"},{"line_number":426,"context_line":"    needs to be created."},{"line_number":427,"context_line":""}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_b1464a4f","line":424,"updated":"2017-03-23 21:57:20.000000000","message":"base also here?","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":443,"context_line":".. code-block: yaml"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    - lvm:"},{"line_number":446,"context_line":"        name: lvm"},{"line_number":447,"context_line":"        base: [root]"},{"line_number":448,"context_line":"        pvs:"},{"line_number":449,"context_line":"          - name: pv"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_11973693","line":446,"updated":"2017-03-23 21:57:20.000000000","message":"Why is this needed? Where can the name be used?","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"8e08ca421bb785d1894635996cfc4543931184d5","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    - lvm:"},{"line_number":446,"context_line":"        name: lvm"},{"line_number":447,"context_line":"        base: [root]"},{"line_number":448,"context_line":"        pvs:"},{"line_number":449,"context_line":"          - name: pv"},{"line_number":450,"context_line":"            options: [\"--force\"]"}],"source_content_type":"text/x-rst","patch_set":20,"id":"ffe62b97_d190ae98","line":447,"updated":"2017-03-23 21:57:20.000000000","message":"Why is this needed?","commit_id":"7794841bd4bf267ee82658e874d084011e4848f1"}]}