)]}'
{"diskimage_builder/elements/dracut-regenerate/finalise.d/98-dracut-regenerate":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e0ea399aa474e27207d9b6e095e9a2b07afe20fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"bff0334d_ca8197fd","line":1,"updated":"2017-04-09 22:02:10.000000000","message":"this runs in the chroot?  it should be using dib-python?","commit_id":"3a60a153f02f42cad69aa135564ff33586fbb16e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e0ea399aa474e27207d9b6e095e9a2b07afe20fc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        # first, install dependent packages"},{"line_number":30,"context_line":"        packages \u003d dracut_object.get(\u0027packages\u0027, [])"},{"line_number":31,"context_line":"        for package in packages:"},{"line_number":32,"context_line":"            subp \u003d subprocess.Popen([\"install-packages\", package],"},{"line_number":33,"context_line":"                                    stdout\u003dsubprocess.PIPE)"},{"line_number":34,"context_line":"            subp.wait()"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"bff0334d_ea90db4c","line":32,"updated":"2017-04-09 22:02:10.000000000","message":"my concern with essentially writing shell scripts in python like this is we loose all useful tracing.\n\nfor example i\u0027ve done a bunch of work on package-installs-squash to make sure it outputs useful status, because with this we swallow stdout but stderr still comes out, but is totally dislocated from anything else.\n\nsee diskimage_builder/elements/package-installs/bin/package-installs-v2:process_output() for an example ... but it really sucks to duplicate this over and over again.  however i\u0027m not sure of any other way ATM.\n\njust a thought bubble -- I wonder if dib-python could wrap into sys.path a common dib library that\u0027s in /tmp, and disappears in the final image?","commit_id":"3a60a153f02f42cad69aa135564ff33586fbb16e"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"401559d798ccb70045814c4a00f9593a577e7a01","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        # first, install dependent packages"},{"line_number":30,"context_line":"        packages \u003d dracut_object.get(\u0027packages\u0027, [])"},{"line_number":31,"context_line":"        for package in packages:"},{"line_number":32,"context_line":"            subp \u003d subprocess.Popen([\"install-packages\", package],"},{"line_number":33,"context_line":"                                    stdout\u003dsubprocess.PIPE)"},{"line_number":34,"context_line":"            subp.wait()"},{"line_number":35,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":11,"id":"bff0334d_37917848","line":32,"in_reply_to":"bff0334d_ea90db4c","updated":"2017-04-10 12:40:40.000000000","message":"I could do a better job on capturing stdout/stderr if needed. Or write in bash as well. I think at the moment we shall go with the needed element, and in the future do a refactor for the common library and update all the code that uses python","commit_id":"3a60a153f02f42cad69aa135564ff33586fbb16e"}]}