)]}'
{"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ab8f7aac5496f9969390a9b78e93e97eaa1338a4","unresolved":false,"context_lines":[{"line_number":298,"context_line":"            return 0"},{"line_number":299,"context_line":"        if symbol \u003d\u003d \u0027mount-points\u0027:"},{"line_number":300,"context_line":"            mount_points \u003d self._config_get_all_mount_points()"},{"line_number":301,"context_line":"            print(\"%s\" % \"|\".join(mount_points))"},{"line_number":302,"context_line":"            return 0"},{"line_number":303,"context_line":"        if symbol \u003d\u003d \u0027image-block-partition\u0027:"},{"line_number":304,"context_line":"            # If there is no partition needed, pass back directly the"}],"source_content_type":"text/x-python","patch_set":18,"id":"1f013ff3_403c9e92","line":301,"updated":"2017-05-16 05:32:27.000000000","message":"it would nice to put a comment in here about why.\n\nclearly, it would be better to get this directly; i quite like the socket idea at some point.  but i think this does the job for now","commit_id":"42fc9264861068e40a44a80ac807b6608c321308"}],"diskimage_builder/elements/rpm-distro/finalise.d/90-selinux-fixfiles-restore":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"fcb3146fb70eba0c5bfae4c8e548e8ba81da840f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        # Without fixing selinux file labels, sshd will run in the kernel_t domain"},{"line_number":16,"context_line":"        # instead of the sshd_t domain, making ssh connections fail with"},{"line_number":17,"context_line":"        # \"Unable to get valid context for \u003cuser\u003e\" error message"},{"line_number":18,"context_line":"        if [ \"${MOUNTPOINT}\" !\u003d \"/tmp/in_target.d\" ] \u0026\u0026 [ \"${MOUNTPOINT}\" !\u003d \"/dev\" ]; then"},{"line_number":19,"context_line":"            $SETFILES /etc/selinux/targeted/contexts/files/file_contexts ${MOUNTPOINT}"},{"line_number":20,"context_line":"        fi"},{"line_number":21,"context_line":"    done"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1a1ced50_e05ce94c","line":18,"updated":"2017-03-22 23:11:28.000000000","message":"I think a dib-block-device export might be better in that it will know what partitions to expose; for example do we need to skip /proc here too?\n\nthat said, this is probably ok until we get to that?","commit_id":"60a1701d56ab41cac6ed8735bf022cf73d641eb7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d090f7b5f7019cff616f628e35cf93d67107f84c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ -e /etc/selinux/targeted/contexts/files/file_contexts -a -x \"${SETFILES}\" ]; then"},{"line_number":12,"context_line":"    # get all mounpoints in the system"},{"line_number":13,"context_line":"    for MOUNTPOINT in \"${DIB_MOUNTPOINTS[@]}\"; do"},{"line_number":14,"context_line":"        # Without fixing selinux file labels, sshd will run in the kernel_t domain"},{"line_number":15,"context_line":"        # instead of the sshd_t domain, making ssh connections fail with"},{"line_number":16,"context_line":"        # \"Unable to get valid context for \u003cuser\u003e\" error message"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"1f013ff3_d6c65817","line":13,"updated":"2017-05-15 04:26:39.000000000","message":"this isn\u0027t an array?  dib-block-device is printing out a space-separated list?\n\neither mount-points should print out the values with \"()\" around it, or we need a \"declare -A\" somewhere?\n\nor we figure out some other way; space-deliminated doesn\u0027t seem particularly safe, although would work 99% of the time","commit_id":"ef261050457a6276ee9b219b03147a77668427fd"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"548488712e76ebabc66601e4f559b47d32fb8b60","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ -e /etc/selinux/targeted/contexts/files/file_contexts -a -x \"${SETFILES}\" ]; then"},{"line_number":12,"context_line":"    # get all mounpoints in the system"},{"line_number":13,"context_line":"    for MOUNTPOINT in \"${DIB_MOUNTPOINTS[@]}\"; do"},{"line_number":14,"context_line":"        # Without fixing selinux file labels, sshd will run in the kernel_t domain"},{"line_number":15,"context_line":"        # instead of the sshd_t domain, making ssh connections fail with"},{"line_number":16,"context_line":"        # \"Unable to get valid context for \u003cuser\u003e\" error message"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"1f013ff3_613fc0d6","line":13,"in_reply_to":"1f013ff3_d6c65817","updated":"2017-05-15 05:56:04.000000000","message":"It is an string separated by spaces, currently disk-image-create is consuming it with $()","commit_id":"ef261050457a6276ee9b219b03147a77668427fd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ab8f7aac5496f9969390a9b78e93e97eaa1338a4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SETFILES\u003d$(which setfiles || true)"},{"line_number":10,"context_line":"if [ -e /etc/selinux/targeted/contexts/files/file_contexts -a -x \"${SETFILES}\" ]; then"},{"line_number":11,"context_line":"    # get all mounpoints in the system"},{"line_number":12,"context_line":"    IFS\u003d\u0027|\u0027 read -ra SPLITTED_MOUNTS \u003c\u003c\u003c \"$DIB_MOUNTPOINTS\""},{"line_number":13,"context_line":"    for MOUNTPOINT in \"${SPLITTED_MOUNTS[@]}\"; do"},{"line_number":14,"context_line":"        # Without fixing selinux file labels, sshd will run in the kernel_t domain"},{"line_number":15,"context_line":"        # instead of the sshd_t domain, making ssh connections fail with"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"1f013ff3_a06da299","line":12,"updated":"2017-05-16 05:32:27.000000000","message":"minor thing but \"splitted\" isn\u0027t a word, it would just be \"split_mount\"","commit_id":"42fc9264861068e40a44a80ac807b6608c321308"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9fba738ffc471801a6a43765f21316e779c7646c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"SETFILES\u003d$(which setfiles || true)"},{"line_number":10,"context_line":"if [ -e /etc/selinux/targeted/contexts/files/file_contexts -a -x \"${SETFILES}\" ]; then"},{"line_number":11,"context_line":"    # get all mounpoints in the system"},{"line_number":12,"context_line":"    IFS\u003d\u0027|\u0027 read -ra SPLITTED_MOUNTS \u003c\u003c\u003c \"$DIB_MOUNTPOINTS\""},{"line_number":13,"context_line":"    for MOUNTPOINT in \"${SPLITTED_MOUNTS[@]}\"; do"},{"line_number":14,"context_line":"        # Without fixing selinux file labels, sshd will run in the kernel_t domain"},{"line_number":15,"context_line":"        # instead of the sshd_t domain, making ssh connections fail with"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"1f013ff3_001456f4","line":12,"in_reply_to":"1f013ff3_a06da299","updated":"2017-05-16 05:33:21.000000000","message":"\"split_mounts\" (plural) i mean :)","commit_id":"42fc9264861068e40a44a80ac807b6608c321308"}]}