)]}'
{"diskimage_builder/elements/ubuntu-minimal/environment.d/10-ubuntu-distro-name.bash":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"c60f93353c67284a84dab25ce8fce04423a889d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# There are two default distro mirrors depending on architecture"},{"line_number":10,"context_line":"ARCH\u003d${ARCH:-}"},{"line_number":11,"context_line":"if [[ \"amd64 x86_64 i386\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":12,"context_line":"    default_ubuntu_mirror\u003dhttp://archive.ubuntu.com/ubuntu"},{"line_number":13,"context_line":"else"},{"line_number":14,"context_line":"    default_ubuntu_mirror\u003dhttp://ports.ubuntu.com/ubuntu-ports"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_45aa2a86","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":45},"updated":"2017-03-23 02:05:17.000000000","message":"Am I enumerating all the arches that should use archive.ubuntu.com here? If there is not way to be certain, then maybe we should flip the logic, and specify which arches should use ports.ubuntu.com, even though there appears to be more of them?","commit_id":"a8507345c5fada9994c8ec8dc708ba0baf1d1c4e"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"626b19a3addd93e17a08664d9446a98c0be95f78","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# There are two default distro mirrors depending on architecture"},{"line_number":10,"context_line":"ARCH\u003d${ARCH:-}"},{"line_number":11,"context_line":"if [[ \"amd64 x86_64 i386\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":12,"context_line":"    default_ubuntu_mirror\u003dhttp://archive.ubuntu.com/ubuntu"},{"line_number":13,"context_line":"else"},{"line_number":14,"context_line":"    default_ubuntu_mirror\u003dhttp://ports.ubuntu.com/ubuntu-ports"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_e942f666","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":45},"in_reply_to":"1a1ced50_28117e5d","updated":"2017-03-23 14:26:56.000000000","message":"I would like to avoid regressing. Inverting the logic and listing arches that should use ports.u.c would achieve that. But if at the same time we list x86 arches explicitly and fail on unlisted ones then some users might have a regression.","commit_id":"a8507345c5fada9994c8ec8dc708ba0baf1d1c4e"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f46926bfd4bc37d1834d962d996f478087c3825f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# There are two default distro mirrors depending on architecture"},{"line_number":10,"context_line":"ARCH\u003d${ARCH:-}"},{"line_number":11,"context_line":"if [[ \"amd64 x86_64 i386\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":12,"context_line":"    default_ubuntu_mirror\u003dhttp://archive.ubuntu.com/ubuntu"},{"line_number":13,"context_line":"else"},{"line_number":14,"context_line":"    default_ubuntu_mirror\u003dhttp://ports.ubuntu.com/ubuntu-ports"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a1ced50_28117e5d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":45},"in_reply_to":"1a1ced50_45aa2a86","updated":"2017-03-23 06:35:27.000000000","message":"Yeah, even though there are more of them, I think it still probably makes sense to specifically list the architectures we know and set that to \"ports.u.c\"\n\nwe should probably error out if it\u0027s an ARCH we don\u0027t know about it.  maybe it works, maybe not, but i think we should at least go through a review before adding anything to that list where we can ask what testing is being done, etc.","commit_id":"a8507345c5fada9994c8ec8dc708ba0baf1d1c4e"}]}