)]}'
{"diskimage_builder/elements/zypper-minimal/root.d/08-zypper-chroot":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f8ae282ecb7642036daa28287a3a5b132ef3d195","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Install filesystem, base and useful tools"},{"line_number":72,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} filesystem"},{"line_number":73,"context_line":"# Install basic components in order"},{"line_number":74,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} ${DIB_OPENSUSE_PATTERNS} python zypper sudo"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Put in a dummy /etc/resolv.conf over the temporary one we used"},{"line_number":77,"context_line":"# to bootstrap.  systemd has a bug/feature [1] that it will assume"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dfeb2761_5ca2394d","line":74,"range":{"start_line":74,"start_character":104,"end_line":74,"end_character":108},"updated":"2017-04-02 05:53:33.000000000","message":"sudo zypper install sudo?\n\nIf sudo is not installed, the command will not work. So, let\u0027s remove sudo from install command - it should be in already","commit_id":"ff46cb314213c2fb48c437af7580a8b44cf78fda"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"50e475b7995de8824752ec0967eb67d3f60f39e6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Install filesystem, base and useful tools"},{"line_number":72,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} filesystem"},{"line_number":73,"context_line":"# Install basic components in order"},{"line_number":74,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} ${DIB_OPENSUSE_PATTERNS} python zypper sudo"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Put in a dummy /etc/resolv.conf over the temporary one we used"},{"line_number":77,"context_line":"# to bootstrap.  systemd has a bug/feature [1] that it will assume"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dfeb2761_bf62573d","line":74,"in_reply_to":"dfeb2761_5ca2394d","updated":"2017-04-02 08:53:46.000000000","message":"Aj, this is using the host sudo to install sudo in the chroot. Sudo is not part of the base pattern however expected to be installed by depending elements.","commit_id":"ff46cb314213c2fb48c437af7580a8b44cf78fda"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"1792446c77dd35f6fd90100d68e8cbc01079be33","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Install filesystem, base and useful tools"},{"line_number":72,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} filesystem"},{"line_number":73,"context_line":"# Install basic components in order"},{"line_number":74,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} ${DIB_OPENSUSE_PATTERNS} python zypper sudo"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Put in a dummy /etc/resolv.conf over the temporary one we used"},{"line_number":77,"context_line":"# to bootstrap.  systemd has a bug/feature [1] that it will assume"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"dfeb2761_021d6865","line":74,"in_reply_to":"dfeb2761_bf62573d","updated":"2017-04-02 09:57:28.000000000","message":"Ah, I see...","commit_id":"ff46cb314213c2fb48c437af7580a8b44cf78fda"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"71ba613f30588a7ce8c489647a2d02a57f9ccee1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Install filesystem, base and useful tools"},{"line_number":72,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} filesystem"},{"line_number":73,"context_line":"# Install basic components in order"},{"line_number":74,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} ${DIB_OPENSUSE_PATTERNS} python zypper sudo"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Put in a dummy /etc/resolv.conf over the temporary one we used"},{"line_number":77,"context_line":"# to bootstrap.  systemd has a bug/feature [1] that it will assume"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dfeb2761_a72241a3","line":74,"updated":"2017-04-03 08:26:03.000000000","message":"Ok so this was saying install \"type pattern\" base ... which is an xml file describing the base system?\n\nbut that doesn\u0027t work outside suse hosts, ok.\n\nso DIB_OPENSUSE_PATTERNS is a package, that basically depends on everything the base pattern does?\n\nIs that all right?\n\nMy only question is, why the variable here?  Is it really configurable?  If it really is, we should document it?","commit_id":"1bdeaadc95118717e2c78d41fd3540bf11c23997"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"2a865b4cf6c051b766bed48f69c2796c10fff8f3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Install filesystem, base and useful tools"},{"line_number":72,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} filesystem"},{"line_number":73,"context_line":"# Install basic components in order"},{"line_number":74,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} ${DIB_OPENSUSE_PATTERNS} python zypper sudo"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Put in a dummy /etc/resolv.conf over the temporary one we used"},{"line_number":77,"context_line":"# to bootstrap.  systemd has a bug/feature [1] that it will assume"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dfeb2761_ed226701","line":74,"in_reply_to":"dfeb2761_a72241a3","updated":"2017-04-03 10:20:18.000000000","message":"Ian, correct, pattern- package and pattern xml are the same thing going forward, and the use of pattern xml has been deprecated for newer versions, so this even makes it future proof.\n\nI made it a variable because the package name depends on the base distro, for example in SLES it is called pattern-sles-Minimal. (And no, no convenient metapackage provide that we could make use of). So an eventual support for sles at some point will need this configurability. At this point it is optional.\n\nLet me know if you want to have that part removed or documented somewhere","commit_id":"1bdeaadc95118717e2c78d41fd3540bf11c23997"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b37b233736b6a999da360585c0d82d8a0bb98569","unresolved":false,"context_lines":[{"line_number":71,"context_line":"# Install filesystem, base and useful tools"},{"line_number":72,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} filesystem"},{"line_number":73,"context_line":"# Install basic components in order"},{"line_number":74,"context_line":"sudo zypper ${ZYPPER_TARGET_OPTS} install ${ZYPPER_INSTALL_OPTS} ${DIB_OPENSUSE_PATTERNS} python zypper sudo"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Put in a dummy /etc/resolv.conf over the temporary one we used"},{"line_number":77,"context_line":"# to bootstrap.  systemd has a bug/feature [1] that it will assume"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"dfeb2761_a3233505","line":74,"in_reply_to":"dfeb2761_ed226701","updated":"2017-04-03 23:27:19.000000000","message":"Ahh, ok, so it\u0027s basically an internal option between sles/opensuse to zypper-minimal ... not really intended to be manually overridden.  \n\nmaybe it makes sense to check the var and exit sensibly if not set, though that\u0027s minor.  i don\u0027t think there\u0027s anything worth holding up","commit_id":"1bdeaadc95118717e2c78d41fd3540bf11c23997"}]}