)]}'
{"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"71ef5eb81f2ee7886628fa5057d881401f325c4c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        source /tmp/grub/install"},{"line_number":55,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":56,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":57,"context_line":"        # ToDo: which ppc distro requires grub-ieee1275, update pkg-map"},{"line_number":58,"context_line":"        # accordingly"},{"line_number":59,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":60,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_de3c45c1","line":57,"range":{"start_line":57,"start_character":10,"end_line":57,"end_character":15},"updated":"2017-04-13 19:58:15.000000000","message":"Not sure if this TODO is warranted. I think it is common sense that if distro package name does not work, a new special case needs to be added to the pkg-map. If you decide to leave that in, then please use all caps for TODO.","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3977327c11853bbdca9e7706f355116a58fd9ea5","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        source /tmp/grub/install"},{"line_number":55,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":56,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":57,"context_line":"        # ToDo: which ppc distro requires grub-ieee1275, update pkg-map"},{"line_number":58,"context_line":"        # accordingly"},{"line_number":59,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":60,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_3f677150","line":57,"range":{"start_line":57,"start_character":10,"end_line":57,"end_character":15},"in_reply_to":"7ffa3b31_de3c45c1","updated":"2017-04-17 13:20:10.000000000","message":"Added for clarity, I removed the TODO comment, as we have grub-ppc64 which is clear.","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"71ef5eb81f2ee7886628fa5057d881401f325c4c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":57,"context_line":"        # ToDo: which ppc distro requires grub-ieee1275, update pkg-map"},{"line_number":58,"context_line":"        # accordingly"},{"line_number":59,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":60,"context_line":"    else"},{"line_number":61,"context_line":"        install-packages -m bootloader grub-pc"},{"line_number":62,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_3ef20908","line":59,"range":{"start_line":59,"start_character":39,"end_line":59,"end_character":52},"updated":"2017-04-13 19:58:15.000000000","message":"Maybe we can use an arch-specific option name here? e.g. grub-ppc64. See my other comments.","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3977327c11853bbdca9e7706f355116a58fd9ea5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":57,"context_line":"        # ToDo: which ppc distro requires grub-ieee1275, update pkg-map"},{"line_number":58,"context_line":"        # accordingly"},{"line_number":59,"context_line":"        install-packages -m bootloader grub-ieee1275"},{"line_number":60,"context_line":"    else"},{"line_number":61,"context_line":"        install-packages -m bootloader grub-pc"},{"line_number":62,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_1f5cb57c","line":59,"range":{"start_line":59,"start_character":39,"end_line":59,"end_character":52},"in_reply_to":"7ffa3b31_3ef20908","updated":"2017-04-17 13:20:10.000000000","message":"Done","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5e1775184301b37b9b957c9a96287e535671f959","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    fi"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":118,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS $BOOT_DEV --no-nvram"},{"line_number":119,"context_line":"    else"},{"line_number":120,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":121,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_67ad11e8","line":118,"updated":"2017-06-26 01:06:30.000000000","message":"origin/mast has changed it\u0027s expectations here.  So this merges cleanly but doesn\u0027t work.","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f9f99fa303dc31a2e8a7a578f2b0ad167d941898","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if [ -f \"/tmp/grub/install\" ] ; then"},{"line_number":57,"context_line":"        source /tmp/grub/install"},{"line_number":58,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":59,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":60,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        install-packages -m bootloader grub-pc"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_b73217f1","line":59,"updated":"2017-06-27 00:57:21.000000000","message":"now i know the difference between ppc64le and el ... does this want a branch for the deb \u0026 rpm based sides?","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if [ -f \"/tmp/grub/install\" ] ; then"},{"line_number":57,"context_line":"        source /tmp/grub/install"},{"line_number":58,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":59,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":60,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        install-packages -m bootloader grub-pc"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_d73c1ec1","line":59,"in_reply_to":"3f1d235d_9469048d","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"309ee4333555e6931aecf1c3609e4a71ecdd4cfd","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if [ -f \"/tmp/grub/install\" ] ; then"},{"line_number":57,"context_line":"        source /tmp/grub/install"},{"line_number":58,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":59,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":60,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        install-packages -m bootloader grub-pc"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_96714a79","line":59,"in_reply_to":"5f201791_ab3d0b90","updated":"2017-06-27 13:07:47.000000000","message":"I believe that ppc64 64-bit and powerpc 32-bit (both Big-Endian) may work but the trend is that Linux KVM on Power users will run ppc64le (Little-Endian), which is the standard supported bitness mode.","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"4d8952c190d1baec8421f9b682292b6a660822db","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if [ -f \"/tmp/grub/install\" ] ; then"},{"line_number":57,"context_line":"        source /tmp/grub/install"},{"line_number":58,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":59,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":60,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        install-packages -m bootloader grub-pc"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_ea33dd12","line":59,"in_reply_to":"5f201791_ab3d0b90","updated":"2017-06-27 21:08:41.000000000","message":"The reason why this is not fully relying on pkg-map is that pkg-map does not support arch branching, it only supports distro branching. I think this is a good compromise to leave part of it in pkg-map. Otherwise it is ugly indeed. The proper solution would be to add arch branching support to pkg-map, but not sure how easy that is.","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d468e6760086b96fff5efc1b3a80c455da93478d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if [ -f \"/tmp/grub/install\" ] ; then"},{"line_number":57,"context_line":"        source /tmp/grub/install"},{"line_number":58,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":59,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":60,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        install-packages -m bootloader grub-pc"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_ab3d0b90","line":59,"in_reply_to":"5f201791_b73217f1","updated":"2017-06-27 05:48:55.000000000","message":"So I think we\u0027re cheating a little and using the bash to do the  broad package selection (grub-pc vs grub-ppc64) and then using pkg-map to so the rpm / deb selection grub-ieee1275 vs grub-tools+grub2.\n\nWe could do something like:\n\n # Select bootloader based on distro and architecture\n if [[ $DISTRO_NAME \u003d \"ubuntu\" || $DISTRO_NAME \u003d \"debian\" ]]; then\n     if [[ \"$ARCH\" \u003d~ \u0027ppc\u0027 ]] ; then\n         install-packages -m bootloader grub-ieee1275\n     else\n         install-packages -m bootloader grub-pc\n     fi\n else\n     install-packages -m bootloader grub-pc\n fi\n\nbut I\u0027m not sure that\u0027s much better?\n\nAs an aside I\u0027m not certain that that \u0027ppc\u0027 check is correct as it\u0027ll match 32-bit powerpc and I don\u0027t think that works with grub.","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    if [ -f \"/tmp/grub/install\" ] ; then"},{"line_number":57,"context_line":"        source /tmp/grub/install"},{"line_number":58,"context_line":"    elif [[ \"$ARCH\" \u003d~ \"ppc\" ]]; then"},{"line_number":59,"context_line":"        # Centos/Redhat does not have any grub-ieee1275 rather they use grub2"},{"line_number":60,"context_line":"        install-packages -m bootloader grub-ppc64"},{"line_number":61,"context_line":"    else"},{"line_number":62,"context_line":"        install-packages -m bootloader grub-pc"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_9469048d","line":59,"in_reply_to":"5f201791_ea33dd12","updated":"2017-06-29 04:45:39.000000000","message":"Ahhh!  indeed.  i think a better comment here also might explain this, that \"grub-ppc64\" is a virtual package to paper over the differences and see pkg-map.\n\nas for adding in archiecture to pkg-map -- i think we could; \"package-installs\" has it already and we could follow a similar pattern.  good follow-on but not a requirement for this change.","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f9f99fa303dc31a2e8a7a578f2b0ad167d941898","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":125,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":126,"context_line":"        # but requires some more investigation."},{"line_number":127,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"},{"line_number":128,"context_line":"    else"},{"line_number":129,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":130,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_57a183f7","line":127,"updated":"2017-06-27 00:57:21.000000000","message":"presumably both install in the same way here?  i would also like to see this comment updated to specifically say it\u0027s a common path for le/el distros","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"309ee4333555e6931aecf1c3609e4a71ecdd4cfd","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":125,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":126,"context_line":"        # but requires some more investigation."},{"line_number":127,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"},{"line_number":128,"context_line":"    else"},{"line_number":129,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":130,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_16f65a64","line":127,"in_reply_to":"5f201791_0b52bfde","updated":"2017-06-27 13:07:47.000000000","message":"Just for the record: From what I could verify, grub requires /dev/mapper for 2.02~beta2 (available in Xenial and Yakkety). Starting from 2.02~beta3 (Zesty), grub-install works fine on /dev/loopXpN directly, no need to use /dev/mapper. I\u0027ve manually built grub from source and verified each version. I did this test for https://review.openstack.org/#/c/471525/.","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a927a52f1b6540ccf65b873cb129d7a3840df744","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":125,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":126,"context_line":"        # but requires some more investigation."},{"line_number":127,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"},{"line_number":128,"context_line":"    else"},{"line_number":129,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":130,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_c701376c","line":127,"in_reply_to":"5f201791_16f65a64","updated":"2017-06-27 23:41:03.000000000","message":"Thanks.  I\u0027ll update the comment to include that information with the next re-spin.","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d468e6760086b96fff5efc1b3a80c455da93478d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":125,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":126,"context_line":"        # but requires some more investigation."},{"line_number":127,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"},{"line_number":128,"context_line":"    else"},{"line_number":129,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":130,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_0b52bfde","line":127,"in_reply_to":"5f201791_57a183f7","updated":"2017-06-27 05:48:55.000000000","message":"So I can confirm that ppc64 (BE and LE) both use this setup (a prep partition) but I can\u0027t comment about the spececifics of grub wanting /dev/mapper nodes.\n\nSo would s/PPC/PPC (64-Bit regardless of Endian-ness)/ basically be what you\u0027re looking for?","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":125,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":126,"context_line":"        # but requires some more investigation."},{"line_number":127,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"},{"line_number":128,"context_line":"    else"},{"line_number":129,"context_line":"        $GRUBNAME --modules\u003d\"biosdisk part_msdos\" $GRUB_OPTS $BOOT_DEV"},{"line_number":130,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_b749a261","line":127,"in_reply_to":"5f201791_c701376c","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"}],"diskimage_builder/elements/bootloader/pkg-map":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"71ef5eb81f2ee7886628fa5057d881401f325c4c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"redhat\": {"},{"line_number":13,"context_line":"      \"extlinux\": \"syslinux-extlinux\","},{"line_number":14,"context_line":"      \"grub-pc\": \"grub2-tools grub2\","},{"line_number":15,"context_line":"      \"grub-ieee1275\": \"grub2-tools grub2\""},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"  },"},{"line_number":18,"context_line":"  \"default\": {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9ff52f3f_efaa8d83","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":42},"updated":"2017-04-13 19:58:15.000000000","message":"If instead of introducing arch variant support to pkg-map itself we end up using special name of package would it be better to specifically name it as grub-ppc64 (or grub-ppc64el) so it is more explicit? Then this can be changed into:\n\n    \"grub-ppc64\": \"grub2-tools grub2\"","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3977327c11853bbdca9e7706f355116a58fd9ea5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"redhat\": {"},{"line_number":13,"context_line":"      \"extlinux\": \"syslinux-extlinux\","},{"line_number":14,"context_line":"      \"grub-pc\": \"grub2-tools grub2\","},{"line_number":15,"context_line":"      \"grub-ieee1275\": \"grub2-tools grub2\""},{"line_number":16,"context_line":"    }"},{"line_number":17,"context_line":"  },"},{"line_number":18,"context_line":"  \"default\": {"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7ffa3b31_bfe38105","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":42},"in_reply_to":"9ff52f3f_efaa8d83","updated":"2017-04-17 13:20:10.000000000","message":"yeah that would be a good option,","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"71ef5eb81f2ee7886628fa5057d881401f325c4c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \"dkms_package\": \"dkms\","},{"line_number":20,"context_line":"    \"extlinux\": \"extlinux\","},{"line_number":21,"context_line":"    \"grub-pc\": \"grub-pc\","},{"line_number":22,"context_line":"    \"grub-ieee1275\": \"grub-ieee1275\""},{"line_number":23,"context_line":"  }"},{"line_number":24,"context_line":"}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9ff52f3f_8f7ae121","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":36},"updated":"2017-04-13 19:58:15.000000000","message":"same as above:\n\n    \"grub-ppc64\": \"grub-ieee1275\"","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"}],"diskimage_builder/elements/centos7/README.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DIB_CLOUD_IMAGES"},{"line_number":17,"context_line":"  :Required: No"},{"line_number":18,"context_line":"  :Default: http://cloud.centos.org/altarch/7/images/${ARCH}"},{"line_number":19,"context_line":"  :Description: Set the desired URL to fetch the images from.  ppc64le:"},{"line_number":20,"context_line":"                Currently the CentOS community is working on providing the"},{"line_number":21,"context_line":"                ppc64le images until then you\u0027ll need to set this to a local"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_b42080f9","line":18,"updated":"2017-06-29 04:45:39.000000000","message":"I\u0027d say\n\n :Default: architecture specific\n\nor something ... or just leave it out probably","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DIB_CLOUD_IMAGES"},{"line_number":17,"context_line":"  :Required: No"},{"line_number":18,"context_line":"  :Default: http://cloud.centos.org/altarch/7/images/${ARCH}"},{"line_number":19,"context_line":"  :Description: Set the desired URL to fetch the images from.  ppc64le:"},{"line_number":20,"context_line":"                Currently the CentOS community is working on providing the"},{"line_number":21,"context_line":"                ppc64le images until then you\u0027ll need to set this to a local"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f1d235d_77e8aa15","line":18,"in_reply_to":"3f1d235d_b42080f9","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"}],"diskimage_builder/elements/centos7/root.d/10-centos7-cloud-image":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"71ef5eb81f2ee7886628fa5057d881401f325c4c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"},{"line_number":22,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9ff52f3f_0f0b718e","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":18},"updated":"2017-04-13 19:58:15.000000000","message":"This makes ppc64, ppc64el, and ppc64le all be ppc64. Is that intentional?","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"3977327c11853bbdca9e7706f355116a58fd9ea5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"},{"line_number":22,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_ff88e91f","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":18},"in_reply_to":"9ff52f3f_0f0b718e","updated":"2017-04-17 13:20:10.000000000","message":"I verified only on ppc64le, so if the repos are at different location it might break.","commit_id":"d1f5fe453d410d9af633f5bfe4e3890a77ed1d93"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"304444dd2c5a65a871cc966a7ac4754584886d49","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"},{"line_number":22,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7ffa3b31_fc4fc9ba","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":18},"updated":"2017-04-17 21:38:45.000000000","message":"I missed it in the last review - why is this case differnt from the two above? Should there also be DIB_CLOUD_IMAGES variable defined?","commit_id":"b0da65dfccd3792be35bdabd5881b06ab5dc71df"},{"author":{"_account_id":8662,"name":"Kyle L. Henderson","email":"kyleh@us.ibm.com","username":"kyleh"},"change_message_id":"d1b4903cdabef577160cd430e1b2ff0e4059d954","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"},{"line_number":22,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7ffa3b31_415e7076","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":18},"in_reply_to":"7ffa3b31_712602d1","updated":"2017-04-20 13:48:57.000000000","message":"Chhavi, I think the comment is really: why isn\u0027t the if statement like this:\n\nelif [[ \"ppc64 ppc64le\" \u003d~ \"$ARCH\" ]]; then\n    ARCH\u003d\"ppc64le\"\nelse \n...\n\nIt would also be good to add a note to the \u0027if\u0027 that DIB_CLOUD_IMAGES must be specified manually because ppc64le images are not hosted by centos.","commit_id":"b0da65dfccd3792be35bdabd5881b06ab5dc71df"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"512a9d0ecb8c69b5feb1dd71a2a41283f69778aa","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"},{"line_number":22,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"7ffa3b31_712602d1","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":18},"in_reply_to":"7ffa3b31_fc4fc9ba","updated":"2017-04-19 14:52:05.000000000","message":"yes in this case user need to define the DIB_CLOUD_IMAGES build manually","commit_id":"b0da65dfccd3792be35bdabd5881b06ab5dc71df"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"97fd68fe2052d3039cf70eb67c64dd68324d3042","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    # For ppc64 architecture since the images are not hosted on the cloude, manually"},{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_9c70c4a7","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":24},"updated":"2017-06-22 13:33:46.000000000","message":"following the standard above, this should be:\n\"ppc64 ppc64el ppc64le\" \u003d~ \"$ARCH\"\nso we handle nuances around arch.\n# ARCH\u003d$(uname -m); if [[ \"ppc64 ppc64le ppc64el\" \u003d~ \"$ARCH\" ]]; then echo \"You\u0027ve got the POWAH!\"; fi\nYou\u0027ve got the POWAH!","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5e1775184301b37b9b957c9a96287e535671f959","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    # For ppc64 architecture since the images are not hosted on the cloude, manually"},{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_441ebc70","line":18,"range":{"start_line":18,"start_character":8,"end_line":18,"end_character":24},"in_reply_to":"5f201791_9c70c4a7","updated":"2017-06-26 01:06:30.000000000","message":"Actually I think \"ppc64le\" \u003d~ $ARCH is correct.  ppc64el is a debian/ubuntu architecture name and here we\u0027re clearly talking about Centos which to the best of my understanding has no concept of ppc64el","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"f10d6d20fe35235a0a0dc2e4361568ef06a722de","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    # For ppc64 architecture since the images are not hosted on the cloude, manually"},{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":22,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_277094a5","line":19,"updated":"2017-06-21 18:21:31.000000000","message":"s/cloude/cloud/","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5e1775184301b37b9b957c9a96287e535671f959","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    # For ppc64 architecture since the images are not hosted on the cloude, manually"},{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":22,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_2415004b","line":19,"in_reply_to":"5f201791_277094a5","updated":"2017-06-26 01:06:30.000000000","message":"+1","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"97fd68fe2052d3039cf70eb67c64dd68324d3042","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    # For ppc64 architecture since the images are not hosted on the cloude, manually"},{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_49ff0c34","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":33},"updated":"2017-06-22 13:33:46.000000000","message":"Currently there is no CentOS ppc64le *official* images. The \"non-official\" builds can be found here: http://ftp.unicamp.br/pub/ppc64el/centos/7/images/.\nApparently there are 2 pending PRs:\n1) https://github.com/CentOS/sig-cloud-instance-build/pull/94\n2) https://github.com/CentOS/sig-cloud-instance-build/pull/95","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5e1775184301b37b9b957c9a96287e535671f959","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ $ARCH \u003d~ \"ppc64\" ]]; then"},{"line_number":19,"context_line":"    # For ppc64 architecture since the images are not hosted on the cloude, manually"},{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_a408f02b","line":20,"range":{"start_line":20,"start_character":17,"end_line":20,"end_character":33},"in_reply_to":"5f201791_49ff0c34","updated":"2017-06-26 01:06:30.000000000","message":"I think leaving DIB_CLOUD_IMAGES unset isand calling it out in ther README is the correct thing to do.  Once we have official CentOS images we can add a defult location.","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"f10d6d20fe35235a0a0dc2e4361568ef06a722de","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_e7697cbe","line":23,"updated":"2017-06-21 18:21:31.000000000","message":"This needs extension.","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5e1775184301b37b9b957c9a96287e535671f959","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    # define the DIB_CLOUD_IMAGES"},{"line_number":21,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":22,"context_line":"else"},{"line_number":23,"context_line":"    echo \u0027centos7 root element only support the x86_64 and aarch64 $ARCH value.\u0027"},{"line_number":24,"context_line":"    exit 1"},{"line_number":25,"context_line":"fi"},{"line_number":26,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_8403b40f","line":23,"in_reply_to":"5f201791_e7697cbe","updated":"2017-06-26 01:06:30.000000000","message":"+1","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/centos/7/images}"},{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ \"ppc64le\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_3434704a","line":16,"updated":"2017-06-29 04:45:39.000000000","message":"now i look at this, can we have even got this far with \"aarch64\" after the gating done in common-defaults?","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    ARCH\u003d\"x86_64\""},{"line_number":14,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/centos/7/images}"},{"line_number":15,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ \"ppc64le\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_97c5865e","line":16,"in_reply_to":"3f1d235d_3434704a","updated":"2017-06-29 05:52:45.000000000","message":"It\u0027s strange but I think we can get here.\n\nwe come into common-defaults with ARCH\u003daarch64, which gets standardised to arm64.  So when we get here we match either and then switch back to aarch64.  We don\u0027t export ARCH so I think at that point ARCH\u003daarch64 is just used for the lifetime of this subshell?\n\nAnyway something for someone with aarch64 hardware to resolve","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ \"ppc64le\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":20,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/ppc64le}"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    echo \u0027centos7 root element only support the x86_64, aarch64 and ppc64le values for $ARCH\u0027"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_f4f8387d","line":19,"updated":"2017-06-29 04:45:39.000000000","message":"doesn\u0027t seem necessary since we don\u0027t override it","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    ARCH\u003d\"aarch64\""},{"line_number":17,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/aarch64}"},{"line_number":18,"context_line":"elif [[ \"ppc64le\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":19,"context_line":"    ARCH\u003d\"ppc64le\""},{"line_number":20,"context_line":"    DIB_CLOUD_IMAGES\u003d${DIB_CLOUD_IMAGES:-http://cloud.centos.org/altarch/7/images/ppc64le}"},{"line_number":21,"context_line":"else"},{"line_number":22,"context_line":"    echo \u0027centos7 root element only support the x86_64, aarch64 and ppc64le values for $ARCH\u0027"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_17f736f8","line":19,"in_reply_to":"3f1d235d_f4f8387d","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"}],"diskimage_builder/elements/rpm-distro/pre-install.d/01-override-yum-arch":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5e1775184301b37b9b957c9a96287e535671f959","unresolved":false,"context_lines":[{"line_number":15,"context_line":"elif [[ \"$ARCH\" \u003d \"ppc64\" ]]; then"},{"line_number":16,"context_line":"    basearch\u003dppc64"},{"line_number":17,"context_line":"    arch\u003dppc64"},{"line_number":18,"context_line":"elif [[ \"$ARCH\" \u003d \"ppc64el\" ]]; then"},{"line_number":19,"context_line":"    basearch\u003dppc64el"},{"line_number":20,"context_line":"    arch\u003dppc64el"},{"line_number":21,"context_line":"elif [[ \"$ARCH\" \u003d \"ppc64le\" ]]; then"},{"line_number":22,"context_line":"    basearch\u003dppc64le"},{"line_number":23,"context_line":"    arch\u003dppc64le"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f201791_47035e0e","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":16},"updated":"2017-06-26 01:06:30.000000000","message":"Remove this.  ppc64el makes no sense in the context of an RPM based distribution.","commit_id":"8c9095b655b071865054b3d356be0aa302fdf034"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f9f99fa303dc31a2e8a7a578f2b0ad167d941898","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    arch\u003dppc64"},{"line_number":18,"context_line":"elif [[ \"$ARCH\" \u003d \"ppc64le\" ]]; then"},{"line_number":19,"context_line":"    basearch\u003dppc64le"},{"line_number":20,"context_line":"    arch\u003dppc64le"},{"line_number":21,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":22,"context_line":"    basearch\u003daarch64"},{"line_number":23,"context_line":"    arch\u003daarch64"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_577ce381","line":20,"updated":"2017-06-27 00:57:21.000000000","message":"So this came in as \"el\" with Iba03226e187609df898732c13b1aa5f895b156e3 in 2015 ... i think fedora switched in the mean-time?  does that make sense?","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    arch\u003dppc64"},{"line_number":18,"context_line":"elif [[ \"$ARCH\" \u003d \"ppc64le\" ]]; then"},{"line_number":19,"context_line":"    basearch\u003dppc64le"},{"line_number":20,"context_line":"    arch\u003dppc64le"},{"line_number":21,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":22,"context_line":"    basearch\u003daarch64"},{"line_number":23,"context_line":"    arch\u003daarch64"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_d4f41cd2","line":20,"in_reply_to":"5f201791_00df3ed6","updated":"2017-06-29 04:45:39.000000000","message":"++ so always just wrong; lgtm","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d468e6760086b96fff5efc1b3a80c455da93478d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    arch\u003dppc64"},{"line_number":18,"context_line":"elif [[ \"$ARCH\" \u003d \"ppc64le\" ]]; then"},{"line_number":19,"context_line":"    basearch\u003dppc64le"},{"line_number":20,"context_line":"    arch\u003dppc64le"},{"line_number":21,"context_line":"elif [[ \"arm64 aarch64\" \u003d~ \"$ARCH\" ]]; then"},{"line_number":22,"context_line":"    basearch\u003daarch64"},{"line_number":23,"context_line":"    arch\u003daarch64"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_00df3ed6","line":20,"in_reply_to":"5f201791_577ce381","updated":"2017-06-27 05:48:55.000000000","message":"Nope it was just plain wrong AFAICT.  rpm only supports ppc64le[1][2]  And the initial secondary architecture for Fedora was ppc64le [3]\n\n[1] https://github.com/rpm-software-management/rpm/blob/cf07feda05822377d62b973adc4010c0d7f9eaa0/installplatform#L63-L68\n[2] https://github.com/rpm-software-management/rpm/commit/cf07feda05822377d62b973adc4010c0d7f9eaa0\n[3] https://lists.fedoraproject.org/pipermail/secondary/2013-October/002628.html","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"}],"diskimage_builder/lib/common-defaults":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# options for create-baremetal-image.sh"},{"line_number":18,"context_line":"if [ -f /etc/debian_version ]; then"},{"line_number":19,"context_line":"  _ARCH\u003d$(dpkg --print-architecture)"},{"line_number":20,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_548ecc2e","line":17,"updated":"2017-06-29 04:45:39.000000000","message":"old comment?  remove","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# options for create-baremetal-image.sh"},{"line_number":18,"context_line":"if [ -f /etc/debian_version ]; then"},{"line_number":19,"context_line":"  _ARCH\u003d$(dpkg --print-architecture)"},{"line_number":20,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_772aeae7","line":17,"in_reply_to":"3f1d235d_548ecc2e","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  _ARCH\u003d$(dpkg --print-architecture)"},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"  _ARCH\u003d$(uname -m)"},{"line_number":22,"context_line":"  case $_ARCH in"},{"line_number":23,"context_line":"    \"x86_64\")"},{"line_number":24,"context_line":"      _ARCH\u003d\"amd64\""},{"line_number":25,"context_line":"      ;;"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_d479bc2f","line":22,"updated":"2017-06-29 04:45:39.000000000","message":"put a comment in here that we\u0027re standardising things that are really the same","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  _ARCH\u003d$(dpkg --print-architecture)"},{"line_number":20,"context_line":"else"},{"line_number":21,"context_line":"  _ARCH\u003d$(uname -m)"},{"line_number":22,"context_line":"  case $_ARCH in"},{"line_number":23,"context_line":"    \"x86_64\")"},{"line_number":24,"context_line":"      _ARCH\u003d\"amd64\""},{"line_number":25,"context_line":"      ;;"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_572feef5","line":22,"in_reply_to":"3f1d235d_d479bc2f","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f9f99fa303dc31a2e8a7a578f2b0ad167d941898","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      ;;"},{"line_number":32,"context_line":"    \"ppc64le\")"},{"line_number":33,"context_line":"      _ARCH\u003d\"ppc64le\""},{"line_number":34,"context_line":"      ;;"},{"line_number":35,"context_line":"    *)"},{"line_number":36,"context_line":"      echo \"WARNING: Unknown architecture: $_ARCH\""},{"line_number":37,"context_line":"      ;;"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_d767d3e8","line":34,"updated":"2017-06-27 00:57:21.000000000","message":"is this really necessary?  the output of \"uname -m\" is correct in this case?  we only need this switch if we\u0027re modifying it?\n\n(adding a comment here would probably not hurt anyway)","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      ;;"},{"line_number":32,"context_line":"    \"ppc64le\")"},{"line_number":33,"context_line":"      _ARCH\u003d\"ppc64le\""},{"line_number":34,"context_line":"      ;;"},{"line_number":35,"context_line":"    *)"},{"line_number":36,"context_line":"      echo \"WARNING: Unknown architecture: $_ARCH\""},{"line_number":37,"context_line":"      ;;"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_d73ade32","line":34,"in_reply_to":"5f201791_40ce5682","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"d468e6760086b96fff5efc1b3a80c455da93478d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      ;;"},{"line_number":32,"context_line":"    \"ppc64le\")"},{"line_number":33,"context_line":"      _ARCH\u003d\"ppc64le\""},{"line_number":34,"context_line":"      ;;"},{"line_number":35,"context_line":"    *)"},{"line_number":36,"context_line":"      echo \"WARNING: Unknown architecture: $_ARCH\""},{"line_number":37,"context_line":"      ;;"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5f201791_40ce5682","line":34,"in_reply_to":"5f201791_d767d3e8","updated":"2017-06-27 05:48:55.000000000","message":"Okay I added this because when was seeing \"WARNING: Unknown architecture: ppc64le\" when I while I was checking things.\n\nI know the warning doesn\u0027t really mean very much but I just wanted to avoid it.\n\nHappy to drop this change or look at an alternate change as you think is best.","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      _ARCH\u003d\"ppc64le\""},{"line_number":34,"context_line":"      ;;"},{"line_number":35,"context_line":"    *)"},{"line_number":36,"context_line":"      echo \"WARNING: Unknown architecture: $_ARCH\""},{"line_number":37,"context_line":"      ;;"},{"line_number":38,"context_line":"  esac"},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_d4c77c45","line":36,"updated":"2017-06-29 04:45:39.000000000","message":"i think just drop this","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      _ARCH\u003d\"ppc64le\""},{"line_number":34,"context_line":"      ;;"},{"line_number":35,"context_line":"    *)"},{"line_number":36,"context_line":"      echo \"WARNING: Unknown architecture: $_ARCH\""},{"line_number":37,"context_line":"      ;;"},{"line_number":38,"context_line":"  esac"},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_17397640","line":36,"in_reply_to":"3f1d235d_d4c77c45","updated":"2017-06-29 05:52:45.000000000","message":"Done","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ee89bb8d7af259b5c72e0cb3d30e7e5987495545","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      ;;"},{"line_number":38,"context_line":"  esac"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":"ARCH\u003d${ARCH:-$_ARCH}"},{"line_number":41,"context_line":"export ARCH"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"export DIB_CHECKSUM\u003d${DIB_CHECKSUM:-0}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_b4d9a023","line":40,"updated":"2017-06-29 04:45:39.000000000","message":"a white-list of ARCH\u0027s that work might be good here; if you specify something not known to work it\u0027s probably just going to cause much more obscure problems later on.  follow-on if you like","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"5cc622824aebd2793ff16dcf552f5a09acf14ea8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      ;;"},{"line_number":38,"context_line":"  esac"},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":"ARCH\u003d${ARCH:-$_ARCH}"},{"line_number":41,"context_line":"export ARCH"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"export DIB_CHECKSUM\u003d${DIB_CHECKSUM:-0}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_370d9290","line":40,"in_reply_to":"3f1d235d_b4d9a023","updated":"2017-06-29 05:52:45.000000000","message":"I\u0027ll do that in a follow-up","commit_id":"47c28f1fd421f759b4b72d9c2a1c70dcdb4b3cea"}]}