)]}'
{"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"47acf04a96878f42bca6b1f3e2e45fb707345b88","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    dib-block-device --phase\u003dinit ..."},{"line_number":70,"context_line":"    # From that point the database can be queried, like"},{"line_number":71,"context_line":"    ROOT_LABEL\u003d$(dib-block-device --phase\u003dgetval --symbol\u003droot-label ...)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    dib-block-device --phase\u003dcreate ..."},{"line_number":74,"context_line":"    trap \"dib-block-device --phase\u003ddelete ...\" EXIT"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_b75f580d","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":14},"updated":"2017-04-22 08:09:25.000000000","message":"this need to be refactored in next patchsets, to be accessible outside the chroot. So you could add a comment now, that you can only access this command inside chroot currently.","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"d46633178965b45ecd627f39d39e5fd44827cb36","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    dib-block-device --phase\u003dinit ..."},{"line_number":70,"context_line":"    # From that point the database can be queried, like"},{"line_number":71,"context_line":"    ROOT_LABEL\u003d$(dib-block-device --phase\u003dgetval --symbol\u003droot-label ...)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    dib-block-device --phase\u003dcreate ..."},{"line_number":74,"context_line":"    trap \"dib-block-device --phase\u003ddelete ...\" EXIT"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_1c03cc44","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":14},"in_reply_to":"5ff73747_b75f580d","updated":"2017-04-23 07:26:09.000000000","message":"Done","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"47acf04a96878f42bca6b1f3e2e45fb707345b88","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        if self.params[\u0027root-label\u0027] is not None:"},{"line_number":106,"context_line":"                            v[\u0027label\u0027] \u003d self.params[\u0027root-label\u0027]"},{"line_number":107,"context_line":"                        else:"},{"line_number":108,"context_line":"                            v[\u0027label\u0027] \u003d \"cloudimg-rootfs\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @staticmethod"},{"line_number":111,"context_line":"    def _load_json(file_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_57a49408","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":36},"updated":"2017-04-22 08:09:25.000000000","message":"you could also check the filesystem here , and if it\u0027s xfs, set the right label, that is shorter? i know that this is done later, but it could be done here for sanity as well","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"d46633178965b45ecd627f39d39e5fd44827cb36","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        if self.params[\u0027root-label\u0027] is not None:"},{"line_number":106,"context_line":"                            v[\u0027label\u0027] \u003d self.params[\u0027root-label\u0027]"},{"line_number":107,"context_line":"                        else:"},{"line_number":108,"context_line":"                            v[\u0027label\u0027] \u003d \"cloudimg-rootfs\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @staticmethod"},{"line_number":111,"context_line":"    def _load_json(file_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_fc84a0b3","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":36},"in_reply_to":"5ff73747_57a49408","updated":"2017-04-23 07:26:09.000000000","message":"The problem doing it here will add some additional effort: It is not possible to add just another test here, because the label might be set before the fs-type.  Therefore a complete \u0027second\u0027 run through the loops is needed to just check this thing - that is already done later.","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"47acf04a96878f42bca6b1f3e2e45fb707345b88","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                            v[\u0027label\u0027] \u003d \"cloudimg-rootfs\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @staticmethod"},{"line_number":111,"context_line":"    def _load_json(file_name):"},{"line_number":112,"context_line":"        if os.path.exists(file_name):"},{"line_number":113,"context_line":"            with codecs.open(file_name, encoding\u003d\"utf-8\", mode\u003d\"r\") as fd:"},{"line_number":114,"context_line":"                return json.load(fd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_17ae0ce7","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":18},"updated":"2017-04-22 08:09:25.000000000","message":"yaml safe_load could also be used to parse a json right? why not use that?","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"d46633178965b45ecd627f39d39e5fd44827cb36","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                            v[\u0027label\u0027] \u003d \"cloudimg-rootfs\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    @staticmethod"},{"line_number":111,"context_line":"    def _load_json(file_name):"},{"line_number":112,"context_line":"        if os.path.exists(file_name):"},{"line_number":113,"context_line":"            with codecs.open(file_name, encoding\u003d\"utf-8\", mode\u003d\"r\") as fd:"},{"line_number":114,"context_line":"                return json.load(fd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_3cbc4868","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":18},"in_reply_to":"5ff73747_17ae0ce7","updated":"2017-04-23 07:26:09.000000000","message":"Because this is only internal configuration - that is saved in line 149.","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"}],"diskimage_builder/lib/common-functions":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"47acf04a96878f42bca6b1f3e2e45fb707345b88","unresolved":false,"context_lines":[{"line_number":402,"context_line":"      mount:"},{"line_number":403,"context_line":"        mount_point: /"},{"line_number":404,"context_line":"        fstab:"},{"line_number":405,"context_line":"          options: \"errors\u003dremount-ro\""},{"line_number":406,"context_line":"          fsck-passno: 1"},{"line_number":407,"context_line":"EOF"},{"line_number":408,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_7788b070","line":405,"range":{"start_line":405,"start_character":10,"end_line":405,"end_character":17},"updated":"2017-04-22 08:09:25.000000000","message":"errors\u003dremount-ro, will not work in XFS environments, not supported. So if someone passes FS_TYPE\u003dxfs, and uses this default , it will crash","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"183bfe5f1ab822660265f7eda63f33d50ae5707d","unresolved":false,"context_lines":[{"line_number":402,"context_line":"      mount:"},{"line_number":403,"context_line":"        mount_point: /"},{"line_number":404,"context_line":"        fstab:"},{"line_number":405,"context_line":"          options: \"errors\u003dremount-ro\""},{"line_number":406,"context_line":"          fsck-passno: 1"},{"line_number":407,"context_line":"EOF"},{"line_number":408,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_9f4c6e77","line":405,"range":{"start_line":405,"start_character":10,"end_line":405,"end_character":17},"in_reply_to":"5ff73747_3c71e8e1","updated":"2017-04-23 08:16:47.000000000","message":"Why not just \"defaults\" , so it just picks the defaults for each filesystem?","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"d46633178965b45ecd627f39d39e5fd44827cb36","unresolved":false,"context_lines":[{"line_number":402,"context_line":"      mount:"},{"line_number":403,"context_line":"        mount_point: /"},{"line_number":404,"context_line":"        fstab:"},{"line_number":405,"context_line":"          options: \"errors\u003dremount-ro\""},{"line_number":406,"context_line":"          fsck-passno: 1"},{"line_number":407,"context_line":"EOF"},{"line_number":408,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_3c71e8e1","line":405,"range":{"start_line":405,"start_character":10,"end_line":405,"end_character":17},"in_reply_to":"5ff73747_7788b070","updated":"2017-04-23 07:26:09.000000000","message":"This is just a copy of the existing implementation (see e.g. elements/debootstrap/install.d/15-cleanup-debootstrap). So what do you think is an appropriate default?","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"4944919eb9b5d63d7f7d4ca4ffbbc88a2ffcf5fc","unresolved":false,"context_lines":[{"line_number":402,"context_line":"      mount:"},{"line_number":403,"context_line":"        mount_point: /"},{"line_number":404,"context_line":"        fstab:"},{"line_number":405,"context_line":"          options: \"errors\u003dremount-ro\""},{"line_number":406,"context_line":"          fsck-passno: 1"},{"line_number":407,"context_line":"EOF"},{"line_number":408,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_bffe0aac","line":405,"range":{"start_line":405,"start_character":10,"end_line":405,"end_character":17},"in_reply_to":"5ff73747_9f4c6e77","updated":"2017-04-23 09:52:59.000000000","message":"Done","commit_id":"7cce2cb1399e9b7a3f097368d37baf45859f8119"}]}