)]}'
{"diskimage_builder/lib/common-functions":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"3b6de7b92c9262f08d7af1dd4f3140c24e6d78fc","unresolved":false,"context_lines":[{"line_number":339,"context_line":"# Recursively unmount directories under a given directory DIR"},{"line_number":340,"context_line":"# usage:"},{"line_number":341,"context_line":"#  unmount_dir DIR"},{"line_number":342,"context_line":"function unmount_dir {"},{"line_number":343,"context_line":"    local dir\u003d\"$1\""},{"line_number":344,"context_line":"    local real_dir"},{"line_number":345,"context_line":"    local mnts"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f013ff3_e0216a4f","line":342,"updated":"2017-05-16 05:35:08.000000000","message":"why do we do this here at all?  shouldn\u0027t it all be under the control of dib-block-device now?","commit_id":"827ffdd2b6a223cdcbd90187c1a9059176fc92e4"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"4618642022d72e817ba70548d3b9ebdd6bb909c8","unresolved":false,"context_lines":[{"line_number":339,"context_line":"# Recursively unmount directories under a given directory DIR"},{"line_number":340,"context_line":"# usage:"},{"line_number":341,"context_line":"#  unmount_dir DIR"},{"line_number":342,"context_line":"function unmount_dir {"},{"line_number":343,"context_line":"    local dir\u003d\"$1\""},{"line_number":344,"context_line":"    local real_dir"},{"line_number":345,"context_line":"    local mnts"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1f013ff3_60067a89","line":342,"in_reply_to":"1f013ff3_e0216a4f","updated":"2017-05-16 05:53:41.000000000","message":"What would be the consequences of dropping it? I think this can cause problems for the images that are just flat, and not managed by block device?","commit_id":"827ffdd2b6a223cdcbd90187c1a9059176fc92e4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"224fad5dfb3f5388be3daf8fbc6b45dbb77d277d","unresolved":false,"context_lines":[{"line_number":354,"context_line":"    real_dir\u003d$(readlink -e $dir)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    # populate the exported mountpoints"},{"line_number":357,"context_line":"    IFS\u003d\u0027|\u0027 read -ra SPLIT_MOUNTS \u003c\u003c\u003c \"$DIB_MOUNTPOINTS\""},{"line_number":358,"context_line":""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    # note the \"/\" on real_dir ... we are just looking for things"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f013ff3_a7d2335b","line":357,"updated":"2017-05-17 06:10:10.000000000","message":"nit; since we\u0027re in a function, can we use locals please (lower case names)","commit_id":"520bad0e5aa2d996dd3dc31e0857e7219cdbec35"}]}