)]}'
{"diskimage_builder/elements/manifests/cleanup.d/01-copy-manifests-dir":[{"author":{"_account_id":26008,"name":"Bogdan Katynski","email":"bogdan.katynski@workday.com","username":"bodgix"},"change_message_id":"41819ab276e058db7911a54893111c1ccf53137c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"cp --no-preserve\u003downership -rv ${MANIFEST_IMAGE_PATH} ${DIB_MANIFEST_SAVE_DIR}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# may contain passwords, etc, so limit permissions"},{"line_number":39,"context_line":"find ${DIB_MANIFEST_SAVE_DIR} -type f | xargs sudo chown root:root # dib-lint: safe_sudo"},{"line_number":40,"context_line":"find ${DIB_MANIFEST_SAVE_DIR} -type f | xargs sudo chmod 600 # dib-lint: safe_sudo"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_cecb2e51","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":82},"updated":"2017-05-18 19:40:48.000000000","message":"Might not be a big concern in this case, but these commands would not change the owner and perms on files whose name contains spaces.\n\n  vagrant@vagrant:/tmp/test$ ls -l\n  total 0\n  -rw-rw-r-- 1 vagrant vagrant 0 May 18 19:35 file\n  -rw-rw-r-- 1 vagrant vagrant 0 May 18 19:35 file with space\n  vagrant@vagrant:/tmp/test$ find . -type f | xargs sudo chown root:root\n  chown: cannot access \u0027with\u0027: No such file or directory\n  chown: cannot access \u0027space\u0027: No such file or directory\n  vagrant@vagrant:/tmp/test$ ls -l\n  total 0\n  -rw-rw-r-- 1 root    root    0 May 18 19:35 file\n  -rw-rw-r-- 1 vagrant vagrant 0 May 18 19:35 file with space\n\nA more robust solution would be to use:\n\n  vagrant@vagrant:/tmp/test$ find . -type f -print0 | xargs -0 sudo chown root:root\n  vagrant@vagrant:/tmp/test$ ls -l\n  total 0\n  -rw-rw-r-- 1 root root 0 May 18 19:35 file\n  -rw-rw-r-- 1 root root 0 May 18 19:35 file with space","commit_id":"57ef187632c97eb7c2f27207c19f11336b28d97c"}]}
