)]}'
{"diskimage_builder/block_device/level1/partitioning.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"caf0590c6f2e40685aadc229577589a929228a62","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        partition_devices \u003d set()"},{"line_number":174,"context_line":"        disk_size \u003d self._size_of_block_dev(image_path)"},{"line_number":175,"context_line":"        with MBR(image_path, disk_size, self.align) as part_impl:"},{"line_number":176,"context_line":"            for part_cfg in self.partitions:"},{"line_number":177,"context_line":"                part_name \u003d part_cfg.get_name()"},{"line_number":178,"context_line":"                part_bootflag \u003d Partitioning.flag_boot \\"},{"line_number":179,"context_line":"                                in part_cfg.get_flags()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff0f0b1f_796647f0","line":176,"updated":"2017-05-18 07:22:16.000000000","message":"My question is -- why are we not building self.partitions[] here from the graph?\n\nAt this point, all the partitions should have been attached to the graph?  So we can use something like\n\n partitions \u003d []\n for node in self.outgoing_nodes():\n    if node \u003d\u003d \"partition\":\n       partitions.append(node)\n\nand *then* do the creation as below.\n\nthe create() call for those partition nodes should just do nothing.  they have already been created here ...","commit_id":"105e85ab91a3cf4fd9196d5337c4bd7dcce0f255"}]}