)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"768751a90173727b45f3b30c4f8bcb668ad46495","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove use of \u0027which\u0027."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Instead, either use the bash built-in of type, or use the target tool"},{"line_number":10,"context_line":"directly with a version or help option to ensure it exists. Since which"},{"line_number":11,"context_line":"is an external dep, things can fail oddly in a constrained environment."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff0f0b1f_0e8366ce","line":9,"range":{"start_line":9,"start_character":58,"end_line":9,"end_character":69},"updated":"2017-05-18 19:46:26.000000000","message":"This doesn\u0027t seem to be used at all? Can we just use the built in since we assume bash?","commit_id":"5adab769452acbbbb4fa8e17cec4a7d077485c2f"}],"bin/dib-lint":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6b3f258bf84a62fbecbdfcaf69b421298549c2ca","unresolved":false,"context_lines":[{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    # check that which calls are not used. It is not built in and is missing"},{"line_number":213,"context_line":"    # from some constrained environments"},{"line_number":214,"context_line":"    if ! excluded which; then"},{"line_number":215,"context_line":"        while read LINE"},{"line_number":216,"context_line":"        do"},{"line_number":217,"context_line":"            if [[ $LINE \u003d~ \"which \" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"ff0f0b1f_60c6344b","line":214,"updated":"2017-05-21 23:36:31.000000000","message":"I hate to be a pain here, but this already takes quite a while when doing pep8 and when you\u0027ve got a big stack and do \"rebase -x tox -epep8\" it\u0027s annoying ...\n\ncan we refactor these into the same loop?  It seems like they should operate on the same files (the dirname above) and then we can go through each line just once instead of doing a whole other loop over all the files","commit_id":"84d10dce570d351e364281dc3965a7f90e7ff51e"}],"diskimage_builder/lib/disk-image-create":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"768751a90173727b45f3b30c4f8bcb668ad46495","unresolved":false,"context_lines":[{"line_number":208,"context_line":"for X in ${!IMAGE_TYPES[@]}; do"},{"line_number":209,"context_line":"    case \"${IMAGE_TYPES[$X]}\" in"},{"line_number":210,"context_line":"        qcow2)"},{"line_number":211,"context_line":"            if [ -z \"$(qemu-img -V)\" ]; then"},{"line_number":212,"context_line":"                echo \"qcow2 output format specified but qemu-img executable not found.\""},{"line_number":213,"context_line":"                exit 1"},{"line_number":214,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ff0f0b1f_ce3e8e28","line":211,"updated":"2017-05-18 19:46:26.000000000","message":"You can clean this up a bit more by doing:\n\n  if ! qemu-img -V \u003e /dev/null 2\u003e\u00261 ; then\n  fi\n\nTo avoid the stderr produced when the executable is not found (since dib is writing its own error message below).","commit_id":"5adab769452acbbbb4fa8e17cec4a7d077485c2f"}]}