)]}'
{"diskimage_builder/block_device/tests/config/deep_graph.yaml":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"729183082f96ff1c8edbbd2e5876faddbf0465a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- local_loop:"},{"line_number":2,"context_line":"    base: image0"},{"line_number":3,"context_line":"    name: image0"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- partitioning:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff0f0b1f_c090d2f0","line":2,"updated":"2017-05-25 16:25:01.000000000","message":"This looks strange: a base for a root node should not be given.","commit_id":"6c5669f225417cf4a9b276f098ca36ef7b6db7ed"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"02d8d75573ca5f20a68c189218c0f16c3a3767e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- local_loop:"},{"line_number":2,"context_line":"    base: image0"},{"line_number":3,"context_line":"    name: image0"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- partitioning:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff0f0b1f_6bb67e8d","line":2,"in_reply_to":"ff0f0b1f_c090d2f0","updated":"2017-05-25 23:44:48.000000000","message":"Yes it is strange -- but this is what the tree-to-graph generator outputs.  i don\u0027t think pointing to yourself counts as a cycle, but i\u0027m not sure.  note in the follow-on, this is a quirk i ensured the single-function generator does not have","commit_id":"6c5669f225417cf4a9b276f098ca36ef7b6db7ed"}],"diskimage_builder/block_device/tests/test_config.py":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"729183082f96ff1c8edbbd2e5876faddbf0465a2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        #                  self.bd._config_tree_to_digraph,"},{"line_number":79,"context_line":"        #                  config, self.bd.plugin_manager)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # a graph should remain the same"},{"line_number":82,"context_line":"    def test_graph(self):"},{"line_number":83,"context_line":"        graph \u003d self.load_config_file(\u0027simple_graph.yaml\u0027)"},{"line_number":84,"context_line":"        parsed_graph \u003d self.bd._config_tree_to_digraph(graph,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_4097223c","line":81,"updated":"2017-05-25 16:25:01.000000000","message":"A general hint:\nInstead of having a comment here what about using this as the documentation of the method?","commit_id":"6c5669f225417cf4a9b276f098ca36ef7b6db7ed"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"02d8d75573ca5f20a68c189218c0f16c3a3767e5","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        #                  self.bd._config_tree_to_digraph,"},{"line_number":79,"context_line":"        #                  config, self.bd.plugin_manager)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # a graph should remain the same"},{"line_number":82,"context_line":"    def test_graph(self):"},{"line_number":83,"context_line":"        graph \u003d self.load_config_file(\u0027simple_graph.yaml\u0027)"},{"line_number":84,"context_line":"        parsed_graph \u003d self.bd._config_tree_to_digraph(graph,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_2ba1a696","line":81,"in_reply_to":"ff0f0b1f_4097223c","updated":"2017-05-25 23:44:48.000000000","message":"it\u0027s much of a muchness because we don\u0027t generate pydoc for .tests.*, so i\u0027d rather just keep it free form","commit_id":"6c5669f225417cf4a9b276f098ca36ef7b6db7ed"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"729183082f96ff1c8edbbd2e5876faddbf0465a2","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        var_log_pos \u003d call_order_list.index(\u0027var_log\u0027)"},{"line_number":149,"context_line":"        self.assertGreater(var_pos, root_pos)"},{"line_number":150,"context_line":"        self.assertGreater(var_log_pos, var_pos)"},{"line_number":151,"context_line":"        # XXX: more asserts for ordering?"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_c02c52ae","line":151,"updated":"2017-05-25 16:25:01.000000000","message":"What do you think about adding checks for at least the \u0027partitioning\u0027 object (e.g. partitiong_pos \u003c root_pos) and one mkfs (e.g. root_pos \u003c mkfs_root_pos)?","commit_id":"6c5669f225417cf4a9b276f098ca36ef7b6db7ed"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"02d8d75573ca5f20a68c189218c0f16c3a3767e5","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        var_log_pos \u003d call_order_list.index(\u0027var_log\u0027)"},{"line_number":149,"context_line":"        self.assertGreater(var_pos, root_pos)"},{"line_number":150,"context_line":"        self.assertGreater(var_log_pos, var_pos)"},{"line_number":151,"context_line":"        # XXX: more asserts for ordering?"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_ebd84e1f","line":151,"in_reply_to":"ff0f0b1f_c02c52ae","updated":"2017-05-25 23:44:48.000000000","message":"Well there is no \"partitioning\" object in the list?  there are only the three partitions\n\nThis is what I was trying to get at with prior changes -- a parent partitioning object that has it\u0027s partitions in order.\n\nanyway, added the mkfs check","commit_id":"6c5669f225417cf4a9b276f098ca36ef7b6db7ed"}]}