)]}'
{"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f1b85270e020445b17071019cd70ef5f40cd316f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        self.config \u003d self._load_json(self.config_json_file_name)"},{"line_number":146,"context_line":"        self.state \u003d self._load_json(self.state_json_file_name)"},{"line_number":147,"context_line":"        if self.state is not None:"},{"line_number":148,"context_line":"            self.state[\u0027loaded\u0027] \u003d True"},{"line_number":149,"context_line":"        logger.debug(\"Using state [%s]\", self.state)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # This needs to exists for the state and config files"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_16004d34","line":148,"updated":"2017-05-29 02:53:35.000000000","message":"this is the first thing i looked at and I don\u0027t want to spend time reverse engineering what arcane ways this will be set or not set.  please comment it","commit_id":"09418ff5188e94a8b711d17de73130b779563e97"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"7f83e735ebd03a8f6368f35153099e723141dad7","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        self.config \u003d self._load_json(self.config_json_file_name)"},{"line_number":146,"context_line":"        self.state \u003d self._load_json(self.state_json_file_name)"},{"line_number":147,"context_line":"        if self.state is not None:"},{"line_number":148,"context_line":"            self.state[\u0027loaded\u0027] \u003d True"},{"line_number":149,"context_line":"        logger.debug(\"Using state [%s]\", self.state)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        # This needs to exists for the state and config files"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_0c3ddaba","line":148,"in_reply_to":"df140735_16004d34","updated":"2017-05-29 05:56:52.000000000","message":"A separate patch is available that handles the initialization of the state dict:\nhttps://review.openstack.org/#/c/468768/","commit_id":"09418ff5188e94a8b711d17de73130b779563e97"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"4cde5028bded0a1a1ecbae0d1e5a6cb6bc6232c9","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            self.state[\u0027_loaded\u0027] \u003d False"},{"line_number":152,"context_line":"        else:"},{"line_number":153,"context_line":"            self.state[\u0027_loaded\u0027] \u003d True"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        logger.debug(\"Using state [%s]\", self.state)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        # This needs to exists for the state and config files"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_ca27c1b6","side":"PARENT","line":154,"updated":"2017-05-29 08:19:28.000000000","message":"may be this change is not required?","commit_id":"2fc5d95a43c7fff45047cbe6bb485223af3d20c9"}],"diskimage_builder/block_device/level3/mount.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2d7023a3c0d889016088b93712eea093e0898c11","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def get_node(self):"},{"line_number":44,"context_line":"        state \u003d self.get_state()"},{"line_number":45,"context_line":"        # If this was loaded the state is already build up."},{"line_number":46,"context_line":"        if \u0027_loaded\u0027 in state:"},{"line_number":47,"context_line":"            return self"},{"line_number":48,"context_line":"        if \u0027mount_points\u0027 not in state:"},{"line_number":49,"context_line":"            self.state[\u0027mount_points\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_1b927b9f","line":46,"updated":"2017-05-31 05:23:22.000000000","message":"I really do not like this magic flag.\n\nBut, I think this whole problem goes away if we make sure that this is only called once.  and it seems we can do that by pickling the node list, because the later cmd_* calls only want to walk the node list -- not actually recreate it from scratch.  I\u0027ve proposed this in I68840594a34af28d41d9522addcfd830bd203b97","commit_id":"8dba026099a4b400a755859f75429972961d4650"}]}