)]}'
{"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ca408e05bcd72e1c10ca4bc351885051ab100b1c","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.config \u003d self._load_json(self.config_json_file_name)"},{"line_number":146,"context_line":"        self.state \u003d self._load_json(self.state_json_file_name)"},{"line_number":147,"context_line":"        # If the state could not be loaded, create a new one."},{"line_number":148,"context_line":"        # Add a an appropriate flag to show this fact to the clients."},{"line_number":149,"context_line":"        if self.state is None:"},{"line_number":150,"context_line":"            self.state \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_8ce1ead3","line":147,"updated":"2017-05-29 06:35:00.000000000","message":"This \"x\u003d1 # set x to 1\" type comment is not the level of detail I\u0027m looking for.  I can see that this is a flag that represents if something is loaded or not.\n\nWhat this has to say is something like \"during the first run, there is no state because blah blah.  After that we persist it to a file because blah blah, and then for the calls such as X, Y, Z the pre-loaded state is used.  clients need to know this because ...\"\n\nWhen I\u0027m trying to understand what this \"state\" thing is we\u0027re passing around, where it is created is the first point I look, and if I have helpful comments there it makes life so much easier.","commit_id":"057f2526e9bc9744090b1884133439a6d753e806"}],"diskimage_builder/block_device/plugin.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ca408e05bcd72e1c10ca4bc351885051ab100b1c","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    The ``state`` (resp. ``results``) dictionary contains always the"},{"line_number":44,"context_line":"    key ``_loaded``.  If the ``state`` object was loaded this is set"},{"line_number":45,"context_line":"    to ``True`` - if it was not loaded it is set to ``False``."},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":"    def __init__(self, name):"},{"line_number":48,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_4c88721e","line":45,"updated":"2017-05-29 06:35:00.000000000","message":"I\u0027m not sure what \"state (resp. results)\" means?\n\nShould this be part of create()?","commit_id":"057f2526e9bc9744090b1884133439a6d753e806"}]}
