)]}'
{"diskimage_builder/block_device/blockdevice.py":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"5682d755615eae4d0849e770de2cd358a6086f4a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        # dictionary.  They can only be accessed after the state has"},{"line_number":290,"context_line":"        # been dumped; i.e. after cmd_create() called."},{"line_number":291,"context_line":"        state \u003d BlockDeviceState(self.state_json_file_name)"},{"line_number":292,"context_line":"        state \u003d state.state"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if symbol \u003d\u003d \u0027image-block-partition\u0027:"},{"line_number":295,"context_line":"            # If there is no partition needed, pass back directly the"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_64ac588c","line":292,"updated":"2017-05-30 05:51:09.000000000","message":"I don\u0027t like this - especially for consistency reasons: in some cases \u0027state\u0027 is the complete object in some only the dict.","commit_id":"091423614abe0513181c03f6aed13792b8b44ae9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"ddb43e63e1d963cbcb007cfd82169dd1ac78eb93","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        # dictionary.  They can only be accessed after the state has"},{"line_number":290,"context_line":"        # been dumped; i.e. after cmd_create() called."},{"line_number":291,"context_line":"        state \u003d BlockDeviceState(self.state_json_file_name)"},{"line_number":292,"context_line":"        state \u003d state.state"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        if symbol \u003d\u003d \u0027image-block-partition\u0027:"},{"line_number":295,"context_line":"            # If there is no partition needed, pass back directly the"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_cf745d9c","line":292,"in_reply_to":"df140735_64ac588c","updated":"2017-05-30 06:31:00.000000000","message":"I don\u0027t particularly like this either, and I think the solution is to make a BlockDeviceState implement the MutableCollection class so it just looks like a normal dictionary and just pass it directly.  As I mention, you could do more introspection as things were added that way.\n\nBut i consider that follow-on work","commit_id":"091423614abe0513181c03f6aed13792b8b44ae9"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"1168aae21f02e1e3a706180c731f950fa302e304","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                print(\"%s\" % state[\u0027blockdev\u0027][\u0027image0\u0027][\u0027device\u0027])"},{"line_number":301,"context_line":"            return 0"},{"line_number":302,"context_line":"        if symbol \u003d\u003d \u0027image-path\u0027:"},{"line_number":303,"context_line":"            print(\"%s\" % state[\u0027blockdev\u0027][\u0027image0\u0027][\u0027image\u0027])"},{"line_number":304,"context_line":"            return 0"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        logger.error(\"Invalid symbol [%s] for getval\" % symbol)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_1e9ba872","line":303,"range":{"start_line":303,"start_character":25,"end_line":303,"end_character":30},"updated":"2017-05-30 08:45:57.000000000","message":"question: i know that this is a refactor from previous patch, but we shall not check for blockdev-\u003eroot as we do for the image-block-partition query?","commit_id":"091423614abe0513181c03f6aed13792b8b44ae9"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2c31f1b7979e5ce648404573e14424074cddf99c","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                print(\"%s\" % state[\u0027blockdev\u0027][\u0027image0\u0027][\u0027device\u0027])"},{"line_number":301,"context_line":"            return 0"},{"line_number":302,"context_line":"        if symbol \u003d\u003d \u0027image-path\u0027:"},{"line_number":303,"context_line":"            print(\"%s\" % state[\u0027blockdev\u0027][\u0027image0\u0027][\u0027image\u0027])"},{"line_number":304,"context_line":"            return 0"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"        logger.error(\"Invalid symbol [%s] for getval\" % symbol)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_fe191488","line":303,"range":{"start_line":303,"start_character":25,"end_line":303,"end_character":30},"in_reply_to":"df140735_1e9ba872","updated":"2017-05-30 09:08:25.000000000","message":"maybe? :) this doesn\u0027t really change the operation of this part I don\u0027t think (at least I don\u0027t intend it to).  That might be a follow-on","commit_id":"091423614abe0513181c03f6aed13792b8b44ae9"}]}