)]}'
{"diskimage_builder/block_device/level3/mount.py":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"dbd0d2b0252e01f9fa0c5210791c2b9290d475d7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # find ourselves in the mount_points, and our parent node"},{"line_number":63,"context_line":"        # is one before us in node_name list."},{"line_number":64,"context_line":"        mount_points \u003d [x[0] for x in sorted_mount_points]"},{"line_number":65,"context_line":"        node_name \u003d [x[1] for x in sorted_mount_points]"},{"line_number":66,"context_line":"        mpi \u003d mount_points.index(self.mount_point)"},{"line_number":67,"context_line":"        if mpi \u003e 0:"},{"line_number":68,"context_line":"            dep \u003d node_name[mpi - 1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf091321_b498596a","line":65,"updated":"2017-06-08 19:36:15.000000000","message":"You create the whole list and then access only one (known) element?","commit_id":"09dee46579446b7d4a8d665e7e5bd34e5575b8cc"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"dbd0d2b0252e01f9fa0c5210791c2b9290d475d7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        node_name \u003d [x[1] for x in sorted_mount_points]"},{"line_number":66,"context_line":"        mpi \u003d mount_points.index(self.mount_point)"},{"line_number":67,"context_line":"        if mpi \u003e 0:"},{"line_number":68,"context_line":"            dep \u003d node_name[mpi - 1]"},{"line_number":69,"context_line":"            edge_from.append(dep)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        edge_from.append(self.base)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf091321_949d555b","line":68,"updated":"2017-06-08 19:36:15.000000000","message":"Why not \n    sorted_mount_points[mpi -1][1]\nhere?","commit_id":"09dee46579446b7d4a8d665e7e5bd34e5575b8cc"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6de451e407dd39d7d0258766072707a4989732ad","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        node_name \u003d [x[1] for x in sorted_mount_points]"},{"line_number":66,"context_line":"        mpi \u003d mount_points.index(self.mount_point)"},{"line_number":67,"context_line":"        if mpi \u003e 0:"},{"line_number":68,"context_line":"            dep \u003d node_name[mpi - 1]"},{"line_number":69,"context_line":"            edge_from.append(dep)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        edge_from.append(self.base)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf091321_6fe9c718","line":68,"in_reply_to":"bf091321_949d555b","updated":"2017-06-09 00:05:34.000000000","message":"we\u0027re just shuffling complexity.  then the index lookup will be something that pulls apart the tuples.  at least here the variables have names that describe what they hold\n\na better idea would be to remove the dump of state to json at all, so we can hold object references in the state.  then we don\u0027t need any of this and can simply call sort() on the objects.  happy to see that as a follow-on","commit_id":"09dee46579446b7d4a8d665e7e5bd34e5575b8cc"}]}