)]}'
{"diskimage_builder/elements/bootloader/finalise.d/50-bootloader":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"4c52d2d363431f58b76f06887f37089117adf1b8","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":120,"context_line":"        # For PPC, we use the \"boot\" partition as the one to point"},{"line_number":121,"context_line":"        # grub-install to, not the loopback device.  ppc has a"},{"line_number":122,"context_line":"        # dedicated PReP boot partition.  This seems to only work on"},{"line_number":123,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":124,"context_line":"        # XXX : this may not be true.  It seems to work,"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df140735_e7aac16f","line":121,"range":{"start_line":121,"start_character":51,"end_line":121,"end_character":53},"updated":"2017-06-07 02:30:09.000000000","message":"extra whitespace, or do you prefer 2 spaces after period [1] style? :D\n\n[1] https://en.wikipedia.org/wiki/Sentence_spacing","commit_id":"1a5d4f71c469bf3fca1e16ec553c11ef8886d803"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d5aaccb0b09580936ae4b6b82c80445887bd693a","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":120,"context_line":"        # For PPC, we use the \"boot\" partition as the one to point"},{"line_number":121,"context_line":"        # grub-install to, not the loopback device.  ppc has a"},{"line_number":122,"context_line":"        # dedicated PReP boot partition.  This seems to only work on"},{"line_number":123,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":124,"context_line":"        # XXX : this may not be true.  It seems to work,"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df140735_879d440c","line":121,"range":{"start_line":121,"start_character":51,"end_line":121,"end_character":53},"in_reply_to":"df140735_e7aac16f","updated":"2017-06-07 03:22:28.000000000","message":"I was always taught to put two spaces after a full-stop :)","commit_id":"1a5d4f71c469bf3fca1e16ec553c11ef8886d803"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"4c52d2d363431f58b76f06887f37089117adf1b8","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":120,"context_line":"        # For PPC, we use the \"boot\" partition as the one to point"},{"line_number":121,"context_line":"        # grub-install to, not the loopback device.  ppc has a"},{"line_number":122,"context_line":"        # dedicated PReP boot partition.  This seems to only work on"},{"line_number":123,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":124,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":125,"context_line":"        # but requires some more investigation."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df140735_67b0f1de","line":122,"range":{"start_line":122,"start_character":40,"end_line":122,"end_character":42},"updated":"2017-06-07 02:30:09.000000000","message":"ditto","commit_id":"1a5d4f71c469bf3fca1e16ec553c11ef8886d803"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"4c52d2d363431f58b76f06887f37089117adf1b8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # grub-install to, not the loopback device.  ppc has a"},{"line_number":122,"context_line":"        # dedicated PReP boot partition.  This seems to only work on"},{"line_number":123,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":124,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":125,"context_line":"        # but requires some more investigation."},{"line_number":126,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"},{"line_number":127,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df140735_c7c0dd2d","line":124,"range":{"start_line":124,"start_character":37,"end_line":124,"end_character":39},"updated":"2017-06-07 02:30:09.000000000","message":"ditto","commit_id":"1a5d4f71c469bf3fca1e16ec553c11ef8886d803"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"4c52d2d363431f58b76f06887f37089117adf1b8","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # grub-install to, not the loopback device.  ppc has a"},{"line_number":122,"context_line":"        # dedicated PReP boot partition.  This seems to only work on"},{"line_number":123,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":124,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":125,"context_line":"        # but requires some more investigation."},{"line_number":126,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"},{"line_number":127,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"df140735_e7c3e137","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":14},"updated":"2017-06-07 02:30:09.000000000","message":"ditto","commit_id":"1a5d4f71c469bf3fca1e16ec553c11ef8886d803"},{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"f97eafe9f19d15b24795d421eabfd303cde993a3","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":120,"context_line":"        # For PPC, we use the \"boot\" partition as the one to point"},{"line_number":121,"context_line":"        # grub-install to, not the loopback device.  ppc has a"},{"line_number":122,"context_line":"        # dedicated PReP boot partition.  This seems to only work on"},{"line_number":123,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":124,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":125,"context_line":"        # but requires some more investigation."},{"line_number":126,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"df140735_cf81fd4c","line":123,"range":{"start_line":122,"start_character":42,"end_line":123,"end_character":61},"updated":"2017-06-07 14:48:41.000000000","message":"Just for the record: This is true for 2.02~beta2 (available in Xenial and Yakkety). Starting from 2.02~beta3 (Zesty), grub-install works fine on /dev/loopXpN directly, no need to use /dev/mapper. I\u0027ve built grub manually and verified each version.","commit_id":"76a2811c304b292c512f392bb3657b284e3a1d13"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6ae950582cc7cd1505948ff485afe26ec39fab8f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    if [[ \"$ARCH\" \u003d~ \"ppc\" ]] ; then"},{"line_number":120,"context_line":"        # For PPC, we use the \"boot\" partition as the one to point"},{"line_number":121,"context_line":"        # grub-install to, not the loopback device.  ppc has a"},{"line_number":122,"context_line":"        # dedicated PReP boot partition.  This seems to only work on"},{"line_number":123,"context_line":"        # /dev/mapper/... nodes due to matching rules in grub"},{"line_number":124,"context_line":"        # XXX : this may not be true.  It seems to work,"},{"line_number":125,"context_line":"        # but requires some more investigation."},{"line_number":126,"context_line":"        $GRUBNAME --modules\u003d\"part_msdos\" $GRUB_OPTS ${DEVICES[boot]} --no-nvram"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"bf091321_07270015","line":123,"range":{"start_line":122,"start_character":42,"end_line":123,"end_character":61},"in_reply_to":"df140735_cf81fd4c","updated":"2017-06-07 22:09:15.000000000","message":"thanks, i will update that comment as it\u0027s always useful to have such breadcrumbs :)\n\nThat said, I think we *want* this list to just have the /dev/mapper nodes consistently.  that way we just have to deal with kpartx","commit_id":"76a2811c304b292c512f392bb3657b284e3a1d13"}]}