)]}'
{"diskimage_builder/block_device/level1/lvm.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"413545df3a719f59061e27afc7e2b54c1e3a3d18","unresolved":false,"context_lines":[{"line_number":24,"context_line":"logger \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class Pvs(NodeBase):"},{"line_number":28,"context_line":"    def __init__(self, name, state, options, base, lvm):"},{"line_number":29,"context_line":"        \"\"\"Physical volume"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_515ff540","line":27,"updated":"2017-07-24 05:21:17.000000000","message":"can we please call the PvsNode (and the other, add the Node) for consistency","commit_id":"2cbfd2e008942ee385023bd912dfb5ac23507653"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"413545df3a719f59061e27afc7e2b54c1e3a3d18","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        pass"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"class LVM(PluginBase):"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _config_error(self, msg):"},{"line_number":116,"context_line":"        raise BlockDeviceSetupException(msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff346bd7_315c714a","line":113,"updated":"2017-07-24 05:21:17.000000000","message":"and this LVMPlugin","commit_id":"2cbfd2e008942ee385023bd912dfb5ac23507653"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"b027e0116d383d1df56d830d48322c95bad5bad7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        if \u0027lvs\u0027 not in config:"},{"line_number":132,"context_line":"            self._config_error(\"Lvm config needs \u0027lvs\u0027\")"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        # create physical volume nodes"},{"line_number":135,"context_line":"        self.pvs \u003d []"},{"line_number":136,"context_line":"        self.pvs_keys \u003d []"},{"line_number":137,"context_line":"        for pvs_cfg in config[\u0027pvs\u0027]:"}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_7f32d2a9","line":134,"updated":"2017-07-29 06:21:25.000000000","message":"This method is very (too?) long.  Why are those \u0027create xyz group nodes\u0027 not part of the appropriate classes?","commit_id":"304955b2c1480cbdf6c529ac786e9c0b3f6e9e5e"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"b027e0116d383d1df56d830d48322c95bad5bad7","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        # XXX:"},{"line_number":247,"context_line":"        #  * multiple PV\u0027s will call this multiple times?  gate like in"},{"line_number":248,"context_line":"        #    partitions?"},{"line_number":249,"context_line":"        for pvs_cfg in self.pvs:"},{"line_number":250,"context_line":"            pvs_base \u003d pvs_cfg.base"},{"line_number":251,"context_line":"            pvs_name \u003d pvs_cfg.name"},{"line_number":252,"context_line":"            pvs_options \u003d pvs_cfg.options"}],"source_content_type":"text/x-python","patch_set":11,"id":"df3967d1_3f2c4a46","line":249,"updated":"2017-07-29 06:21:25.000000000","message":"Same here: why is this functionality not moved to the appropriate classes?","commit_id":"304955b2c1480cbdf6c529ac786e9c0b3f6e9e5e"}],"diskimage_builder/block_device/tests/config/lvm_tree.yaml":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"b027e0116d383d1df56d830d48322c95bad5bad7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        size: 3G"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- lvm:"},{"line_number":15,"context_line":"    base: mbr"},{"line_number":16,"context_line":"    pvs:"},{"line_number":17,"context_line":"      - name: pv"},{"line_number":18,"context_line":"        options: [\"--force\"]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"df3967d1_7f09b2db","line":15,"updated":"2017-07-29 06:21:25.000000000","message":"Can you please explain why / where this is needed?\n\nThis looks very strange to me especially when having PV which use different partitioning or even images directly.","commit_id":"304955b2c1480cbdf6c529ac786e9c0b3f6e9e5e"}]}