)]}'
{"diskimage_builder/elements/openstack-ci-mirrors/environment.d/11-dib-distribution-mirror.bash":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e42e314fd882cba7e98dc0df75ed1a735780a685","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    elif [[ \"${DISTRO_NAME}\" \u003d\u003d \"centos7\" ]]; then"},{"line_number":23,"context_line":"        export DIB_DISTRIBUTION_MIRROR\u003d$NODEPOOL_CENTOS_MIRROR"},{"line_number":24,"context_line":"    elif [[ \"${DISTRO_NAME}\" \u003d\u003d \"opensuse\" ]]; then"},{"line_number":25,"context_line":"        export DIB_DISTRIBUTION_MIRROR\u003d$NODEPOOL_OPENSUSE_MIRROR"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f1d235d_888e8725","line":25,"updated":"2017-06-29 07:26:52.000000000","message":"but ... do the elements actually obey this?  i\u0027m not seeing this in opensuse-minimal for example?\n\nif you need to build custom repo files i added contrib/setup-gate-mirrors.sh to do just that\n\ni would strongly prefer if we had a method to do this that doesn\u0027t leave the mirrors in the build image, so it can be used as a more generic thing","commit_id":"f913f4e65cd1ae70e60b1f4475b6ccc875749e8f"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"8eedffef2f55409de80b6fa2cdb6f62eae2bdb54","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    elif [[ \"${DISTRO_NAME}\" \u003d\u003d \"centos7\" ]]; then"},{"line_number":23,"context_line":"        export DIB_DISTRIBUTION_MIRROR\u003d$NODEPOOL_CENTOS_MIRROR"},{"line_number":24,"context_line":"    elif [[ \"${DISTRO_NAME}\" \u003d\u003d \"opensuse\" ]]; then"},{"line_number":25,"context_line":"        export DIB_DISTRIBUTION_MIRROR\u003d$NODEPOOL_OPENSUSE_MIRROR"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3f1d235d_a855c31f","line":25,"in_reply_to":"3f1d235d_888e8725","updated":"2017-06-29 07:39:36.000000000","message":"yeah good point I forgot that the opensuse elements are not using the standard variables. I will fix it.","commit_id":"f913f4e65cd1ae70e60b1f4475b6ccc875749e8f"}],"diskimage_builder/elements/opensuse-minimal/environment.d/10-opensuse-distro-name.bash":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d3616b1ca7230e3ae8cb6f0e3f267beda4e55edb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"export DIB_RELEASE\u003d${DIB_RELEASE,,}"},{"line_number":4,"context_line":"export DIB_OPENSUSE_PATTERNS\u003dpatterns-openSUSE-base"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ -n \"${DIB_OPENSUSE_DISTRIBUTION_MIRROR:-}\" ]; then"},{"line_number":7,"context_line":"    export DIB_DISTRIBUTION_MIRROR\u003d$DIB_OPENSUSE_DISTRIBUTION_MIRROR"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f1d235d_c1818a4c","line":6,"updated":"2017-07-04 00:25:57.000000000","message":"If anything, I guess we\u0027d set\n\n DIB_DISTRIBUTION_MIRROR\u003dDIB_OPENSUSE_MIRROR\n\nif set, to maintain compatibility ... if we care","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"03ae7815d17417b9f8adaa1736464095fe1fc688","unresolved":false,"context_lines":[{"line_number":3,"context_line":"export DIB_RELEASE\u003d${DIB_RELEASE,,}"},{"line_number":4,"context_line":"export DIB_OPENSUSE_PATTERNS\u003dpatterns-openSUSE-base"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ -n \"${DIB_OPENSUSE_DISTRIBUTION_MIRROR:-}\" ]; then"},{"line_number":7,"context_line":"    export DIB_DISTRIBUTION_MIRROR\u003d$DIB_OPENSUSE_DISTRIBUTION_MIRROR"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f1d235d_1206abcf","line":6,"in_reply_to":"3f1d235d_6f3a9c34","updated":"2017-07-04 06:58:36.000000000","message":"DIB_OPENSUSE_DISTRIBUTION_MIRROR is new, right?\n\nThere was a push some time ago to make \"DIB_DISTRIBUTION_MIRROR\" the global way to reset the mirror for all elements.  So that\u0027s why there\u0027s a few that translate from element specific vars to that.  So we shouldn\u0027t re-introduce more, just for consistency.","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"ae270b7fd92d418eaf9cfb539d7832596e123b1e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"export DIB_RELEASE\u003d${DIB_RELEASE,,}"},{"line_number":4,"context_line":"export DIB_OPENSUSE_PATTERNS\u003dpatterns-openSUSE-base"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ -n \"${DIB_OPENSUSE_DISTRIBUTION_MIRROR:-}\" ]; then"},{"line_number":7,"context_line":"    export DIB_DISTRIBUTION_MIRROR\u003d$DIB_OPENSUSE_DISTRIBUTION_MIRROR"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3f1d235d_6f3a9c34","line":6,"in_reply_to":"3f1d235d_c1818a4c","updated":"2017-07-04 06:26:49.000000000","message":"Possibly but I am not sure if I need to convert from DIB_OPENSUSE_MIRROR to DIB_OPENSUSE_DISTRIBUTION_MIRROR in the first place.","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"}],"diskimage_builder/elements/opensuse/README.rst":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"841445de694ed47847f636d4c3d4d28f30dc0444","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  :Default: http://download.opensuse.org/repositories/Cloud:/Images:/(openSUSE|Leap)_${DIB_RELEASE}"},{"line_number":23,"context_line":"  :Description: Set the desired URL to fetch the images from."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DIB_OPENSUSE_MIRROR:"},{"line_number":26,"context_line":"   :Required: No"},{"line_number":27,"context_line":"   :Default: http://download.opensuse.org"},{"line_number":28,"context_line":"   :Description: To use a specific openSUSE mirror, set this variable to the"}],"source_content_type":"text/x-rst","patch_set":14,"id":"1f1a1f67_1d29139a","line":25,"updated":"2017-07-17 04:49:52.000000000","message":"So to be clear, this is just DIB_DISTRIBUTION_MIRROR","commit_id":"0c9cfbc7f55c3231cc8445bf18d66c3bea96b84f"}],"diskimage_builder/elements/opensuse/pre-install.d/00-opensuse-setup":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d3616b1ca7230e3ae8cb6f0e3f267beda4e55edb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Fix up mirrors if needed. Mirrors only have core packages. OBS repositories"},{"line_number":13,"context_line":"# are not mirrored."},{"line_number":14,"context_line":"for repo in /etc/zypp/repos.d/repo-{oss,non-oss}.repo; do"},{"line_number":15,"context_line":"    sed -i \"s@http://download.opensuse.org@${DIB_DISTRIBUTION_MIRROR}@\" $repo"},{"line_number":16,"context_line":"done"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"zypper ar -f http://download.opensuse.org/repositories/X11:/Bumblebee/${OPENSUSE_REPO_DIR}/X11:Bumblebee.repo"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_a1c68e99","line":15,"updated":"2017-07-04 00:25:57.000000000","message":"so this is actually in-place modifying the repos on the build system?\n\nI guess this doesn\u0027t matter for CI, really ... but is there a better way?  This is why for centos/fedora what happens is we create a separate bunch of .repo files with the contrib/ script, and then point yum at that for the chroot buildup","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"ae270b7fd92d418eaf9cfb539d7832596e123b1e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Fix up mirrors if needed. Mirrors only have core packages. OBS repositories"},{"line_number":13,"context_line":"# are not mirrored."},{"line_number":14,"context_line":"for repo in /etc/zypp/repos.d/repo-{oss,non-oss}.repo; do"},{"line_number":15,"context_line":"    sed -i \"s@http://download.opensuse.org@${DIB_DISTRIBUTION_MIRROR}@\" $repo"},{"line_number":16,"context_line":"done"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"zypper ar -f http://download.opensuse.org/repositories/X11:/Bumblebee/${OPENSUSE_REPO_DIR}/X11:Bumblebee.repo"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_ef17cca2","line":15,"in_reply_to":"3f1d235d_a1c68e99","updated":"2017-07-04 06:26:49.000000000","message":"But this runs in the pre-install.d phase which according to https://docs.openstack.org/diskimage-builder/latest/developer/developing_elements.html it\u0027s executed in the chroot. So it modifies the repos in the chroot (ie the build image) right?","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"e92de7769c6e0efe74cc0ff6b08c254e452a8493","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Fix up mirrors if needed. Mirrors only have core packages. OBS repositories"},{"line_number":13,"context_line":"# are not mirrored."},{"line_number":14,"context_line":"for repo in /etc/zypp/repos.d/repo-{oss,non-oss}.repo; do"},{"line_number":15,"context_line":"    sed -i \"s@http://download.opensuse.org@${DIB_DISTRIBUTION_MIRROR}@\" $repo"},{"line_number":16,"context_line":"done"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"zypper ar -f http://download.opensuse.org/repositories/X11:/Bumblebee/${OPENSUSE_REPO_DIR}/X11:Bumblebee.repo"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_ad879c0f","line":15,"in_reply_to":"3f1d235d_b244971c","updated":"2017-07-04 07:46:01.000000000","message":"Hmm OK let me see how to do that then.","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"03ae7815d17417b9f8adaa1736464095fe1fc688","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# Fix up mirrors if needed. Mirrors only have core packages. OBS repositories"},{"line_number":13,"context_line":"# are not mirrored."},{"line_number":14,"context_line":"for repo in /etc/zypp/repos.d/repo-{oss,non-oss}.repo; do"},{"line_number":15,"context_line":"    sed -i \"s@http://download.opensuse.org@${DIB_DISTRIBUTION_MIRROR}@\" $repo"},{"line_number":16,"context_line":"done"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"zypper ar -f http://download.opensuse.org/repositories/X11:/Bumblebee/${OPENSUSE_REPO_DIR}/X11:Bumblebee.repo"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3f1d235d_b244971c","line":15,"in_reply_to":"3f1d235d_ef17cca2","updated":"2017-07-04 06:58:36.000000000","message":"hmm, yeah, i guess i\u0027m getting confused with 08-zypper-chroot, which does seem to be using the infra repos\n\nstill, i think it\u0027s kind of wrong to leave the mirrors inside the built image.  for example infra might like to build a generic image but using local mirrors.  but it\u0027s a minor point","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"}],"releasenotes/notes/change-opensuse-mirror-variable-4b5e02a0e27543b0.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d3616b1ca7230e3ae8cb6f0e3f267beda4e55edb","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The ``DIB_OPENSUSE_MIRROR`` variable has been replaced"},{"line_number":8,"context_line":"    with ``DIB_OPENSUSE_DISTRIBUTION_MIRROR`` to follow"},{"line_number":9,"context_line":"    the pattern of the other distributions."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_a1afaee1","line":9,"updated":"2017-07-04 00:25:57.000000000","message":"This is not quite right ... we moved everything to the standard DIB_DISTRIBUTION_MIRROR and the DIB_[FEDORA|...]_DISTRIBUTION_MIRROR were just left was backwards compatibility","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"03ae7815d17417b9f8adaa1736464095fe1fc688","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The ``DIB_OPENSUSE_MIRROR`` variable has been replaced"},{"line_number":8,"context_line":"    with ``DIB_OPENSUSE_DISTRIBUTION_MIRROR`` to follow"},{"line_number":9,"context_line":"    the pattern of the other distributions."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_9222bb51","line":9,"in_reply_to":"3f1d235d_0f7a08f0","updated":"2017-07-04 06:58:36.000000000","message":"yeah, I wouldn\u0027t introduce DIB_OPENSUSE_DISTRIBUTION_MIRROR, but either leave it, or deprecate it DIB_DISTRIBUTION_MIRROR for consistency.\n\nToo many similarly named variables!","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"ae270b7fd92d418eaf9cfb539d7832596e123b1e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - The ``DIB_OPENSUSE_MIRROR`` variable has been replaced"},{"line_number":8,"context_line":"    with ``DIB_OPENSUSE_DISTRIBUTION_MIRROR`` to follow"},{"line_number":9,"context_line":"    the pattern of the other distributions."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f1d235d_0f7a08f0","line":9,"in_reply_to":"3f1d235d_a1afaee1","updated":"2017-07-04 06:26:49.000000000","message":"So I guess it\u0027s fine if we stick to DIB_OPENSUSE_MIRROR instead of DIB_OPENSUSE_DISTRIBUTION_MIRROR?","commit_id":"9b4d882f8a77aa35693fb13d8c164573792f35f7"}]}