)]}'
{"diskimage_builder/block_device/level2/mkfs.py":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"a10a5393e94b149b6ffdc0b01a241035244e7d25","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        if self.opts:"},{"line_number":111,"context_line":"            cmd.extend(self.opts)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if self.type \u003d\u003d \"vfat\" or self.type \u003d\u003d \"fat\":"},{"line_number":114,"context_line":"            cmd.extend([\"-n\", self.label])"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            cmd.extend([\"-L\", self.label])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_403dd42a","line":113,"updated":"2017-07-08 05:57:28.000000000","message":"For consistency reasons (see line 118) could you please rephrase in:\n\n    if self.type in (\u0027vfat\u0027, \u0027fat\u0027):","commit_id":"53e63766925e4a2be066d3c42761bccc2a0f329b"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"7741975547109d045ff48a075ce6b4cf19d095b8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        if self.opts:"},{"line_number":111,"context_line":"            cmd.extend(self.opts)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if self.type in [\u0027vfat\u0027, \u0027fat\u0027]:"},{"line_number":114,"context_line":"            cmd.extend([\"-n\", self.label])"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            cmd.extend([\"-L\", self.label])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_8bcccf61","line":113,"updated":"2017-07-15 05:46:06.000000000","message":"Can you please explain why are you using a list instead of a tuple here?","commit_id":"36aeac13f051251d015a1f196689468f6a3afe54"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"3ca83105ce6d159ca495d106179f4a939cb14d75","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        if self.opts:"},{"line_number":111,"context_line":"            cmd.extend(self.opts)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if self.type in [\u0027vfat\u0027, \u0027fat\u0027]:"},{"line_number":114,"context_line":"            cmd.extend([\"-n\", self.label])"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            cmd.extend([\"-L\", self.label])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f1a1f67_64aabdd2","line":113,"in_reply_to":"1f1a1f67_8bcccf61","updated":"2017-07-15 21:58:29.000000000","message":"because I screwed up :)","commit_id":"36aeac13f051251d015a1f196689468f6a3afe54"}]}
