)]}'
{"diskimage_builder/elements/growroot/static/usr/local/sbin/growroot":[{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"6a982de20be48eea846a928e8d55d6deb8a71381","unresolved":false,"context_lines":[{"line_number":31,"context_line":"growpart $disk $part_no"},{"line_number":32,"context_line":"# Error code 1 means no change"},{"line_number":33,"context_line":"if [ \"$?\" -le 1 ]; then"},{"line_number":34,"context_line":"    # always return true because this might not work if were are non ext4"},{"line_number":35,"context_line":"    # Add support for XFS format"},{"line_number":36,"context_line":"    fs_type\u003d$(mount |grep \"$root_dev\" |awk \u0027{print $5}\u0027)"},{"line_number":37,"context_line":"    fs_type_temp\u003d\"xfs\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff346bd7_32d5a5ba","line":34,"updated":"2017-07-22 04:38:40.000000000","message":"Do we (still) need this comment?","commit_id":"e7d2a600c17d05a8524fccd660ac700bffc4a1dd"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"6a982de20be48eea846a928e8d55d6deb8a71381","unresolved":false,"context_lines":[{"line_number":33,"context_line":"if [ \"$?\" -le 1 ]; then"},{"line_number":34,"context_line":"    # always return true because this might not work if were are non ext4"},{"line_number":35,"context_line":"    # Add support for XFS format"},{"line_number":36,"context_line":"    fs_type\u003d$(mount |grep \"$root_dev\" |awk \u0027{print $5}\u0027)"},{"line_number":37,"context_line":"    fs_type_temp\u003d\"xfs\""},{"line_number":38,"context_line":"    if [ \"$fs_type_tmp\" \u003d\u003d \"$fs_type\" ]; then"},{"line_number":39,"context_line":"        xfs_growfs $root_dev || true"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff346bd7_d2e3f9a3","line":36,"updated":"2017-07-22 04:38:40.000000000","message":"This does not (always) work. Example: on my system root_dev\u003d/dev/dm-0 - and \u0027mount | grep /dev/dm-0\u0027 returns an empty list (because the appropriate /dev/mapper/lv-root is reported in mount).\n\nAlso the check is too sloppy: imagine that the root_dev is /dev/dm-1 and you have /dev/dm-1 and /dev/dm-10 and /dev/dm-11 and so on.","commit_id":"e7d2a600c17d05a8524fccd660ac700bffc4a1dd"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"79ae4843ce2981cb3f4fd1109b3565c78957930f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # always return true because this might not work if were are non ext4"},{"line_number":35,"context_line":"    # Add support for XFS format"},{"line_number":36,"context_line":"    fs_type\u003d$(mount |grep \"$root_dev\" |awk \u0027{print $5}\u0027)"},{"line_number":37,"context_line":"    fs_type_temp\u003d\"xfs\""},{"line_number":38,"context_line":"    if [ \"$fs_type_tmp\" \u003d\u003d \"$fs_type\" ]; then"},{"line_number":39,"context_line":"        xfs_growfs $root_dev || true"},{"line_number":40,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1f1a1f67_b4ea95a9","line":37,"updated":"2017-07-21 04:29:13.000000000","message":"what is this variable doing?","commit_id":"e7d2a600c17d05a8524fccd660ac700bffc4a1dd"},{"author":{"_account_id":21741,"name":"Andreas Florath","email":"andreas@florath.net","username":"florath"},"change_message_id":"6a982de20be48eea846a928e8d55d6deb8a71381","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    fs_type\u003d$(mount |grep \"$root_dev\" |awk \u0027{print $5}\u0027)"},{"line_number":37,"context_line":"    fs_type_temp\u003d\"xfs\""},{"line_number":38,"context_line":"    if [ \"$fs_type_tmp\" \u003d\u003d \"$fs_type\" ]; then"},{"line_number":39,"context_line":"        xfs_growfs $root_dev || true"},{"line_number":40,"context_line":"    else"},{"line_number":41,"context_line":"        resize2fs $root_dev || true"},{"line_number":42,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ff346bd7_72f44d5c","line":39,"updated":"2017-07-22 04:38:40.000000000","message":"If we now know the exact filesystem type, there is no need for the \u0027|| true\u0027 any more.","commit_id":"e7d2a600c17d05a8524fccd660ac700bffc4a1dd"}]}